@dartess/eslint-plugin 0.8.1 → 0.10.0

package/CHANGELOG.md

@@ -2,6 +2,17 @@
 
 [//]: # (https://keepachangelog.com/en/1.1.0/)
 
+## [0.10.0] - 2026-02-23
+
+- add rule `@dartess/mobx-no-action-bound`
+- add `@dartess/mobx-no-action-bound` to `mobx` config
+- change `no-sequences` option `allowInParentheses` from `true` to `false`
+- allow `mobx-require-observer` without settings because `mobx` can be used without hooks
+
+## [0.9.0] - 2026-02-03
+
+- add `eslint-plugin-complete` to `recommended` config
+
 ## [0.8.1] - 2026-01-24
 
 - fix `mobx-require-observer`: now it doesn't lose generics

package/README.md

@@ -8,6 +8,7 @@ Also extends
 * `eslint-plugin-import-x` — `recommended` & `typescript`
 * `@eslint-community/eslint-plugin-eslint-comments` — `recommended`
 * `eslint-plugin-de-morgan` — `recommended`
+* `eslint-plugin-complete` — `recommended`
 
 Also can extends (if it is applicable)
 * `@eslint-react/eslint-plugin` — `strict-type-checked`
@@ -38,6 +39,7 @@ npm i -D eslint \
   eslint-plugin-import-x \
   eslint-import-resolver-typescript \
   eslint-plugin-unicorn \
+  eslint-plugin-complete \
   eslint-plugin-decorator-position \
   eslint-plugin-de-morgan \
   typescript-eslint \
@@ -68,6 +70,7 @@ npm i -D eslint-plugin-storybook
 Edit or create `eslint.config.ts` (or `eslint.config.mts`). You probably have to install `jiti` for it.
 
 ```ts
+import type { TSESLint } from '@typescript-eslint/utils';
 import dartessEslintPluginRecommended from '@dartess/eslint-plugin/recommended';
 import dartessEslintPluginRecommendedPostFormat from '@dartess/eslint-plugin/recommended-post-format';
 
@@ -108,7 +111,7 @@ export default [
   // @see `Fine Tuning` -> `Formatters` section below 
   
   ...dartessEslintPluginRecommendedPostFormat,
-]
+] satisfies TSESLint.FlatConfig.ConfigArray;
 
 ```
 
@@ -152,6 +155,8 @@ This plugin requires manual setup for you build tools.
 
 If you're using Mobx with legacy decorators, you have to enable rule `mobx/missing-make-observable` manually.
 
+if you're using Mobx stores with your custom hooks, set `settings.mobx.storeHooks` [by docs](docs/rules/mobx-require-observer.md). 
+
 ## Supported Rules
 
 Each rule has emojis denoting:
@@ -177,6 +182,7 @@ Each rule has emojis denoting:
 | [mobx-require-observer](docs/rules/mobx-require-observer.md)                                                 | Components using the stores must be wrapped in an `observer`                  | ✅ | 🔧 |    |
 | [mobx-sync-autorun](docs/rules/mobx-sync-autorun.md)                                                         | Enforce synchronous autorun callback                                          | ✅ |    |    |
 | [mobx-sync-action](docs/rules/mobx-sync-action.md)                                                           | Enforce synchronous actions                                                   | ✅ |    |    |
+| [mobx-no-action-bound](docs/rules/mobx-no-action-bound.md)                                                   | Enforce using arrow functions for binging `this` to actions                   | ✅ |    |    |
 
 ## Code Reuse Policy
 

package/dist/configs/mobx.js

@@ -9,6 +9,7 @@ const config = [
             'mobx/missing-make-observable': 'off', // useless with modern decorators syntax. TODO check original plugin?
             '@dartess/mobx-strict-observable-components-declaration': 'error',
             '@dartess/mobx-require-observer': 'error',
+            '@dartess/mobx-no-action-bound': 'error',
             '@dartess/mobx-sync-autorun': 'error', // TODO implement it by types?
             '@dartess/mobx-sync-action': 'error', // TODO implement it by types?
         },

package/dist/configs/recommended.js

@@ -10,6 +10,7 @@ import eslintCommentsPlugin from '@eslint-community/eslint-plugin-eslint-comment
 // @ts-ignore: https://github.com/NullVoxPopuli/eslint-plugin-decorator-position/issues/778
 import eslintPluginDecoratorPosition from 'eslint-plugin-decorator-position';
 import eslintPluginDeMorgan from 'eslint-plugin-de-morgan';
+import esLintPluginComplete from 'eslint-plugin-complete';
 import dartessPlugin from "../index.js";
 import vendorRulesBestPractices from "./vendor-rules/best-practices.js";
 import vendorRulesErrors from "./vendor-rules/errors.js";
@@ -47,6 +48,7 @@ const config = [
     convertWarnsToErrorsIfNeeded(eslintPluginImportX.flatConfigs.typescript),
     convertWarnsToErrorsIfNeeded(eslintCommentsPlugin.recommended),
     convertWarnsToErrorsIfNeeded(eslintPluginDeMorgan.configs.recommended),
+    ...convertWarnsToErrorsIfNeeded(esLintPluginComplete.configs.recommended),
     {
         name: '@dartess/recommended',
         plugins: {
@@ -108,6 +110,8 @@ const config = [
                     methods: 'above',
                 },
             ],
+            // totally disable comma operator
+            'no-sequences': ['error', { allowInParentheses: false }],
         },
     },
     {
@@ -224,6 +228,12 @@ const config = [
             ],
             // require names for tuple elements
             '@dartess/ts-named-tuple-elements': 'error',
+            // disable some recommended rules
+            'complete/prefer-readonly-parameter-types': 'off', // can be flase-positive for Built-in methods
+            'complete/no-mutable-return': 'off', // can be hamful
+            'complete/strict-undefined-functions': 'off', // prefer unicorn/no-useless-undefined
+            'complete/require-break': 'off', // can be false-positive with TS7027
+            'complete/no-void-return-type': 'off', // conflict with @typescript-eslint/explicit-module-boundary-types
         },
     },
     {

package/dist/configs/vendor-rules/best-practices.d.ts

@@ -8,9 +8,6 @@ declare const rules: {
     }];
     'default-case-last': "error";
     'default-param-last': "error";
-    eqeqeq: ["error", string, {
-        null: string;
-    }];
     'grouped-accessor-pairs': "error";
     'guard-for-in': "error";
     'max-classes-per-file': ["error", number];
@@ -86,9 +83,7 @@ declare const rules: {
     'no-return-assign': ["error", string];
     'no-script-url': "error";
     'no-self-compare': "error";
-    'no-sequences': "error";
     'no-useless-concat': "error";
-    'no-useless-return': "error";
     'no-void': "error";
     'prefer-promise-reject-errors': ["error", {
         allowEmptyReject: boolean;

package/dist/configs/vendor-rules/best-practices.js

@@ -17,9 +17,6 @@ const rules = {
     'default-case-last': 'error',
     // https://eslint.org/docs/rules/default-param-last
     'default-param-last': 'error',
-    // require the use of === and !==
-    // https://eslint.org/docs/rules/eqeqeq
-    eqeqeq: ['error', 'always', { null: 'ignore' }],
     // Require grouped accessor pairs in object literals and classes
     // https://eslint.org/docs/rules/grouped-accessor-pairs
     'grouped-accessor-pairs': 'error',
@@ -168,15 +165,9 @@ const rules = {
     // disallow comparisons where both sides are exactly the same
     // https://eslint.org/docs/rules/no-self-compare
     'no-self-compare': 'error',
-    // disallow use of comma operator
-    // https://eslint.org/docs/rules/no-sequences
-    'no-sequences': 'error',
     // disallow useless string concatenation
     // https://eslint.org/docs/rules/no-useless-concat
     'no-useless-concat': 'error',
-    // disallow redundant return; keywords
-    // https://eslint.org/docs/rules/no-useless-return
-    'no-useless-return': 'error',
     // disallow use of void operator
     // https://eslint.org/docs/rules/no-void
     'no-void': 'error',

package/dist/configs/vendor-rules/errors.d.ts

@@ -3,7 +3,6 @@ declare const rules: {
     'no-cond-assign': ["error", string];
     'no-inner-declarations': "error";
     'no-promise-executor-return': "error";
-    'no-template-curly-in-string': "error";
     'no-unreachable-loop': ["error", {
         ignore: never[];
     }];

package/dist/configs/vendor-rules/errors.js

@@ -13,9 +13,6 @@ const rules = {
     // Disallow returning values from Promise executor functions
     // https://eslint.org/docs/rules/no-promise-executor-return
     'no-promise-executor-return': 'error',
-    // Disallow template literal placeholder syntax in regular strings
-    // https://eslint.org/docs/rules/no-template-curly-in-string
-    'no-template-curly-in-string': 'error',
     // Disallow loops with a body that allows only one iteration
     // https://eslint.org/docs/rules/no-unreachable-loop
     'no-unreachable-loop': [

package/dist/configs/vendor-rules/es6.d.ts

@@ -12,10 +12,6 @@ declare const rules: {
         ignoreConstructors: boolean;
         avoidQuotes: boolean;
     }];
-    'prefer-const': ["error", {
-        destructuring: string;
-        ignoreReadBeforeAssign: boolean;
-    }];
     'prefer-destructuring': ["error", {
         VariableDeclarator: {
             array: boolean;

package/dist/configs/vendor-rules/es6.js

@@ -37,14 +37,6 @@ const rules = {
             avoidQuotes: true,
         },
     ],
-    // suggest using of const declaration for variables that are never modified after declared
-    'prefer-const': [
-        'error',
-        {
-            destructuring: 'any',
-            ignoreReadBeforeAssign: true,
-        },
-    ],
     // Prefer destructuring from arrays and objects
     // https://eslint.org/docs/rules/prefer-destructuring
     'prefer-destructuring': [

package/dist/configs/vendor-rules/style.d.ts

@@ -14,7 +14,6 @@ declare const rules: {
     'no-lonely-if': "error";
     'no-multi-assign': ["error"];
     'no-nested-ternary': "error";
-    'no-plusplus': "error";
     'no-underscore-dangle': ["error", {
         allow: never[];
         allowAfterThis: boolean;

package/dist/configs/vendor-rules/style.js

@@ -39,9 +39,6 @@ const rules = {
     'no-multi-assign': ['error'],
     // disallow nested ternary expressions
     'no-nested-ternary': 'error',
-    // disallow use of unary operators, ++ and --
-    // https://eslint.org/docs/rules/no-plusplus
-    'no-plusplus': 'error',
     // disallow dangling underscores in identifiers
     // https://eslint.org/docs/rules/no-underscore-dangle
     'no-underscore-dangle': [

package/dist/index.js

@@ -5,6 +5,7 @@ import ruleStoriesExportMeta from "./rules/stories-export-meta.js";
 import ruleStoriesExportTyped from "./rules/stories-export-typed.js";
 import ruleMobxStrictObservableComponentsDeclaration from "./rules/mobx-strict-observable-components-declaration.js";
 import ruleMobxRequireObserver from "./rules/mobx-require-observer.js";
+import ruleMobxNoActionBound from "./rules/mobx-no-action-bound.js";
 import ruleImportsMaxParentDepth from "./rules/imports-max-parent-depth.js";
 import ruleTsNamedTupleElements from "./rules/ts-named-tuple-elements.js";
 import ruleMobxSyncAutorun from "./rules/mobx-sync-autorun.js";
@@ -23,6 +24,7 @@ const plugin = {
         'mobx-sync-action': ruleMobxSyncAction,
         'mobx-sync-autorun': ruleMobxSyncAutorun,
         'mobx-require-observer': ruleMobxRequireObserver,
+        'mobx-no-action-bound': ruleMobxNoActionBound,
         'stories-export-typed': ruleStoriesExportTyped,
         'stories-export-meta': ruleStoriesExportMeta,
         'ts-named-tuple-elements': ruleTsNamedTupleElements,

package/dist/rules/mobx-no-action-bound.d.ts

@@ -0,0 +1,3 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+declare const _default: ESLintUtils.RuleModule<"noActionBound", [], unknown, ESLintUtils.RuleListener>;
+export default _default;

package/dist/rules/mobx-no-action-bound.js

@@ -0,0 +1,25 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+export default ESLintUtils.RuleCreator(() => '')({
+    name: 'mobx-no-action-bound',
+    defaultOptions: [],
+    meta: {
+        type: 'problem',
+        docs: {
+            description: 'Enforce using arrow functions for binging `this` to actions',
+        },
+        messages: {
+            noActionBound: 'rewrite action with arrow function for binding `this`',
+        },
+        schema: [],
+    },
+    create(context) {
+        return {
+            "Decorator[expression.object.name='action'][expression.property.name='bound']": function (node) {
+                context.report({
+                    node,
+                    messageId: 'noActionBound',
+                });
+            },
+        };
+    },
+});

package/dist/rules/mobx-require-observer.js

@@ -54,7 +54,7 @@ export default ESLintUtils.RuleCreator(() => '')({
         const mobxSettings = context.settings.mobx;
         const hooks = Array.isArray(mobxSettings?.storeHooks) ? mobxSettings.storeHooks : [];
         if (hooks.length === 0) {
-            throw new Error('Please fill settings.mobx.storeHooks');
+            return {};
         }
         const { sourceCode } = context;
         const program = sourceCode.ast;
@@ -138,7 +138,7 @@ export default ESLintUtils.RuleCreator(() => '')({
                                 const replacement = `const ${name} = observer(${original});`;
                                 fixes.push(fixer.replaceText(fn, replacement));
                             }
-                            else if (varDecl && varDecl.type === AST_NODE_TYPES.VariableDeclaration) {
+                            else if (varDecl?.type === AST_NODE_TYPES.VariableDeclaration) {
                                 // const Name = () => {} or function expression
                                 const id = fn.parent.id;
                                 const { name } = id;

package/docs/rules/mobx-no-action-bound.md

@@ -0,0 +1,40 @@
+# Enforce using arrow functions for binging `this` to actions (mobx-no-action-bound)
+
+Decorator `@action.bound` automatically bind methods to class instances to avoid context loss (`this`).
+However, this can also be achieved by declaring methods as an properies with arrow functions.
+
+This is the first problem with bound methods—their functionality is duplicated by native abilities.
+
+In general, for optimization purposes, it's not recommended to bind _everything_; by default,
+class methods should be on the prototype.
+
+To resolve the dilemma of "how to avoid binding unnecessary things and avoid losing context"
+the [`@typescript-eslint/unbound-method`](https://typescript-eslint.io/rules/unbound-method/) rule exists.
+
+However, it can't detect whether a method is bound via an `@action.bound`. Therefore, it's best to avoid
+using `@action.bound` at all and leave only one binding method—arrow functions with `@typescript-eslint/unbound-method`.
+In this case you don't need think about it.
+
+## Rule Details
+
+Examples of **incorrect** code for this rule:
+
+```ts
+class Store {
+  @action.bound
+  reset() {
+    this.value = null;
+  };
+}
+```
+
+Examples of **correct** code for this rule:
+
+```ts
+class Store {
+  @action
+  reset = () => {
+    this.value = null;
+  };
+}
+```

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@dartess/eslint-plugin",
   "type": "module",
-  "version": "0.8.1",
+  "version": "0.10.0",
   "description": "A set of rules and configs for various TypeScript projects",
   "keywords": [
     "eslint",
@@ -53,6 +53,7 @@
     "@stylistic/eslint-plugin": "^5.7.0",
     "eslint": "^9.0.0",
     "eslint-import-resolver-typescript": "^4.0.0",
+    "eslint-plugin-complete": "^1.2.0",
     "eslint-plugin-de-morgan": "^2.0.0",
     "eslint-plugin-decorator-position": "^6.0.0",
     "eslint-plugin-import-x": "^4.1.0",