@dartess/eslint-plugin 0.8.0 → 0.9.0

package/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 [//]: # (https://keepachangelog.com/en/1.1.0/)
 
+## [0.9.0] - 2026-02-03
+
+- add `eslint-plugin-complete` to `recommended` config
+
+## [0.8.1] - 2026-01-24
+
+- fix `mobx-require-observer`: now it doesn't lose generics
+- fix `mobx-require-observer`: now it respects directives like `'use client'`
+
 ## [0.8.0] - 2026-01-22
 
 - All recommended warnings are converted to errors because warnings are useless.

package/README.md

@@ -8,6 +8,7 @@ Also extends
 * `eslint-plugin-import-x` — `recommended` & `typescript`
 * `@eslint-community/eslint-plugin-eslint-comments` — `recommended`
 * `eslint-plugin-de-morgan` — `recommended`
+* `eslint-plugin-complete` — `recommended`
 
 Also can extends (if it is applicable)
 * `@eslint-react/eslint-plugin` — `strict-type-checked`
@@ -23,7 +24,7 @@ All of it pinched with extra configs, setups and extra rules. Just take it and u
 
 ### Notes
 
-1. The package is intended for use with TypeScript (it'll be useful for plain JS, but it hasn't been weel-tested).
+1. The package is intended for use with TypeScript (it'll be useful for plain JS, but it hasn't been well-tested).
 
 2. The package is intended for use only with the `flat` eslint config.
 
@@ -38,6 +39,7 @@ npm i -D eslint \
   eslint-plugin-import-x \
   eslint-import-resolver-typescript \
   eslint-plugin-unicorn \
+  eslint-plugin-complete \
   eslint-plugin-decorator-position \
   eslint-plugin-de-morgan \
   typescript-eslint \

package/dist/configs/recommended.js

@@ -10,6 +10,7 @@ import eslintCommentsPlugin from '@eslint-community/eslint-plugin-eslint-comment
 // @ts-ignore: https://github.com/NullVoxPopuli/eslint-plugin-decorator-position/issues/778
 import eslintPluginDecoratorPosition from 'eslint-plugin-decorator-position';
 import eslintPluginDeMorgan from 'eslint-plugin-de-morgan';
+import esLintPluginComplete from 'eslint-plugin-complete';
 import dartessPlugin from "../index.js";
 import vendorRulesBestPractices from "./vendor-rules/best-practices.js";
 import vendorRulesErrors from "./vendor-rules/errors.js";
@@ -47,6 +48,7 @@ const config = [
     convertWarnsToErrorsIfNeeded(eslintPluginImportX.flatConfigs.typescript),
     convertWarnsToErrorsIfNeeded(eslintCommentsPlugin.recommended),
     convertWarnsToErrorsIfNeeded(eslintPluginDeMorgan.configs.recommended),
+    ...convertWarnsToErrorsIfNeeded(esLintPluginComplete.configs.recommended),
     {
         name: '@dartess/recommended',
         plugins: {
@@ -224,6 +226,12 @@ const config = [
             ],
             // require names for tuple elements
             '@dartess/ts-named-tuple-elements': 'error',
+            // disable some recommended rules
+            'complete/prefer-readonly-parameter-types': 'off', // can be flase-positive for Built-in methods
+            'complete/no-mutable-return': 'off', // can be hamful
+            'complete/strict-undefined-functions': 'off', // prefer unicorn/no-useless-undefined
+            'complete/require-break': 'off', // can be false-positive with TS7027
+            'complete/no-void-return-type': 'off', // conflict with @typescript-eslint/explicit-module-boundary-types
         },
     },
     {

package/dist/configs/vendor-rules/best-practices.d.ts

@@ -8,9 +8,6 @@ declare const rules: {
     }];
     'default-case-last': "error";
     'default-param-last': "error";
-    eqeqeq: ["error", string, {
-        null: string;
-    }];
     'grouped-accessor-pairs': "error";
     'guard-for-in': "error";
     'max-classes-per-file': ["error", number];
@@ -88,7 +85,6 @@ declare const rules: {
     'no-self-compare': "error";
     'no-sequences': "error";
     'no-useless-concat': "error";
-    'no-useless-return': "error";
     'no-void': "error";
     'prefer-promise-reject-errors': ["error", {
         allowEmptyReject: boolean;

package/dist/configs/vendor-rules/best-practices.js

@@ -17,9 +17,6 @@ const rules = {
     'default-case-last': 'error',
     // https://eslint.org/docs/rules/default-param-last
     'default-param-last': 'error',
-    // require the use of === and !==
-    // https://eslint.org/docs/rules/eqeqeq
-    eqeqeq: ['error', 'always', { null: 'ignore' }],
     // Require grouped accessor pairs in object literals and classes
     // https://eslint.org/docs/rules/grouped-accessor-pairs
     'grouped-accessor-pairs': 'error',
@@ -174,9 +171,6 @@ const rules = {
     // disallow useless string concatenation
     // https://eslint.org/docs/rules/no-useless-concat
     'no-useless-concat': 'error',
-    // disallow redundant return; keywords
-    // https://eslint.org/docs/rules/no-useless-return
-    'no-useless-return': 'error',
     // disallow use of void operator
     // https://eslint.org/docs/rules/no-void
     'no-void': 'error',

package/dist/configs/vendor-rules/errors.d.ts

@@ -3,7 +3,6 @@ declare const rules: {
     'no-cond-assign': ["error", string];
     'no-inner-declarations': "error";
     'no-promise-executor-return': "error";
-    'no-template-curly-in-string': "error";
     'no-unreachable-loop': ["error", {
         ignore: never[];
     }];

package/dist/configs/vendor-rules/errors.js

@@ -13,9 +13,6 @@ const rules = {
     // Disallow returning values from Promise executor functions
     // https://eslint.org/docs/rules/no-promise-executor-return
     'no-promise-executor-return': 'error',
-    // Disallow template literal placeholder syntax in regular strings
-    // https://eslint.org/docs/rules/no-template-curly-in-string
-    'no-template-curly-in-string': 'error',
     // Disallow loops with a body that allows only one iteration
     // https://eslint.org/docs/rules/no-unreachable-loop
     'no-unreachable-loop': [

package/dist/configs/vendor-rules/es6.d.ts

@@ -12,10 +12,6 @@ declare const rules: {
         ignoreConstructors: boolean;
         avoidQuotes: boolean;
     }];
-    'prefer-const': ["error", {
-        destructuring: string;
-        ignoreReadBeforeAssign: boolean;
-    }];
     'prefer-destructuring': ["error", {
         VariableDeclarator: {
             array: boolean;

package/dist/configs/vendor-rules/es6.js

@@ -37,14 +37,6 @@ const rules = {
             avoidQuotes: true,
         },
     ],
-    // suggest using of const declaration for variables that are never modified after declared
-    'prefer-const': [
-        'error',
-        {
-            destructuring: 'any',
-            ignoreReadBeforeAssign: true,
-        },
-    ],
     // Prefer destructuring from arrays and objects
     // https://eslint.org/docs/rules/prefer-destructuring
     'prefer-destructuring': [

package/dist/configs/vendor-rules/style.d.ts

@@ -14,7 +14,6 @@ declare const rules: {
     'no-lonely-if': "error";
     'no-multi-assign': ["error"];
     'no-nested-ternary': "error";
-    'no-plusplus': "error";
     'no-underscore-dangle': ["error", {
         allow: never[];
         allowAfterThis: boolean;

package/dist/configs/vendor-rules/style.js

@@ -39,9 +39,6 @@ const rules = {
     'no-multi-assign': ['error'],
     // disallow nested ternary expressions
     'no-nested-ternary': 'error',
-    // disallow use of unary operators, ++ and --
-    // https://eslint.org/docs/rules/no-plusplus
-    'no-plusplus': 'error',
     // disallow dangling underscores in identifiers
     // https://eslint.org/docs/rules/no-underscore-dangle
     'no-underscore-dangle': [

package/dist/rules/mobx-require-observer.js

@@ -1,4 +1,4 @@
-import { ESLintUtils, AST_NODE_TYPES } from '@typescript-eslint/utils';
+import { ESLintUtils, AST_NODE_TYPES, } from '@typescript-eslint/utils';
 function isCustomHook(fn) {
     if (fn.type === AST_NODE_TYPES.FunctionDeclaration && fn.id?.name.startsWith('use')) {
         return true;
@@ -13,6 +13,29 @@ function isCustomHook(fn) {
     }
     return false;
 }
+function getTypeParamsText(fn, sourceCode) {
+    return fn.typeParameters ? sourceCode.getText(fn.typeParameters) : '';
+}
+function getObserverImportAnchor(program) {
+    const firstImport = program.body.find(n => n.type === AST_NODE_TYPES.ImportDeclaration);
+    if (firstImport) {
+        return { anchor: firstImport, method: 'insertTextBefore' };
+    }
+    let lastPrologue = null;
+    for (const node of program.body) {
+        if (node.type === AST_NODE_TYPES.ExpressionStatement &&
+            node.expression.type === AST_NODE_TYPES.Literal &&
+            typeof node.expression.value === 'string') {
+            lastPrologue = node;
+            continue;
+        }
+        break;
+    }
+    if (lastPrologue) {
+        return { anchor: lastPrologue, method: 'insertTextAfter' };
+    }
+    return { anchor: program.body[0], method: 'insertTextBefore' };
+}
 export default ESLintUtils.RuleCreator(() => '')({
     name: 'mobx-require-observer',
     meta: {
@@ -97,7 +120,10 @@ export default ESLintUtils.RuleCreator(() => '')({
                         fix(fixer) {
                             const fixes = [];
                             if (!hasObserverImport) {
-                                fixes.push(fixer.insertTextBefore(program.body[0], "import { observer } from 'mobx-react-lite';\n"));
+                                const { anchor, method } = getObserverImportAnchor(program);
+                                const nBefore = method === 'insertTextAfter' ? '\n' : '';
+                                const nAfter = method === 'insertTextBefore' ? '\n' : '';
+                                fixes.push(fixer[method](anchor, `${nBefore}import { observer } from 'mobx-react-lite';${nAfter}`));
                             }
                             const paramsText = fn.params.map(p => sourceCode.getText(p)).join(', ');
                             const bodyText = sourceCode.getText(fn.body);
@@ -112,12 +138,13 @@ export default ESLintUtils.RuleCreator(() => '')({
                                 const replacement = `const ${name} = observer(${original});`;
                                 fixes.push(fixer.replaceText(fn, replacement));
                             }
-                            else if (varDecl && varDecl.type === AST_NODE_TYPES.VariableDeclaration) {
+                            else if (varDecl?.type === AST_NODE_TYPES.VariableDeclaration) {
                                 // const Name = () => {} or function expression
                                 const id = fn.parent.id;
                                 const { name } = id;
                                 const isExport = exportDecl?.type === AST_NODE_TYPES.ExportNamedDeclaration;
-                                const funcExpression = `function ${name}(${paramsText}) ${bodyText}`;
+                                const typeParamsText = getTypeParamsText(fn, sourceCode);
+                                const funcExpression = `function ${name}${typeParamsText}(${paramsText}) ${bodyText}`;
                                 const replacementNodeText = `${isExport ? 'export ' : ''}const ${name} = observer(${funcExpression});`;
                                 fixes.push(fixer.replaceText(exportDecl || varDecl, replacementNodeText));
                             }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@dartess/eslint-plugin",
   "type": "module",
-  "version": "0.8.0",
+  "version": "0.9.0",
   "description": "A set of rules and configs for various TypeScript projects",
   "keywords": [
     "eslint",
@@ -53,6 +53,7 @@
     "@stylistic/eslint-plugin": "^5.7.0",
     "eslint": "^9.0.0",
     "eslint-import-resolver-typescript": "^4.0.0",
+    "eslint-plugin-complete": "^1.2.0",
     "eslint-plugin-de-morgan": "^2.0.0",
     "eslint-plugin-decorator-position": "^6.0.0",
     "eslint-plugin-import-x": "^4.1.0",