@dartess/eslint-plugin 0.7.1 → 0.8.1

package/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 [//]: # (https://keepachangelog.com/en/1.1.0/)
 
+## [0.8.1] - 2026-01-24
+
+- fix `mobx-require-observer`: now it doesn't lose generics
+- fix `mobx-require-observer`: now it respects directives like `'use client'`
+
+## [0.8.0] - 2026-01-22
+
+- All recommended warnings are converted to errors because warnings are useless.
+
 ## [0.7.1] - 2026-01-18
 - rename some rules for more clear naming and consistency:
 

package/README.md

@@ -17,11 +17,13 @@ Also can extends (if it is applicable)
 * `eslint-plugin-mobx` — `recommended`
 * `eslint-plugin-storybook` — `recommended` & `csf-strict`
 
+_Note: all recommended warnings are converted to errors because warnings are useless._
+
 All of it pinched with extra configs, setups and extra rules. Just take it and use it!
 
 ### Notes
 
-1. The package is intended for use with TypeScript (it'll be useful for plain JS, but it hasn't been weel-tested).
+1. The package is intended for use with TypeScript (it'll be useful for plain JS, but it hasn't been well-tested).
 
 2. The package is intended for use only with the `flat` eslint config.
 

package/dist/configs/mobx.d.ts

@@ -1,3 +1,3 @@
-import type { Linter } from 'eslint';
-declare const config: Array<Linter.Config>;
+import type { TSESLint } from '@typescript-eslint/utils';
+declare const config: TSESLint.FlatConfig.ConfigArray;
 export default config;

package/dist/configs/mobx.js

@@ -1,6 +1,7 @@
 import pluginMobx from 'eslint-plugin-mobx';
+import { convertWarnsToErrorsIfNeeded } from "./utils/convertWarnsToErrorsIfNeeded.js";
 const config = [
-    pluginMobx.flatConfigs.recommended,
+    convertWarnsToErrorsIfNeeded(pluginMobx.flatConfigs.recommended),
     {
         name: '@dartess/mobx',
         rules: {

package/dist/configs/next.d.ts

@@ -1,3 +1,3 @@
-import type { Linter } from 'eslint';
-declare const config: Array<Linter.Config>;
+import type { TSESLint } from '@typescript-eslint/utils';
+declare const config: TSESLint.FlatConfig.ConfigArray;
 export default config;

package/dist/configs/post-format.d.ts

@@ -1,3 +1,3 @@
 import type { TSESLint } from '@typescript-eslint/utils';
-declare const config: Array<TSESLint.FlatConfig.Config>;
+declare const config: TSESLint.FlatConfig.ConfigArray;
 export default config;

package/dist/configs/react.js

@@ -2,6 +2,7 @@ import eslintReact from '@eslint-react/eslint-plugin';
 import stylisticPlugin from '@stylistic/eslint-plugin';
 import reactHooksPlugin from 'eslint-plugin-react-hooks';
 import jsxA11yPlugin from 'eslint-plugin-jsx-a11y';
+import { convertWarnsToErrorsIfNeeded } from "./utils/convertWarnsToErrorsIfNeeded.js";
 const config = [
     {
         name: '@dartess/react-setup',
@@ -16,8 +17,8 @@ const config = [
             },
         },
     },
-    eslintReact.configs['strict-type-checked'],
-    reactHooksPlugin.configs.flat.recommended,
+    convertWarnsToErrorsIfNeeded(eslintReact.configs['strict-type-checked']),
+    convertWarnsToErrorsIfNeeded(reactHooksPlugin.configs.flat.recommended),
     {
         name: '@dartess/react',
         files: ['**/*.{jsx,tsx}'],
@@ -51,20 +52,6 @@ const config = [
             '@eslint-react/naming-convention/filename': 'error', // enforce corrent filename
             // disable some recommended rules
             '@eslint-react/prefer-destructuring-assignment': 'off', // can break discriminated union types
-            // mark some recommended warns as errors
-            '@eslint-react/dom/no-missing-button-type': 'error',
-            '@eslint-react/naming-convention/use-state': 'error',
-            '@eslint-react/naming-convention/ref-name': 'error',
-            '@eslint-react/naming-convention/context-name': 'error',
-            '@eslint-react/dom/no-missing-iframe-sandbox': 'error',
-            '@eslint-react/dom/no-unsafe-iframe-sandbox': 'error',
-            '@eslint-react/jsx-no-comment-textnodes': 'error',
-            '@eslint-react/no-unstable-context-value': 'error',
-            '@eslint-react/dom/no-script-url': 'error',
-            '@eslint-react/dom/no-unsafe-target-blank': 'error',
-            '@eslint-react/no-useless-fragment': 'error',
-            '@eslint-react/dom/no-dangerously-set-innerhtml': 'error',
-            '@eslint-react/no-forward-ref': 'error',
             // enable airbnb-style rules
             '@eslint-react/jsx-shorthand-boolean': 'error',
             '@eslint-react/jsx-shorthand-fragment': 'error',

package/dist/configs/recommended.js

@@ -20,6 +20,7 @@ import vendorRulesImports from "./vendor-rules/imports.js";
 import vendorRulesStrict from "./vendor-rules/strict.js";
 import vendorRulesTypescriptDisablings from "./vendor-rules/typescript-disablings.js";
 import vendorRulesTypescript from "./vendor-rules/typescript.js";
+import { convertWarnsToErrorsIfNeeded } from "./utils/convertWarnsToErrorsIfNeeded.js";
 const NO_MIDDLE_ABBRS = '(?!.*[A-Z]{3})';
 const NO_END_ABBRS = '(?!.*[A-Z]{2}$)';
 const NO_MIDDLE_UNDERSCORE = '(?!.*_{2})';
@@ -38,14 +39,14 @@ const config = [
     },
     {
         name: '@eslint/js/recommended',
-        ...pluginJs.configs.recommended,
+        ...convertWarnsToErrorsIfNeeded(pluginJs.configs.recommended),
     },
-    ...tsEslint.configs.strictTypeChecked,
-    ...tsEslint.configs.stylisticTypeChecked,
-    eslintPluginImportX.flatConfigs.recommended,
-    eslintPluginImportX.flatConfigs.typescript,
-    eslintCommentsPlugin.recommended,
-    eslintPluginDeMorgan.configs.recommended,
+    ...convertWarnsToErrorsIfNeeded(tsEslint.configs.strictTypeChecked),
+    ...convertWarnsToErrorsIfNeeded(tsEslint.configs.stylisticTypeChecked),
+    convertWarnsToErrorsIfNeeded(eslintPluginImportX.flatConfigs.recommended),
+    convertWarnsToErrorsIfNeeded(eslintPluginImportX.flatConfigs.typescript),
+    convertWarnsToErrorsIfNeeded(eslintCommentsPlugin.recommended),
+    convertWarnsToErrorsIfNeeded(eslintPluginDeMorgan.configs.recommended),
     {
         name: '@dartess/recommended',
         plugins: {
@@ -227,7 +228,7 @@ const config = [
     },
     {
         files: ['**/*.js', '**/*.mjs', '**/*.cjs', '**/*.jsx'],
-        ...tsEslint.configs.disableTypeChecked,
+        ...convertWarnsToErrorsIfNeeded(tsEslint.configs.disableTypeChecked),
     },
     {
         name: '@dartess/recommended-js',

package/dist/configs/storybook.d.ts

@@ -1,3 +1,3 @@
 import type { TSESLint } from '@typescript-eslint/utils';
-declare const config: Array<TSESLint.FlatConfig.Config>;
+declare const config: TSESLint.FlatConfig.ConfigArray;
 export default config;

package/dist/configs/storybook.js

@@ -1,10 +1,11 @@
 import pluginStorybook from 'eslint-plugin-storybook';
+import { convertWarnsToErrorsIfNeeded } from "./utils/convertWarnsToErrorsIfNeeded.js";
 const config = [
     {
         ignores: ['!.storybook'],
     },
-    ...pluginStorybook.configs['flat/recommended'],
-    ...pluginStorybook.configs['flat/csf-strict'],
+    ...convertWarnsToErrorsIfNeeded(pluginStorybook.configs['flat/recommended']),
+    ...convertWarnsToErrorsIfNeeded(pluginStorybook.configs['flat/csf-strict']),
     {
         name: '@dartess/storybook',
         files: ['**/*.stories.tsx'],

package/dist/configs/utils/convertWarnsToErrorsIfNeeded.d.ts

@@ -0,0 +1,4 @@
+import type { TSESLint } from '@typescript-eslint/utils';
+declare function convertWarnsToErrorsIfNeeded(configs: TSESLint.FlatConfig.Config): TSESLint.FlatConfig.Config;
+declare function convertWarnsToErrorsIfNeeded(configs: TSESLint.FlatConfig.ConfigArray): TSESLint.FlatConfig.ConfigArray;
+export { convertWarnsToErrorsIfNeeded };

package/dist/configs/utils/convertWarnsToErrorsIfNeeded.js

@@ -0,0 +1,36 @@
+const FORCE_ERRORS_INSTEAD_OF_WARNS = true;
+function updateRuleLevel(ruleLevel) {
+    switch (ruleLevel) {
+        case 1:
+            return 2;
+        case 'warn':
+            return 'error';
+        default:
+            return ruleLevel;
+    }
+}
+function implementation(config) {
+    if (!config.rules) {
+        return config;
+    }
+    const rules = Object.fromEntries(Object.entries(config.rules).map(([ruleName, ruleEntry]) => {
+        if (ruleEntry === undefined) {
+            return [ruleName, ruleEntry];
+        }
+        if (Array.isArray(ruleEntry)) {
+            const [ruleLevel, ...options] = ruleEntry;
+            return [ruleName, [updateRuleLevel(ruleLevel), ...options]];
+        }
+        return [ruleName, updateRuleLevel(ruleEntry)];
+    }));
+    return { ...config, rules };
+}
+function convertWarnsToErrorsIfNeeded(configs) {
+    if (!FORCE_ERRORS_INSTEAD_OF_WARNS) {
+        return configs;
+    }
+    return Array.isArray(configs)
+        ? configs.map(config => implementation(config))
+        : implementation(configs);
+}
+export { convertWarnsToErrorsIfNeeded };

package/dist/configs/vendor-rules/imports.d.ts

@@ -5,7 +5,6 @@ declare const rules: {
     }];
     'import-x/default': "off";
     'import-x/namespace': "off";
-    'import-x/no-named-as-default': "error";
     'import-x/no-extraneous-dependencies': ["error", {
         devDependencies: string[];
         optionalDependencies: boolean;
@@ -14,7 +13,6 @@ declare const rules: {
     'import-x/no-amd': "error";
     'import-x/no-nodejs-modules': "error";
     'import-x/first': "error";
-    'import-x/no-duplicates': "error";
     'import-x/extensions': ["error", string, {
         js: string;
         mjs: string;

package/dist/configs/vendor-rules/imports.js

@@ -13,9 +13,6 @@ const rules = {
     // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/namespace.md
     'import-x/namespace': 'off',
     // Helpful warnings:
-    // do not allow a default import name to match a named export
-    // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-named-as-default.md
-    'import-x/no-named-as-default': 'error',
     // Forbid the use of extraneous packages
     // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-extraneous-dependencies.md
     // paths are treated both as absolute paths, and relative to process.cwd()
@@ -58,9 +55,6 @@ const rules = {
     // disallow non-import statements appearing before import statements
     // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/first.md
     'import-x/first': 'error',
-    // disallow duplicate imports
-    // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-duplicates.md
-    'import-x/no-duplicates': 'error',
     // Ensure consistent use of file extension within the import path
     // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/extensions.md
     'import-x/extensions': [

package/dist/index.d.ts

@@ -1,3 +1,3 @@
-import type { ESLint } from 'eslint';
-declare const plugin: ESLint.Plugin;
+import type { Linter } from '@typescript-eslint/utils/ts-eslint';
+declare const plugin: Linter.Plugin;
 export default plugin;

package/dist/rules/mobx-require-observer.js

@@ -1,4 +1,4 @@
-import { ESLintUtils, AST_NODE_TYPES } from '@typescript-eslint/utils';
+import { ESLintUtils, AST_NODE_TYPES, } from '@typescript-eslint/utils';
 function isCustomHook(fn) {
     if (fn.type === AST_NODE_TYPES.FunctionDeclaration && fn.id?.name.startsWith('use')) {
         return true;
@@ -13,6 +13,29 @@ function isCustomHook(fn) {
     }
     return false;
 }
+function getTypeParamsText(fn, sourceCode) {
+    return fn.typeParameters ? sourceCode.getText(fn.typeParameters) : '';
+}
+function getObserverImportAnchor(program) {
+    const firstImport = program.body.find(n => n.type === AST_NODE_TYPES.ImportDeclaration);
+    if (firstImport) {
+        return { anchor: firstImport, method: 'insertTextBefore' };
+    }
+    let lastPrologue = null;
+    for (const node of program.body) {
+        if (node.type === AST_NODE_TYPES.ExpressionStatement &&
+            node.expression.type === AST_NODE_TYPES.Literal &&
+            typeof node.expression.value === 'string') {
+            lastPrologue = node;
+            continue;
+        }
+        break;
+    }
+    if (lastPrologue) {
+        return { anchor: lastPrologue, method: 'insertTextAfter' };
+    }
+    return { anchor: program.body[0], method: 'insertTextBefore' };
+}
 export default ESLintUtils.RuleCreator(() => '')({
     name: 'mobx-require-observer',
     meta: {
@@ -97,7 +120,10 @@ export default ESLintUtils.RuleCreator(() => '')({
                         fix(fixer) {
                             const fixes = [];
                             if (!hasObserverImport) {
-                                fixes.push(fixer.insertTextBefore(program.body[0], "import { observer } from 'mobx-react-lite';\n"));
+                                const { anchor, method } = getObserverImportAnchor(program);
+                                const nBefore = method === 'insertTextAfter' ? '\n' : '';
+                                const nAfter = method === 'insertTextBefore' ? '\n' : '';
+                                fixes.push(fixer[method](anchor, `${nBefore}import { observer } from 'mobx-react-lite';${nAfter}`));
                             }
                             const paramsText = fn.params.map(p => sourceCode.getText(p)).join(', ');
                             const bodyText = sourceCode.getText(fn.body);
@@ -117,7 +143,8 @@ export default ESLintUtils.RuleCreator(() => '')({
                                 const id = fn.parent.id;
                                 const { name } = id;
                                 const isExport = exportDecl?.type === AST_NODE_TYPES.ExportNamedDeclaration;
-                                const funcExpression = `function ${name}(${paramsText}) ${bodyText}`;
+                                const typeParamsText = getTypeParamsText(fn, sourceCode);
+                                const funcExpression = `function ${name}${typeParamsText}(${paramsText}) ${bodyText}`;
                                 const replacementNodeText = `${isExport ? 'export ' : ''}const ${name} = observer(${funcExpression});`;
                                 fixes.push(fixer.replaceText(exportDecl || varDecl, replacementNodeText));
                             }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@dartess/eslint-plugin",
   "type": "module",
-  "version": "0.7.1",
+  "version": "0.8.1",
   "description": "A set of rules and configs for various TypeScript projects",
   "keywords": [
     "eslint",