@dartess/eslint-plugin 0.2.1 → 0.4.0

package/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 [//]: # (https://keepachangelog.com/en/1.1.0/)
 
+## [0.4.0] - 2026-01-15
+- add rule `@dartess/mobx-sync-autorun`
+- add `@dartess/mobx-sync-autorun` to `mobx` config
+
+## [0.3.0] - 2026-01-12
+
+- add `eslint-plugin-react-hooks:recommended` config to `react` config
+
 ## [0.2.1] - 2026-01-10
 
 - add `recommended-post-format` config for using after formatting tools

package/README.md

@@ -11,13 +11,12 @@ Also extends
 
 Also can extends (if it is applicable)
 * `eslint-plugin-react` — `recommended` & `jsx-runtime`
+* `eslint-plugin-react-hooks` — `recommended`
 * `@next/eslint-plugin-next` — `recommended` & `core-web-vitals`
 * `eslint-config-next`
 * `eslint-plugin-mobx` — `recommended`
 * `eslint-plugin-storybook` — `recommended` & `csf-strict`
 
-_(We also use `eslint-plugin-unicorn` and `eslint-plugin-decorator-position` but only special rules, without `recommended` config)_
-
 All of it pinched with extra configs, setups and extra rules. Just take it and use it!
 
 ### Notes
@@ -168,6 +167,7 @@ Each rule has emojis denoting:
 | [stories-export-typed](docs/rules/stories-export-typed.md)                                                 | Storybook's Stories should be typed                                           | ✅ |    |    |
 | [max-parent-import-depth](docs/rules/max-parent-import-depth.md)                                           | Limit relative imports to a maximum parent depth.                             | ✅ |    |    |
 | [ts-named-tuple-elements](docs/rules/ts-named-tuple-elements.md)                                           | Enforce (or forbid) named tuple elements                                      | ✅ |    |    |
+| [mobx-sync-autorun](docs/rules/mobx-sync-autorun.md)                                           | Enforce synchronous autorun callback                                          | ✅ |    |    |
 
 ## Code Reuse Policy
 

package/dist/configs/mobx.js

@@ -8,6 +8,7 @@ const config = [
             'mobx/missing-make-observable': 'off', // useless with modern decorators syntax
             '@dartess/strict-observable-components-declaration': 'error',
             '@dartess/require-observer': 'error',
+            '@dartess/mobx-sync-autorun': 'error',
         },
     },
 ];

package/dist/configs/react.js

@@ -5,7 +5,6 @@ import reactPlugin from 'eslint-plugin-react';
 import reactHooksPlugin from 'eslint-plugin-react-hooks';
 import jsxA11yPlugin from 'eslint-plugin-jsx-a11y';
 import vendorRulesReact from "./vendor-rules/react.js";
-import vendorRulesReactHooks from "./vendor-rules/react-hooks.js";
 const config = [
     {
         name: '@dartess/react-setup',
@@ -19,6 +18,7 @@ const config = [
             },
         },
     },
+    reactHooksPlugin.configs.flat.recommended,
     {
         name: 'react/recommended', // missed name, @see e.g. https://github.com/jsx-eslint/eslint-plugin-react/pull/3882
         ...reactPlugin.configs.flat.recommended,
@@ -71,11 +71,5 @@ const config = [
             'react/jsx-no-undef': 'off', // checked by typescript
         },
     },
-    {
-        name: '@dartess/react-hooks',
-        rules: {
-            ...vendorRulesReactHooks,
-        },
-    },
 ];
 export default config;

package/dist/index.js

@@ -7,6 +7,7 @@ import ruleStrictObservableComponentsDeclaration from "./rules/strict-observable
 import ruleRequireObserver from "./rules/require-observer.js";
 import ruleMaxParentImportDepth from "./rules/max-parent-import-depth.js";
 import ruleTsNamedTupleElements from "./rules/ts-named-tuple-elements.js";
+import ruleMobxSyncAutorun from "./rules/mobx-sync-autorun.js";
 const plugin = {
     meta: {
         name: packageJson.name,
@@ -22,6 +23,7 @@ const plugin = {
         'require-observer': ruleRequireObserver,
         'max-parent-import-depth': ruleMaxParentImportDepth,
         'ts-named-tuple-elements': ruleTsNamedTupleElements,
+        'mobx-sync-autorun': ruleMobxSyncAutorun,
     },
 };
 export default plugin;

package/dist/rules/mobx-sync-autorun.d.ts

@@ -0,0 +1,3 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+declare const _default: ESLintUtils.RuleModule<"requireSyncAutorun", [], unknown, ESLintUtils.RuleListener>;
+export default _default;

package/dist/rules/mobx-sync-autorun.js

@@ -0,0 +1,26 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+export default ESLintUtils.RuleCreator(() => '')({
+    name: 'mobx-sync-autorun',
+    defaultOptions: [],
+    meta: {
+        type: 'problem',
+        docs: {
+            description: "Autorun tracks only the observables that are read during the synchronous execution of the provided function, but it won't track anything that happens asynchronously.",
+        },
+        messages: {
+            requireSyncAutorun: '`effect` must be synchronous function',
+        },
+        schema: [],
+    },
+    create(context) {
+        const selector = [
+            'CallExpression[callee.name="autorun"] > ArrowFunctionExpression[async="true"]',
+            'CallExpression[callee.name="autorun"] > FunctionExpression[async="true"]',
+        ].join(', ');
+        return {
+            [selector]: node => {
+                context.report({ node, messageId: 'requireSyncAutorun' });
+            },
+        };
+    },
+});

package/docs/rules/mobx-sync-autorun.md

@@ -0,0 +1,29 @@
+# Enforce synchronous autorun callback
+
+Mobx `autorun` function must accept only synchronous `effect` callback.
+This follows from the rules from official documentation, https://mobx.js.org/reactions.html#rules #2:  
+
+```
+Autorun tracks only the observables that are read during the synchronous execution of the provided function, but it won't track anything that happens asynchronously.
+```
+
+It would be nice to track this at the type level, but that doesn't happen at the moment.
+
+## Rule Details
+
+Examples of **incorrect** code for this rule:
+
+```ts
+autorun(async () => {
+  await sleep(1);
+  console.log(store.value)
+})
+```
+
+Examples of **correct** code for this rule:
+
+```ts
+autorun(() => {
+  console.log(store.value)
+})
+```

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@dartess/eslint-plugin",
   "type": "module",
-  "version": "0.2.1",
+  "version": "0.4.0",
   "description": "A set of rules and configs for various TypeScript projects",
   "keywords": [
     "eslint",
@@ -83,7 +83,7 @@
     }
   },
   "devDependencies": {
-    "@eslint-community/eslint-plugin-eslint-comments": "^4.5.0",
+    "@eslint-community/eslint-plugin-eslint-comments": "^4.6.0",
     "@eslint/js": "^9.39.2",
     "@types/confusing-browser-globals": "^1.0.3",
     "@types/eslint-plugin-jsx-a11y": "^6.10.1",

package/dist/configs/vendor-rules/react-hooks.d.ts

@@ -1,10 +0,0 @@
-declare const rules: {
-    /**
-     * react-hooks
-     * copied from
-     * https://github.com/airbnb/javascript/blob/c25bce83be4db06e6a221d79686c485cd2ed5d5d/packages/eslint-config-airbnb/rules/react-hooks.js
-     * */
-    'react-hooks/rules-of-hooks': "error";
-    'react-hooks/exhaustive-deps': "error";
-};
-export default rules;

package/dist/configs/vendor-rules/react-hooks.js

@@ -1,17 +0,0 @@
-// This file contains code from the `eslint-config-airbnb` project
-// Original author: Jake Teton-Landis (https://twitter.com/@jitl)
-// License: MIT (see LICENSE-eslint-config-airbnb.md file)
-const rules = {
-    /**
-     * react-hooks
-     * copied from
-     * https://github.com/airbnb/javascript/blob/c25bce83be4db06e6a221d79686c485cd2ed5d5d/packages/eslint-config-airbnb/rules/react-hooks.js
-     * */
-    // Enforce Rules of Hooks
-    // https://github.com/facebook/react/blob/c11015ff4f610ac2924d1fc6d569a17657a404fd/packages/eslint-plugin-react-hooks/src/RulesOfHooks.js
-    'react-hooks/rules-of-hooks': 'error',
-    // Verify the list of the dependencies for Hooks like useEffect and similar
-    // https://github.com/facebook/react/blob/1204c789776cb01fbaf3e9f032e7e2ba85a44137/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js
-    'react-hooks/exhaustive-deps': 'error',
-};
-export default rules;