@dartess/eslint-plugin 0.10.0 → 0.11.2

package/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 [//]: # (https://keepachangelog.com/en/1.1.0/)
 
+##  [0.11.0] - 2026-03-27
+
+- remove throwing errors from rules
+- add `unicorn/numeric-separators-style` to `recommended` config
+- replace `import-x/order` with `perfectionist/sort-imports`: now sort side-effects as first group and styles as last group; please, install `eslint-plugin-perfectionist` 
+- add rule `@dartess/no-props-with-children-type`: Disallow the use of PropsWithChildren utility type. Prefer explicit children prop typing instead.
+- add `@dartess/no-props-with-children-type` to `react` config
+- update deps
+
 ## [0.10.0] - 2026-02-23
 
 - add rule `@dartess/mobx-no-action-bound`

package/README.md

@@ -42,6 +42,7 @@ npm i -D eslint \
   eslint-plugin-complete \
   eslint-plugin-decorator-position \
   eslint-plugin-de-morgan \
+  eslint-plugin-perfectionist \
   typescript-eslint \
   @eslint-community/eslint-plugin-eslint-comments \
   @dartess/eslint-plugin
@@ -174,6 +175,7 @@ Each rule has emojis denoting:
 | **React**                                                                                                    | _config: react_                                                               |   |    |    |
 | [jsx-no-text-as-child](docs/rules/jsx-no-text-as-child.md)                                                   | JSX elements should not have text without translation                         |   |    |    |
 | [jsx-no-cross-context-classes](docs/rules/jsx-no-cross-context-classes.md)                                   | Prevent mixing of outer and inner classes to avoid dependency on style order. |   |    |    |
+| [no-props-with-children-type](docs/rules/no-props-with-children-type.md)                                     | Disallow the use of `PropsWithChildren` utility type in favor explicit types. | ✅ |    |    |
 | **Storybook**                                                                                                | _config: storybook_                                                           |   |    |    |
 | [stories-export-meta](docs/rules/stories-export-meta.md)                                                     | Storybook's Meta should be typed                                              | ✅ |    |    |
 | [stories-export-typed](docs/rules/stories-export-typed.md)                                                   | Storybook's Stories should be typed                                           | ✅ |    |    |

package/dist/configs/react.js

@@ -58,6 +58,7 @@ const config = [
             '@eslint-react/naming-convention/component-name': 'error',
             '@stylistic/jsx-curly-brace-presence': ['error', { props: 'never', children: 'never' }],
             '@stylistic/jsx-self-closing-comp': 'error',
+            '@dartess/no-props-with-children-type': 'error',
         },
     },
 ];

package/dist/configs/recommended.js

@@ -11,6 +11,7 @@ import eslintCommentsPlugin from '@eslint-community/eslint-plugin-eslint-comment
 import eslintPluginDecoratorPosition from 'eslint-plugin-decorator-position';
 import eslintPluginDeMorgan from 'eslint-plugin-de-morgan';
 import esLintPluginComplete from 'eslint-plugin-complete';
+import esLintPluginPerfectionist from 'eslint-plugin-perfectionist';
 import dartessPlugin from "../index.js";
 import vendorRulesBestPractices from "./vendor-rules/best-practices.js";
 import vendorRulesErrors from "./vendor-rules/errors.js";
@@ -54,7 +55,9 @@ const config = [
         plugins: {
             unicorn: eslintPluginUnicorn,
             '@dartess': dartessPlugin,
+            // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment -- https://github.com/NullVoxPopuli/eslint-plugin-decorator-position/issues/778
             'decorator-position': eslintPluginDecoratorPosition,
+            perfectionist: esLintPluginPerfectionist,
         },
         languageOptions: {
             parser: tsEslint.parser,
@@ -87,12 +90,20 @@ const config = [
             ],
             'unicorn/no-useless-undefined': 'error',
             'unicorn/prefer-node-protocol': 'error',
+            'unicorn/numeric-separators-style': 'error',
             '@dartess/imports-max-parent-depth': 'error',
-            'import-x/order': [
+            'perfectionist/sort-imports': [
                 'error',
                 {
-                    groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'],
-                    'newlines-between': 'always',
+                    type: 'unsorted',
+                    groups: [
+                        'side-effect',
+                        ...['builtin', 'external', 'internal', 'parent', 'sibling', 'index'].map(group => [
+                            `type-${group}`,
+                            `value-${group}`,
+                        ]),
+                        'style',
+                    ],
                 },
             ],
             'prefer-arrow-callback': [
@@ -234,6 +245,7 @@ const config = [
             'complete/strict-undefined-functions': 'off', // prefer unicorn/no-useless-undefined
             'complete/require-break': 'off', // can be false-positive with TS7027
             'complete/no-void-return-type': 'off', // conflict with @typescript-eslint/explicit-module-boundary-types
+            'complete/require-ascii': 'off', // absoule useless
         },
     },
     {

package/dist/index.js

@@ -10,6 +10,7 @@ import ruleImportsMaxParentDepth from "./rules/imports-max-parent-depth.js";
 import ruleTsNamedTupleElements from "./rules/ts-named-tuple-elements.js";
 import ruleMobxSyncAutorun from "./rules/mobx-sync-autorun.js";
 import ruleMobxSyncAction from "./rules/mobx-sync-action.js";
+import ruleNoPropsWithChildrenType from "./rules/no-props-with-children-type.js";
 const plugin = {
     meta: {
         name: packageJson.name,
@@ -28,6 +29,7 @@ const plugin = {
         'stories-export-typed': ruleStoriesExportTyped,
         'stories-export-meta': ruleStoriesExportMeta,
         'ts-named-tuple-elements': ruleTsNamedTupleElements,
+        'no-props-with-children-type': ruleNoPropsWithChildrenType,
     },
 };
 export default plugin;

package/dist/rules/imports-max-parent-depth.d.ts

@@ -1,3 +1,5 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-declare const _default: ESLintUtils.RuleModule<"tooDeep", [], unknown, ESLintUtils.RuleListener>;
+declare const _default: ESLintUtils.RuleModule<"tooDeep", [], unknown, ESLintUtils.RuleListener> & {
+    name: string;
+};
 export default _default;

package/dist/rules/jsx-no-cross-context-classes.d.ts

@@ -5,9 +5,11 @@ import { ESLintUtils } from '@typescript-eslint/utils';
  */
 type Options = [
     mainOptions: {
-        libName?: string;
+        libName: string;
     }
 ];
 type MessageIds = 'avoidMix' | 'avoidRenaming';
-declare const _default: ESLintUtils.RuleModule<MessageIds, Options, unknown, ESLintUtils.RuleListener>;
+declare const _default: ESLintUtils.RuleModule<MessageIds, Options, unknown, ESLintUtils.RuleListener> & {
+    name: string;
+};
 export default _default;

package/dist/rules/jsx-no-cross-context-classes.js

@@ -1,7 +1,7 @@
 import { ESLintUtils, AST_NODE_TYPES } from '@typescript-eslint/utils';
 export default ESLintUtils.RuleCreator(() => '')({
     name: 'jsx-no-cross-context-classes',
-    defaultOptions: [{}],
+    defaultOptions: [{ libName: 'clsx' }],
     meta: {
         type: 'suggestion',
         docs: {
@@ -26,10 +26,7 @@ export default ESLintUtils.RuleCreator(() => '')({
     },
     create(context) {
         const [options] = context.options;
-        const libName = options?.libName;
-        if (!libName || typeof libName !== 'string') {
-            throw new Error('libName option is required and must be a string');
-        }
+        const { libName } = options;
         const isClassLike = (string) => /class/i.exec(string);
         return {
             CallExpression(node) {

package/dist/rules/jsx-no-text-as-child.d.ts

@@ -1,3 +1,7 @@
+/**
+ * @fileoverview Disallows text as child in JSX elements, except specified characters like emojis, digits, special symbols and extra strings
+ * @author Sergey Kozlov
+ */
 import { ESLintUtils } from '@typescript-eslint/utils';
 type Options = [
     mainOptions: {
@@ -9,5 +13,7 @@ type Options = [
     }
 ];
 type MessageIds = 'textAsChild' | 'disallowedSymbols';
-declare const _default: ESLintUtils.RuleModule<MessageIds, Options, unknown, ESLintUtils.RuleListener>;
+declare const _default: ESLintUtils.RuleModule<MessageIds, Options, unknown, ESLintUtils.RuleListener> & {
+    name: string;
+};
 export default _default;

package/dist/rules/jsx-no-text-as-child.js

@@ -1,8 +1,8 @@
-import { ESLintUtils, AST_NODE_TYPES } from '@typescript-eslint/utils';
 /**
  * @fileoverview Disallows text as child in JSX elements, except specified characters like emojis, digits, special symbols and extra strings
  * @author Sergey Kozlov
  */
+import { ESLintUtils, AST_NODE_TYPES } from '@typescript-eslint/utils';
 import emojiRegex from 'emoji-regex';
 export default ESLintUtils.RuleCreator(() => '')({
     name: 'jsx-no-text-as-child',

package/dist/rules/mobx-no-action-bound.d.ts

@@ -1,3 +1,5 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-declare const _default: ESLintUtils.RuleModule<"noActionBound", [], unknown, ESLintUtils.RuleListener>;
+declare const _default: ESLintUtils.RuleModule<"noActionBound", [], unknown, ESLintUtils.RuleListener> & {
+    name: string;
+};
 export default _default;

package/dist/rules/mobx-require-observer.d.ts

@@ -1,3 +1,5 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-declare const _default: ESLintUtils.RuleModule<"requireObserver", [], unknown, ESLintUtils.RuleListener>;
+declare const _default: ESLintUtils.RuleModule<"requireObserver", [], unknown, ESLintUtils.RuleListener> & {
+    name: string;
+};
 export default _default;

package/dist/rules/mobx-strict-observable-components-declaration.d.ts

@@ -10,5 +10,7 @@ type Options = [
     }
 ];
 type MessageIds = 'observedIsInlined' | 'observedIsFE' | 'extraCallsAsParam' | 'observedIsNamed' | 'componentIsNamed' | 'componentIsNamedAsObserved';
-declare const _default: ESLintUtils.RuleModule<MessageIds, Options, unknown, ESLintUtils.RuleListener>;
+declare const _default: ESLintUtils.RuleModule<MessageIds, Options, unknown, ESLintUtils.RuleListener> & {
+    name: string;
+};
 export default _default;

package/dist/rules/mobx-sync-action.d.ts

@@ -1,3 +1,5 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-declare const _default: ESLintUtils.RuleModule<"requireSyncAction", [], unknown, ESLintUtils.RuleListener>;
+declare const _default: ESLintUtils.RuleModule<"requireSyncAction", [], unknown, ESLintUtils.RuleListener> & {
+    name: string;
+};
 export default _default;

package/dist/rules/mobx-sync-autorun.d.ts

@@ -1,3 +1,5 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-declare const _default: ESLintUtils.RuleModule<"requireSyncAutorun", [], unknown, ESLintUtils.RuleListener>;
+declare const _default: ESLintUtils.RuleModule<"requireSyncAutorun", [], unknown, ESLintUtils.RuleListener> & {
+    name: string;
+};
 export default _default;

package/dist/rules/no-props-with-children-type.d.ts

@@ -0,0 +1,9 @@
+/**
+ * @fileoverview Disallow the use of `PropsWithChildren` utility type in favor explicit types
+ * @author Sergey Kozlov
+ */
+import { ESLintUtils } from '@typescript-eslint/utils';
+declare const _default: ESLintUtils.RuleModule<"unexpectedPropsWithChildren", [], unknown, ESLintUtils.RuleListener> & {
+    name: string;
+};
+export default _default;

package/dist/rules/no-props-with-children-type.js

@@ -0,0 +1,45 @@
+/**
+ * @fileoverview Disallow the use of `PropsWithChildren` utility type in favor explicit types
+ * @author Sergey Kozlov
+ */
+import { ESLintUtils, AST_NODE_TYPES } from '@typescript-eslint/utils';
+import { exhaustiveCheck } from "./utils/exhaustiveCheck.js";
+function getTypeName(tsEntityName) {
+    switch (tsEntityName.type) {
+        case AST_NODE_TYPES.Identifier:
+            return tsEntityName.name;
+        case AST_NODE_TYPES.TSQualifiedName:
+            return tsEntityName.right.name;
+        case AST_NODE_TYPES.ThisExpression:
+            return null;
+        default:
+            exhaustiveCheck(tsEntityName);
+    }
+}
+export default ESLintUtils.RuleCreator(() => '')({
+    name: 'no-props-with-children-type',
+    defaultOptions: [],
+    meta: {
+        type: 'problem',
+        docs: {
+            description: 'Disallow the use of PropsWithChildren utility type. Prefer explicit children prop typing instead.',
+        },
+        messages: {
+            unexpectedPropsWithChildren: 'Do not use PropsWithChildren. Type the children prop explicitly instead.',
+        },
+        schema: [],
+    },
+    create(context) {
+        return {
+            TSTypeReference(node) {
+                const name = getTypeName(node.typeName);
+                if (name === 'PropsWithChildren') {
+                    context.report({
+                        node,
+                        messageId: 'unexpectedPropsWithChildren',
+                    });
+                }
+            },
+        };
+    },
+});

package/dist/rules/stories-export-meta.d.ts

@@ -1,3 +1,5 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-declare const _default: ESLintUtils.RuleModule<"exportDefaultTypeCheck", [], unknown, ESLintUtils.RuleListener>;
+declare const _default: ESLintUtils.RuleModule<"exportDefaultTypeCheck", [], unknown, ESLintUtils.RuleListener> & {
+    name: string;
+};
 export default _default;

package/dist/rules/stories-export-typed.d.ts

@@ -1,3 +1,5 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-declare const _default: ESLintUtils.RuleModule<"exportStoryType", [], unknown, ESLintUtils.RuleListener>;
+declare const _default: ESLintUtils.RuleModule<"exportStoryType", [], unknown, ESLintUtils.RuleListener> & {
+    name: string;
+};
 export default _default;

package/dist/rules/ts-named-tuple-elements.d.ts

@@ -9,5 +9,7 @@ type Options = [
     }
 ];
 type MessageIds = 'requireNames' | 'forbidNames';
-declare const _default: ESLintUtils.RuleModule<MessageIds, Options, unknown, ESLintUtils.RuleListener>;
+declare const _default: ESLintUtils.RuleModule<MessageIds, Options, unknown, ESLintUtils.RuleListener> & {
+    name: string;
+};
 export default _default;

package/dist/rules/ts-named-tuple-elements.js

@@ -1,4 +1,5 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
+import { exhaustiveCheck } from "./utils/exhaustiveCheck.js";
 export default ESLintUtils.RuleCreator(() => '')({
     name: 'ts-named-tuple-elements',
     defaultOptions: [{ mode: 'always' }],
@@ -41,7 +42,7 @@ export default ESLintUtils.RuleCreator(() => '')({
                     },
                 };
             default:
-                throw new Error(`Invalig mode value: ${String(mode)}`);
+                exhaustiveCheck(mode);
         }
     },
 });

package/dist/rules/utils/exhaustiveCheck.d.ts

@@ -0,0 +1 @@
+export declare function exhaustiveCheck(param: never): never;

package/dist/rules/utils/exhaustiveCheck.js

@@ -0,0 +1,11 @@
+export function exhaustiveCheck(param) {
+    const paramAsString = (() => {
+        try {
+            return JSON.stringify(param);
+        }
+        catch {
+            return String(param);
+        }
+    })();
+    throw new Error(`unknown param: ${paramAsString}`);
+}

package/docs/rules/imports-max-parent-depth.md

@@ -20,7 +20,7 @@ import a from '../../two-up';
 
 ## Options
 
-This rule does not accept inline options, but requires a global ESLint setting:
+This rule does not accept inline options, but allows a global ESLint setting:
 
 ```json
 {

package/docs/rules/no-props-with-children-type.md

@@ -0,0 +1,29 @@
+# Disallow `PropsWithChildren` utility type (no-props-with-children-type)
+
+Disallow the use of `PropsWithChildren` utility type from `@types/react`.
+Prefer explicit `children` prop typing instead, as `PropsWithChildren` makes `children` optional by default,
+which may hide bugs. Additionally, `children` is often narrower than `ReactNode` and should be typed explicitly.
+
+## Rule Details
+
+Examples of **incorrect** code for this rule:
+
+```ts
+type ModalProps = PropsWithChildren<{ title: string }>;
+```
+
+Examples of **correct** code for this rule:
+
+```ts
+type ModalProps = {
+  title: string;
+  children: React.ReactNode;
+};
+```
+
+```ts
+type ModalProps = {
+  title: string;
+  children: string | number;
+};
+```

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@dartess/eslint-plugin",
   "type": "module",
-  "version": "0.10.0",
+  "version": "0.11.2",
   "description": "A set of rules and configs for various TypeScript projects",
   "keywords": [
     "eslint",
@@ -59,6 +59,7 @@
     "eslint-plugin-import-x": "^4.1.0",
     "eslint-plugin-jsx-a11y": "^6.10.0",
     "eslint-plugin-mobx": "~0.0.13",
+    "eslint-plugin-perfectionist": "^5.6.0",
     "eslint-plugin-react-hooks": "^7.0.0",
     "eslint-plugin-storybook": "^10.0.0",
     "eslint-plugin-unicorn": ">=58.0.0",
@@ -88,32 +89,40 @@
     }
   },
   "devDependencies": {
-    "@eslint-community/eslint-plugin-eslint-comments": "^4.6.0",
+    "@eslint-community/eslint-plugin-eslint-comments": "^4.7.1",
+    "@eslint-react/eslint-plugin": "^2.13.0",
     "@eslint/js": "^9.39.2",
+    "@next/eslint-plugin-next": "^16.1.6",
+    "@stylistic/eslint-plugin": "^5.10.0",
     "@types/confusing-browser-globals": "^1.0.3",
     "@types/eslint-plugin-jsx-a11y": "^6.10.1",
     "@types/eslint-plugin-mobx": "~0.0.0",
     "@types/node": "^25.0.2",
-    "@typescript-eslint/rule-tester": "^8.50.0",
-    "eslint": "^9.39.2",
+    "@typescript-eslint/rule-tester": "^8.56.1",
+    "eslint": "^9.39.4",
     "eslint-config-prettier": "^10.1.8",
     "eslint-import-resolver-typescript": "^4.4.4",
-    "eslint-plugin-eslint-plugin": "^7.2.0",
+    "eslint-plugin-complete": "^1.3.0",
+    "eslint-plugin-de-morgan": "^2.1.1",
+    "eslint-plugin-decorator-position": "^6.0.0",
+    "eslint-plugin-eslint-plugin": "^7.3.2",
     "eslint-plugin-import-x": "^4.16.1",
-    "eslint-plugin-prettier": "^5.5.4",
+    "eslint-plugin-perfectionist": "^5.6.0",
+    "eslint-plugin-prettier": "^5.5.5",
     "eslint-plugin-react-hooks": "^7.0.1",
-    "eslint-plugin-unicorn": "^62.0.0",
+    "eslint-plugin-storybook": "^10.2.16",
+    "eslint-plugin-unicorn": "^63.0.0",
     "husky": "^9.1.7",
     "jiti": "^2.6.1",
-    "rimraf": "^6.1.2",
+    "rimraf": "^6.1.3",
     "typescript": "~5.9.3",
-    "typescript-eslint": "^8.50.0"
+    "typescript-eslint": "^8.56.1"
   },
   "dependencies": {
-    "@eslint/compat": "^2.0.0",
-    "@typescript-eslint/utils": "^8.50.0",
+    "@eslint/compat": "^2.0.3",
+    "@typescript-eslint/utils": "^8.56.1",
     "confusing-browser-globals": "^1.0.11",
     "emoji-regex": "^10.6.0",
-    "globals": "^16.5.0"
+    "globals": "^17.4.0"
   }
 }