@darksheep/eslint 6.7.8 → 6.8.1

package/CHANGELOG.md

@@ -1,5 +1,37 @@
 # Changelog
 
+## [6.8.1](https://github.com/DarkSheepSoftware/eslint/compare/v6.8.0...v6.8.1) (2025-02-20)
+
+
+### 🧹 Chores
+
+* why u break things typescript ([b6a1ff1](https://github.com/DarkSheepSoftware/eslint/commit/b6a1ff151f4493bce0e370caef916bb6f563c6f2))
+
+## [6.8.0](https://github.com/DarkSheepSoftware/eslint/compare/v6.7.8...v6.8.0) (2025-02-20)
+
+
+### 🌟 Features
+
+* no-keyword-prefix - checkProperties: false ([6c4f38b](https://github.com/DarkSheepSoftware/eslint/commit/6c4f38bf3f9ccc6b88aaffbf8217beb7c0720ba8))
+* Update some missing rules ([6acf90f](https://github.com/DarkSheepSoftware/eslint/commit/6acf90ff2442775aad5f277e7b2d89c30bed7d8e))
+
+
+### 📦 Dependencies
+
+* **pkg:** update dependency @stylistic/eslint-plugin to v4 ([#834](https://github.com/DarkSheepSoftware/eslint/issues/834)) ([200ad37](https://github.com/DarkSheepSoftware/eslint/commit/200ad3779eb843bc8bdf80015b2d0cc495fe06f1))
+* **pkg:** update dependency editorconfig to v2.0.1 ([#823](https://github.com/DarkSheepSoftware/eslint/issues/823)) ([fb6251c](https://github.com/DarkSheepSoftware/eslint/commit/fb6251cc9fbf1843320566d416e7d27c6eddd314))
+* **pkg:** update dependency eslint-plugin-package-json to v0.26.0 ([#822](https://github.com/DarkSheepSoftware/eslint/issues/822)) ([9aeeff5](https://github.com/DarkSheepSoftware/eslint/commit/9aeeff5129c6a5edd3c206ffe2e9ea195d9e389e))
+* **pkg:** update dependency eslint-plugin-perfectionist to v4.9.0 ([#837](https://github.com/DarkSheepSoftware/eslint/issues/837)) ([9225f97](https://github.com/DarkSheepSoftware/eslint/commit/9225f97e23803accd9f40d8b2ac525f044da13ee))
+* **pkg:** update dependency eslint-plugin-yml to v1.17.0 ([#833](https://github.com/DarkSheepSoftware/eslint/issues/833)) ([39c876c](https://github.com/DarkSheepSoftware/eslint/commit/39c876c2efab1faded19d22d25e75043b155bb72))
+* **pkg:** update eslint monorepo ([#824](https://github.com/DarkSheepSoftware/eslint/issues/824)) ([fe04e20](https://github.com/DarkSheepSoftware/eslint/commit/fe04e204a7f7746f58d040aa066f199c8dc14e42))
+* **pkg:** update typescript-eslint monorepo to v8.24.1 ([#827](https://github.com/DarkSheepSoftware/eslint/issues/827)) ([31b6e9b](https://github.com/DarkSheepSoftware/eslint/commit/31b6e9bd5149bfb2cf5e0c1c887a5b11baeef7b1))
+
+
+### 🧹 Chores
+
+* enable projectService ([6beeec7](https://github.com/DarkSheepSoftware/eslint/commit/6beeec752c5ac32c8b8df1024508624c8faeab8a))
+* eslint . --fix ([52de94a](https://github.com/DarkSheepSoftware/eslint/commit/52de94a2ffde870c87b224370f06c1352034aee8))
+
 ## [6.7.8](https://github.com/DarkSheepSoftware/eslint/compare/v6.7.7...v6.7.8) (2025-02-04)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@darksheep/eslint",
-  "version": "6.7.8",
+  "version": "6.8.1",
   "repository": {
     "type": "git",
     "url": "https://github.com/DarkSheepSoftware/eslint"
@@ -24,31 +24,31 @@
   "dependencies": {
     "@darksheep/environment": "3.1.0",
     "@eslint-community/eslint-plugin-eslint-comments": "4.4.1",
-    "@eslint/js": "9.19.0",
-    "@stylistic/eslint-plugin": "3.0.1",
-    "@typescript-eslint/eslint-plugin": "8.23.0",
-    "@typescript-eslint/parser": "8.23.0",
-    "editorconfig": "2.0.0",
+    "@eslint/js": "9.20.0",
+    "@stylistic/eslint-plugin": "4.0.1",
+    "@typescript-eslint/eslint-plugin": "8.24.1",
+    "@typescript-eslint/parser": "8.24.1",
+    "editorconfig": "2.0.1",
     "eslint-plugin-jsdoc": "50.6.3",
     "eslint-plugin-jsonc": "2.19.1",
     "eslint-plugin-n": "17.15.1",
-    "eslint-plugin-package-json": "0.22.0",
-    "eslint-plugin-perfectionist": "4.8.0",
+    "eslint-plugin-package-json": "0.26.0",
+    "eslint-plugin-perfectionist": "4.9.0",
     "eslint-plugin-promise": "7.2.1",
     "eslint-plugin-react": "7.37.4",
     "eslint-plugin-regexp": "2.7.0",
     "eslint-plugin-security": "3.0.1",
     "eslint-plugin-unicorn": "56.0.1",
     "eslint-plugin-unused-imports": "4.1.4",
-    "eslint-plugin-yml": "1.16.0",
+    "eslint-plugin-yml": "1.17.0",
     "jsonc-eslint-parser": "2.4.0",
     "yaml-eslint-parser": "1.2.3"
   },
   "devDependencies": {
     "@darksheep/eslint-formatter-github": "2.1.0",
     "@types/node": "~22.13.0",
-    "eslint": "~9.19.0",
-    "type-fest": "~4.33.0",
+    "eslint": "~9.20.0",
+    "type-fest": "~4.35.0",
     "typescript": "~5.7.0"
   },
   "peerDependenciesMeta": {
@@ -64,7 +64,7 @@
     "node": "^20 || ^22"
   },
   "volta": {
-    "node": "22.13.1",
+    "node": "22.14.0",
     "yarn": "4.6.0"
   }
 }

package/src/custom-rules/loose-types.js

@@ -1,3 +1,11 @@
+/**
+ * @param {unknown} input - The possible object.
+ * @returns {input is { [key: string]: unknown }}
+ */
+function isObject(input) {
+  return typeof input === 'object' && input != null;
+}
+
 /**
  * @param {string} optionName - Name of the property option.
  * @param {import('eslint').Rule.RuleContext} context - ESLint rule context.
@@ -12,7 +20,10 @@ function createReporter(optionName, context, message) {
    * @returns {void}
    */
   function validateNode(node) {
-    if (options?.[optionName] !== true) {
+    if (
+      isObject(options) &&
+      options[optionName] !== true
+    ) {
       context.report({ node, message });
     }
   }

package/src/plugins/eslint-comments.js

@@ -15,12 +15,13 @@ export function createEslintCommentsConfig() {
         'eslint-comments/disable-enable-pair': [ 'error', { allowWholeFile: true } ],
         'eslint-comments/no-aggregating-enable': 'error',
         'eslint-comments/no-duplicate-disable': 'error',
+        'eslint-comments/no-restricted-disable': 'off',
         'eslint-comments/no-unlimited-disable': 'error',
         'eslint-comments/no-unused-disable': 'error',
         'eslint-comments/no-unused-enable': 'error',
+        'eslint-comments/no-use': 'off',
+        'eslint-comments/require-description': 'off',
 
-        'line-comment-position': 'off',
-        'multiline-comment-style': 'off',
         'no-inline-comments': 'off',
       },
     },

package/src/plugins/package-json.js

@@ -16,14 +16,21 @@ export async function createEslintPackageJsonConfig() {
       },
       files: [ 'package.json', '**/package.json' ],
       rules: {
+        'package-json/no-empty-fields': 'error',
+        'package-json/no-redundant-files': 'error',
         'package-json/order-properties': [ 'error', { order: 'sort-package-json' } ],
         'package-json/prefer-repository-shorthand': 'off',
         'package-json/repository-shorthand': [ 'error', { form: 'object' } ],
+        'package-json/require-author': 'off',
+        'package-json/require-files': 'warn',
+        'package-json/require-keywords': 'off',
+        'package-json/require-name': 'error',
+        'package-json/require-version': 'error',
         'package-json/sort-collections': 'error',
         'package-json/unique-dependencies': 'error',
         'package-json/valid-local-dependency': 'error',
         'package-json/valid-name': 'error',
-        'package-json/valid-package-def': 'warn',
+        'package-json/valid-package-definition': 'warn',
         'package-json/valid-repository-directory': 'error',
         'package-json/valid-version': 'error',
       },

package/src/plugins/perfectionist.js

@@ -29,7 +29,10 @@ const commonRules = {
     },
   ],
   'perfectionist/sort-array-includes': 0,
+  'perfectionist/sort-decorators': 'off',
+  'perfectionist/sort-heritage-clauses': 'off',
   'perfectionist/sort-maps': 0,
+  'perfectionist/sort-modules': 'off',
   'perfectionist/sort-objects': 0,
 };
 

package/src/plugins/promise.js

@@ -15,6 +15,7 @@ export function createEslintPromiseConfig() {
       'promise/no-return-wrap': [ 'error', { allowReject: true } ],
       'promise/prefer-await-to-callbacks': 'off',
       'promise/prefer-await-to-then': 'off',
+      'promise/prefer-catch': 'error',
       'promise/spec-only': 'error',
     },
   } ];

package/src/plugins/react.js

@@ -1,11 +1,34 @@
 import react from 'eslint-plugin-react';
 
 import { getPackageJson } from '../utilities/package.js';
+/** @type {import('eslint').Linter.RulesRecord} */
+const disabledStyle = {
+  'react/jsx-child-element-spacing': 'off',
+  'react/jsx-closing-bracket-location': 'off',
+  'react/jsx-closing-tag-location': 'off',
+  'react/jsx-curly-spacing': 'off',
+  'react/jsx-curly-newline': 'off',
+  'react/jsx-equals-spacing': 'off',
+  'react/jsx-first-prop-new-line': 'off',
+  'react/jsx-indent': 'off',
+  'react/jsx-indent-props': 'off',
+  'react/jsx-max-props-per-line': 'off',
+  'react/jsx-newline': 'off',
+  'react/jsx-one-expression-per-line': 'off',
+  'react/jsx-curly-brace-presence': 'off',
+  'react/jsx-props-no-multi-spaces': 'off',
+  'react/jsx-props-no-spread-multi': 'off',
+  'react/jsx-sort-props': 'off',
+  'react/jsx-tag-spacing': 'off',
+  'react/jsx-wrap-multilines': 'off',
+};
 
 /** @type {import('eslint').Linter.RulesRecord} */
 const rules = {
+  ...disabledStyle,
   'react/boolean-prop-naming': 'off',
   'react/button-has-type': 'off',
+  'react/checked-requires-onchange-or-readonly': 'off',
   'react/default-props-match-prop-types': 'off',
   'react/destructuring-assignment': 'off',
   'react/display-name': 'error',
@@ -14,6 +37,7 @@ const rules = {
   'react/forbid-elements': 'off',
   'react/forbid-foreign-prop-types': 'off',
   'react/forbid-prop-types': 'off',
+  'react/forward-ref-uses-ref': 'off',
   'react/function-component-definition': 'off',
   'react/hook-use-state': 'off',
   'react/iframe-missing-sandbox': 'off',
@@ -107,6 +131,7 @@ export async function createEslintReactConfig(root) {
         },
         plugins: { react },
         rules: {
+          ...Object.fromEntries(Object.entries(rules).map(([ rule ]) => [ rule, 'off' ])),
           'react/jsx-uses-vars': 'error',
         },
       },

package/src/plugins/style.js

@@ -20,6 +20,7 @@ export function createEslintStyleConfig() {
       'style/comma-spacing': [ 'error', { before: false, after: true } ],
       'style/comma-style': [ 'error', 'last' ],
       'style/computed-property-spacing': [ 'error', 'never' ],
+      'style/curly-newline': [ 'error', { consistent: true } ],
       'style/dot-location': [ 'error', 'property' ],
       'style/func-call-spacing': [ 'error', 'never' ],
       'style/function-call-argument-newline': [ 'error', 'consistent' ],

package/src/plugins/typescript.js

@@ -31,6 +31,7 @@ export async function createEslintTypescriptConfig(root) {
       parser: typescriptParser,
       sourceType: 'module',
       parserOptions: {
+        projectService: true,
         warnOnUnsupportedTypeScriptVersion: false,
       },
     },
@@ -40,6 +41,7 @@ export async function createEslintTypescriptConfig(root) {
     rules: {
       // Rules that fight with typescript
       'constructor-super': 'off',
+      'dot-notation': 'off',
       'getter-return': 'off',
       'no-const-assign': 'off',
       'no-dupe-args': 'off',
@@ -80,6 +82,67 @@ export async function createEslintTypescriptConfig(root) {
       '@typescript-eslint/no-require-imports': 'error',
       '@typescript-eslint/prefer-as-const': 'error',
       '@typescript-eslint/triple-slash-reference': 'error',
+
+      // custom extras
+      '@typescript-eslint/adjacent-overload-signatures': 'off',
+      '@typescript-eslint/array-type': 'error',
+      '@typescript-eslint/await-thenable': 'warn',
+      '@typescript-eslint/ban-tslint-comment': 'error',
+      '@typescript-eslint/class-literal-property-style': 'off',
+      '@typescript-eslint/class-methods-use-this': 'off',
+      '@typescript-eslint/consistent-generic-constructors': 'off',
+      '@typescript-eslint/consistent-indexed-object-style': [ 'error', 'index-signature' ],
+      '@typescript-eslint/consistent-return': 'off',
+      '@typescript-eslint/consistent-type-assertions': 'off',
+      '@typescript-eslint/consistent-type-definitions': [ 'error', 'type' ],
+      '@typescript-eslint/consistent-type-exports': [ 'error', { fixMixedExportsWithInlineTypeSpecifier: true } ],
+      '@typescript-eslint/consistent-type-imports': [ 'error', { fixStyle: 'inline-type-imports', prefer: 'no-type-imports' } ],
+      '@typescript-eslint/default-param-last': 'off',
+      '@typescript-eslint/dot-notation': 'error',
+      '@typescript-eslint/explicit-function-return-type': 'off',
+      '@typescript-eslint/explicit-member-accessibility': 'off',
+      '@typescript-eslint/explicit-module-boundary-types': 'off',
+      '@typescript-eslint/init-declarations': 'off',
+      '@typescript-eslint/max-params': 'off',
+      '@typescript-eslint/member-ordering': 'off',
+      '@typescript-eslint/method-signature-style': 'off',
+      '@typescript-eslint/naming-convention': 'off',
+      '@typescript-eslint/no-array-delete': 'error',
+      '@typescript-eslint/no-base-to-string': 'warn',
+      '@typescript-eslint/no-confusing-non-null-assertion': 'warn',
+      '@typescript-eslint/no-confusing-void-expression': 'warn',
+      '@typescript-eslint/no-deprecated': 'error',
+      '@typescript-eslint/only-throw-error': 'error',
+      '@typescript-eslint/prefer-destructuring': 'off',
+      '@typescript-eslint/prefer-enum-initializers': 'off',
+      '@typescript-eslint/prefer-find': 'error',
+      '@typescript-eslint/prefer-for-of': 'error',
+      '@typescript-eslint/prefer-function-type': 'off',
+      '@typescript-eslint/prefer-includes': 'error',
+      '@typescript-eslint/prefer-literal-enum-member': 'off',
+      '@typescript-eslint/prefer-namespace-keyword': 'off',
+      '@typescript-eslint/prefer-nullish-coalescing': 'error',
+      '@typescript-eslint/prefer-optional-chain': 'error',
+      '@typescript-eslint/prefer-promise-reject-errors': 'error',
+      '@typescript-eslint/prefer-readonly-parameter-types': 'off',
+      '@typescript-eslint/prefer-readonly': 'off',
+      '@typescript-eslint/prefer-reduce-type-parameter': 'off',
+      '@typescript-eslint/prefer-regexp-exec': 'off',
+      '@typescript-eslint/prefer-return-this-type': 'off',
+      '@typescript-eslint/prefer-string-starts-ends-with': 'error',
+      '@typescript-eslint/promise-function-async': 'off',
+      '@typescript-eslint/related-getter-setter-pairs': 'off',
+      '@typescript-eslint/require-array-sort-compare': 'off',
+      '@typescript-eslint/require-await': 'warn',
+      '@typescript-eslint/restrict-plus-operands': 'error',
+      '@typescript-eslint/restrict-template-expressions': 'off',
+      '@typescript-eslint/return-await': 'off',
+      '@typescript-eslint/strict-boolean-expressions': 'error',
+      '@typescript-eslint/switch-exhaustiveness-check': 'off',
+      '@typescript-eslint/typedef': 'off',
+      '@typescript-eslint/unbound-method': 'off',
+      '@typescript-eslint/unified-signatures': [ 'warn', { ignoreDifferentlyNamedParameters: true } ],
+      '@typescript-eslint/use-unknown-in-catch-callback-variable': 'error',
     },
   } ];
 }

package/src/plugins/unicorn.js

@@ -28,6 +28,7 @@ export async function createEslintUnicornConfig(root) {
         'unicorn/catch-error-name': 'error',
         'unicorn/consistent-destructuring': 'off',
         'unicorn/consistent-empty-array-spread': 'error',
+        'unicorn/consistent-existence-index-check': 'warn',
         'unicorn/consistent-function-scoping': 'warn',
         'unicorn/custom-error-definition': 'off',
         'unicorn/empty-brace-spaces': 'off',
@@ -55,7 +56,7 @@ export async function createEslintUnicornConfig(root) {
         'unicorn/no-instanceof-array': 'off',
         'unicorn/no-invalid-fetch-options': 'off',
         'unicorn/no-invalid-remove-event-listener': 'error',
-        'unicorn/no-keyword-prefix': 'warn',
+        'unicorn/no-keyword-prefix': [ 'warn', { checkProperties: false } ],
         'unicorn/no-length-as-slice-end': 'warn',
         'unicorn/no-lonely-if': 'warn',
         'unicorn/no-magic-array-flat-depth': 'off', // Breaks typescript
@@ -103,10 +104,12 @@ export async function createEslintUnicornConfig(root) {
         'unicorn/prefer-dom-node-text-content': 'error',
         'unicorn/prefer-event-target': 'warn',
         'unicorn/prefer-export-from': 'warn',
+        'unicorn/prefer-global-this': 'warn',
         'unicorn/prefer-includes': 'error',
         'unicorn/prefer-json-parse-buffer': 'error',
         'unicorn/prefer-keyboard-event-key': 'error',
         'unicorn/prefer-logical-operator-over-ternary': 'error',
+        'unicorn/prefer-math-min-max': 'error',
         'unicorn/prefer-math-trunc': 'error',
         'unicorn/prefer-modern-dom-apis': 'error',
         'unicorn/prefer-modern-math-apis': 'error',

package/src/types.d.ts

@@ -1,7 +1,10 @@
-/* eslint no-duplicate-imports: 0 */
+/* eslint
+  no-duplicate-imports: 0,
+  n/no-unpublished-import:  ["error", { "allowModules": [ "eslint" ] } ]
+*/
 
 declare module '@eslint/js' {
-  import type { ESLint } from 'eslint';
+  import { ESLint } from 'eslint';
   export default {
     configs: {
       all: WithRequired<ESLint.ConfigData, 'rules'>,
@@ -13,22 +16,22 @@ declare module '@eslint/js' {
 type WithRequired<T, K extends keyof T> = T & { [P in K]-?: T[P] };
 
 declare module '@eslint-community/eslint-plugin-eslint-comments' {
-  import type { ESLint } from 'eslint';
+  import { ESLint } from 'eslint';
   export default {} as ESLint.Plugin;
 }
 
 declare module 'eslint-plugin-perfectionist' {
-  import type { ESLint } from 'eslint';
+  import { ESLint } from 'eslint';
   export default {} as ESLint.Plugin;
 }
 
 declare module '@stylistic/eslint-plugin' {
-  import type { ESLint } from 'eslint';
+  import { ESLint } from 'eslint';
   export default {} as WithRequired<ESLint.Plugin, 'environments'>;
 }
 
 declare module 'eslint-plugin-promise' {
-  import type { ESLint } from 'eslint';
+  import { ESLint } from 'eslint';
   export default {} as {
     configs: {
       recommended: WithRequired<ESLint.ConfigData, 'plugins' | 'rules'>;
@@ -38,12 +41,12 @@ declare module 'eslint-plugin-promise' {
 }
 
 declare module 'eslint-plugin-react' {
-  import type { ESLint } from 'eslint';
+  import { ESLint } from 'eslint';
   export default {} as ESLint.Plugin;
 }
 
 declare module 'eslint-plugin-security' {
-  import type { ESLint } from 'eslint';
+  import { ESLint } from 'eslint';
   export default {} as {
     configs: {
       recommended: WithRequired<ESLint.ConfigData, 'plugins' | 'rules'>;