@darksheep/eslint 5.3.0 → 5.3.2

package/src/custom/loose-types.js

@@ -5,158 +5,158 @@
  * @returns {(node: import('eslint').Rule.Node) => void}
  */
 function createReporter(optionName, context, message) {
-    const [ options ] = context.options;
-
-    /**
-     * @param {(
-     *   import('eslint').Rule.Node |
-     *   import('estree').Identifier |
-     *   import('estree').MemberExpression |
-     *   import('estree').ChainExpression |
-     *   import('estree').CallExpression |
-     *   import('estree').LogicalExpression |
-     *   import('estree').UnaryExpression
-     * )} node The AST function node
-     *
-     * @returns {void}
-     */
-    function validateNode(node) {
-        if (options?.[optionName] !== true) {
-            context.report({ node, message });
-        }
+  const [ options ] = context.options;
+
+  /**
+   * @param {(
+   *   import('eslint').Rule.Node |
+   *   import('estree').Identifier |
+   *   import('estree').MemberExpression |
+   *   import('estree').ChainExpression |
+   *   import('estree').CallExpression |
+   *   import('estree').LogicalExpression |
+   *   import('estree').UnaryExpression
+   * )} node The AST function node
+   *
+   * @returns {void}
+   */
+  function validateNode(node) {
+    if (options?.[optionName] !== true) {
+      context.report({ node, message });
     }
+  }
 
-    return validateNode;
+  return validateNode;
 }
 
 /** @type {import('eslint').Rule.RuleModule} */
 const rule = {
-    meta: {
-        type: 'problem',
-        docs: {
-            description: 'Prevent accidental implicit coercion in Expressions',
-            recommended: true,
-        },
-        schema: [
-            {
-                type: 'object',
-                properties: {
-                    allowConditionalExpressionCallExpression: { type: 'boolean' },
-                    allowConditionalExpressionIdentifier: { type: 'boolean' },
-                    allowConditionalExpressionMemberExpression: { type: 'boolean' },
-                    allowConditionalExpressionChainExpression: { type: 'boolean' },
-
-                    allowLogicalExpressionCallExpression: { type: 'boolean' },
-                    allowLogicalExpressionIdentifier: { type: 'boolean' },
-                    allowLogicalExpressionMemberExpression: { type: 'boolean' },
-                    allowLogicalExpressionChainExpression: { type: 'boolean' },
-
-                    allowNegatedUnaryExpression: { type: 'boolean' },
-                },
-                additionalProperties: false,
-            },
-        ],
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'Prevent accidental implicit coercion in Expressions',
+      recommended: true,
     },
-
-    create: function (context) {
-        return {
-            /*
+    schema: [
+      {
+        type: 'object',
+        properties: {
+          allowConditionalExpressionCallExpression: { type: 'boolean' },
+          allowConditionalExpressionIdentifier: { type: 'boolean' },
+          allowConditionalExpressionMemberExpression: { type: 'boolean' },
+          allowConditionalExpressionChainExpression: { type: 'boolean' },
+
+          allowLogicalExpressionCallExpression: { type: 'boolean' },
+          allowLogicalExpressionIdentifier: { type: 'boolean' },
+          allowLogicalExpressionMemberExpression: { type: 'boolean' },
+          allowLogicalExpressionChainExpression: { type: 'boolean' },
+
+          allowNegatedUnaryExpression: { type: 'boolean' },
+        },
+        additionalProperties: false,
+      },
+    ],
+  },
+
+  create: function (context) {
+    return {
+      /*
              *  var b = a ? 'hello' : 'there';
              *  if (a) return 'hello';
              */
-            'Identifier.test': createReporter(
-                'allowConditionalExpressionIdentifier',
-                context,
-                'Unexpected Identifier as Conditional',
-            ),
+      'Identifier.test': createReporter(
+        'allowConditionalExpressionIdentifier',
+        context,
+        'Unexpected Identifier as Conditional',
+      ),
 
-            /*
+      /*
              *  var b = object.key ? 'hello' : 'there';
              *  if (object.key) return 'hello';
              */
-            'MemberExpression.test': createReporter(
-                'allowConditionalExpressionMemberExpression',
-                context,
-                'Unexpected MemberExpression as Conditional',
-            ),
+      'MemberExpression.test': createReporter(
+        'allowConditionalExpressionMemberExpression',
+        context,
+        'Unexpected MemberExpression as Conditional',
+      ),
 
-            /*
+      /*
              *  var b = object?.key ? 'hello' : 'there';
              *  if (object?.key) return 'hello';
              */
-            'ChainExpression.test': createReporter(
-                'allowConditionalExpressionChainExpression',
-                context,
-                'Unexpected ChainExpression as Conditional',
-            ),
+      'ChainExpression.test': createReporter(
+        'allowConditionalExpressionChainExpression',
+        context,
+        'Unexpected ChainExpression as Conditional',
+      ),
 
-            /*
+      /*
              *  var b = a() ? 'hello' : 'there';
              *  if (a()) return 'hello';
              *
              *  var b = object.key() ? 'hello' : 'there';
              *  if (object.key()) return 'hello';
              */
-            'CallExpression.test': createReporter(
-                'allowConditionalExpressionCallExpression',
-                context,
-                'Unexpected CallExpression as Conditional',
-            ),
+      'CallExpression.test': createReporter(
+        'allowConditionalExpressionCallExpression',
+        context,
+        'Unexpected CallExpression as Conditional',
+      ),
 
-            /*
+      /*
              *  one === 1 && two
              *  one === 1 || two
              */
-            'LogicalExpression[operator="&&"] > Identifier.right, LogicalExpression[operator="||"] > Identifier.right': createReporter(
-                'allowLogicalExpressionIdentifier',
-                context,
-                'Unexpected Identifier as right hand of LogicalExpression',
-            ),
+      'LogicalExpression[operator="&&"] > Identifier.right, LogicalExpression[operator="||"] > Identifier.right': createReporter(
+        'allowLogicalExpressionIdentifier',
+        context,
+        'Unexpected Identifier as right hand of LogicalExpression',
+      ),
 
-            /*
+      /*
              *  one === 1 && two()
              *  one === 1 || two()
              *
              *  one === 1 && object.two()
              *  one === 1 || object.two()
              */
-            'LogicalExpression[operator="&&"] > CallExpression.right, LogicalExpression[operator="||"] > CallExpression.right': createReporter(
-                'allowLogicalExpressionCallExpression',
-                context,
-                'Unexpected CallExpression as right hand of LogicalExpression',
-            ),
+      'LogicalExpression[operator="&&"] > CallExpression.right, LogicalExpression[operator="||"] > CallExpression.right': createReporter(
+        'allowLogicalExpressionCallExpression',
+        context,
+        'Unexpected CallExpression as right hand of LogicalExpression',
+      ),
 
-            /*
+      /*
              *  one === 1 && object.two
              *  one === 1 || object.two
              */
-            'LogicalExpression[operator="&&"] > MemberExpression.right, LogicalExpression[operator="||"] > MemberExpression.right': createReporter(
-                'allowLogicalExpressionMemberExpression',
-                context,
-                'Unexpected MemberExpression as right hand of LogicalExpression',
-            ),
+      'LogicalExpression[operator="&&"] > MemberExpression.right, LogicalExpression[operator="||"] > MemberExpression.right': createReporter(
+        'allowLogicalExpressionMemberExpression',
+        context,
+        'Unexpected MemberExpression as right hand of LogicalExpression',
+      ),
 
-            /*
+      /*
              *  one === 1 && object?.two
              *  one === 1 || object?.two
              */
-            'LogicalExpression[operator="&&"] > ChainExpression.right, LogicalExpression[operator="||"] > ChainExpression.right': createReporter(
-                'allowLogicalExpressionChainExpression',
-                context,
-                'Unexpected ChainExpression as right hand of LogicalExpression',
-            ),
+      'LogicalExpression[operator="&&"] > ChainExpression.right, LogicalExpression[operator="||"] > ChainExpression.right': createReporter(
+        'allowLogicalExpressionChainExpression',
+        context,
+        'Unexpected ChainExpression as right hand of LogicalExpression',
+      ),
 
-            /*
+      /*
              *  one && two === 2
              *  one || two === 2
              */
-            'LogicalExpression[operator="&&"] > Identifier.left, LogicalExpression[operator="||"] > Identifier.left': createReporter(
-                'allowLogicalExpressionIdentifier',
-                context,
-                'Unexpected Identifier as left hand of LogicalExpression',
-            ),
+      'LogicalExpression[operator="&&"] > Identifier.left, LogicalExpression[operator="||"] > Identifier.left': createReporter(
+        'allowLogicalExpressionIdentifier',
+        context,
+        'Unexpected Identifier as left hand of LogicalExpression',
+      ),
 
-            /*
+      /*
              *  one() && two === 2
              *  one() || two === 2
              *
@@ -166,39 +166,39 @@ const rule = {
              *  object?.one() && two === 2
              *  object?.one() || two === 2
              */
-            'LogicalExpression[operator="&&"] > CallExpression.left, LogicalExpression[operator="||"] > CallExpression.left': createReporter(
-                'allowLogicalExpressionCallExpression',
-                context,
-                'Unexpected CallExpression as left hand of LogicalExpression',
-            ),
+      'LogicalExpression[operator="&&"] > CallExpression.left, LogicalExpression[operator="||"] > CallExpression.left': createReporter(
+        'allowLogicalExpressionCallExpression',
+        context,
+        'Unexpected CallExpression as left hand of LogicalExpression',
+      ),
 
-            /*
+      /*
              *  object.one && two === 2
              *  object.one || two === 2
              */
-            'LogicalExpression[operator="&&"] > MemberExpression.left, LogicalExpression[operator="||"] > MemberExpression.left': createReporter(
-                'allowLogicalExpressionMemberExpression',
-                context,
-                'Unexpected MemberExpression as left hand of LogicalExpression',
-            ),
+      'LogicalExpression[operator="&&"] > MemberExpression.left, LogicalExpression[operator="||"] > MemberExpression.left': createReporter(
+        'allowLogicalExpressionMemberExpression',
+        context,
+        'Unexpected MemberExpression as left hand of LogicalExpression',
+      ),
 
-            /*
+      /*
              *  object?.one && two === 2
              *  object?.one || two === 2
              */
-            'LogicalExpression[operator="&&"] > ChainExpression.left, LogicalExpression[operator="||"] > ChainExpression.left': createReporter(
-                'allowLogicalExpressionChainExpression',
-                context,
-                'Unexpected ChainExpression as left hand of LogicalExpression',
-            ),
-
-            'UnaryExpression[operator="!"]': createReporter(
-                'allowNegatedUnaryExpression',
-                context,
-                'Unexpected "!" UnaryExpression',
-            ),
-        };
-    },
+      'LogicalExpression[operator="&&"] > ChainExpression.left, LogicalExpression[operator="||"] > ChainExpression.left': createReporter(
+        'allowLogicalExpressionChainExpression',
+        context,
+        'Unexpected ChainExpression as left hand of LogicalExpression',
+      ),
+
+      'UnaryExpression[operator="!"]': createReporter(
+        'allowNegatedUnaryExpression',
+        context,
+        'Unexpected "!" UnaryExpression',
+      ),
+    };
+  },
 };
 
 export default rule;

package/src/custom/no-useless-expression.js

@@ -1,28 +1,28 @@
 const selector = [
-    // test || false, false || test
-    'LogicalExpression[operator="||"] > [type=/Literal$/]',
-    // true && test, test && true
-    'LogicalExpression[operator="&&"] > [type=/Literal$/]',
+  // test || false, false || test
+  'LogicalExpression[operator="||"] > [type=/Literal$/]',
+  // true && test, test && true
+  'LogicalExpression[operator="&&"] > [type=/Literal$/]',
 ].join(', ');
 
 /** @type {import('eslint').Rule.RuleModule} */
 const rule = {
-    meta: { type: 'suggestion' },
+  meta: { type: 'suggestion' },
 
-    create: function (context) {
-        return {
-            /**
-             * @param {import('estree').Literal} node The AST function node
-             * @returns {void}
-             */
-            [selector]: (node) => {
-                context.report({
-                    node: node,
-                    message: 'Unexpected Literal in LogicalExpression',
-                });
-            },
-        };
-    },
+  create: function (context) {
+    return {
+      /**
+       * @param {import('estree').Literal} node The AST function node
+       * @returns {void}
+       */
+      [selector]: (node) => {
+        context.report({
+          node: node,
+          message: 'Unexpected Literal in LogicalExpression',
+        });
+      },
+    };
+  },
 };
 
 export default rule;

package/src/custom/sequence-expression.js

@@ -1,21 +1,21 @@
 /** @type {import('eslint').Rule.RuleModule} */
 const rule = {
-    meta: { type: 'suggestion' },
+  meta: { type: 'suggestion' },
 
-    create: function (context) {
-        return {
-            /**
-             * @param {import('estree').SequenceExpression} node The AST function node
-             * @returns {void}
-             */
-            SequenceExpression: (node) => {
-                context.report({
-                    node: node,
-                    message: 'Unexpected use of a SequenceExpression',
-                });
-            },
-        };
-    },
+  create: function (context) {
+    return {
+      /**
+       * @param {import('estree').SequenceExpression} node The AST function node
+       * @returns {void}
+       */
+      SequenceExpression: (node) => {
+        context.report({
+          node: node,
+          message: 'Unexpected use of a SequenceExpression',
+        });
+      },
+    };
+  },
 };
 
 export default rule;

package/src/index.js

@@ -24,28 +24,28 @@ import { createEslintUnusedImportsConfig } from './plugins/unused-imports.js';
 import { createEslintYmlConfig } from './plugins/yml.js';
 
 const configBuilders = [
-    createEslintIgnoresConfig,
-    createEslintRecommendsConfig,
-    createEslintBaseConfig,
-    createEslintComplexityConfig,
-    createStyleConfig,
-    createEslintCommentsConfig,
-    createEslintNodeConfig,
-    createEslintPerfectionistConfig,
-    createEslintPackageJsonConfig,
-    createEslintJsonConfig,
-    createEslintYmlConfig,
-    createEslintPromiseConfig,
-    createEslintTypescriptConfig,
-    createEslintReactConfig,
-    createEslintSecurityConfig,
-    createEslintUnicornConfig,
-    createEslintRegexpConfig,
-    createEslintSCAConfig,
-    createEslintSonarJSConfig,
-    createEslintStyleConfig,
-    createEslintUnusedImportsConfig,
-    createEslintJSDocConfig,
+  createEslintIgnoresConfig,
+  createEslintRecommendsConfig,
+  createEslintBaseConfig,
+  createEslintComplexityConfig,
+  createStyleConfig,
+  createEslintCommentsConfig,
+  createEslintNodeConfig,
+  createEslintPerfectionistConfig,
+  createEslintPackageJsonConfig,
+  createEslintJsonConfig,
+  createEslintYmlConfig,
+  createEslintPromiseConfig,
+  createEslintTypescriptConfig,
+  createEslintReactConfig,
+  createEslintSecurityConfig,
+  createEslintUnicornConfig,
+  createEslintRegexpConfig,
+  createEslintSCAConfig,
+  createEslintSonarJSConfig,
+  createEslintStyleConfig,
+  createEslintUnusedImportsConfig,
+  createEslintJSDocConfig,
 ];
 
 /**
@@ -53,11 +53,11 @@ const configBuilders = [
  * @returns {Promise<import('eslint').Linter.FlatConfig[]>}
  */
 async function createConfigUrl(root) {
-    const configs = await Promise.all(
-        configBuilders.map((builder) => builder(root)),
-    );
+  const configs = await Promise.all(
+    configBuilders.map((builder) => builder(root)),
+  );
 
-    return configs.flat();
+  return configs.flat();
 }
 
 /**
@@ -65,21 +65,21 @@ async function createConfigUrl(root) {
  * @returns {Promise<import('eslint').Linter.FlatConfig[]>}
  */
 export async function createConfig(root) {
-    if (root instanceof URL) {
-        return createConfigUrl(root);
-    }
+  if (root instanceof URL) {
+    return createConfigUrl(root);
+  }
 
-    if (typeof root !== 'string') {
-        throw new TypeError('Invalid file root');
-    }
+  if (typeof root !== 'string') {
+    throw new TypeError('Invalid file root');
+  }
 
-    root = root
-        // This is to remove: file:/ or file:///
-        .replace(/^file:\/*/, '/')
-        // This is prevent ?time=<stamp>
-        .replace(/\?.*$/, '');
+  root = root
+  // This is to remove: file:/ or file:///
+    .replace(/^file:\/*/, '/')
+  // This is prevent ?time=<stamp>
+    .replace(/\?.*$/, '');
 
-    return createConfigUrl(pathToFileURL(root));
+  return createConfigUrl(pathToFileURL(root));
 }
 
 export * from 'eslint';

package/src/plugins/eslint-comments.js

@@ -5,24 +5,24 @@ import eslintComments from '@eslint-community/eslint-plugin-eslint-comments';
  * @returns {import('eslint').Linter.FlatConfig[]}
  */
 export function createEslintCommentsConfig() {
-    return [
-        {
-            name: 'eslint-comments/custom',
-            plugins: {
-                'eslint-comments': eslintComments,
-            },
-            rules: {
-                'eslint-comments/disable-enable-pair': [ 'error', { allowWholeFile: true } ],
-                'eslint-comments/no-aggregating-enable': 'error',
-                'eslint-comments/no-duplicate-disable': 'error',
-                'eslint-comments/no-unlimited-disable': 'error',
-                'eslint-comments/no-unused-disable': 'error',
-                'eslint-comments/no-unused-enable': 'error',
+  return [
+    {
+      name: 'eslint-comments/custom',
+      plugins: {
+        'eslint-comments': eslintComments,
+      },
+      rules: {
+        'eslint-comments/disable-enable-pair': [ 'error', { allowWholeFile: true } ],
+        'eslint-comments/no-aggregating-enable': 'error',
+        'eslint-comments/no-duplicate-disable': 'error',
+        'eslint-comments/no-unlimited-disable': 'error',
+        'eslint-comments/no-unused-disable': 'error',
+        'eslint-comments/no-unused-enable': 'error',
 
-                // 'line-comment-position': 'off',
-                // 'multiline-comment-style': 'off',
-                'no-inline-comments': 'off',
-            },
-        },
-    ];
+        // 'line-comment-position': 'off',
+        // 'multiline-comment-style': 'off',
+        'no-inline-comments': 'off',
+      },
+    },
+  ];
 }