@darksheep/eslint 5.3.0 → 5.3.1

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [5.3.1](https://github.com/DarkSheepSoftware/eslint/compare/v5.3.0...v5.3.1) (2024-08-08)
+
+
+### 📦 Dependencies
+
+* **pkg:** update dependency @stylistic/eslint-plugin to v2.6.2 ([#564](https://github.com/DarkSheepSoftware/eslint/issues/564)) ([6d4296b](https://github.com/DarkSheepSoftware/eslint/commit/6d4296b5f5d24468bd29e640f4651842d959e899))
+* **pkg:** update dependency eslint-plugin-unused-imports to v4.1.2 ([#563](https://github.com/DarkSheepSoftware/eslint/issues/563)) ([464a465](https://github.com/DarkSheepSoftware/eslint/commit/464a465b6293ae94d049f55d311e0ae4d09dd8d8))
+
 ## [5.3.0](https://github.com/DarkSheepSoftware/eslint/compare/v5.2.1...v5.3.0) (2024-08-08)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@darksheep/eslint",
-  "version": "5.3.0",
+  "version": "5.3.1",
   "repository": {
     "type": "git",
     "url": "https://github.com/DarkSheepSoftware/eslint"
@@ -24,7 +24,7 @@
     "@eslint-community/eslint-plugin-eslint-comments": "4.3.0",
     "@eslint/eslintrc": "3.1.0",
     "@eslint/js": "9.8.0",
-    "@stylistic/eslint-plugin": "2.6.1",
+    "@stylistic/eslint-plugin": "2.6.2",
     "@typescript-eslint/eslint-plugin": "8.0.1",
     "@typescript-eslint/parser": "8.0.1",
     "editorconfig": "2.0.0",
@@ -39,7 +39,7 @@
     "eslint-plugin-security": "3.0.1",
     "eslint-plugin-sonarjs": "1.0.4",
     "eslint-plugin-unicorn": "55.0.0",
-    "eslint-plugin-unused-imports": "4.0.1",
+    "eslint-plugin-unused-imports": "4.1.2",
     "eslint-plugin-yml": "1.14.0",
     "jsonc-eslint-parser": "2.4.0",
     "yaml-eslint-parser": "1.2.3"

package/src/configs/eslint-base.js

@@ -1,110 +1,110 @@
 /** @type {import('eslint').Linter.RulesRecord} */
 const rules = {
-    'no-else-return': 'error',
+  'no-else-return': 'error',
 
-    'radix': 'error',
-    'prefer-exponentiation-operator': 'error',
+  'radix': 'error',
+  'prefer-exponentiation-operator': 'error',
 
-    'class-methods-use-this': 'off',
-    'no-eval': 'error',
-    'no-extend-native': 'error',
-    'no-implicit-coercion': 'error',
-    'no-implied-eval': 'error',
-    'no-invalid-this': 'error',
-    'no-new-func': 'error',
-    'no-proto': 'error',
-    'no-script-url': 'error',
-    'no-unexpected-multiline': 'error',
-    'no-void': 'error',
+  'class-methods-use-this': 'off',
+  'no-eval': 'error',
+  'no-extend-native': 'error',
+  'no-implicit-coercion': 'error',
+  'no-implied-eval': 'error',
+  'no-invalid-this': 'error',
+  'no-new-func': 'error',
+  'no-proto': 'error',
+  'no-script-url': 'error',
+  'no-unexpected-multiline': 'error',
+  'no-void': 'error',
 
-    'no-caller': 'error',
-    'no-empty': [ 'error', { allowEmptyCatch: true } ],
-    'no-empty-function': [ 'error', { allow: [ 'arrowFunctions' ] } ],
-    'no-labels': 'error',
-    'no-lone-blocks': 'error',
-    'no-loop-func': 'error',
-    'no-misleading-character-class': 'error',
-    'no-new-wrappers': 'error',
-    'no-new': 'error',
-    'no-undef': [ 'error', { typeof: true } ],
-    'no-use-before-define': 'off',
+  'no-caller': 'error',
+  'no-empty': [ 'error', { allowEmptyCatch: true } ],
+  'no-empty-function': [ 'error', { allow: [ 'arrowFunctions' ] } ],
+  'no-labels': 'error',
+  'no-lone-blocks': 'error',
+  'no-loop-func': 'error',
+  'no-misleading-character-class': 'error',
+  'no-new-wrappers': 'error',
+  'no-new': 'error',
+  'no-undef': [ 'error', { typeof: true } ],
+  'no-use-before-define': 'off',
 
-    'arrow-body-style': [ 'error', 'as-needed' ],
-    'constructor-super': 'error',
-    'no-class-assign': 'error',
-    'no-const-assign': 'error',
-    'no-dupe-class-members': 'error',
-    'no-duplicate-imports': 'error',
-    'no-new-native-nonconstructor': 'error',
-    'no-restricted-imports': 'error',
-    'no-this-before-super': 'error',
-    'no-useless-computed-key': 'error',
-    'no-useless-constructor': 'error',
-    'no-useless-rename': 'error',
-    'no-var': 'error',
-    'object-shorthand': [ 'error', 'consistent-as-needed' ],
-    'prefer-arrow-callback': [
-        'error',
-        {
-            allowNamedFunctions: false,
-            allowUnboundThis: true,
-        },
-    ],
-    'prefer-const': 'error',
-    'prefer-destructuring': [
-        'error',
-        { array: false, object: true },
-        { enforceForRenamedProperties: false },
-    ],
-    'prefer-numeric-literals': 'error',
-    'prefer-rest-params': 'error',
-    'prefer-spread': 'error',
-    'prefer-template': 'error',
-    'require-yield': 'error',
-    'sort-imports': 'off',
-    'symbol-description': 'error',
+  'arrow-body-style': [ 'error', 'as-needed' ],
+  'constructor-super': 'error',
+  'no-class-assign': 'error',
+  'no-const-assign': 'error',
+  'no-dupe-class-members': 'error',
+  'no-duplicate-imports': 'error',
+  'no-new-native-nonconstructor': 'error',
+  'no-restricted-imports': 'error',
+  'no-this-before-super': 'error',
+  'no-useless-computed-key': 'error',
+  'no-useless-constructor': 'error',
+  'no-useless-rename': 'error',
+  'no-var': 'error',
+  'object-shorthand': [ 'error', 'consistent-as-needed' ],
+  'prefer-arrow-callback': [
+    'error',
+    {
+      allowNamedFunctions: false,
+      allowUnboundThis: true,
+    },
+  ],
+  'prefer-const': 'error',
+  'prefer-destructuring': [
+    'error',
+    { array: false, object: true },
+    { enforceForRenamedProperties: false },
+  ],
+  'prefer-numeric-literals': 'error',
+  'prefer-rest-params': 'error',
+  'prefer-spread': 'error',
+  'prefer-template': 'error',
+  'require-yield': 'error',
+  'sort-imports': 'off',
+  'symbol-description': 'error',
 
-    'eqeqeq': [ 'error', 'always', { null: 'ignore' } ],
-    'no-extra-bind': 'error',
-    'no-loss-of-precision': 'error',
-    'no-useless-call': 'error',
-    'no-useless-catch': 'error',
-    'no-useless-concat': 'error',
-    'no-useless-escape': 'error',
-    'no-useless-return': 'error',
-    'no-multi-str': 'error',
-    'no-octal': 'error',
-    'no-octal-escape': 'error',
-    'no-return-assign': 'error',
-    'prefer-promise-reject-errors': 'error',
-    'require-await': 'off',
+  'eqeqeq': [ 'error', 'always', { null: 'ignore' } ],
+  'no-extra-bind': 'error',
+  'no-loss-of-precision': 'error',
+  'no-useless-call': 'error',
+  'no-useless-catch': 'error',
+  'no-useless-concat': 'error',
+  'no-useless-escape': 'error',
+  'no-useless-return': 'error',
+  'no-multi-str': 'error',
+  'no-octal': 'error',
+  'no-octal-escape': 'error',
+  'no-return-assign': 'error',
+  'prefer-promise-reject-errors': 'error',
+  'require-await': 'off',
 
-    'no-shadow-restricted-names': 'error',
-    'no-undefined': 'off',
+  'no-shadow-restricted-names': 'error',
+  'no-undefined': 'off',
 
-    'func-name-matching': [ 'error', 'never' ],
-    'func-style': [
-        'error',
-        'declaration',
-        { allowArrowFunctions: true },
-    ],
-    'consistent-this': [ 'error', 'that' ],
-    'no-array-constructor': 'error',
-    'no-lonely-if': 'error',
-    'no-negated-condition': 'error',
-    'no-object-constructor': 'error',
-    'no-nested-ternary': 'warn',
-    'no-unneeded-ternary': 'warn',
+  'func-name-matching': [ 'error', 'never' ],
+  'func-style': [
+    'error',
+    'declaration',
+    { allowArrowFunctions: true },
+  ],
+  'consistent-this': [ 'error', 'that' ],
+  'no-array-constructor': 'error',
+  'no-lonely-if': 'error',
+  'no-negated-condition': 'error',
+  'no-object-constructor': 'error',
+  'no-nested-ternary': 'warn',
+  'no-unneeded-ternary': 'warn',
 
-    'one-var': [
-        'error',
-        'never',
-    ],
-    'operator-assignment': [ 'error', 'always' ],
+  'one-var': [
+    'error',
+    'never',
+  ],
+  'operator-assignment': [ 'error', 'always' ],
 
-    'yoda': 'error',
+  'yoda': 'error',
 
-    'prefer-object-spread': 'error',
+  'prefer-object-spread': 'error',
 };
 
 /**
@@ -112,13 +112,13 @@ const rules = {
  * @returns {Promise<import('eslint').Linter.FlatConfig[]>}
  */
 export async function createEslintBaseConfig() {
-    return [ {
-        name: 'darksheep/base',
-        linterOptions: {
-            noInlineConfig: false,
-            reportUnusedDisableDirectives: true,
-        },
+  return [ {
+    name: 'darksheep/base',
+    linterOptions: {
+      noInlineConfig: false,
+      reportUnusedDisableDirectives: true,
+    },
 
-        rules: rules,
-    } ];
+    rules: rules,
+  } ];
 }

package/src/configs/eslint-complexity.js

@@ -3,29 +3,29 @@
  * @returns {import('eslint').Linter.FlatConfig[]}
  */
 export function createEslintComplexityConfig() {
-    return [ {
-        name: 'darksheep/complexity',
-        rules: {
-            'max-depth': [ 'error', 4 ],
-            'complexity': 'off',
-            'max-lines': [
-                'warn',
-                {
-                    max: 512,
-                    skipBlankLines: true,
-                    skipComments: true,
-                },
-            ],
-            'max-lines-per-function': [
-                'warn',
-                {
-                    max: 120,
-                    skipBlankLines: true,
-                    skipComments: true,
-                },
-            ],
-            'max-nested-callbacks': [ 'warn', 3 ],
-            'max-params': [ 'error', 5 ],
+  return [ {
+    name: 'darksheep/complexity',
+    rules: {
+      'max-depth': [ 'error', 4 ],
+      'complexity': 'off',
+      'max-lines': [
+        'warn',
+        {
+          max: 512,
+          skipBlankLines: true,
+          skipComments: true,
         },
-    } ];
+      ],
+      'max-lines-per-function': [
+        'warn',
+        {
+          max: 120,
+          skipBlankLines: true,
+          skipComments: true,
+        },
+      ],
+      'max-nested-callbacks': [ 'warn', 3 ],
+      'max-params': [ 'error', 5 ],
+    },
+  } ];
 }

package/src/configs/eslint-ignores.js

@@ -9,23 +9,23 @@ import { findUp } from '../utilities/filesystem.js';
  * @returns {Promise<string[]>}
  */
 async function getGitignore(root) {
-    const rootPath = fileURLToPath(root);
-    const gitPath = await findUp(rootPath, '.git');
-    const path = resolve(gitPath ?? rootPath, '..', '.gitignore');
-
-    try {
-        const raw = await fs.readFile(path, 'utf8');
-
-        return raw
-            .split(/\r?\n|\r/)
-            .filter(Boolean);
-    } catch (error) {
-        if (/** @type {NodeJS.ErrnoException} */ (error).code === 'ENOENT') {
-            return [];
-        }
-
-        throw error;
+  const rootPath = fileURLToPath(root);
+  const gitPath = await findUp(rootPath, '.git');
+  const path = resolve(gitPath ?? rootPath, '..', '.gitignore');
+
+  try {
+    const raw = await fs.readFile(path, 'utf8');
+
+    return raw
+      .split(/\r?\n|\r/)
+      .filter(Boolean);
+  } catch (error) {
+    if (/** @type {NodeJS.ErrnoException} */ (error).code === 'ENOENT') {
+      return [];
     }
+
+    throw error;
+  }
 }
 
 /**
@@ -34,20 +34,20 @@ async function getGitignore(root) {
  * @returns {Promise<import('eslint').Linter.FlatConfig[]>}
  */
 export async function createEslintIgnoresConfig(root) {
-    const ignores = await getGitignore(root);
-
-    return [ {
-        name: 'darksheep/git-ignores',
-        ignores: [
-            ...ignores,
-
-            // Some things we always want to ignore
-            '.yarn/',
-            '.pnp.cjs',
-            '.pnp.loader.mjs',
-            '.git/',
-            'coverage/',
-            'node_modules/',
-        ],
-    } ];
+  const ignores = await getGitignore(root);
+
+  return [ {
+    name: 'darksheep/git-ignores',
+    ignores: [
+      ...ignores,
+
+      // Some things we always want to ignore
+      '.yarn/',
+      '.pnp.cjs',
+      '.pnp.loader.mjs',
+      '.git/',
+      'coverage/',
+      'node_modules/',
+    ],
+  } ];
 }

package/src/configs/eslint-recommended.js

@@ -5,8 +5,8 @@ import js from '@eslint/js';
  * @returns {Promise<import('eslint').Linter.FlatConfig[]>}
  */
 export async function createEslintRecommendsConfig() {
-    return [ {
-        name: 'eslint/recomended',
-        ...js.configs.recommended,
-    } ];
+  return [ {
+    name: 'eslint/recomended',
+    ...js.configs.recommended,
+  } ];
 }

package/src/configs/eslint-style.js

@@ -2,12 +2,12 @@ import { createEditorOverrides } from '../utilities/editorconfig.js';
 
 /** @type {import('eslint').Linter.RulesRecord} */
 const rules = {
-    'dot-notation': 'error',
-    'curly': 'error',
-    'unicode-bom': [ 'error', 'never' ],
+  'dot-notation': 'error',
+  'curly': 'error',
+  'unicode-bom': [ 'error', 'never' ],
 
-    'no-div-regex': 'error',
-    'no-control-regex': 'error',
+  'no-div-regex': 'error',
+  'no-control-regex': 'error',
 };
 
 /**
@@ -16,11 +16,11 @@ const rules = {
  * @returns {Promise<import('eslint').Linter.FlatConfig[]>}
  */
 export async function createStyleConfig(root) {
-    return [
-        {
-            name: 'style/core',
-            rules: rules,
-        },
-        ...await createEditorOverrides(root),
-    ];
+  return [
+    {
+      name: 'style/core',
+      rules: rules,
+    },
+    ...await createEditorOverrides(root),
+  ];
 }

package/src/custom/index.js

@@ -3,9 +3,9 @@ import noUselessExpression from './no-useless-expression.js';
 import sequenceExpression from './sequence-expression.js';
 
 export default {
-    rules: {
-        'loose-types': looseTypes,
-        'no-useless-expression': noUselessExpression,
-        'sequence-expression': sequenceExpression,
-    },
+  rules: {
+    'loose-types': looseTypes,
+    'no-useless-expression': noUselessExpression,
+    'sequence-expression': sequenceExpression,
+  },
 };

package/src/custom/instance-of-array.js

@@ -3,23 +3,23 @@
  * @returns {import('eslint').Rule.RuleListener}
  */
 const preferInstance = (context) => ({
-    /**
-     * @param {import('estree').CallExpression} node The AST function node
-     * @returns {void}
-     */
-    'CallExpression[callee.object.name = "Array"][callee.property.name = "isArray"]': (node) => {
-        const message = 'Use `instanceof Array` instead of `Array.isArray()`';
+  /**
+   * @param {import('estree').CallExpression} node The AST function node
+   * @returns {void}
+   */
+  'CallExpression[callee.object.name = "Array"][callee.property.name = "isArray"]': (node) => {
+    const message = 'Use `instanceof Array` instead of `Array.isArray()`';
 
-        if (node.arguments.length !== 1) {
-            return context.report({ node, message });
-        }
+    if (node.arguments.length !== 1) {
+      return context.report({ node, message });
+    }
 
-        const left = context.sourceCode.getText(node.arguments[0]);
-        /** @type {import('eslint').Rule.ReportFixer} */
-        const fix = (fixer) => fixer.replaceText(node, `${left} instanceof Array`);
+    const left = context.sourceCode.getText(node.arguments[0]);
+    /** @type {import('eslint').Rule.ReportFixer} */
+    const fix = (fixer) => fixer.replaceText(node, `${left} instanceof Array`);
 
-        context.report({ node, message, fix });
-    },
+    context.report({ node, message, fix });
+  },
 });
 
 /**
@@ -27,46 +27,46 @@ const preferInstance = (context) => ({
  * @returns {import('eslint').Rule.RuleListener}
  */
 const preferIsArray = (context) => ({
-    /**
-     * @param {import('estree').BinaryExpression} node The AST function node
-     * @returns {void}
-     */
-    'BinaryExpression[operator="instanceof"][right.type="Identifier"][right.name="Array"]': (node) => {
-        const message = 'Use `Array.isArray()` instead of `instanceof Array`';
+  /**
+   * @param {import('estree').BinaryExpression} node The AST function node
+   * @returns {void}
+   */
+  'BinaryExpression[operator="instanceof"][right.type="Identifier"][right.name="Array"]': (node) => {
+    const message = 'Use `Array.isArray()` instead of `instanceof Array`';
 
-        const argument = context.sourceCode.getText(node.left);
-        /** @type {import('eslint').Rule.ReportFixer} */
-        const fix = (fixer) => fixer.replaceText(node, `Array.isArray(${argument})`);
+    const argument = context.sourceCode.getText(node.left);
+    /** @type {import('eslint').Rule.ReportFixer} */
+    const fix = (fixer) => fixer.replaceText(node, `Array.isArray(${argument})`);
 
-        context.report({ node, message, fix });
-    },
+    context.report({ node, message, fix });
+  },
 });
 
 /** @type {import('eslint').Rule.RuleModule} */
 const rule = {
-    meta: {
-        type: 'suggestion',
-        fixable: 'code',
-        schema: [
-            {
-                type: 'string',
-                enum: [
-                    'instanceof',
-                    'isarray',
-                ],
-            },
+  meta: {
+    type: 'suggestion',
+    fixable: 'code',
+    schema: [
+      {
+        type: 'string',
+        enum: [
+          'instanceof',
+          'isarray',
         ],
-    },
+      },
+    ],
+  },
 
-    create: function (context) {
-        const [ option = 'instanceof' ] = context.options;
+  create: function (context) {
+    const [ option = 'instanceof' ] = context.options;
 
-        if (option === 'instanceof') {
-            return preferInstance(context);
-        }
+    if (option === 'instanceof') {
+      return preferInstance(context);
+    }
 
-        return preferIsArray(context);
-    },
+    return preferIsArray(context);
+  },
 };
 
 export default rule;