@darksheep/eslint 5.1.5 → 5.2.0

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [5.2.0](https://github.com/DarkSheepSoftware/eslint/compare/v5.1.5...v5.2.0) (2024-08-06)
+
+
+### 🌟 Features
+
+* remove deprecated rules and add config names ([5765861](https://github.com/DarkSheepSoftware/eslint/commit/57658619314ced4312467ae58bfcc09cee98cf8b))
+* Unbundle eslint ([f0550b5](https://github.com/DarkSheepSoftware/eslint/commit/f0550b5910327b0e9f74e4ee78ca296d279f37b0))
+
+
+### 📦 Dependencies
+
+* **pkg:** update dependency eslint-plugin-perfectionist to v3.1.2 ([#550](https://github.com/DarkSheepSoftware/eslint/issues/550)) ([c0da407](https://github.com/DarkSheepSoftware/eslint/commit/c0da407889520a13f401411974f397c34360bc46))
+* **pkg:** update typescript-eslint monorepo to v8.0.1 ([#551](https://github.com/DarkSheepSoftware/eslint/issues/551)) ([1dfbc75](https://github.com/DarkSheepSoftware/eslint/commit/1dfbc75f37d53aa4ee0df19ab90d01a0964adb68))
+
 ## [5.1.5](https://github.com/DarkSheepSoftware/eslint/compare/v5.1.4...v5.1.5) (2024-08-05)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@darksheep/eslint",
-  "version": "5.1.5",
+  "version": "5.2.0",
   "repository": {
     "type": "git",
     "url": "https://github.com/DarkSheepSoftware/eslint"
@@ -13,7 +13,6 @@
     }
   },
   "types": "./types/src/index.d.ts",
-  "bin": "./src/bin/eslint.cjs",
   "files": [
     "src",
     "types"
@@ -26,15 +25,14 @@
     "@eslint/eslintrc": "3.1.0",
     "@eslint/js": "9.8.0",
     "@stylistic/eslint-plugin": "2.6.1",
-    "@typescript-eslint/eslint-plugin": "8.0.0",
-    "@typescript-eslint/parser": "8.0.0",
+    "@typescript-eslint/eslint-plugin": "8.0.1",
+    "@typescript-eslint/parser": "8.0.1",
     "editorconfig": "2.0.0",
-    "eslint": "9.8.0",
     "eslint-plugin-jsdoc": "48.11.0",
     "eslint-plugin-jsonc": "2.16.0",
     "eslint-plugin-n": "17.10.2",
     "eslint-plugin-package-json": "0.15.2",
-    "eslint-plugin-perfectionist": "3.1.1",
+    "eslint-plugin-perfectionist": "3.1.2",
     "eslint-plugin-promise": "7.0.0",
     "eslint-plugin-react": "7.35.0",
     "eslint-plugin-regexp": "2.6.0",
@@ -51,9 +49,13 @@
     "@types/eslint__js": "~8.42.3",
     "@types/estree": "~1.0.2",
     "@types/node": "~20.14.0",
+    "eslint": "~9.8.0",
     "type-fest": "~4.23.0",
     "typescript": "~5.5.0"
   },
+  "peerDependencies": {
+    "eslint": "~9.8.0"
+  },
   "peerDependenciesMeta": {
     "typescript": {
       "optional": true

package/src/configs/eslint-base.js

@@ -12,7 +12,6 @@ const rules = {
     'no-implied-eval': 'error',
     'no-invalid-this': 'error',
     'no-new-func': 'error',
-    'no-process-env': 'off',
     'no-proto': 'error',
     'no-script-url': 'error',
     'no-unexpected-multiline': 'error',
@@ -36,7 +35,7 @@ const rules = {
     'no-const-assign': 'error',
     'no-dupe-class-members': 'error',
     'no-duplicate-imports': 'error',
-    'no-new-symbol': 'error',
+    'no-new-native-nonconstructor': 'error',
     'no-restricted-imports': 'error',
     'no-this-before-super': 'error',
     'no-useless-computed-key': 'error',
@@ -67,6 +66,7 @@ const rules = {
 
     'eqeqeq': [ 'error', 'always', { null: 'ignore' } ],
     'no-extra-bind': 'error',
+    'no-loss-of-precision': 'error',
     'no-useless-call': 'error',
     'no-useless-catch': 'error',
     'no-useless-concat': 'error',
@@ -76,7 +76,6 @@ const rules = {
     'no-octal': 'error',
     'no-octal-escape': 'error',
     'no-return-assign': 'error',
-    'no-return-await': 'error',
     'prefer-promise-reject-errors': 'error',
     'require-await': 'off',
 
@@ -93,7 +92,7 @@ const rules = {
     'no-array-constructor': 'error',
     'no-lonely-if': 'error',
     'no-negated-condition': 'error',
-    'no-new-object': 'error',
+    'no-object-constructor': 'error',
     'no-nested-ternary': 'warn',
     'no-unneeded-ternary': 'warn',
 
@@ -114,6 +113,7 @@ const rules = {
  */
 export async function createEslintBaseConfig() {
     return [ {
+        name: 'darksheep/base',
         linterOptions: {
             noInlineConfig: false,
             reportUnusedDisableDirectives: true,

package/src/configs/eslint-complexity.js

@@ -3,26 +3,29 @@
  * @returns {import('eslint').Linter.FlatConfig[]}
  */
 export function createEslintComplexityConfig() {
-    return [ { rules: {
-        'max-depth': [ 'error', 4 ],
-        'complexity': 'off',
-        'max-lines': [
-            'warn',
-            {
-                max: 512,
-                skipBlankLines: true,
-                skipComments: true,
-            },
-        ],
-        'max-lines-per-function': [
-            'warn',
-            {
-                max: 120,
-                skipBlankLines: true,
-                skipComments: true,
-            },
-        ],
-        'max-nested-callbacks': [ 'warn', 3 ],
-        'max-params': [ 'error', 5 ],
-    } } ];
+    return [ {
+        name: 'darksheep/complexity',
+        rules: {
+            'max-depth': [ 'error', 4 ],
+            'complexity': 'off',
+            'max-lines': [
+                'warn',
+                {
+                    max: 512,
+                    skipBlankLines: true,
+                    skipComments: true,
+                },
+            ],
+            'max-lines-per-function': [
+                'warn',
+                {
+                    max: 120,
+                    skipBlankLines: true,
+                    skipComments: true,
+                },
+            ],
+            'max-nested-callbacks': [ 'warn', 3 ],
+            'max-params': [ 'error', 5 ],
+        },
+    } ];
 }

package/src/configs/eslint-ignores.js

@@ -37,6 +37,7 @@ export async function createEslintIgnoresConfig(root) {
     const ignores = await getGitignore(root);
 
     return [ {
+        name: 'darksheep/git-ignores',
         ignores: [
             ...ignores,
 

package/src/configs/eslint-recommended.js

@@ -5,5 +5,8 @@ import js from '@eslint/js';
  * @returns {Promise<import('eslint').Linter.FlatConfig[]>}
  */
 export async function createEslintRecommendsConfig() {
-    return [ js.configs.recommended ];
+    return [ {
+        name: 'eslint/recomended',
+        ...js.configs.recommended,
+    } ];
 }

package/src/configs/eslint-style.js

@@ -17,7 +17,10 @@ const rules = {
  */
 export async function createStyleConfig(root) {
     return [
-        { rules },
+        {
+            name: 'style/core',
+            rules: rules,
+        },
         ...await createEditorOverrides(root),
     ];
 }

package/src/plugins/eslint-comments.js

@@ -7,6 +7,7 @@ import eslintComments from '@eslint-community/eslint-plugin-eslint-comments';
 export function createEslintCommentsConfig() {
     return [
         {
+            name: 'eslint-comments/custom',
             plugins: {
                 'eslint-comments': eslintComments,
             },
@@ -18,8 +19,8 @@ export function createEslintCommentsConfig() {
                 'eslint-comments/no-unused-disable': 'error',
                 'eslint-comments/no-unused-enable': 'error',
 
-                'line-comment-position': 'off',
-                'multiline-comment-style': 'off',
+                // 'line-comment-position': 'off',
+                // 'multiline-comment-style': 'off',
                 'no-inline-comments': 'off',
             },
         },

package/src/plugins/jsdoc.js

@@ -14,6 +14,7 @@ export async function createEslintJSDocConfig(root) {
 
     return [
         {
+            name: 'jsdoc/javascript',
             plugins: { jsdoc },
             settings: {
                 jsdoc: {
@@ -53,6 +54,7 @@ export async function createEslintJSDocConfig(root) {
             },
         },
         {
+            name: 'jsdoc/typescript',
             files: getTypescriptFiles(),
             rules: {
                 'jsdoc/no-types': 'warn',

package/src/plugins/json.js

@@ -1,8 +1,6 @@
 import jsonc from 'eslint-plugin-jsonc';
 import parser from 'jsonc-eslint-parser';
 
-import { getJsonFiles } from '../utilities/eslint-files.js';
-
 /**
  * Get ESLint config for imports check
  * @returns {Promise<import('eslint').Linter.FlatConfig[]>}
@@ -10,22 +8,26 @@ import { getJsonFiles } from '../utilities/eslint-files.js';
 export async function createEslintJsonConfig() {
     return [
         {
-            files: await getJsonFiles(),
+            name: 'json/core',
+            files: [ '**/*.json', '**/*.jsonc', '**/*.json5' ],
             languageOptions: { parser },
             // @ts-expect-error jsonc does not match the plugin interface
             plugins: { jsonc },
         },
         {
+            name: 'json/.json',
             files: [ '**/*.json' ],
             // @ts-expect-error Record<string, string> vs Record<string, 'error'>
             rules: jsonc.configs['recommended-with-json'].rules,
         },
         {
+            name: 'json/.jsonc',
             files: [ '**/*.jsonc' ],
             // @ts-expect-error Record<string, string> vs Record<string, 'error'>
             rules: jsonc.configs['recommended-with-jsonc'].rules,
         },
         {
+            name: 'json/.json5',
             files: [ '**/*.json5' ],
             // @ts-expect-error Record<string, string> vs Record<string, 'error'>
             rules: jsonc.configs['recommended-with-json5'].rules,

package/src/plugins/node.js

@@ -22,6 +22,7 @@ const commonRules = {
     'n/callback-return': 'error',
     'n/handle-callback-err': 'error',
     'n/no-process-exit': 'warn',
+    'n/no-process-env': 'warn',
     'n/no-path-concat': 'error',
 
     'n/no-callback-literal': 'off',
@@ -77,6 +78,7 @@ export async function createEslintNodeConfig(root) {
 
     return [
         {
+            name: 'node/common',
             files: commonFiles,
             ignores: exampleFiles,
             plugins: { n },
@@ -103,6 +105,7 @@ export async function createEslintNodeConfig(root) {
             },
         },
         {
+            name: 'node/module-and-typescript',
             files: [ ...typescriptFiles, ...moduleFiles ],
             ignores: exampleFiles,
             plugins: { n },
@@ -128,6 +131,7 @@ export async function createEslintNodeConfig(root) {
             },
         },
         {
+            name: 'node/test-files',
             files: getTestFiles(),
             plugins: { n },
             rules: { 'n/no-sync': 'off' },

package/src/plugins/package-json.js

@@ -8,6 +8,7 @@ import jsoncParser from 'jsonc-eslint-parser';
 export async function createEslintPackageJsonConfig() {
     return [
         {
+            name: 'package-json/custom',
             // @ts-expect-error
             plugins: { 'package-json': plugin },
             languageOptions: {

package/src/plugins/perfectionist.js

@@ -202,20 +202,18 @@ const typescriptRules = {
  * @returns {Promise<import('eslint').Linter.FlatConfig[]>}
  */
 export async function createEslintPerfectionistConfig(root) {
-    const commonFiles = await getCommonFiles(root);
-    const moduleFiles = await getModuleFiles(root);
-    const typescriptFiles = getTypescriptFiles();
-
     return [
         {
-            files: commonFiles,
+            name: 'perfectionist/common',
+            files: await getCommonFiles(root),
             plugins: { perfectionist },
             rules: {
                 ...commonRules,
             },
         },
         {
-            files: moduleFiles,
+            name: 'perfectionist/module',
+            files: await getModuleFiles(root),
             plugins: { perfectionist },
             rules: {
                 ...commonRules,
@@ -223,7 +221,8 @@ export async function createEslintPerfectionistConfig(root) {
             },
         },
         {
-            files: typescriptFiles,
+            name: 'perfectionist/typescript',
+            files: getTypescriptFiles(),
             plugins: { perfectionist },
             rules: {
                 ...commonRules,

package/src/plugins/promise.js

@@ -6,6 +6,7 @@ import promise from 'eslint-plugin-promise';
  */
 export function createEslintPromiseConfig() {
     return [ {
+        name: 'promise/custom',
         plugins: { promise },
         rules: {
             ...promise.configs.recommended.rules,

package/src/plugins/react.js

@@ -98,6 +98,7 @@ export async function createEslintReactConfig(root) {
 
     return [
         {
+            name: 'react/jsx',
             files: [ '**/*.jsx' ],
             languageOptions: {
                 parserOptions: {
@@ -111,6 +112,7 @@ export async function createEslintReactConfig(root) {
             rules: rules,
         },
         {
+            name: 'react/tsx',
             files: [ '**/*.tsx' ],
             languageOptions: {
                 parserOptions: {

package/src/plugins/regexp.js

@@ -1,13 +1,14 @@
-import { makeCompat } from '../utilities/make-compat.js';
+import regexp from 'eslint-plugin-regexp';
 
 /**
  * Get ESLint config for the regexp plugin
- * @param {import('node:url').URL} root root url
  * @returns {import('eslint').Linter.FlatConfig[]}
  */
-export function createEslintRegexpConfig(root) {
-    return makeCompat(root).config({
-        plugins: [ 'regexp' ],
-        extends: [ 'plugin:regexp/recommended' ],
-    });
+export function createEslintRegexpConfig() {
+    return [
+        {
+            name: 'regexp/recommended',
+            ...regexp.configs['flat/recommended'],
+        },
+    ];
 }

package/src/plugins/sca.js

@@ -13,6 +13,7 @@ import {
 export async function createEslintSCAConfig(root) {
     return [
         {
+            name: 'sca/javascript',
             files: [
                 ...await getCommonFiles(root),
                 ...await getModuleFiles(root),
@@ -31,6 +32,7 @@ export async function createEslintSCAConfig(root) {
             },
         },
         {
+            name: 'sca/typescript',
             files: getTypescriptFiles(),
             plugins: { sca },
             rules: {

package/src/plugins/security.js

@@ -6,10 +6,19 @@ import security from 'eslint-plugin-security';
  */
 export function createEslintSecurityConfig() {
     return [ {
-        ...security.configs.recommended,
+        name: 'security/recommended',
         plugins: { security },
         rules: {
+            ...security.configs.recommended.rules,
+            'security/detect-object-injection': 0,
+
+            // I dont particularly care here..
             'security/detect-non-literal-fs-filename': 0,
+            'security/detect-non-literal-require': 0,
+
+            // eslint-plugin-regexp does this better...
+            'security/detect-non-literal-regexp': 0,
+            'security/detect-unsafe-regex': 0,
         },
     } ];
 }

package/src/plugins/sonarjs.js

@@ -7,6 +7,7 @@ import sonarjs from 'eslint-plugin-sonarjs';
 export function createEslintSonarJSConfig() {
     return [
         {
+            name: 'sonarjs/recommended',
             plugins: { sonarjs },
             rules: {
                 ...sonarjs.configs.recommended.rules,
@@ -14,6 +15,7 @@ export function createEslintSonarJSConfig() {
             },
         },
         {
+            name: 'sonarjs/tests',
             files: [
                 '**/*.test.*',
                 '*.test.*',

package/src/plugins/style.js

@@ -7,6 +7,7 @@ import stylistic from '@stylistic/eslint-plugin';
  */
 export function createEslintStyleConfig() {
     return [ {
+        name: 'stylistic/custom',
         plugins: { style: stylistic },
         rules: {
             // Require or disallow newline at the end of files

package/src/plugins/typescript.js

@@ -27,6 +27,7 @@ export async function createEslintTypescriptConfig(root) {
     const typescriptPlugin = idef(await import('@typescript-eslint/eslint-plugin'));
 
     return [ {
+        name: 'typescript/custom',
         files: getTypescriptFiles(),
         languageOptions: {
             parser: typescriptParser,
@@ -48,7 +49,7 @@ export async function createEslintTypescriptConfig(root) {
             'no-dupe-keys': 'off',
             'no-func-assign': 'off',
             'no-import-assign': 'off',
-            'no-new-symbol': 'off',
+            // 'no-new-symbol': 'off',
             'no-obj-calls': 'off',
             'no-redeclare': 'off',
             'no-setter-return': 'off',
@@ -57,7 +58,6 @@ export async function createEslintTypescriptConfig(root) {
             'no-unreachable': 'off',
             'no-unsafe-negation': 'off',
             'no-array-constructor': 'off',
-            'no-loss-of-precision': 'off',
 
             // Rules that prevert some commmon ts issues
             'no-var': 'error',
@@ -74,14 +74,13 @@ export async function createEslintTypescriptConfig(root) {
             '@typescript-eslint/no-duplicate-enum-values': 'error',
             '@typescript-eslint/no-explicit-any': 'error',
             '@typescript-eslint/no-extra-non-null-assertion': 'error',
-            '@typescript-eslint/no-loss-of-precision': 'error',
             '@typescript-eslint/no-misused-new': 'error',
             '@typescript-eslint/no-namespace': [ 'error', { allowDeclarations: true } ],
             '@typescript-eslint/no-non-null-asserted-optional-chain': 'error',
             '@typescript-eslint/no-this-alias': 'error',
             '@typescript-eslint/no-unnecessary-type-constraint': 'error',
             '@typescript-eslint/no-unsafe-declaration-merging': 'error',
-            '@typescript-eslint/no-var-requires': 'error',
+            '@typescript-eslint/no-require-imports': 'error',
             '@typescript-eslint/prefer-as-const': 'error',
             '@typescript-eslint/triple-slash-reference': 'error',
         },

package/src/plugins/unicorn.js

@@ -1,20 +1,19 @@
-import { makeCompat } from '../utilities/make-compat.js';
+import unicorn from 'eslint-plugin-unicorn';
 
 /**
  * Get ESLint config for the unicorn plugin
- * @param {import('node:url').URL} root root url
  * @returns {Promise<import('eslint').Linter.FlatConfig[]>}
  */
-export async function createEslintUnicornConfig(root) {
-    return makeCompat(root).config({
-        plugins: [ 'unicorn' ],
+export async function createEslintUnicornConfig() {
+    return [ {
+        name: 'unicorn/custom',
+        plugins: { unicorn },
         rules: {
             /*
              * Sanity checks
             */
             'unicorn/better-regex': 'off',
             'unicorn/no-empty-file': 'warn',
-            'unicorn/no-unsafe-regex': 'off',
             'unicorn/no-zero-fractions': 'error',
             'unicorn/no-unreadable-array-destructuring': 'error',
             'unicorn/no-useless-undefined': 'error',
@@ -54,5 +53,5 @@ export async function createEslintUnicornConfig(root) {
             'unicorn/require-array-join-separator': 'error',
             'unicorn/text-encoding-identifier-case': 'error',
         },
-    });
+    } ];
 }

package/src/plugins/unused-imports.js

@@ -13,6 +13,7 @@ import {
 export async function createEslintUnusedImportsConfig(root) {
     return [
         {
+            name: 'no-unused-imports/custom',
             files: [
                 ...await getModuleFiles(root),
                 ...getTypescriptFiles(),

package/src/utilities/editorconfig.js

@@ -195,11 +195,13 @@ export async function createEditorOverrides(root) {
 
             if (files.includes('*')) {
                 addOrMergeConfig(configs, {
+                    name: `editor-config/${extensions.join(', ')}`,
                     files: extensions.map((extension) => `**/*${extension}`),
                     rules: convert(body, rules),
                 });
             } else {
                 addOrMergeConfig(configs, {
+                    name: `editor-config/${files.join(', ')}`,
                     files: files.map((file) => `**/${file}`),
                     rules: convert(body, rules),
                 });

package/src/utilities/eslint-files.js

@@ -15,14 +15,6 @@ function getFiles(files, type, target) {
     return files;
 }
 
-/**
- * Get a list of globs for common js files
- * @returns {Promise<string[]>}
- */
-export async function getJsonFiles() {
-    return [ '**/*.json', '**/*.jsonc', '**/*.json5' ];
-}
-
 /**
  * Get a list of globs for common js files
  * @param {import('node:url').URL} root root url

package/types/src/plugins/regexp.d.ts

@@ -1,6 +1,5 @@
 /**
  * Get ESLint config for the regexp plugin
- * @param {import('node:url').URL} root root url
  * @returns {import('eslint').Linter.FlatConfig[]}
  */
-export function createEslintRegexpConfig(root: import("node:url").URL): import("eslint").Linter.FlatConfig[];
+export function createEslintRegexpConfig(): import("eslint").Linter.FlatConfig[];

package/types/src/plugins/unicorn.d.ts

@@ -1,6 +1,5 @@
 /**
  * Get ESLint config for the unicorn plugin
- * @param {import('node:url').URL} root root url
  * @returns {Promise<import('eslint').Linter.FlatConfig[]>}
  */
-export function createEslintUnicornConfig(root: import("node:url").URL): Promise<import("eslint").Linter.FlatConfig[]>;
+export function createEslintUnicornConfig(): Promise<import("eslint").Linter.FlatConfig[]>;

package/types/src/utilities/eslint-files.d.ts

@@ -1,8 +1,3 @@
-/**
- * Get a list of globs for common js files
- * @returns {Promise<string[]>}
- */
-export function getJsonFiles(): Promise<string[]>;
 /**
  * Get a list of globs for common js files
  * @param {import('node:url').URL} root root url

package/src/bin/eslint.cjs

@@ -1,11 +0,0 @@
-#!/usr/bin/env node
-
-const path = require('node:path');
-
-const ESLINT_BIN_PATH = path.resolve(
-  require.resolve('eslint'), // eslint api
-  '../..', // eslint package root
-  'bin/eslint.js', // eslint cli
-);
-
-require(ESLINT_BIN_PATH);

package/types/src/bin/eslint.d.cts

@@ -1,2 +0,0 @@
-#!/usr/bin/env node
-export {};