@darkpos/pricing 1.0.97 → 1.0.100

package/__TEST__/item.test.js

@@ -11,6 +11,7 @@ describe('Item actions', () => {
   test('Get calculated Item: included: false && direct: false', () => {
     const modifiers = [
       {
+        _id: 1111,
         compute: {
           amount: 20,
           type: 'percentage',
@@ -25,6 +26,7 @@ describe('Item actions', () => {
         },
       },
       {
+        _id: 2222,
         compute: {
           amount: 20,
           type: 'percentage',
@@ -39,6 +41,7 @@ describe('Item actions', () => {
         },
       },
       {
+        _id: 3333,
         compute: {
           amount: 2,
           type: 'fixed',
@@ -69,6 +72,7 @@ describe('Item actions', () => {
   test('Get calculated Item: included: false && direct: true', () => {
     const modifiers = [
       {
+        _id: '123213213',
         compute: { amount: 2, type: 'fixed', action: 'subtract' },
         type: 'discount',
         name: 'modifier1',
@@ -79,6 +83,7 @@ describe('Item actions', () => {
         },
       },
       {
+        _id: '22222',
         compute: {
           amount: 20,
           type: 'percentage',
@@ -93,6 +98,7 @@ describe('Item actions', () => {
         },
       },
       {
+        _id: '3333',
         compute: {
           amount: 2,
           type: 'fixed',
@@ -124,6 +130,7 @@ describe('Item actions', () => {
   test('Get calculated Item: included: true && direct: true', () => {
     const modifiers = [
       {
+        _id: '111111',
         compute: {
           amount: 2,
           type: 'fixed',
@@ -138,6 +145,8 @@ describe('Item actions', () => {
         },
       },
       {
+        _id: '222222',
+
         compute: {
           amount: 20,
           type: 'percentage',
@@ -152,6 +161,8 @@ describe('Item actions', () => {
         },
       },
       {
+        _id: '33333',
+
         compute: {
           amount: 2,
           type: 'fixed',
@@ -215,6 +226,7 @@ describe('Item actions', () => {
         properties: {
           sort: 1,
         },
+        _id: '1255115',
       },
       {
         compute: {
@@ -229,6 +241,7 @@ describe('Item actions', () => {
         },
         included: true,
         direct: true,
+        _id: '2256659',
       },
     ];
     const orderItem = { price: 2, quantity: 1, modifiers };
@@ -246,6 +259,7 @@ describe('Item actions', () => {
   test('Get calculated Item: included: true, sample 3', () => {
     const modifiers = [
       {
+        _id: 12323,
         compute: {
           amount: 2,
           type: 'fixed',
@@ -260,6 +274,7 @@ describe('Item actions', () => {
         direct: true,
       },
       {
+        _id: 5555,
         compute: {
           amount: 2,
           type: 'fixed',
@@ -274,6 +289,7 @@ describe('Item actions', () => {
         },
       },
       {
+        _id: 77777,
         compute: {
           amount: 10,
           type: 'percentage',
@@ -288,6 +304,7 @@ describe('Item actions', () => {
         direct: true,
       },
       {
+        _id: 8888,
         compute: {
           amount: 6,
           type: 'percentage',
@@ -479,6 +496,8 @@ describe('Item actions', () => {
       },
       name: 'fixedFee16',
       type: 'tax',
+      modifierId: '11111',
+      _id: '123',
     };
 
     const fixedFee10 = {
@@ -489,6 +508,8 @@ describe('Item actions', () => {
       },
       name: 'fixedFee10',
       type: 'tax',
+      modifierId: '22222',
+      _id: '234',
     };
 
     const orderItem = {
@@ -528,6 +549,8 @@ describe('Item actions', () => {
       },
       name: 'fixedFee16',
       type: 'tax',
+      _id: '123',
+      modifierId: 1111,
     };
 
     const percentageFee10 = {
@@ -538,6 +561,8 @@ describe('Item actions', () => {
       },
       name: 'percentageFee10',
       type: 'tax',
+      _id: '234',
+      modifierId: 222,
     };
 
     const orderItem = {

package/__TEST__/modifier/addItemModifier.test.js

@@ -236,4 +236,142 @@ describe('addItemModifier Function', () => {
       pricingService.order.addItemModifier(invalidModifierMock, orderMock);
     }).toThrow(Error); // Expect an error to be thrown with invalid input
   });
+
+  test('Add department modifier with customerTagsExtend and confirm price is correct, then remove it and confirm correct price again.', () => {
+    const order = {
+      _id: '68532dec3d51e6291225ccd9',
+
+      items: [
+        {
+          pieces: 2,
+
+          total: 129,
+          price: 129,
+          quantity: 1,
+          modifiers: [],
+          tags: ['default'],
+          category: null,
+          __typename: 'OrderItem',
+          priceLevels: [
+            {
+              value: 129,
+              tags: ['default'],
+            },
+            {
+              value: 15,
+              tags: ['default', 'vip'],
+            },
+            {
+              value: 10,
+              tags: ['default', 'rich'],
+            },
+          ],
+          costLevels: [],
+          itemId: '67fea241af24e570c032b319',
+          subTotals: {},
+        },
+      ],
+      notes: [],
+      customer: {
+        _id: '67feae8eeb5aa1e1848374b9',
+        tags: ['default'],
+      },
+      start: {
+        location: {
+          name: 'Sunshine Cleaners',
+          locationType: 'store',
+          storeId: '67e1c09c05b96100127280a8',
+        },
+        requestDate: '2025-06-18T21:21:48.745Z',
+      },
+
+      _storeId: '',
+      __typename: 'Order',
+      subTotals: {},
+    };
+    const originalItem = {
+      _id: '67fea241af24e570c032b319',
+      _updatedAt: '2025-06-18T20:21:00.922Z',
+      _createdAt: '2025-04-15T18:15:30.262Z',
+      name: "2pc Men's Suit",
+      description: null,
+      pieces: 2,
+      weight: 0,
+      properties: {
+        url: null,
+        color: 'rgba(178,232,239,1)',
+        label: {
+          backgroundColor: 'rgba(255,235,59,1)',
+          align: null,
+        },
+      },
+      sku: null,
+      hasInventory: false,
+      inventoryType: 'push',
+      quantity: 0,
+      tags: ['default'],
+      category: null,
+      __typename: 'Item',
+      modifiers: [],
+      priceLevels: [
+        {
+          value: 129,
+          tags: ['default'],
+        },
+        {
+          value: 15,
+          tags: ['default', 'vip'],
+        },
+        {
+          value: 10,
+          tags: ['default', 'rich'],
+        },
+      ],
+      costLevels: [],
+    };
+    let result = pricingService.order.addItemModifier({
+      itemIndex: 0,
+      modifier: {
+        _id: '67fea241af24e570c032b33f',
+        attributes: ['department'],
+        name: 'Dry Cleaning',
+        group: 'Department',
+        tags: ['default'],
+        included: true,
+        direct: true,
+        code: 'D',
+        properties: {
+          group: null,
+          department: {
+            tagSize: 'small',
+            customerTagsExtend: ['vip'],
+            autoSplit: false,
+            splitUnit: 'quantity',
+            maxItems: '3',
+          },
+          url: null,
+          color: null,
+          label: {
+            backgroundColor: null,
+            align: null,
+          },
+          sort: null,
+        },
+      },
+      order,
+      force: true,
+      originalItem,
+    });
+
+    expect(result.items[0].price).toBe(15);
+
+    result = pricingService.order.removeItemModifier({
+      order: result,
+      modifier: result.items[0].modifiers[0],
+      itemIndex: 0,
+      originalItem,
+    });
+
+    expect(result.items[0].price).toBe(129);
+  });
 });

package/__TEST__/modifier.test.js

@@ -52,17 +52,10 @@ describe('Modifier actions', () => {
       modifiers: [],
     });
 
-    const conditionsBag = [];
-
     const updatedOrder = pricingService.order.addItemModifier({
       order,
       modifier,
       itemIndex: 0,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
     });
 
     let error = '';
@@ -70,17 +63,11 @@ describe('Modifier actions', () => {
       order: { ...updatedOrder },
       modifier,
       itemIndex: 0,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
       onError: errorMessage => {
         error = errorMessage;
       },
     });
 
-    expect(conditionsBag).toEqual([]);
     expect(error).toEqual('');
 
     expect(updatedOrder2.items[0].modifiers.length).toEqual(2);
@@ -110,17 +97,10 @@ describe('Modifier actions', () => {
       modifiers: [],
     });
 
-    const conditionsBag = [];
-
     const updatedOrder = pricingService.order.addItemModifier({
       order,
       modifier,
       itemIndex: 0,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
     });
 
     let error = '';
@@ -128,17 +108,11 @@ describe('Modifier actions', () => {
       order: { ...updatedOrder },
       modifier,
       itemIndex: 0,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
       onError: errorMessage => {
         error = errorMessage;
       },
     });
 
-    expect(conditionsBag).toEqual([]);
     expect(error).toEqual('modifier.has.reached.the.maximum.amount.of.applies');
     expect(updatedOrder2).toEqual(updatedOrder);
   });
@@ -165,17 +139,10 @@ describe('Modifier actions', () => {
       properties: {},
     });
 
-    const conditionsBag = [];
-
     const updatedOrder = pricingService.order.addItemModifier({
       order,
       modifier,
       itemIndex: 0,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
     });
 
     let error = '';
@@ -183,17 +150,12 @@ describe('Modifier actions', () => {
       order: { ...updatedOrder },
       modifier,
       itemIndex: 0,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
+
       onError: errorMessage => {
         error = errorMessage;
       },
     });
 
-    expect(conditionsBag).toEqual([]);
     expect(error).toEqual('');
     expect(updatedOrder2).toEqual(order);
   });
@@ -902,17 +864,10 @@ describe('Modifier actions', () => {
       modifiers: [],
     });
 
-    const conditionsBag = [];
-
     const updatedOrder = pricingService.order.addItemModifier({
       order,
       modifier,
       itemIndex: 0,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
     });
 
     let error = '';
@@ -920,17 +875,11 @@ describe('Modifier actions', () => {
       order: { ...updatedOrder },
       modifier,
       itemIndex: 0,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
       onError: errorMessage => {
         error = errorMessage;
       },
     });
 
-    expect(conditionsBag).toEqual([]);
     expect(error).toEqual('modifier.has.reached.the.maximum.amount.of.applies');
     expect(updatedOrder2.items[0].modifiers.length).toBe(1);
     expect(updatedOrder2.items[0].modifiers).toMatchObject([
@@ -976,8 +925,6 @@ describe('Modifier actions', () => {
       modifiers: [],
     });
 
-    const conditionsBag = [];
-
     let error = '';
     let currentOrder = { ...order };
 
@@ -986,11 +933,7 @@ describe('Modifier actions', () => {
         order: currentOrder,
         modifier,
         itemIndex: 0,
-        onConditionsNotMet: bag => {
-          bag.forEach(condition => {
-            conditionsBag.push(condition);
-          });
-        },
+
         // eslint-disable-next-line no-loop-func
         onError: errorMessage => {
           error = errorMessage;
@@ -998,7 +941,6 @@ describe('Modifier actions', () => {
       });
     }
 
-    expect(conditionsBag).toEqual([]);
     expect(error).toEqual('');
 
     expect(currentOrder.items[0].modifiers.length).toBe(5);
@@ -1030,8 +972,6 @@ describe('Modifier actions', () => {
       modifiers: [],
     });
 
-    const conditionsBag = [];
-
     let error = '';
     let currentOrder = { ...order };
 
@@ -1040,11 +980,7 @@ describe('Modifier actions', () => {
         order: currentOrder,
         modifier,
         itemIndex: 0,
-        onConditionsNotMet: bag => {
-          bag.forEach(condition => {
-            conditionsBag.push(condition);
-          });
-        },
+
         // eslint-disable-next-line no-loop-func
         onError: errorMessage => {
           error = errorMessage;
@@ -1052,7 +988,6 @@ describe('Modifier actions', () => {
       });
     }
 
-    expect(conditionsBag).toEqual([]);
     expect(error).toEqual('');
 
     const calculatedOrder = pricingService.order.calculate(currentOrder);
@@ -1085,8 +1020,6 @@ describe('Modifier actions', () => {
       modifiers: [],
     });
 
-    const conditionsBag = [];
-
     let error = '';
     let currentOrder = { ...order };
 
@@ -1095,11 +1028,6 @@ describe('Modifier actions', () => {
         order: currentOrder,
         modifier,
         itemIndex: 0,
-        onConditionsNotMet: bag => {
-          bag.forEach(condition => {
-            conditionsBag.push(condition);
-          });
-        },
         // eslint-disable-next-line no-loop-func
         onError: errorMessage => {
           error = errorMessage;
@@ -1107,7 +1035,6 @@ describe('Modifier actions', () => {
       });
     }
 
-    expect(conditionsBag).toEqual([]);
     expect(error).toEqual('modifier.has.reached.the.maximum.amount.of.applies');
 
     expect(currentOrder.items[0].modifiers.length).toBe(10);
@@ -1138,8 +1065,6 @@ describe('Modifier actions', () => {
       modifiers: [],
     });
 
-    const conditionsBag = [];
-
     let error = '';
     let currentOrder = { ...order };
 
@@ -1148,11 +1073,6 @@ describe('Modifier actions', () => {
         order: currentOrder,
         modifier,
         itemIndex: 0,
-        onConditionsNotMet: bag => {
-          bag.forEach(condition => {
-            conditionsBag.push(condition);
-          });
-        },
         // eslint-disable-next-line no-loop-func
         onError: errorMessage => {
           error = errorMessage;
@@ -1160,7 +1080,6 @@ describe('Modifier actions', () => {
       });
     }
 
-    expect(conditionsBag).toEqual([]);
     expect(error).toEqual('');
 
     expect(currentOrder.items[0].modifiers.length).toBe(5);
@@ -1191,8 +1110,6 @@ describe('Modifier actions', () => {
       modifiers: [],
     });
 
-    const conditionsBag = [];
-
     let error = '';
     let currentOrder = { ...order };
 
@@ -1201,11 +1118,7 @@ describe('Modifier actions', () => {
         order: currentOrder,
         modifier,
         itemIndex: 0,
-        onConditionsNotMet: bag => {
-          bag.forEach(condition => {
-            conditionsBag.push(condition);
-          });
-        },
+
         // eslint-disable-next-line no-loop-func
         onError: errorMessage => {
           error = errorMessage;
@@ -1213,7 +1126,6 @@ describe('Modifier actions', () => {
       });
     }
 
-    expect(conditionsBag).toEqual([]);
     expect(error).toEqual('');
 
     expect(currentOrder.items[0].modifiers.length).toBe(2);
@@ -1263,8 +1175,6 @@ describe('Modifier actions', () => {
       modifiers: [],
     });
 
-    const conditionsBag = [];
-
     let error = '';
     let currentOrder = { ...order };
 
@@ -1272,11 +1182,7 @@ describe('Modifier actions', () => {
       order: currentOrder,
       modifier,
       itemIndex: 0,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
+
       onError: errorMessage => {
         error = errorMessage;
       },
@@ -1286,11 +1192,7 @@ describe('Modifier actions', () => {
       order: currentOrder,
       modifier,
       itemIndex: 1,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
+
       onError: errorMessage => {
         error = errorMessage;
       },
@@ -1300,17 +1202,12 @@ describe('Modifier actions', () => {
       order: currentOrder,
       modifier,
       itemIndex: 2,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
+
       onError: errorMessage => {
         error = errorMessage;
       },
     });
 
-    expect(conditionsBag).toEqual([]);
     expect(error).toEqual('');
     expect(currentOrder.items[0].modifiers.length).toBe(1);
     expect(currentOrder.items[1].modifiers.length).toBe(1);
@@ -1323,17 +1220,12 @@ describe('Modifier actions', () => {
       order: currentOrder,
       modifier,
       itemIndex: 3,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
+
       onError: errorMessage => {
         error = errorMessage;
       },
     });
 
-    expect(conditionsBag).toEqual([]);
     expect(error).toEqual('modifier.has.reached.the.maximum.amount.of.applies');
     expect(currentOrder.items[3].modifiers.length).toBe(0);
   });
@@ -1760,17 +1652,10 @@ describe('Modifier actions', () => {
       modifiers: [],
     });
 
-    const conditionsBag = [];
-
     const updatedOrder = pricingService.order.addItemModifier({
       order,
       modifier,
       itemIndex: 0,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
     });
 
     let error = '';
@@ -1778,17 +1663,12 @@ describe('Modifier actions', () => {
       order: { ...updatedOrder },
       modifier,
       itemIndex: 0,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
+
       onError: errorMessage => {
         error = errorMessage;
       },
     });
 
-    expect(conditionsBag).toEqual([]);
     expect(error).toEqual('');
 
     expect(updatedOrder2.items[0].modifiers.length).toEqual(2);
@@ -1819,17 +1699,10 @@ describe('Modifier actions', () => {
       modifiers: [],
     });
 
-    const conditionsBag = [];
-
     const updatedOrder = pricingService.order.addItemModifier({
       order,
       modifier,
       itemIndex: 0,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
     });
 
     let error = '';
@@ -1837,17 +1710,12 @@ describe('Modifier actions', () => {
       order: { ...updatedOrder },
       modifier,
       itemIndex: 0,
-      onConditionsNotMet: bag => {
-        bag.forEach(condition => {
-          conditionsBag.push(condition);
-        });
-      },
+
       onError: errorMessage => {
         error = errorMessage;
       },
     });
 
-    expect(conditionsBag).toEqual([]);
     expect(error).toEqual('modifier.has.reached.the.maximum.amount.of.applies');
 
     expect(updatedOrder2.items[0].modifiers.length).toEqual(1);