@darkpos/pricing 1.0.96 → 1.0.97

package/__TEST__/order/order-payment-modifier.test.js

@@ -1435,4 +1435,67 @@ describe('Order actions', () => {
     expect(resultedOrderPrepay.modifiers[1]._computed.amount).toBe(-1);
     expect(resultedOrderPrepay.modifiers[2]._computed.amount).toBe(-1);
   });
+
+  test('Should ignore modifier when conditions are not met and apply it when they are', () => {
+    const cashDiscountModifier = {
+      _id: '670e7cd236bf42091cb35624',
+      attributes: [],
+      modifierId: '670d7f7e746d1ae0f847aba6',
+      _parentId: null,
+      locked: false,
+      name: 'CASH 2 USD DISCOUNT',
+      sku: '',
+      description: '',
+      group: 'Offers',
+      type: 'discount',
+      tags: ['default', 'all'],
+      conditions: {
+        valid: false,
+        rules: [
+          {
+            key: 'paymentTypes',
+            value: ['cash'],
+            operand: '$nin',
+          },
+        ],
+      },
+      compute: {
+        type: 'fixed',
+        action: 'subtract',
+        amount: 2,
+      },
+    };
+    const orderItem = {
+      price: 10,
+      quantity: 1,
+      modifiers: [cashDiscountModifier],
+      total: 10,
+      totalPaid: 0,
+    };
+
+    let cashFixedDiscountOrder = pricingService.order.calculate(
+      { items: [orderItem] },
+      { paymentType: 'cash' }
+    );
+
+    expect(cashFixedDiscountOrder).toHaveProperty('total', 10);
+    expect(cashFixedDiscountOrder).toHaveProperty('subTotal', 10);
+    expect(cashFixedDiscountOrder).toHaveProperty('subTotals', {});
+    expect(cashFixedDiscountOrder.items[0].modifiers).toHaveLength(1);
+
+    cashFixedDiscountOrder = pricingService.order.calculate(
+      { items: [orderItem] },
+      {
+        paymentType: 'check',
+        amountToPay: 1,
+        lockPaymentModifiers: true,
+      }
+    );
+    expect(cashFixedDiscountOrder).toHaveProperty('total', 8);
+    expect(cashFixedDiscountOrder).toHaveProperty('subTotal', 10);
+    expect(cashFixedDiscountOrder).toHaveProperty('subTotals', {
+      discount: -2,
+    });
+    expect(cashFixedDiscountOrder.items[0].modifiers).toHaveLength(2);
+  });
 });

package/lib/item/calculate.js

@@ -58,6 +58,9 @@ module.exports = ({ _, utils, actions, modifierActions }) => {
         startRequestDate,
         endRequestDate,
         allItems,
+        paymentMethod,
+        paymentType,
+        isPrepay,
       })
     );
 
@@ -66,19 +69,15 @@ module.exports = ({ _, utils, actions, modifierActions }) => {
         ((each.compute && each.compute.type) ||
           (modifierActions.isOverride(each) &&
             !modifierActions.isNotesOverride(each))) &&
-        modifierActions.isValid(each)
+        modifierActions.isValid(each) &&
+        !modifierActions.isPaymentModifier(each)
     );
 
     const paymentModifiersToCompute = validatedModifiers
       .filter(
         modifier =>
-          modifierActions.isPaymentModifier(modifier) &&
-          modifierActions.hasPaymentMethodType({
-            paymentModifier: modifier,
-            paymentMethod,
-            paymentType,
-            isPrepay,
-          })
+          modifierActions.isValid(modifier) &&
+          modifierActions.isPaymentModifier(modifier)
       )
       .filter(paymentModifier => {
         const childModifiers = modifierActions.getChildren({
@@ -161,10 +160,7 @@ module.exports = ({ _, utils, actions, modifierActions }) => {
               typeof item.totalPaid === 'number' && item.totalPaid > 0
                 ? actions.getItemsBalance({ items: [item] })
                 : math.sub(computedPrice, item.totalPaid),
-            paymentMethod,
-            paymentType,
             paymentId,
-            isPrepay,
           });
         }
 

package/lib/item/index.js

@@ -33,7 +33,6 @@ const isFullyPaid = require('./isFullyPaid');
 const getTotalPrice = require('./getTotalPrice');
 const getItems = require('./getItems');
 const getAmounts = require('./getAmounts');
-const hasPaymentMethodType = require('./hasPaymentMethodType');
 const removePaymentModifiersByPaymentId = require('./removePaymentModifiersByPaymentId');
 const hasPaymentModifierWithPaymentId = require('./hasPaymentModifierWithPaymentId');
 const getBalance = require('./getBalance');
@@ -111,7 +110,6 @@ const itemActions = (deps = {}) => {
     getTotalPrice: getTotalPrice(innerDeps),
     getItems: getItems(innerDeps),
     getAmounts: getAmounts(innerDeps),
-    hasPaymentMethodType: hasPaymentMethodType(innerDeps),
     removePaymentModifiersByPaymentId:
       removePaymentModifiersByPaymentId(innerDeps),
     hasPaymentModifierWithPaymentId: hasPaymentModifierWithPaymentId(innerDeps),

package/lib/modifier/areConditionsMet.js

@@ -1,7 +1,15 @@
 module.exports = ({ actions, utils }) => {
   const modifierConditionPass = (
     modifier,
-    { item, startRequestDate, endRequestDate, allItems }
+    {
+      item,
+      startRequestDate,
+      endRequestDate,
+      allItems,
+      paymentMethod,
+      paymentType,
+      isPrepay,
+    }
   ) =>
     modifier.conditions && Array.isArray(modifier.conditions.rules)
       ? modifier.conditions.rules.every(condition => {
@@ -89,11 +97,17 @@ module.exports = ({ actions, utils }) => {
                 condition.operand
               );
             case 'paymentMethods':
-              return false;
+              return actions.validatePaymentCondition({
+                condition,
+                paymentValue: paymentMethod,
+              });
             case 'paymentTypes':
-              return false;
+              return actions.validatePaymentCondition({
+                condition,
+                paymentValue: paymentType,
+              });
             case 'payment': {
-              return false;
+              return !!isPrepay;
             }
             default:
               return false;
@@ -107,6 +121,9 @@ module.exports = ({ actions, utils }) => {
       endRequestDate = null,
       startRequestDate = null,
       allItems = null,
+      paymentMethod,
+      paymentType,
+      isPrepay,
     } = opts;
     return (
       modifier &&
@@ -115,6 +132,9 @@ module.exports = ({ actions, utils }) => {
         startRequestDate,
         endRequestDate,
         allItems,
+        paymentMethod,
+        paymentType,
+        isPrepay,
       })
     );
   }

package/lib/modifier/calculatePaymentModifier.js

@@ -5,20 +5,9 @@ module.exports = ({ actions, utils }) => {
     paymentModifier: paymentModifierParam,
     amountToPay: amountToPayParam,
     itemBalance: itemBalanceParam,
-    paymentMethod,
-    paymentType,
     paymentId,
-    isPrepay,
   }) {
-    if (
-      !actions.hasPaymentMethodType({
-        paymentModifier: paymentModifierParam,
-        paymentMethod,
-        paymentType,
-        isPrepay,
-      })
-    )
-      return undefined;
+    if (!actions.isValid(paymentModifierParam)) return false;
 
     const paymentModifier = {
       ...paymentModifierParam,

package/lib/modifier/index.js

@@ -126,7 +126,6 @@ const validateInArr = require('./validateInArr');
 const isPercentage = require('./isPercentage');
 const getChildren = require('./getChildren');
 const getComputedAmount = require('./getComputedAmount');
-const hasPaymentMethodType = require('./hasPaymentMethodType');
 const calculatePaymentModifier = require('./calculatePaymentModifier');
 const calculatePaymentDiscountModifier = require('./calculatePaymentDiscountModifier');
 const calculatePaymentFeeModifier = require('./calculatePaymentFeeModifier');
@@ -167,6 +166,7 @@ const getOverrideAmount = require('./getOverrideAmount');
 const getOverrideNote = require('./getOverrideNote');
 const isNotesOverride = require('./isNotesOverride');
 const isOverrideSubtotal = require('./isOverrideSubtotal');
+const validatePaymentCondition = require('./validatePaymentCondition');
 
 const modifierActions = (deps = {}) => {
   const actions = {};
@@ -304,7 +304,6 @@ const modifierActions = (deps = {}) => {
     isPercentage: isPercentage(innerDeps),
     getChildren: getChildren(innerDeps),
     getComputedAmount: getComputedAmount(innerDeps),
-    hasPaymentMethodType: hasPaymentMethodType(innerDeps),
     calculatePaymentModifier: calculatePaymentModifier(innerDeps),
     calculatePaymentDiscountModifier:
       calculatePaymentDiscountModifier(innerDeps),
@@ -347,6 +346,7 @@ const modifierActions = (deps = {}) => {
     getOverrideNote: getOverrideNote(innerDeps),
     isNotesOverride: isNotesOverride(innerDeps),
     isOverrideSubtotal: isOverrideSubtotal(innerDeps),
+    validatePaymentCondition: validatePaymentCondition(innerDeps),
   });
 
   Object.keys(freezedActions).forEach(actionName => {

package/lib/modifier/validatePaymentCondition.js

@@ -0,0 +1,16 @@
+module.exports = () =>
+  function validatePaymentCondition({ condition, paymentValue }) {
+    const { value, operand } = condition;
+    if (!value || !operand || !paymentValue) return false;
+
+    const includes = value.includes(paymentValue);
+
+    switch (operand) {
+      case '$in':
+        return includes;
+      case '$nin':
+        return !includes;
+      default:
+        return false;
+    }
+  };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@darkpos/pricing",
-  "version": "1.0.96",
+  "version": "1.0.97",
   "description": "Pricing calculator",
   "author": "Dark POS",
   "license": "ISC",
@@ -54,5 +54,5 @@
     "supertest": "^6.2.3",
     "supervisor": "^0.12.0"
   },
-  "gitHead": "aed710f165a1442c14bba31c5936682faa6b9364"
+  "gitHead": "f0f3b0c934c2061d16a7237e6173d317dc15e811"
 }

package/lib/item/hasPaymentMethodType.js

@@ -1,23 +0,0 @@
-module.exports = ({ modifierActions }) =>
-  function hasPaymentMethodType({
-    item,
-    paymentMethod,
-    paymentType,
-    isPrepay,
-  }) {
-    if (
-      !item ||
-      !Array.isArray(item.modifiers) ||
-      (!paymentMethod && !paymentType)
-    )
-      return false;
-
-    return item.modifiers.some(modifier =>
-      modifierActions.hasPaymentMethodType({
-        paymentModifier: modifier,
-        paymentMethod,
-        paymentType,
-        isPrepay,
-      })
-    );
-  };

package/lib/modifier/hasPaymentMethodType.js

@@ -1,29 +0,0 @@
-module.exports = ({ actions }) =>
-  function hasPaymentMethodType({
-    paymentModifier,
-    paymentMethod,
-    paymentType,
-    isPrepay,
-  }) {
-    if (!actions.isPaymentModifier(paymentModifier)) return false;
-
-    if (actions.isPrepayModifier(paymentModifier) && !isPrepay) return false;
-
-    if (
-      actions.isPaymentTypeModifier(paymentModifier) &&
-      !paymentModifier.conditions.rules.some(rule =>
-        rule.value.includes(paymentType)
-      )
-    )
-      return false;
-
-    if (
-      actions.isPaymentMethodModifier(paymentModifier) &&
-      !paymentModifier.conditions.rules.some(rule =>
-        rule.value.includes(paymentMethod)
-      )
-    )
-      return false;
-
-    return true;
-  };