@darkpos/pricing 1.0.144 → 1.0.145

package/__TEST__/order/hasSerial.test.js

@@ -0,0 +1,86 @@
+const usePricing = require('../../index');
+const mockStores = require('../mocks/stores');
+
+const session = {
+  store: mockStores[0],
+};
+
+const pricingService = usePricing(session);
+
+describe('hasSerial function', () => {
+  test('returns true when another item has the same serial', () => {
+    const { hasSerial } = pricingService.order;
+
+    const order = {
+      items: [
+        {
+          _id: '1',
+          serial: 'ABC-123',
+        },
+      ],
+    };
+
+    const item = {
+      _id: '2',
+      serial: ' abc-123 ',
+    };
+
+    const result = hasSerial({ order, item });
+
+    expect(result).toBe(true);
+  });
+
+  test('returns false when the matching serial belongs to the same item', () => {
+    const { hasSerial } = pricingService.order;
+
+    const order = {
+      items: [
+        {
+          _id: '1',
+          serial: 'ABC-123',
+        },
+      ],
+    };
+
+    const item = {
+      _id: '1',
+      serial: 'ABC-123',
+    };
+
+    const result = hasSerial({ order, item });
+
+    expect(result).toBe(false);
+  });
+
+  test('returns false for related items', () => {
+    const { hasSerial } = pricingService.order;
+
+    const order = {
+      items: [
+        {
+          _id: '1',
+          serial: 'ABC-123',
+        },
+      ],
+    };
+
+    const item = {
+      _id: '2',
+      serial: 'ABC-123',
+      properties: {
+        relatedItem: true,
+      },
+    };
+
+    const result = hasSerial({ order, item });
+
+    expect(result).toBe(false);
+  });
+
+  test('returns false when order or item is missing', () => {
+    const { hasSerial } = pricingService.order;
+
+    expect(hasSerial({ order: null, item: { serial: 'ABC-123' } })).toBe(false);
+    expect(hasSerial({ order: { items: [] }, item: null })).toBe(false);
+  });
+});

package/lib/order/hasSerial.js

@@ -0,0 +1,29 @@
+const normalizeSerial = serial => {
+  if (typeof serial !== 'string') return '';
+  return serial.trim().toUpperCase();
+};
+
+module.exports = ({ itemActions }) =>
+  function hasSerial({ order, item }) {
+    if (
+      !item ||
+      !item.serial ||
+      !order ||
+      !order.items ||
+      itemActions.isRelatedItem(item)
+    )
+      return false;
+
+    const normalizedSerial = normalizeSerial(item.serial);
+
+    if (!normalizedSerial) return false;
+
+    return order.items
+      .filter(
+        orderItem =>
+          orderItem._id !== item._id && !itemActions.isRelatedItem(orderItem)
+      )
+      .some(
+        orderItem => normalizeSerial(orderItem.serial) === normalizedSerial
+      );
+  };

package/lib/order/index.js

@@ -101,6 +101,7 @@ const getTaxes = require('./getTaxes');
 const getPickedStatus = require('./getPickedStatus');
 const calculateWithPayment = require('./calculateWithPayment');
 const getOverpaidAmount = require('./getOverpaidAmount');
+const hasSerial = require('./hasSerial');
 
 const orderActions = (deps = {}) => {
   const actions = {};
@@ -213,6 +214,7 @@ const orderActions = (deps = {}) => {
     getPickedStatus: getPickedStatus(innerDeps),
     calculateWithPayment: calculateWithPayment(innerDeps),
     getOverpaidAmount: getOverpaidAmount(innerDeps),
+    hasSerial: hasSerial(innerDeps),
   });
 
   Object.keys(freezedActions).forEach(actionName => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@darkpos/pricing",
-  "version": "1.0.144",
+  "version": "1.0.145",
   "description": "Pricing calculator",
   "author": "Dark POS",
   "license": "ISC",
@@ -32,6 +32,7 @@
     "test:addItemModifier": "jest --runInBand --detectOpenHandles --logHeapUsage  --forceExit ./__TEST__/modifier/addItemModifier.test.js",
     "test:payment": "jest --runInBand --detectOpenHandles --logHeapUsage  --forceExit ./__TEST__/payment.test.js",
     "test:orderPaymentModifier": "jest --runInBand --detectOpenHandles --logHeapUsage  --forceExit ./__TEST__/order/order-payment-modifier.test.js",
+    "test:hasSerial": "jest --runInBand --detectOpenHandles --logHeapUsage  --forceExit ./__TEST__/order/hasSerial.test.js",
     "lint": "eslint --quiet lib/"
   },
   "publishConfig": {
@@ -53,5 +54,5 @@
     "supertest": "^6.2.3",
     "supervisor": "^0.12.0"
   },
-  "gitHead": "1dd175a8c063d4fd1d636c7ee5725676d3d33977"
+  "gitHead": "eb6adf31020d7ca3b57f6e6b1bfa20c4e0289ca0"
 }