@darkpos/pricing 1.0.134 → 1.0.136

package/__TEST__/item.test.js

@@ -2501,4 +2501,74 @@ describe('Item actions', () => {
     expect(newItem.price).toBe(100);
     expect(newItem.total).toBe(115);
   });
+
+  describe('pricingService.item.getTaxes (object of tax totals)', () => {
+    test('Returns {} when item is null', () => {
+      expect(pricingService.item.getTaxes(null)).toEqual({});
+    });
+
+    test('Returns {} when modifiers is not an array', () => {
+      expect(pricingService.item.getTaxes({ modifiers: {} })).toEqual({});
+    });
+
+    test('Returns empty object when no tax modifiers exist', () => {
+      const item = {
+        modifiers: [{ name: 'env', type: 'env', _computed: { amount: 5 } }],
+      };
+
+      expect(pricingService.item.getTaxes(item)).toEqual({});
+    });
+
+    test('Returns a single tax entry with correct amount', () => {
+      const item = {
+        modifiers: [{ name: 'VAT', type: 'tax', _computed: { amount: 3 } }],
+      };
+
+      expect(pricingService.item.getTaxes(item)).toEqual({
+        VAT: 3,
+      });
+    });
+
+    test('Sums amounts for tax modifiers with the same name', () => {
+      const item = {
+        modifiers: [
+          { name: 'VAT', type: 'tax', _computed: { amount: 2 } },
+          { name: 'VAT', type: 'tax', _computed: { amount: 3 } },
+        ],
+      };
+
+      expect(pricingService.item.getTaxes(item)).toEqual({
+        VAT: 5,
+      });
+    });
+
+    test('Handles multiple different tax names', () => {
+      const item = {
+        modifiers: [
+          { name: 'VAT', type: 'tax', _computed: { amount: 1 } },
+          { name: 'Service Tax', type: 'tax', _computed: { amount: 4 } },
+        ],
+      };
+
+      expect(pricingService.item.getTaxes(item)).toEqual({
+        VAT: 1,
+        'Service Tax': 4,
+      });
+    });
+
+    test('Ignores non-tax modifiers but includes tax ones', () => {
+      const item = {
+        modifiers: [
+          { name: 'VAT', type: 'tax', _computed: { amount: 1 } },
+          { name: 'Env Fee', type: 'env', _computed: { amount: 7 } },
+          { name: 'City Tax', type: 'tax', _computed: { amount: 3 } },
+        ],
+      };
+
+      expect(pricingService.item.getTaxes(item)).toEqual({
+        VAT: 1,
+        'City Tax': 3,
+      });
+    });
+  });
 });

package/__TEST__/order/order.test.js

@@ -3966,4 +3966,102 @@ describe('Order actions', () => {
     expect(removeEmptyNotes(order2)).toEqual(order2);
     expect(removeEmptyNotes(order3)).toEqual(order3);
   });
+
+  describe('pricingService.order.getTaxes – real integration', () => {
+    test('Returns {} when order is null', () => {
+      expect(pricingService.order.getTaxes(null)).toEqual({});
+    });
+
+    test('Returns {} when order.items is not an array', () => {
+      expect(pricingService.order.getTaxes({ items: null })).toEqual({});
+    });
+
+    test('Returns {} when order has no items', () => {
+      expect(pricingService.order.getTaxes({ items: [] })).toEqual({});
+    });
+
+    test('Aggregates taxes from a single item', () => {
+      const order = {
+        items: [
+          {
+            modifiers: [{ name: 'VAT', type: 'tax', _computed: { amount: 3 } }],
+          },
+        ],
+      };
+
+      const result = pricingService.order.getTaxes(order);
+
+      expect(result).toEqual({
+        VAT: 3,
+      });
+    });
+
+    test('Sums taxes from multiple items with the same tax name', () => {
+      const order = {
+        items: [
+          {
+            modifiers: [{ name: 'VAT', type: 'tax', _computed: { amount: 2 } }],
+          },
+          {
+            modifiers: [{ name: 'VAT', type: 'tax', _computed: { amount: 1 } }],
+          },
+        ],
+      };
+
+      const result = pricingService.order.getTaxes(order);
+
+      expect(result).toEqual({
+        VAT: 3,
+      });
+    });
+
+    test('Handles multiple different tax names across items', () => {
+      const order = {
+        items: [
+          {
+            modifiers: [{ name: 'VAT', type: 'tax', _computed: { amount: 1 } }],
+          },
+          {
+            modifiers: [
+              { name: 'ServiceTax', type: 'tax', _computed: { amount: 4 } },
+            ],
+          },
+          {
+            modifiers: [{ name: 'VAT', type: 'tax', _computed: { amount: 2 } }],
+          },
+        ],
+      };
+
+      const result = pricingService.order.getTaxes(order);
+
+      expect(result).toEqual({
+        VAT: 3, // 1 + 2
+        ServiceTax: 4,
+      });
+    });
+
+    test('Skips non-tax modifiers completely', () => {
+      const order = {
+        items: [
+          {
+            modifiers: [
+              { name: 'Fee', type: 'fee', _computed: { amount: 10 } },
+              { name: 'VAT', type: 'tax', _computed: { amount: 2 } },
+            ],
+          },
+          {
+            modifiers: [
+              { name: 'Other', type: 'env', _computed: { amount: 5 } },
+            ],
+          },
+        ],
+      };
+
+      const result = pricingService.order.getTaxes(order);
+
+      expect(result).toEqual({
+        VAT: 2,
+      });
+    });
+  });
 });

package/lib/item/getTaxes.js

@@ -0,0 +1,18 @@
+module.exports = ({ modifierActions, utils }) => {
+  const { math } = utils;
+
+  return function getTaxes(item) {
+    if (!item || !Array.isArray(item.modifiers)) return {};
+
+    const taxes = {};
+
+    item.modifiers.forEach(mod => {
+      if (!modifierActions.isTax(mod)) return;
+
+      const prevVal = taxes[mod.name] || 0;
+      taxes[mod.name] = math.add(prevVal, mod._computed.amount);
+    });
+
+    return taxes;
+  };
+};

package/lib/item/index.js

@@ -77,6 +77,7 @@ const isRemoveParentItem = require('./isRemoveParentItem');
 const hasRelatedItems = require('./hasRelatedItems');
 const getAddModifiers = require('./getAddModifiers');
 const hasAddModifiers = require('./hasAddModifiers');
+const getTaxes = require('./getTaxes');
 
 const itemActions = (deps = {}) => {
   const actions = {};
@@ -167,6 +168,7 @@ const itemActions = (deps = {}) => {
     hasRelatedItems: hasRelatedItems(innerDeps),
     getAddModifiers: getAddModifiers(innerDeps),
     hasAddModifiers: hasAddModifiers(innerDeps),
+    getTaxes: getTaxes(innerDeps),
   });
 
   Object.keys(freezedActions).forEach(actionName => {

package/lib/modifier/index.js

@@ -182,6 +182,7 @@ const getCountPerCustomer = require('./getCountPerCustomer');
 const getAmountMultiplier = require('./getAmountMultiplier');
 const isAmountMultiplier = require('./isAmountMultiplier');
 const isRemoveParentItem = require('./isRemoveParentItem');
+const isTax = require('./isTax');
 
 const modifierActions = (deps = {}) => {
   const actions = {};
@@ -376,6 +377,7 @@ const modifierActions = (deps = {}) => {
     getAmountMultiplier: getAmountMultiplier(innerDeps),
     isAmountMultiplier: isAmountMultiplier(innerDeps),
     isRemoveParentItem: isRemoveParentItem(innerDeps),
+    isTax: isTax(innerDeps),
   });
 
   Object.keys(freezedActions).forEach(actionName => {

package/lib/modifier/isTax.js

@@ -0,0 +1,6 @@
+module.exports = ({ constants }) => {
+  const { Modifier } = constants;
+  return function isTax(modifier) {
+    return modifier && modifier.type === Modifier.Types.TAX;
+  };
+};

package/lib/order/createSubOrder.js

@@ -23,7 +23,7 @@ module.exports = ({ actions, settings, _ }) => {
       ...rest,
       parentId: orderSettings.allowSuborder ? _id : null,
       status: {
-        order: 'open',
+        order: status.order || 'open',
         delivery: status.delivery || false,
         detailed: status.detailed || false,
         paid: false,

package/lib/order/getTaxes.js

@@ -0,0 +1,20 @@
+module.exports = ({ itemActions, utils }) => {
+  const { math } = utils;
+
+  return function getTaxes(order) {
+    if (!order || !Array.isArray(order.items)) return {};
+
+    const taxes = {};
+
+    order.items.forEach(item => {
+      const itemTaxes = itemActions.getTaxes(item);
+
+      Object.keys(itemTaxes).forEach(taxName => {
+        const prev = taxes[taxName] || 0;
+        taxes[taxName] = math.add(prev, itemTaxes[taxName]);
+      });
+    });
+
+    return taxes;
+  };
+};

package/lib/order/index.js

@@ -96,6 +96,7 @@ const copyItemToParents = require('./copyItemToParents');
 const getItemsWithParents = require('./getItemsWithParents');
 const addModifiersToParentItem = require('./addModifiersToParentItem');
 const removeEmptyNotes = require('./removeEmptyNotes');
+const getTaxes = require('./getTaxes');
 
 const orderActions = (deps = {}) => {
   const actions = {};
@@ -203,6 +204,7 @@ const orderActions = (deps = {}) => {
     getItemsWithParents: getItemsWithParents(innerDeps),
     addModifiersToParentItem: addModifiersToParentItem(innerDeps),
     removeEmptyNotes: removeEmptyNotes(innerDeps),
+    getTaxes: getTaxes(innerDeps),
   });
 
   Object.keys(freezedActions).forEach(actionName => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@darkpos/pricing",
-  "version": "1.0.134",
+  "version": "1.0.136",
   "description": "Pricing calculator",
   "author": "Dark POS",
   "license": "ISC",
@@ -52,5 +52,5 @@
     "supertest": "^6.2.3",
     "supervisor": "^0.12.0"
   },
-  "gitHead": "cfe52c49a64c3418b808a7c5ce7f76324b8340a5"
+  "gitHead": "9e4e2bf0729c8be75468d488d0199d2d74ec0139"
 }