@darkpos/pricing 1.0.107 → 1.0.108

package/__TEST__/item.test.js

@@ -1557,4 +1557,136 @@ describe('Item actions', () => {
       'No Clean (0 Unit @ $0.00/Unit)'
     );
   });
+
+  test('Should not apply modifier value when extractCalculatedValue is true but modifier is invalid', () => {
+    const prepayDiscount50Percent = {
+      compute: {
+        amount: 50,
+        type: 'percentage',
+        action: 'subtract',
+      },
+      properties: {
+        extractCalculatedValue: true,
+      },
+      conditions: {
+        valid: null,
+        rules: [
+          {
+            key: 'payment',
+            value: 'prepay',
+            operand: '$in',
+          },
+        ],
+      },
+      name: 'percentageDiscount50',
+      type: 'discount',
+    };
+
+    const orderItem = {
+      price: 7.59,
+      quantity: 1,
+      modifiers: [prepayDiscount50Percent],
+    };
+    const order = {
+      items: [orderItem],
+    };
+
+    const calculatedOrder = pricingService.order.calculate(order);
+
+    expect(calculatedOrder.total).toBe(7.59);
+    expect(calculatedOrder.items[0].price).toBe(7.59);
+    expect(calculatedOrder.items[0].total).toBe(7.59);
+    expect(calculatedOrder.items[0].modifiers.length).toBe(1);
+    expect(calculatedOrder.items[0].modifiers[0]._computed).toMatchObject({
+      amount: 0,
+      description: 'percentageDiscount50',
+    });
+  });
+
+  test('Should apply modifier value when extractCalculatedValue is true and modifier is valid', () => {
+    const prepayDiscount50Percent = {
+      compute: {
+        amount: 50,
+        type: 'percentage',
+        action: 'subtract',
+      },
+      properties: {
+        extractCalculatedValue: true,
+      },
+      name: 'percentageDiscount50',
+      type: 'discount',
+    };
+
+    const orderItem = {
+      price: 7.59,
+      quantity: 1,
+      modifiers: [prepayDiscount50Percent],
+    };
+    const order = {
+      items: [orderItem],
+    };
+
+    const calculatedOrder = pricingService.order.calculate(order);
+
+    expect(calculatedOrder.total).toBe(7.59);
+    expect(calculatedOrder.items[0].price).toBe(7.59);
+    expect(calculatedOrder.items[0].total).toBe(7.59);
+    expect(calculatedOrder.items[0].modifiers.length).toBe(1);
+    expect(calculatedOrder.items[0].modifiers[0]._computed).toMatchObject({
+      amount: -7.59,
+      description: 'percentageDiscount50 (-$7.59)',
+    });
+  });
+
+  test('Should apply modifier value when extractCalculatedValue is true and modifier is valid (being also a payment modifier)', () => {
+    const prepayDiscount50Percent = {
+      compute: {
+        amount: 50,
+        type: 'percentage',
+        action: 'subtract',
+      },
+      properties: {
+        extractCalculatedValue: true,
+      },
+      conditions: {
+        valid: null,
+        rules: [
+          {
+            key: 'payment',
+            value: 'prepay',
+            operand: '$in',
+          },
+        ],
+      },
+      name: 'percentageDiscount50',
+      type: 'discount',
+    };
+
+    const orderItem = {
+      price: 7.59,
+      quantity: 1,
+      modifiers: [prepayDiscount50Percent],
+    };
+    const order = {
+      items: [orderItem],
+    };
+
+    const calculatedOrder = pricingService.order.calculate(order, {
+      isPrepay: true,
+    });
+
+    expect(calculatedOrder.total).toBe(7.59);
+    expect(calculatedOrder.items[0].price).toBe(7.59);
+    expect(calculatedOrder.items[0].total).toBe(7.59);
+    expect(calculatedOrder.items[0].modifiers.length).toBe(2);
+
+    expect(calculatedOrder.items[0].modifiers[0]._computed).toMatchObject({
+      amount: 0,
+      description: 'percentageDiscount50',
+    });
+    expect(calculatedOrder.items[0].modifiers[1]._computed).toMatchObject({
+      amount: -7.59,
+      description: '$7.59 discount (-$7.59)',
+    });
+  });
 });

package/lib/item/calculate.js

@@ -40,10 +40,6 @@ module.exports = ({ _, utils, actions, modifierActions }) => {
       item.properties.overwrittenQuantity = undefined;
     }
 
-    const price = parseFloat(actions.getPriceWithoutModifiers({ item }));
-    let quantity = parseInt(item.quantity, 10);
-    subTotals._simple = math.mul(price, quantity);
-
     const modifiers = [];
     let { modifiers: itemModifiersPrev = [] } =
       actions.removeModifiersByQuantity(item);
@@ -103,6 +99,15 @@ module.exports = ({ _, utils, actions, modifierActions }) => {
         );
       });
 
+    const price = parseFloat(
+      actions.getPriceWithoutModifiers({
+        price: item.price,
+        modifiers: validatedModifiers,
+      })
+    );
+    let quantity = parseInt(item.quantity, 10);
+    subTotals._simple = math.mul(price, quantity);
+
     const modifiersToNotCompute = actions.getModifiersToNotCompute({
       item,
       validatedModifiers,

package/lib/item/getPriceWithoutModifiers.js

@@ -1,17 +1,15 @@
 module.exports = ({ actions, modifierActions }) =>
   /* eslint-disable no-restricted-syntax */
-  function getPriceWithoutModifiers({ item }) {
-    const basePrice = actions.getBasePrice(item);
+  function getPriceWithoutModifiers({ price, modifiers }) {
+    const basePrice = actions.getBasePrice({ price });
 
-    if (
-      !item ||
-      !Array.isArray(item.modifiers) ||
-      typeof basePrice !== 'number'
-    )
+    if (!Array.isArray(modifiers) || typeof basePrice !== 'number')
       return basePrice;
 
-    const calculatedModifiers = item.modifiers.filter(modifier =>
-      modifierActions.isExtractCalculatedValue({ modifier })
+    const calculatedModifiers = modifiers.filter(
+      modifier =>
+        modifierActions.isValid(modifier) &&
+        modifierActions.isExtractCalculatedValue({ modifier })
     );
 
     if (calculatedModifiers.length === 0) return basePrice;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@darkpos/pricing",
-  "version": "1.0.107",
+  "version": "1.0.108",
   "description": "Pricing calculator",
   "author": "Dark POS",
   "license": "ISC",
@@ -54,5 +54,5 @@
     "supertest": "^6.2.3",
     "supervisor": "^0.12.0"
   },
-  "gitHead": "16a66c27afee8501a123219c6653b59800654b81"
+  "gitHead": "263ab257a926d73b861d12ae2ccfdb46b7d162ee"
 }