@danypops/tickets 0.8.5 → 0.8.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/tickets",
-  "version": "0.8.5",
+  "version": "0.8.6",
   "description": "Unified CLI, daemon, and TypeScript library for issue tracking across GitHub, GitLab, and Jira.",
   "type": "module",
   "license": "MIT",
@@ -24,8 +24,8 @@
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
-    "@danypops/vehicle-core": "^0.11.0",
-    "@danypops/vehicle-server": "^0.16.0",
+    "@danypops/vehicle-core": "^0.12.1",
+    "@danypops/vehicle-server": "^0.17.0",
     "@danypops/vehicle-client": "^0.5.0",
     "@danypops/enigma-client": "^0.3.0",
     "@gitbeaker/rest": "^43.8.0",

package/src/agent-tools/tickets-vehicle.ts

@@ -16,6 +16,7 @@
  */
 import {
   bindVehicleOperation,
+  defineErrorMapping,
   defineLooseObjectSchema,
   defineVehicleOperation,
   type LooseObjectProperty,
@@ -24,11 +25,21 @@ import {
 } from "@danypops/vehicle-core";
 import { VehicleRegistry } from "@danypops/vehicle-server";
 import type { BackendCapabilities, TicketService } from "../issue/service.js";
+import { statusForKnownTicketError } from "../rpc/error-status.js";
 import type { TicketOperation } from "../rpc/ops.js";
 import { TICKET_OP_HANDLERS, type TicketsAppDeps } from "../rpc/server.js";
 
 const OWNER = "tickets";
 
+const withTicketsErrorParity = defineErrorMapping(
+  [
+    { matches: (error) => statusForKnownTicketError(error) === 404, category: "not_found" },
+    { matches: (error) => statusForKnownTicketError(error) === 400, category: "validation" },
+    { matches: (error) => statusForKnownTicketError(error) === 422, category: "authorization" },
+  ],
+  { fallbackCategory: "internal", fallbackCode: "handler-failed", fallbackMessage: "Tickets operation failed" },
+);
+
 const LIMITS = { defaultTimeoutMs: 10_000, maxTimeoutMs: 30_000, maxRequestBytes: 65_536, maxResponseBytes: 262_144 };
 
 const stringProp: LooseObjectProperty = { type: "string" };
@@ -288,10 +299,8 @@ export function createTicketsVehicleRegistry(deps: Omit<TicketsAppDeps, "vehicle
     version: deps.version,
     description: "Unified issue tracking across GitHub, GitLab, and Jira.",
   });
-  // setExposeHandlerFailureDetails left off: ApiError (issue/errors.ts) embeds the raw HTTP
-  // response body, untrusted external content from GitHub/GitLab/Jira. No error-parity wrapper
-  // here either -- TICKET_OP_HANDLERS' real errors reach the registry's own catch-all as-is.
-
+  // Every handler passes through the reviewed mapper above; unmatched failures stay redacted.
+  registry.setExposeHandlerFailureDetails(true);
   for (const spec of OPERATIONS) {
     const operation = defineVehicleOperation({
       name: spec.action,
@@ -308,7 +317,11 @@ export function createTicketsVehicleRegistry(deps: Omit<TicketsAppDeps, "vehicle
     const mapInput = spec.mapInput ?? ((input: Record<string, unknown>) => input);
     registry.register(
       OWNER,
-      bindVehicleOperation(operation, () => async (context) => handler(deps, mapInput(context.input as Record<string, unknown>) as never)),
+      bindVehicleOperation(
+        operation,
+        () => async (context) =>
+          withTicketsErrorParity<unknown>(() => handler(deps, mapInput(context.input as Record<string, unknown>) as never)),
+      ),
     );
   }
 

package/src/rpc/error-status.ts

@@ -0,0 +1,12 @@
+import { AuthRequiredError, IssueNotFoundError } from "../issue/errors.js";
+import { NotSupportedError, UnknownBackendError } from "../issue/service.js";
+import { FocusError } from "../sqlite/focus.js";
+import { SavedQueryNotFoundError } from "../sqlite/saved-queries.js";
+
+/** Returns the legacy HTTP status only for reviewed business errors; unknown failures stay unclassified. */
+export function statusForKnownTicketError(error: unknown): number | undefined {
+  if (error instanceof IssueNotFoundError || error instanceof SavedQueryNotFoundError) return 404;
+  if (error instanceof UnknownBackendError || error instanceof NotSupportedError || error instanceof FocusError) return 400;
+  if (error instanceof AuthRequiredError) return 422;
+  return undefined;
+}

package/src/rpc/server.ts

@@ -11,12 +11,12 @@ import type { VehicleRegistry } from "@danypops/vehicle-server";
 import { createVehicleHttpApp } from "@danypops/vehicle-server/http";
 import type { Logger } from "@danypops/vehicle-server/logging";
 import { errorResponse, healthResponse, jsonResponse, readyResponse, requireBearerToken } from "@danypops/vehicle-server/rpc-http";
-import { AuthRequiredError, IssueNotFoundError } from "../issue/errors.js";
 import { parseRef } from "../issue/issue.js";
-import { NotSupportedError, type TicketService, UnknownBackendError } from "../issue/service.js";
+import type { TicketService } from "../issue/service.js";
 import { FocusError, type FocusStore } from "../sqlite/focus.js";
 import type { Ledger } from "../sqlite/ledger.js";
 import { SavedQueryNotFoundError, type SavedQueryStore } from "../sqlite/saved-queries.js";
+import { statusForKnownTicketError } from "./error-status.js";
 import { TICKET_OPERATIONS, type TicketOperation, type TicketOpInputs, type TicketOpOutputs } from "./ops.js";
 
 export interface TicketsAppDeps {
@@ -117,10 +117,7 @@ function isTicketOperation(value: unknown): value is TicketOperation {
 }
 
 function statusFor(error: unknown): number {
-  if (error instanceof IssueNotFoundError || error instanceof SavedQueryNotFoundError) return 404;
-  if (error instanceof UnknownBackendError || error instanceof NotSupportedError || error instanceof FocusError) return 400;
-  if (error instanceof AuthRequiredError) return 422;
-  return 500;
+  return statusForKnownTicketError(error) ?? 500;
 }
 
 export function buildApp(deps: TicketsAppDeps): { fetch(request: Request): Promise<Response> } {