@danypops/pi-papyrus 0.52.1 → 0.52.3

package/extension/src/tools/vehicle-artifact-renderers.ts

@@ -46,7 +46,9 @@ import {
 } from "../tool-rendering/render-model.ts";
 import { recordRenderDiagnostic, shapeFingerprint } from "./render-diagnostics.ts";
 
-function isArtifact(value: unknown): value is Artifact {
+/** Every field an Artifact and its lean list-default ArtifactSummary (tasks.list/docs.list/
+ * rules.list/playbooks.list without full:true -- see summarizeArtifact()) both always carry. */
+function hasArtifactCoreFields(value: unknown): value is Omit<Artifact, "body" | "extra"> {
 	if (typeof value !== "object" || value === null) return false;
 	const row = value as Record<string, unknown>;
 	return (
@@ -55,15 +57,27 @@ function isArtifact(value: unknown): value is Artifact {
 		typeof row.title === "string" &&
 		typeof row.status === "string" &&
 		typeof row.subtype === "string" &&
-		typeof row.body === "string" &&
 		Array.isArray(row.labels) &&
 		typeof row.created_at === "string" &&
 		typeof row.updated_at === "string"
 	);
 }
 
+function isArtifact(value: unknown): value is Artifact {
+	return hasArtifactCoreFields(value) && typeof (value as Record<string, unknown>).body === "string";
+}
+
+/**
+ * Regression (real, live-observed): tasks.list's own documented default ("Returns a lean
+ * summary (no body/extra) unless full: true is passed") returns ArtifactSummary rows, which
+ * omit body entirely. createArtifactListDetails/artifactSummary (render-model.ts) never read
+ * .body for list rendering -- only single-artifact createArtifactDetails does -- so requiring
+ * body here (matching isArtifact) silently fell every default (lean, the common case) list
+ * call for tasks.list/docs.list/rules.list/playbooks.list through to the generic raw Vehicle
+ * table renderer instead of the curated ArtifactListCard.
+ */
 function isArtifactArray(value: unknown): value is Artifact[] {
-	return Array.isArray(value) && value.every(isArtifact);
+	return Array.isArray(value) && value.every(hasArtifactCoreFields);
 }
 
 /** tasks.focused/tasks.pause/tasks.unpause's own wrapper shape -- an Artifact

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/pi-papyrus",
-  "version": "0.52.1",
+  "version": "0.52.3",
   "description": "Pi host extension for Papyrus: native tools, TUI panels, and context injection over the daemon-backed graph store",
   "type": "module",
   "keywords": ["pi-package"],
@@ -20,7 +20,7 @@
     "@danypops/jittor": "^0.14.0",
     "@danypops/papyrus": "^0.52.0",
     "@danypops/vehicle-client": "^0.7.0",
-    "@danypops/vehicle-client-pi": "^0.24.1",
+    "@danypops/vehicle-client-pi": "^0.27.1",
     "@danypops/vehicle-core": "^0.12.3",
     "@danypops/vehicle-server": "^0.18.1",
     "beautiful-mermaid": "1.1.3",
@@ -46,5 +46,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "files": ["extension", "README.md", "THIRD_PARTY_LICENSES.md"]
+  "files": ["extension", "README.md"]
 }

package/THIRD_PARTY_LICENSES.md

@@ -1,31 +0,0 @@
-# Third-party licenses
-
-## pi-ask-user (MIT)
-
-`extension/src/discuss-ask-view.ts` and `extension/src/discuss-ask-layout.ts` are substantially
-adapted from [pi-ask-user](https://github.com/edlsh/pi-ask-user), used here as the interactive
-UI for Discuss's own `live:true` synchronous ask.
-
-```
-MIT License
-
-Copyright (c) 2026 Enzo Lucchesi
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
-```

package/extension/src/discuss/discuss-ask-layout.ts

@@ -1,195 +0,0 @@
-/**
- * discuss-ask-layout.ts — row layout for the searchable single-select list used by Discuss's
- * live:true ask UI (discuss-ask-view.ts). Wraps long option titles/descriptions to a target
- * width and returns flat annotated rows, windowed around the current selection when the full
- * list would overflow the available rows.
- *
- * Adapted from pi-ask-user's single-select-layout.ts (MIT, Copyright (c) 2026 Enzo Lucchesi --
- * see THIRD_PARTY_LICENSES.md) so Discuss owns this UI directly instead of depending on that
- * package at runtime.
- */
-
-export interface AskOption {
-	title: string;
-	description?: string;
-}
-
-export interface AnnotatedRow {
-	line: string;
-	selected: boolean;
-}
-
-export interface RenderSingleSelectRowsParams {
-	options: AskOption[];
-	selectedIndex: number;
-	width: number;
-	allowFreeform: boolean;
-	allowComment?: boolean;
-	commentEnabled?: boolean;
-	maxRows?: number;
-	hideDescriptions?: boolean;
-}
-
-function wrapText(text: string, width: number): string[] {
-	const normalized = text.replace(/\s+/g, " ").trim();
-	if (!normalized) return [""];
-	if (width <= 1) return normalized.split("");
-
-	const words = normalized.split(" ");
-	const lines: string[] = [];
-	let current = "";
-
-	for (const word of words) {
-		if (!current) {
-			if (word.length <= width) {
-				current = word;
-			} else {
-				for (let i = 0; i < word.length; i += width) {
-					lines.push(word.slice(i, i + width));
-				}
-			}
-			continue;
-		}
-
-		const candidate = `${current} ${word}`;
-		if (candidate.length <= width) {
-			current = candidate;
-			continue;
-		}
-
-		lines.push(current);
-		if (word.length <= width) {
-			current = word;
-		} else {
-			current = "";
-			for (let i = 0; i < word.length; i += width) {
-				const chunk = word.slice(i, i + width);
-				if (chunk.length === width || i + width < word.length) lines.push(chunk);
-				else current = chunk;
-			}
-		}
-	}
-
-	if (current) lines.push(current);
-	return lines;
-}
-
-function padLine(prefix: string, content: string): string {
-	return `${prefix}${content}`.trimEnd();
-}
-
-interface ItemBlock {
-	itemIndex: number;
-	lines: string[];
-}
-
-type ListItem =
-	| { type: "option"; option: AskOption }
-	| { type: "comment-toggle"; option: AskOption }
-	| { type: "freeform"; option: AskOption };
-
-function buildItemBlocks(
-	options: AskOption[],
-	width: number,
-	allowFreeform: boolean,
-	allowComment: boolean,
-	commentEnabled: boolean,
-	selectedIndex: number,
-	hideDescriptions = false,
-): ItemBlock[] {
-	const normalizedWidth = Math.max(12, width);
-	const freeformLabel = "Type something. — Enter a custom response";
-	const commentToggleLabel = `${commentEnabled ? "[✓]" : "[ ]"} Add extra context after selection`;
-	const allItems: ListItem[] = options.map((option) => ({ type: "option", option }));
-	if (allowComment) allItems.push({ type: "comment-toggle", option: { title: commentToggleLabel } });
-	if (allowFreeform) allItems.push({ type: "freeform", option: { title: freeformLabel } });
-
-	return allItems.map((item, itemIndex) => {
-		const pointer = itemIndex === selectedIndex ? "→" : " ";
-		const lines: string[] = [];
-
-		if (item.type === "comment-toggle" || item.type === "freeform") {
-			const prefix = `${pointer}   `;
-			const wrapped = wrapText(item.option.title, Math.max(8, normalizedWidth - prefix.length));
-			wrapped.forEach((line, lineIndex) => {
-				lines.push(padLine(lineIndex === 0 ? prefix : " ".repeat(prefix.length), line));
-			});
-			return { itemIndex, lines };
-		}
-
-		const numberPrefix = `${pointer} ${itemIndex + 1}. `;
-		const continuationPrefix = " ".repeat(numberPrefix.length);
-		const titleLines = wrapText(item.option.title, Math.max(8, normalizedWidth - numberPrefix.length));
-		titleLines.forEach((line, lineIndex) => {
-			lines.push(padLine(lineIndex === 0 ? numberPrefix : continuationPrefix, line));
-		});
-
-		if (item.option.description && !hideDescriptions) {
-			const descriptionPrefix = "      ";
-			const descriptionLines = wrapText(item.option.description, Math.max(8, normalizedWidth - descriptionPrefix.length));
-			descriptionLines.forEach((line) => {
-				lines.push(padLine(descriptionPrefix, line));
-			});
-		}
-
-		return { itemIndex, lines };
-	});
-}
-
-function flatten(blocks: ItemBlock[], selectedIndex: number): AnnotatedRow[] {
-	return blocks.flatMap((block) => block.lines.map((line) => ({ line, selected: block.itemIndex === selectedIndex })));
-}
-
-export function renderSingleSelectRows({
-	options,
-	selectedIndex,
-	width,
-	allowFreeform,
-	allowComment = false,
-	commentEnabled = false,
-	maxRows,
-	hideDescriptions,
-}: RenderSingleSelectRowsParams): AnnotatedRow[] {
-	const itemCount = options.length + (allowComment ? 1 : 0) + (allowFreeform ? 1 : 0);
-	const blocks = buildItemBlocks(options, width, allowFreeform, allowComment, commentEnabled, selectedIndex, hideDescriptions);
-	const allRows = flatten(blocks, selectedIndex);
-
-	if (!Number.isFinite(maxRows) || !maxRows || maxRows <= 0 || allRows.length <= maxRows) return allRows;
-
-	const safeMaxRows = Math.max(1, Math.floor(maxRows));
-	const selectedBlock = blocks[selectedIndex] ?? blocks[0];
-	if (!selectedBlock) return [];
-
-	const indicator = `  (${selectedIndex + 1}/${itemCount})`;
-	const availableRows = safeMaxRows > 1 ? safeMaxRows - 1 : 1;
-
-	if (selectedBlock.lines.length >= availableRows) {
-		const visible = selectedBlock.lines.slice(0, availableRows).map((line) => ({ line, selected: true }));
-		if (safeMaxRows > 1) visible.push({ line: indicator, selected: false });
-		return visible.slice(0, safeMaxRows);
-	}
-
-	let start = selectedIndex;
-	let end = selectedIndex + 1;
-	let usedRows = selectedBlock.lines.length;
-
-	while (true) {
-		const nextCanFit = end < blocks.length && usedRows + blocks[end]!.lines.length <= availableRows;
-		if (nextCanFit) {
-			usedRows += blocks[end]!.lines.length;
-			end += 1;
-			continue;
-		}
-		const prevCanFit = start > 0 && usedRows + blocks[start - 1]!.lines.length <= availableRows;
-		if (prevCanFit) {
-			start -= 1;
-			usedRows += blocks[start]!.lines.length;
-			continue;
-		}
-		break;
-	}
-
-	const visible = flatten(blocks.slice(start, end), selectedIndex);
-	visible.push({ line: indicator, selected: false });
-	return visible.slice(0, safeMaxRows);
-}