@danypops/pi-papyrus 0.38.1 → 0.38.3

package/extension/src/domain-tools.ts

@@ -1,14 +1,12 @@
 import type { AgentToolUpdateCallback, ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
 import { Type } from "typebox";
 import {
-	NOTE_DISPOSITIONS,
 	PROOF_TYPES,
 	readDiscussionExtra,
 	type Artifact,
 	type DiscussionAndRounds,
 	type DiscussionRound,
 	type GateResult,
-	type NoteHistoryPage,
 	type OperationName,
 	type WorkflowRunResult,
 	type TaskCompletion,
@@ -491,69 +489,9 @@ export function registerTasksTool(pi: ExtensionAPI): void {
 	});
 }
 
-export function registerNotesTool(pi: ExtensionAPI): void {
-	pi.registerTool({
-		name: "notes",
-		label: "Notes",
-		description: "Deferred human-intent inbox. ACTIONS: capture, list, show, history, consume, promote, archive. Capture stores a request without creating work. Consume marks it considered. To promote, first create the resulting Task, Doc, Rule, or Skill through its domain tool, then link it with target_id (or target_name). Archive requires an explicit disposition. history returns this note's own real append-only event log (captured/consumed/promoted/archived), not the generic cross-kind graph.history. PREFER `name` (the note's exact title) over `id` for show/history/consume/promote/archive, and `target_name` over `target_id` for promote -- all are backend implementation details, resolved from name automatically (target_name searches across every kind, since a promotion target can be a task, doc, rule, or skill).",
-		parameters: Type.Object({
-			action: Type.String(),
-			id: Type.Optional(Type.String()),
-			name: Type.Optional(Type.String()),
-			body: Type.Optional(Type.String()),
-			title: Type.Optional(Type.String()),
-			status: Type.Optional(Type.Union([Type.Literal("draft"), Type.Literal("active"), Type.Literal("archived")])),
-			text: Type.Optional(Type.String()),
-			limit: Type.Optional(Type.Number()),
-			target_id: Type.Optional(Type.String()),
-			target_name: Type.Optional(Type.String()),
-			disposition: Type.Optional(Type.Union(NOTE_DISPOSITIONS.map((value) => Type.Literal(value)))),
-			reason: Type.Optional(Type.String()),
-			session_id: Type.Optional(Type.String()),
-			project_root: Type.Optional(Type.String()),
-		}),
-		renderCall(args, theme) { return renderPapyrusToolCall("Notes", args, theme); },
-		renderResult(result, options, theme, context) { return renderPapyrusToolResult(result, options, theme, context); },
-		async execute(_id, rawParams, _signal, _onUpdate, ctx) {
-			try {
-				const params: Record<string, unknown> = { ...rawParams };
-				const action = params.action;
-				const baseRequest = { project_root: params.project_root ?? ctx.cwd, actor: "agent", source: "notes-tool" };
-				await resolveNameFields(params, [
-					{ nameKey: "name", idKey: "id", listOperation: "notes.list", baseRequest },
-					// Kind-agnostic: a promotion target can be a task, doc, rule, or skill, so this searches every kind rather than only notes.
-					{ nameKey: "target_name", idKey: "target_id", listOperation: "artifact.query", baseRequest },
-				]);
-				const request = { ...params, ...baseRequest };
-				if (action === "capture") {
-					const artifact = await callService<Record<string, unknown>, Artifact>("notes.capture", request);
-					return text(`Captured note ${artifactLine(artifact)}`, createArtifactDetails("notes.capture", artifact));
-				}
-				if (action === "list") {
-					const rows = await callService<Record<string, unknown>, Artifact[]>("notes.list", request);
-					return text(rows.length ? artifactLines(rows).join("\n") : "No open notes.", createArtifactListDetails("notes.list", rows));
-				}
-				if (action === "show") {
-					const artifact = await callService<Record<string, unknown>, Artifact>("notes.show", request);
-					return text(`${artifactLine(artifact)}\n\n${artifact.body}`, createArtifactDetails("notes.show", artifact));
-				}
-				if (action === "history") {
-					const page = await callService<Record<string, unknown>, NoteHistoryPage>("notes.history", request);
-					const lines = page.events.map((event) => `${event.occurredAt} ${event.type} · ${event.actor}/${event.source}${event.relatedId ? ` · ${event.relatedId}` : ""}${event.disposition ? ` · ${event.disposition}` : ""}${event.reason ? ` · ${event.reason}` : ""}`);
-					const output = lines.join("\n") || "No recorded history for this note.";
-					return text(output, createPreviewDetails("notes.history", "Note history", output));
-				}
-				const operations = { consume: "notes.consume", promote: "notes.promote", archive: "notes.archive" } as const;
-				const operation = operations[action as keyof typeof operations];
-				if (!operation) throw new Error(`unknown notes action: ${action}`);
-				const artifact = await callService<Record<string, unknown>, Artifact>(operation, request);
-				return text(`${action}: ${artifactLine(artifact)}`, createArtifactDetails(operation, artifact));
-			} catch (error) {
-				throw new Error(`notes failed: ${error instanceof Error ? error.message : error}`);
-			}
-		},
-	});
-}
+// notes.* is registered as a real Vehicle (see ../vehicle-notes-client.ts and index.ts),
+// not a hand-rolled pi.registerTool() -- the first domain migrated off the
+// action-dispatch mega-tool pattern this file's other tools still use.
 
 export function registerDocsTool(pi: ExtensionAPI): void {
 	pi.registerTool({
@@ -943,7 +881,6 @@ export function registerDiscussTool(pi: ExtensionAPI): void {
 /** Thin orchestrator: each domain's tool is independently navigable/testable via its own registerXTool function. */
 export function registerDomainTools(pi: ExtensionAPI): void {
 	registerTasksTool(pi);
-	registerNotesTool(pi);
 	registerDocsTool(pi);
 	registerRulesTool(pi);
 	registerPlaybooksTool(pi);

package/extension/src/index.ts

@@ -28,6 +28,7 @@ import { formatMetadata } from "./artifact-format.ts";
 import { callService, subscribeTaskPushChannel } from "./service-client.ts";
 import type { PushChannelClient } from "@danypops/daemon-kit/pi-client";
 import { registerDomainTools, resolveNameFields } from "./domain-tools.ts";
+import { registerNotesVehicle } from "./vehicle-notes-client.ts";
 import { BoundedPoll } from "./bounded-poll.ts";
 import { renderNoteWidgetLines } from "./note-widget.ts";
 import { ensureTypingCourtesyTracking, isLiveAskPending } from "./discuss-ask-view.ts";
@@ -677,6 +678,18 @@ export default async function (pi: ExtensionAPI) {
 	// ── Task widget (TodoOverlay pattern: factory form, requestRender) ──
 
 	pi.on("session_start", async (_event, ctx) => {
+		// registerVehicleTools() (which registerNotesVehicle wraps) needs
+		// pi.getAllTools()/getActiveTools()/setActiveTools() -- Pi's extension
+		// runtime only finishes initializing after every extension's top-level
+		// factory (this one included) has resolved, so calling it directly from
+		// there throws "Extension runtime not initialized" (previously silently
+		// swallowed by registerNotesVehicle's own daemon-unreachable try/catch,
+		// making every projected notes.* tool invisible to the model with zero
+		// visible sign why -- confirmed live in the identical pi-tickets bug).
+		// session_start fires only after that initialization completes, and Pi
+		// awaits every session_start handler before the model's first turn, so
+		// registering here is both safe and still visible on turn one.
+		await registerNotesVehicle(pi);
 		// Registers this session's identity with the daemon as early as possible -- before any
 		// Focus-mutating call could plausibly happen -- shrinking (not eliminating; see
 		// domain/session-identity.ts) the first-touch race window. Best-effort: the daemon may be
@@ -731,7 +744,9 @@ export default async function (pi: ExtensionAPI) {
 		if (event.toolName.startsWith("papyrus_") || event.toolName === "tasks") {
 			await overlay?.refresh();
 		}
-		if (event.toolName === "notes") {
+		// notes.* projects to notes_capture/notes_list/notes_show/... (see
+		// registerNotesVehicle) -- not a single "notes" tool name anymore.
+		if (event.toolName.startsWith("notes_")) {
 			await noteOverlay?.refresh();
 		}
 	});

package/extension/src/service-client.ts

@@ -1,5 +1,5 @@
 import { connectPushChannel, createRetryingClient, type PushChannelClient, type PushChannelState, type RetryingClient } from "@danypops/daemon-kit/pi-client";
-import { connectPapyrusClient, resolvePushChannelTarget, type OperationName, type PapyrusClient } from "@danypops/papyrus";
+import { connectPapyrusClient, resolvePushChannelTarget, resolveVehicleClientTarget, type OperationName, type PapyrusClient, type VehicleClientTarget } from "@danypops/papyrus";
 
 type ClientConnector = () => Promise<PapyrusClient>;
 
@@ -37,6 +37,27 @@ export function resetPushChannelTargetResolverForTests(): void {
 	pushChannelTargetResolver = resolvePushChannelTarget;
 }
 
+let vehicleClientTargetResolver: typeof resolveVehicleClientTarget = resolveVehicleClientTarget;
+
+/**
+ * Defaults to the real daemonStateDir() -- every test that exercises the full extension
+ * entrypoint (registerPapyrus(api)), not just registerDomainTools, must override this
+ * first, the same way mockService already overrides setPapyrusClientConnectorForTests,
+ * or a hermetic unit test can silently start depending on whatever real Papyrus daemon
+ * handle happens to exist on the machine running it.
+ */
+export function setVehicleClientTargetResolverForTests(value: () => VehicleClientTarget | undefined): void {
+	vehicleClientTargetResolver = value;
+}
+
+export function resetVehicleClientTargetResolverForTests(): void {
+	vehicleClientTargetResolver = resolveVehicleClientTarget;
+}
+
+export function currentVehicleClientTarget(): VehicleClientTarget | undefined {
+	return vehicleClientTargetResolver();
+}
+
 /**
  * Subscribes to the daemon's "tasks" push topic so a widget can refresh the moment
  * a mutation happens, instead of waiting for its next poll tick. Returns undefined

package/extension/src/vehicle-notes-client.ts

@@ -0,0 +1,43 @@
+/**
+ * Registers notes.* as a real Vehicle instead of a hand-rolled `pi.registerTool()`
+ * mega-tool -- see @danypops/papyrus's src/vehicle/notes-vehicle.ts for the
+ * VehicleRegistry side. Same daemon, same handle file, same Bearer token every
+ * other Papyrus RPC call already uses (resolveVehicleClientTarget mirrors
+ * resolvePushChannelTarget's own resolution).
+ *
+ * Papyrus's daemon is expected to already be running as an installed service
+ * (see `packed install-service`), not auto-spawned on first use -- so unlike
+ * registerVehicleTools' README example, failure here (daemon not started yet,
+ * stale handle) is tolerated the same silent-degrade way
+ * subscribeTaskPushChannel already tolerates it, rather than letting a
+ * daemon-not-running condition abort the rest of extension setup. There is
+ * no retry-on-later-connect for a tool that was never registered at all --
+ * Pi has no way to add one after the fact outside the initial registration
+ * flow.
+ *
+ * Resolves the target through service-client.ts's currentVehicleClientTarget()
+ * (test-injectable, see setVehicleClientTargetResolverForTests), never
+ * @danypops/papyrus's resolveVehicleClientTarget() directly -- this runs from
+ * the bare extension entrypoint on every registerPapyrus(api) call, so an
+ * un-injected default would resolve the real daemonStateDir() in any test
+ * exercising the full entrypoint, not just ones about notes.
+ */
+import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import { RemoteVehicleClient } from "@danypops/vehicle-client/http";
+import { registerVehicleTools } from "@danypops/vehicle-client-pi";
+import { currentVehicleClientTarget } from "./service-client.ts";
+
+export async function registerNotesVehicle(pi: ExtensionAPI): Promise<void> {
+	const target = currentVehicleClientTarget();
+	if (!target) return;
+	try {
+		const client = new RemoteVehicleClient({ baseUrl: target.baseUrl, token: target.token });
+		await registerVehicleTools(pi, client, {
+			permissions: ["notes:read", "notes:write"],
+			principal: { id: "pi-papyrus" },
+		});
+	} catch {
+		// Daemon state is stale/unreachable -- degrade silently, matching
+		// subscribeTaskPushChannel's own tolerance for the same condition.
+	}
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/pi-papyrus",
-  "version": "0.38.1",
+  "version": "0.38.3",
   "description": "Pi host extension for Papyrus: native tools, TUI panels, and context injection over the daemon-backed graph store",
   "type": "module",
   "keywords": ["pi-package"],
@@ -18,7 +18,10 @@
   },
   "dependencies": {
     "@danypops/daemon-kit": "^0.10.0",
-    "@danypops/papyrus": "^0.38.0",
+    "@danypops/papyrus": "^0.38.1",
+    "@danypops/vehicle-core": "^0.1.0",
+    "@danypops/vehicle-client": "^0.1.1",
+    "@danypops/vehicle-client-pi": "^0.1.5",
     "beautiful-mermaid": "1.1.3"
   },
   "devDependencies": {