@danypops/pi-packed 0.28.3 → 0.28.4

package/dist/adoption/smoke.d.ts

@@ -7,6 +7,15 @@ export interface SmokeRegistrations {
     providers: string[];
     events: string[];
     renderers: string[];
+    /**
+     * Names, within tools/commands/shortcuts/flags respectively, whose registration call carried an
+     * explicit `shared: true` marker -- see @danypops/vehicle-client-pi's own markSharedRegistration.
+     * doctor.ts only suppresses a name's conflict once EVERY one of its claimants marked it shared.
+     */
+    sharedTools: string[];
+    sharedCommands: string[];
+    sharedShortcuts: string[];
+    sharedFlags: string[];
 }
 export interface ExtensionSmokeResult {
     path: string;

package/dist/adoption/smoke.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"smoke.d.ts","sourceRoot":"","sources":["../../service/src/adoption/smoke.ts"],"names":[],"mappings":"AAKA,MAAM,MAAM,WAAW,GAAG,IAAI,GAAG,SAAS,GAAG,OAAO,GAAG,mBAAmB,GAAG,cAAc,GAAG,qBAAqB,CAAC;AAEpH,MAAM,WAAW,kBAAkB;IAClC,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,QAAQ,EAAE,MAAM,EAAE,CAAC;IACnB,SAAS,EAAE,MAAM,EAAE,CAAC;IACpB,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,SAAS,EAAE,MAAM,EAAE,CAAC;IACpB,MAAM,EAAE,MAAM,EAAE,CAAC;IACjB,SAAS,EAAE,MAAM,EAAE,CAAC;CACpB;AAED,MAAM,WAAW,oBAAoB;IACpC,IAAI,EAAE,MAAM,CAAC;IACb,MAAM,EAAE,WAAW,CAAC;IACpB,UAAU,EAAE,MAAM,CAAC;IACnB,aAAa,EAAE,kBAAkB,CAAC;IAClC,OAAO,CAAC,EAAE,MAAM,CAAC;CACjB;AAED,MAAM,WAAW,YAAY;IAC5B,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,YAAY,CAAC,EAAE,MAAM,CAAC;CACtB;AAuDD;;;;;;;;;;;;;GAaG;AACH,wBAAgB,2BAA2B,CAAC,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,GAAG,MAAM,GAAG,SAAS,CAO7F;AAsLD,wBAAsB,iBAAiB,CACtC,WAAW,EAAE,MAAM,EACnB,aAAa,EAAE,MAAM,EACrB,OAAO,GAAE,YAAiB,GACxB,OAAO,CAAC,oBAAoB,CAAC,CAoF/B"}
+{"version":3,"file":"smoke.d.ts","sourceRoot":"","sources":["../../service/src/adoption/smoke.ts"],"names":[],"mappings":"AAKA,MAAM,MAAM,WAAW,GAAG,IAAI,GAAG,SAAS,GAAG,OAAO,GAAG,mBAAmB,GAAG,cAAc,GAAG,qBAAqB,CAAC;AAEpH,MAAM,WAAW,kBAAkB;IAClC,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,QAAQ,EAAE,MAAM,EAAE,CAAC;IACnB,SAAS,EAAE,MAAM,EAAE,CAAC;IACpB,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,SAAS,EAAE,MAAM,EAAE,CAAC;IACpB,MAAM,EAAE,MAAM,EAAE,CAAC;IACjB,SAAS,EAAE,MAAM,EAAE,CAAC;IACpB;;;;OAIG;IACH,WAAW,EAAE,MAAM,EAAE,CAAC;IACtB,cAAc,EAAE,MAAM,EAAE,CAAC;IACzB,eAAe,EAAE,MAAM,EAAE,CAAC;IAC1B,WAAW,EAAE,MAAM,EAAE,CAAC;CACtB;AAED,MAAM,WAAW,oBAAoB;IACpC,IAAI,EAAE,MAAM,CAAC;IACb,MAAM,EAAE,WAAW,CAAC;IACpB,UAAU,EAAE,MAAM,CAAC;IACnB,aAAa,EAAE,kBAAkB,CAAC;IAClC,OAAO,CAAC,EAAE,MAAM,CAAC;CACjB;AAED,MAAM,WAAW,YAAY;IAC5B,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,YAAY,CAAC,EAAE,MAAM,CAAC;CACtB;AA2DD;;;;;;;;;;;;;GAaG;AACH,wBAAgB,2BAA2B,CAAC,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,GAAG,MAAM,GAAG,SAAS,CAO7F;AA0LD,wBAAsB,iBAAiB,CACtC,WAAW,EAAE,MAAM,EACnB,aAAa,EAAE,MAAM,EACrB,OAAO,GAAE,YAAiB,GACxB,OAAO,CAAC,oBAAoB,CAAC,CAoF/B"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/pi-packed",
-  "version": "0.28.3",
+  "version": "0.28.4",
   "description": "Pi package lifecycle, validation, daemon, tools, profiles, and TUI",
   "type": "module",
   "bin": {
@@ -40,13 +40,13 @@
   },
   "devDependencies": {
     "@danypops/pi-tui-harness": "^0.0.1",
-    "@danypops/vehicle-client-pi": "^0.43.1",
+    "@danypops/vehicle-client-pi": "^0.44.0",
     "@danypops/vehicle-conformance": "^0.4.0",
     "@types/semver": "^7.7.1",
     "follow-redirects": "^1.16.0"
   },
   "peerDependencies": {
-    "@danypops/vehicle-client-pi": "^0.43.1",
+    "@danypops/vehicle-client-pi": "^0.44.0",
     "@earendil-works/pi-coding-agent": "*",
     "@earendil-works/pi-tui": "*",
     "typebox": "*"

package/service/src/adoption/doctor.ts

@@ -31,6 +31,18 @@ const CONFLICT_KIND: Record<RegistrationKind, "tool" | "command" | "shortcut" |
 	shortcuts: "shortcut",
 	flags: "flag",
 };
+/**
+ * Maps each RegistrationKind to the smoke result's own parallel "which of these names were marked
+ * shared" field (see smoke.ts's own SmokeRegistrations doc comment). A name is only exempted from
+ * conflict reporting once EVERY one of its claimants marked it shared -- see runDoctor's own
+ * allSharedByName tracking below.
+ */
+const SHARED_REGISTRATION_KIND: Record<RegistrationKind, "sharedTools" | "sharedCommands" | "sharedShortcuts" | "sharedFlags"> = {
+	tools: "sharedTools",
+	commands: "sharedCommands",
+	shortcuts: "sharedShortcuts",
+	flags: "sharedFlags",
+};
 
 const MAX_EXTENSIONS_SCANNED = 50;
 
@@ -63,6 +75,11 @@ export async function runDoctor(piHome: string, projectRoot?: string, options: S
 	const bounded = jobs.slice(0, MAX_EXTENSIONS_SCANNED);
 
 	const claims = new Map<RegistrationKind, Map<string, DoctorClaim[]>>(REGISTRATION_KINDS.map((kind) => [kind, new Map()]));
+	// True for a (kind, name) pair only while EVERY claimant seen so far marked that exact
+	// registration shared: true -- a single unmarked claimant permanently flips it false, since an
+	// unmarked registration is a genuinely ambiguous case, not the coordinated-by-design pattern
+	// shared:true exists to exempt.
+	const allSharedByName = new Map<RegistrationKind, Map<string, boolean>>(REGISTRATION_KINDS.map((kind) => [kind, new Map()]));
 	const extensions: DoctorExtensionResult[] = [];
 	let anyNotOk = false;
 
@@ -82,14 +99,20 @@ export async function runDoctor(piHome: string, projectRoot?: string, options: S
 		const claim: DoctorClaim = { name: job.group.name, source: job.group.source, scope: job.group.scope, extension: job.extension };
 		for (const kind of REGISTRATION_KINDS) {
 			const byName = claims.get(kind)!;
-			for (const name of result.registrations[kind]) byName.set(name, [...(byName.get(name) ?? []), claim]);
+			const sharedFlags = allSharedByName.get(kind)!;
+			const sharedNamesHere = new Set(result.registrations[SHARED_REGISTRATION_KIND[kind]]);
+			for (const name of result.registrations[kind]) {
+				byName.set(name, [...(byName.get(name) ?? []), claim]);
+				sharedFlags.set(name, (sharedFlags.get(name) ?? true) && sharedNamesHere.has(name));
+			}
 		}
 	}
 
 	const conflicts: DoctorConflict[] = [];
 	for (const kind of REGISTRATION_KINDS) {
+		const sharedFlags = allSharedByName.get(kind)!;
 		for (const [name, claimants] of claims.get(kind)!) {
-			if (claimants.length > 1) conflicts.push({ kind: CONFLICT_KIND[kind], name, claimants });
+			if (claimants.length > 1 && !sharedFlags.get(name)) conflicts.push({ kind: CONFLICT_KIND[kind], name, claimants });
 		}
 	}
 	conflicts.sort((a, b) => a.kind.localeCompare(b.kind) || a.name.localeCompare(b.name));

package/service/src/adoption/smoke-child.ts

@@ -8,6 +8,15 @@ interface Registrations {
 	providers: string[];
 	events: string[];
 	renderers: string[];
+	/**
+	 * Names, within tools/commands/shortcuts/flags respectively, whose registration call carried an
+	 * explicit `shared: true` marker -- see @danypops/vehicle-client-pi's own markSharedRegistration.
+	 * doctor.ts only suppresses a name's conflict once EVERY one of its claimants marked it shared.
+	 */
+	sharedTools: string[];
+	sharedCommands: string[];
+	sharedShortcuts: string[];
+	sharedFlags: string[];
 }
 
 const MAX_REGISTRATIONS_TOTAL = 100;
@@ -43,6 +52,10 @@ const registrations: Registrations = {
 	providers: [],
 	events: [],
 	renderers: [],
+	sharedTools: [],
+	sharedCommands: [],
+	sharedShortcuts: [],
+	sharedFlags: [],
 };
 
 function capture(kind: keyof Registrations, value: unknown): void {
@@ -51,19 +64,33 @@ function capture(kind: keyof Registrations, value: unknown): void {
 	registrations[kind].push(name.slice(0, MAX_NAME_LENGTH));
 }
 
+const SHARED_KIND: Partial<Record<keyof Registrations, keyof Registrations>> = {
+	tools: "sharedTools",
+	commands: "sharedCommands",
+	shortcuts: "sharedShortcuts",
+	flags: "sharedFlags",
+};
+
+/** Captures the plain registration as usual, plus a parallel sharedX entry when the caller's own definition/options object carried an explicit `shared: true` marker. */
+function captureWithSharedMarker(kind: keyof Registrations, value: unknown, sharedMarker: unknown): void {
+	capture(kind, value);
+	const sharedKind = SHARED_KIND[kind];
+	if (sharedKind && sharedMarker === true) capture(sharedKind, value);
+}
+
 const api = new Proxy<Record<string, unknown>>(
 	{},
 	{
 		get(_target, property) {
 			switch (property) {
 				case "registerTool":
-					return (definition: { name?: unknown }) => capture("tools", definition?.name);
+					return (definition: { name?: unknown; shared?: unknown }) => captureWithSharedMarker("tools", definition?.name, definition?.shared);
 				case "registerCommand":
-					return (name: unknown) => capture("commands", name);
+					return (name: unknown, options?: { shared?: unknown }) => captureWithSharedMarker("commands", name, options?.shared);
 				case "registerShortcut":
-					return (name: unknown) => capture("shortcuts", name);
+					return (name: unknown, options?: { shared?: unknown }) => captureWithSharedMarker("shortcuts", name, options?.shared);
 				case "registerFlag":
-					return (name: unknown) => capture("flags", name);
+					return (name: unknown, options?: { shared?: unknown }) => captureWithSharedMarker("flags", name, options?.shared);
 				case "registerProvider":
 					return (name: unknown) => capture("providers", name);
 				case "registerMessageRenderer":

package/service/src/adoption/smoke.ts

@@ -13,6 +13,15 @@ export interface SmokeRegistrations {
 	providers: string[];
 	events: string[];
 	renderers: string[];
+	/**
+	 * Names, within tools/commands/shortcuts/flags respectively, whose registration call carried an
+	 * explicit `shared: true` marker -- see @danypops/vehicle-client-pi's own markSharedRegistration.
+	 * doctor.ts only suppresses a name's conflict once EVERY one of its claimants marked it shared.
+	 */
+	sharedTools: string[];
+	sharedCommands: string[];
+	sharedShortcuts: string[];
+	sharedFlags: string[];
 }
 
 export interface ExtensionSmokeResult {
@@ -43,6 +52,10 @@ const EMPTY_REGISTRATIONS: SmokeRegistrations = {
 	providers: [],
 	events: [],
 	renderers: [],
+	sharedTools: [],
+	sharedCommands: [],
+	sharedShortcuts: [],
+	sharedFlags: [],
 };
 
 function bounded(value: number | undefined, fallback: number, maximum: number): number {
@@ -282,6 +295,10 @@ function normalizeRegistrations(value: unknown): SmokeRegistrations {
 		providers: names("providers"),
 		events: names("events"),
 		renderers: names("renderers"),
+		sharedTools: names("sharedTools"),
+		sharedCommands: names("sharedCommands"),
+		sharedShortcuts: names("sharedShortcuts"),
+		sharedFlags: names("sharedFlags"),
 	};
 }
 

package/service/test/doctor.test.ts

@@ -132,6 +132,57 @@ describeIfSandboxed("runDoctor", () => {
 		expect(report.conflicts).toEqual([]);
 	});
 
+	it("never flags a conflict when every claimant self-declared the shared name via shared: true -- e.g. registerSharedSecretsCommand's own /secrets command, or Vehicle Shell's tools_list/tools_man/tools_type, both of which every claimant's own smoke scan sees as 'the first (and only) one' since each runs in its own isolated sandbox", async () => {
+		const home = piHome(["npm:pi-a", "npm:pi-b"]);
+		installNpmPackage(
+			home,
+			"pi-a",
+			{ extensions: ["extension/index.ts"] },
+			{
+				"extension/index.ts": 'export default function (pi: any) { pi.registerCommand("secrets", { handler() {}, shared: true }); }',
+			},
+		);
+		installNpmPackage(
+			home,
+			"pi-b",
+			{ extensions: ["extension/index.ts"] },
+			{
+				"extension/index.ts": 'export default function (pi: any) { pi.registerCommand("secrets", { handler() {}, shared: true }); }',
+			},
+		);
+
+		const report = await runDoctor(home);
+
+		expect(report.ok).toBe(true);
+		expect(report.conflicts).toEqual([]);
+	});
+
+	it("still flags a conflict when only SOME claimants self-declared the name shared -- an unmarked claimant is a genuinely ambiguous case, not the coordinated-by-design pattern shared: true exists to exempt", async () => {
+		const home = piHome(["npm:pi-a", "npm:pi-b"]);
+		installNpmPackage(
+			home,
+			"pi-a",
+			{ extensions: ["extension/index.ts"] },
+			{
+				"extension/index.ts": 'export default function (pi: any) { pi.registerCommand("secrets", { handler() {}, shared: true }); }',
+			},
+		);
+		installNpmPackage(
+			home,
+			"pi-b",
+			{ extensions: ["extension/index.ts"] },
+			{
+				"extension/index.ts": 'export default function (pi: any) { pi.registerCommand("secrets", { handler() {} }); }',
+			},
+		);
+
+		const report = await runDoctor(home);
+
+		expect(report.ok).toBe(false);
+		expect(report.conflicts).toHaveLength(1);
+		expect(report.conflicts[0]).toMatchObject({ kind: "command", name: "secrets" });
+	});
+
 	it("surfaces a genuinely crashing extension as a non-ok result without treating it as a conflict", async () => {
 		const home = piHome(["npm:pi-broken"]);
 		installNpmPackage(

package/service/test/smoke.test.ts

@@ -112,6 +112,10 @@ describeIfSandboxed("isolated extension smoke runner", () => {
 			commands: ["hello"],
 			shortcuts: ["ctrl+h"],
 			flags: ["hello"],
+			sharedTools: [],
+			sharedCommands: [],
+			sharedShortcuts: [],
+			sharedFlags: [],
 			providers: ["local"],
 			events: ["session_start"],
 			renderers: [],