@danypops/pi-packed 0.28.1 → 0.28.3

package/dist/adoption/smoke.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"smoke.d.ts","sourceRoot":"","sources":["../../service/src/adoption/smoke.ts"],"names":[],"mappings":"AAKA,MAAM,MAAM,WAAW,GAAG,IAAI,GAAG,SAAS,GAAG,OAAO,GAAG,mBAAmB,GAAG,cAAc,GAAG,qBAAqB,CAAC;AAEpH,MAAM,WAAW,kBAAkB;IAClC,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,QAAQ,EAAE,MAAM,EAAE,CAAC;IACnB,SAAS,EAAE,MAAM,EAAE,CAAC;IACpB,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,SAAS,EAAE,MAAM,EAAE,CAAC;IACpB,MAAM,EAAE,MAAM,EAAE,CAAC;IACjB,SAAS,EAAE,MAAM,EAAE,CAAC;CACpB;AAED,MAAM,WAAW,oBAAoB;IACpC,IAAI,EAAE,MAAM,CAAC;IACb,MAAM,EAAE,WAAW,CAAC;IACpB,UAAU,EAAE,MAAM,CAAC;IACnB,aAAa,EAAE,kBAAkB,CAAC;IAClC,OAAO,CAAC,EAAE,MAAM,CAAC;CACjB;AAED,MAAM,WAAW,YAAY;IAC5B,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,YAAY,CAAC,EAAE,MAAM,CAAC;CACtB;AAuDD;;;;;;;;;;;;;GAaG;AACH,wBAAgB,2BAA2B,CAAC,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,GAAG,MAAM,GAAG,SAAS,CAO7F;AAmJD,wBAAsB,iBAAiB,CACtC,WAAW,EAAE,MAAM,EACnB,aAAa,EAAE,MAAM,EACrB,OAAO,GAAE,YAAiB,GACxB,OAAO,CAAC,oBAAoB,CAAC,CAoF/B"}
+{"version":3,"file":"smoke.d.ts","sourceRoot":"","sources":["../../service/src/adoption/smoke.ts"],"names":[],"mappings":"AAKA,MAAM,MAAM,WAAW,GAAG,IAAI,GAAG,SAAS,GAAG,OAAO,GAAG,mBAAmB,GAAG,cAAc,GAAG,qBAAqB,CAAC;AAEpH,MAAM,WAAW,kBAAkB;IAClC,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,QAAQ,EAAE,MAAM,EAAE,CAAC;IACnB,SAAS,EAAE,MAAM,EAAE,CAAC;IACpB,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,SAAS,EAAE,MAAM,EAAE,CAAC;IACpB,MAAM,EAAE,MAAM,EAAE,CAAC;IACjB,SAAS,EAAE,MAAM,EAAE,CAAC;CACpB;AAED,MAAM,WAAW,oBAAoB;IACpC,IAAI,EAAE,MAAM,CAAC;IACb,MAAM,EAAE,WAAW,CAAC;IACpB,UAAU,EAAE,MAAM,CAAC;IACnB,aAAa,EAAE,kBAAkB,CAAC;IAClC,OAAO,CAAC,EAAE,MAAM,CAAC;CACjB;AAED,MAAM,WAAW,YAAY;IAC5B,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,YAAY,CAAC,EAAE,MAAM,CAAC;CACtB;AAuDD;;;;;;;;;;;;;GAaG;AACH,wBAAgB,2BAA2B,CAAC,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,GAAG,MAAM,GAAG,SAAS,CAO7F;AAsLD,wBAAsB,iBAAiB,CACtC,WAAW,EAAE,MAAM,EACnB,aAAa,EAAE,MAAM,EACrB,OAAO,GAAE,YAAiB,GACxB,OAAO,CAAC,oBAAoB,CAAC,CAoF/B"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/pi-packed",
-  "version": "0.28.1",
+  "version": "0.28.3",
   "description": "Pi package lifecycle, validation, daemon, tools, profiles, and TUI",
   "type": "module",
   "bin": {
@@ -42,7 +42,8 @@
     "@danypops/pi-tui-harness": "^0.0.1",
     "@danypops/vehicle-client-pi": "^0.43.1",
     "@danypops/vehicle-conformance": "^0.4.0",
-    "@types/semver": "^7.7.1"
+    "@types/semver": "^7.7.1",
+    "follow-redirects": "^1.16.0"
   },
   "peerDependencies": {
     "@danypops/vehicle-client-pi": "^0.43.1",

package/service/src/adoption/smoke-child.ts

@@ -99,7 +99,16 @@ async function main(): Promise<void> {
 	const extensionPath = process.argv[2];
 	if (!extensionPath) throw new Error("extension path is required");
 	try {
-		const jiti = createJiti(import.meta.url, { interopDefault: true, tryNative: false });
+		// tryNative matches loader.ts's own real, non-Bun-binary Pi extension loading convention:
+		// prefer Bun's native TS/ESM transform, falling back to jiti's own Babel transform only for
+		// what native genuinely can't handle. Confirmed live: tryNative:false forced EVERY
+		// transitive dependency (including plain CJS libraries that never needed a Babel transform,
+		// e.g. follow-redirects) through jiti's Babel path -- which has its own real, reproducible
+		// bug interacting with a library that calls Error.captureStackTrace on a not-yet-initialized
+		// Error instance during module-level prototype setup (confirmed outside this sandbox too,
+		// given a cold jiti transform cache), surfacing as an opaque "First argument must be an
+		// Error object" crash unrelated to the extension's own code.
+		const jiti = createJiti(import.meta.url, { interopDefault: true, tryNative: true });
 		const factory = (await jiti.import(extensionPath, { default: true })) as unknown;
 		if (typeof factory !== "function") throw new Error("extension has no default factory export");
 		await factory(api);

package/service/src/adoption/smoke.ts

@@ -1,4 +1,4 @@
-import { existsSync, realpathSync } from "node:fs";
+import { existsSync, readFileSync, readdirSync, realpathSync } from "node:fs";
 import { createRequire } from "node:module";
 import { dirname, join, relative, resolve, sep } from "node:path";
 import { fileURLToPath } from "node:url";
@@ -105,6 +105,41 @@ export function resolveDependencyModulesDir(fromDir: string, name: string): stri
 	}
 }
 
+const MAX_PROCESS_SCAN_ENTRIES = 100_000;
+
+/**
+ * RLIMIT_NPROC (prlimit's own --nproc) is a per-real-UID, system-wide limit -- NOT scoped to
+ * this sandbox's own process tree. A small absolute constant breaks the instant the invoking
+ * user's REAL total process count already exceeds it (routine on a heavily-used workstation
+ * with several long-running agent sessions): any further thread/fork Bun's own runtime needs
+ * internally (confirmed live: its native TS transpiler spawns one) immediately fails, surfacing
+ * as an unrecoverable SIGABRT (exit 134) with no output at all, not a catchable error. Correct
+ * enforcement of "at most N NEW processes the sandboxed extension can spawn" requires an offset
+ * from the CURRENT real count, not an absolute cap. Returns 0 (never throws) if /proc can't be
+ * read at all -- the caller's own maxProcesses then applies as an absolute floor, same as before
+ * this existed.
+ */
+function currentProcessCountForUid(uid: number): number {
+	let entries: string[];
+	try {
+		entries = readdirSync("/proc");
+	} catch {
+		return 0;
+	}
+	let count = 0;
+	for (const entry of entries.slice(0, MAX_PROCESS_SCAN_ENTRIES)) {
+		if (!/^\d+$/.test(entry)) continue;
+		try {
+			const status = readFileSync(`/proc/${entry}/status`, "utf8");
+			const match = status.match(/^Uid:\s+(\d+)/m);
+			if (match && Number(match[1]) === uid) count++;
+		} catch {
+			// The process exited mid-scan, or is otherwise unreadable -- not this sandbox's concern.
+		}
+	}
+	return count;
+}
+
 function sandboxCommand(packageRoot: string, extensionPath: string, maxProcesses: number): string[] | undefined {
 	if (process.platform !== "linux" || !existsSync("/usr/bin/bwrap") || !existsSync("/usr/bin/prlimit")) return undefined;
 	const serviceRoot = dirname(dirname(dirname(fileURLToPath(import.meta.url))));
@@ -185,7 +220,7 @@ function sandboxCommand(packageRoot: string, extensionPath: string, maxProcesses
 		packageRoot,
 		"--",
 		"/usr/bin/prlimit",
-		`--nproc=${maxProcesses}`,
+		`--nproc=${(typeof process.getuid === "function" ? currentProcessCountForUid(process.getuid()) : 0) + maxProcesses}`,
 		"--nofile=64",
 		"--fsize=16777216",
 		"--as=8589934592",

package/service/test/smoke.test.ts

@@ -1,8 +1,9 @@
 import { afterEach, describe, expect, it } from "bun:test";
 import { spawnSync } from "node:child_process";
-import { existsSync, mkdirSync, mkdtempSync, realpathSync, rmSync, writeFileSync } from "node:fs";
+import { cpSync, existsSync, mkdirSync, mkdtempSync, realpathSync, rmSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
-import { join } from "node:path";
+import { dirname, join } from "node:path";
+import { createRequire } from "node:module";
 import { checkPackage } from "../src/adoption/check.ts";
 import { resolveDependencyModulesDir, runExtensionSmoke } from "../src/adoption/smoke.ts";
 
@@ -180,6 +181,56 @@ describeIfSandboxed("isolated extension smoke runner", () => {
 		expect(result.registrations.commands).toEqual(["hoisted-sibling"]);
 	});
 
+	it("never routes a plain CJS dependency through jiti's own Babel transform path -- confirmed live: forcing every transitive dependency through Babel (tryNative:false) hit a real, reproducible upstream bug in jiti's own Babel-installed Error.prepareStackTrace hook, triggered by follow-redirects' own module-level Error.captureStackTrace call during its chained error-type prototype setup, surfacing as an opaque 'First argument must be an Error object' crash unrelated to the scanned extension's own code -- reproduces with a cold jiti transform cache regardless of this sandbox specifically, so a real npm package (not a synthetic fixture) is the only faithful way to prove it stays fixed", async () => {
+		const require = createRequire(import.meta.url);
+		const followRedirectsDir = dirname(require.resolve("follow-redirects/package.json"));
+
+		const workspaceRoot = mkdtempSync(join(tmpdir(), "packed-smoke-follow-redirects-"));
+		roots.push(workspaceRoot);
+		const sharedNodeModules = join(workspaceRoot, "node_modules");
+		cpSync(followRedirectsDir, join(sharedNodeModules, "follow-redirects"), { recursive: true });
+		const packageDir = join(sharedNodeModules, "@fixture", "pi-smoke-follow-redirects");
+		mkdirSync(join(packageDir, "extension"), { recursive: true });
+		const extensionPath = join(packageDir, "extension", "index.ts");
+		writeFileSync(
+			extensionPath,
+			'import { http } from "follow-redirects";\nexport default function (pi: any) { pi.registerCommand(String(typeof http), { handler() {} }); }\n',
+		);
+		writeFileSync(
+			join(packageDir, "package.json"),
+			JSON.stringify({
+				name: "@fixture/pi-smoke-follow-redirects",
+				version: "1.0.0",
+				keywords: ["pi-package"],
+				files: ["extension"],
+				pi: { extensions: ["extension/index.ts"] },
+			}),
+		);
+
+		const result = await runExtensionSmoke(packageDir, extensionPath);
+
+		expect(result.status).toBe("ok");
+		expect(result.registrations.commands).toEqual(["object"]);
+	});
+
+	it("never breaks under a real per-UID process count that already exceeds the sandbox's own maxProcesses budget -- confirmed live: prlimit's --nproc is a per-real-UID, system-wide limit, not scoped to this sandbox's own process tree, so a small absolute cap unconditionally breaks the instant the invoking user's REAL total process count exceeds it (routine on a busy multi-session workstation) -- any further thread Bun's own runtime needs internally (its native TS transpiler spawns one) immediately fails, aborting with SIGABRT and zero output, not a catchable error", async () => {
+		const dummyProcessCount = 40;
+		const dummies = Array.from({ length: dummyProcessCount }, () => Bun.spawn(["/usr/bin/sleep", "20"], { stdin: "ignore", stdout: "ignore", stderr: "ignore" }));
+		try {
+			const fixture = extension(`export default function (pi: any) {
+				pi.registerCommand("hello", { handler() {} });
+			}`);
+
+			const result = await runExtensionSmoke(fixture.root, fixture.path, { maxProcesses: 5 });
+
+			expect(result.status).toBe("ok");
+			expect(result.registrations.commands).toEqual(["hello"]);
+		} finally {
+			for (const dummy of dummies) dummy.kill("SIGKILL");
+			await Promise.all(dummies.map((dummy) => dummy.exited));
+		}
+	});
+
 	it("keeps default package checks static and adds smoke results only when requested", async () => {
 		const fixture = extension(
 			'import { writeFileSync } from "node:fs"; export default function (pi: any) { writeFileSync("executed", "yes"); pi.registerCommand("x", { handler() {} }); }',