@danypops/pi-packed 0.28.1 → 0.28.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/pi-packed",
-  "version": "0.28.1",
+  "version": "0.28.2",
   "description": "Pi package lifecycle, validation, daemon, tools, profiles, and TUI",
   "type": "module",
   "bin": {
@@ -42,7 +42,8 @@
     "@danypops/pi-tui-harness": "^0.0.1",
     "@danypops/vehicle-client-pi": "^0.43.1",
     "@danypops/vehicle-conformance": "^0.4.0",
-    "@types/semver": "^7.7.1"
+    "@types/semver": "^7.7.1",
+    "follow-redirects": "^1.16.0"
   },
   "peerDependencies": {
     "@danypops/vehicle-client-pi": "^0.43.1",

package/service/src/adoption/smoke-child.ts

@@ -99,7 +99,16 @@ async function main(): Promise<void> {
 	const extensionPath = process.argv[2];
 	if (!extensionPath) throw new Error("extension path is required");
 	try {
-		const jiti = createJiti(import.meta.url, { interopDefault: true, tryNative: false });
+		// tryNative matches loader.ts's own real, non-Bun-binary Pi extension loading convention:
+		// prefer Bun's native TS/ESM transform, falling back to jiti's own Babel transform only for
+		// what native genuinely can't handle. Confirmed live: tryNative:false forced EVERY
+		// transitive dependency (including plain CJS libraries that never needed a Babel transform,
+		// e.g. follow-redirects) through jiti's Babel path -- which has its own real, reproducible
+		// bug interacting with a library that calls Error.captureStackTrace on a not-yet-initialized
+		// Error instance during module-level prototype setup (confirmed outside this sandbox too,
+		// given a cold jiti transform cache), surfacing as an opaque "First argument must be an
+		// Error object" crash unrelated to the extension's own code.
+		const jiti = createJiti(import.meta.url, { interopDefault: true, tryNative: true });
 		const factory = (await jiti.import(extensionPath, { default: true })) as unknown;
 		if (typeof factory !== "function") throw new Error("extension has no default factory export");
 		await factory(api);

package/service/test/smoke.test.ts

@@ -1,8 +1,9 @@
 import { afterEach, describe, expect, it } from "bun:test";
 import { spawnSync } from "node:child_process";
-import { existsSync, mkdirSync, mkdtempSync, realpathSync, rmSync, writeFileSync } from "node:fs";
+import { cpSync, existsSync, mkdirSync, mkdtempSync, realpathSync, rmSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
-import { join } from "node:path";
+import { dirname, join } from "node:path";
+import { createRequire } from "node:module";
 import { checkPackage } from "../src/adoption/check.ts";
 import { resolveDependencyModulesDir, runExtensionSmoke } from "../src/adoption/smoke.ts";
 
@@ -180,6 +181,38 @@ describeIfSandboxed("isolated extension smoke runner", () => {
 		expect(result.registrations.commands).toEqual(["hoisted-sibling"]);
 	});
 
+	it("never routes a plain CJS dependency through jiti's own Babel transform path -- confirmed live: forcing every transitive dependency through Babel (tryNative:false) hit a real, reproducible upstream bug in jiti's own Babel-installed Error.prepareStackTrace hook, triggered by follow-redirects' own module-level Error.captureStackTrace call during its chained error-type prototype setup, surfacing as an opaque 'First argument must be an Error object' crash unrelated to the scanned extension's own code -- reproduces with a cold jiti transform cache regardless of this sandbox specifically, so a real npm package (not a synthetic fixture) is the only faithful way to prove it stays fixed", async () => {
+		const require = createRequire(import.meta.url);
+		const followRedirectsDir = dirname(require.resolve("follow-redirects/package.json"));
+
+		const workspaceRoot = mkdtempSync(join(tmpdir(), "packed-smoke-follow-redirects-"));
+		roots.push(workspaceRoot);
+		const sharedNodeModules = join(workspaceRoot, "node_modules");
+		cpSync(followRedirectsDir, join(sharedNodeModules, "follow-redirects"), { recursive: true });
+		const packageDir = join(sharedNodeModules, "@fixture", "pi-smoke-follow-redirects");
+		mkdirSync(join(packageDir, "extension"), { recursive: true });
+		const extensionPath = join(packageDir, "extension", "index.ts");
+		writeFileSync(
+			extensionPath,
+			'import { http } from "follow-redirects";\nexport default function (pi: any) { pi.registerCommand(String(typeof http), { handler() {} }); }\n',
+		);
+		writeFileSync(
+			join(packageDir, "package.json"),
+			JSON.stringify({
+				name: "@fixture/pi-smoke-follow-redirects",
+				version: "1.0.0",
+				keywords: ["pi-package"],
+				files: ["extension"],
+				pi: { extensions: ["extension/index.ts"] },
+			}),
+		);
+
+		const result = await runExtensionSmoke(packageDir, extensionPath);
+
+		expect(result.status).toBe("ok");
+		expect(result.registrations.commands).toEqual(["object"]);
+	});
+
 	it("keeps default package checks static and adds smoke results only when requested", async () => {
 		const fixture = extension(
 			'import { writeFileSync } from "node:fs"; export default function (pi: any) { writeFileSync("executed", "yes"); pi.registerCommand("x", { handler() {} }); }',