@danypops/pi-packed 0.27.4 → 0.27.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/pi-packed",
-  "version": "0.27.4",
+  "version": "0.27.6",
   "description": "Pi package lifecycle, validation, daemon, tools, profiles, and TUI",
   "type": "module",
   "bin": {
@@ -31,7 +31,6 @@
     "@danypops/packed": "^0.7.0",
     "@danypops/pi-extension-harness": "^0.7.0",
     "@danypops/vehicle-client": "^0.10.0",
-    "@danypops/vehicle-client-pi": "^0.40.1",
     "@danypops/vehicle-core": "^0.15.0",
     "@danypops/vehicle-server": "^0.24.2",
     "jiti": "^2.7.0",
@@ -41,9 +40,11 @@
   },
   "devDependencies": {
     "@danypops/pi-tui-harness": "^0.0.1",
+    "@danypops/vehicle-client-pi": "^0.41.3",
     "@types/semver": "^7.7.1"
   },
   "peerDependencies": {
+    "@danypops/vehicle-client-pi": "^0.41.3",
     "@earendil-works/pi-coding-agent": "*",
     "@earendil-works/pi-tui": "*",
     "typebox": "*"

package/service/src/adoption/check.ts

@@ -566,8 +566,14 @@ function dependencyCheck(context: Context): void {
 						path: file,
 						message: `${name} must be declared as peerDependencies[${name}] = *`,
 					});
-			} else if (dependencies[name] === undefined && optional[name] === undefined) {
-				const misplaced = dev[name] !== undefined ? "devDependency" : peers[name] !== undefined ? "peerDependency" : undefined;
+			} else if (dependencies[name] === undefined && optional[name] === undefined && peers[name] === undefined) {
+				// A real (non-"*") peerDependency range genuinely satisfies this -- npm's own
+				// documented mechanism for "a real runtime dependency the host is expected to
+				// already share a single instance of," distinct from CORE_PACKAGES' own stricter
+				// peers[name] === "*" contract (Pi's own always-exactly-one-host-version packages,
+				// checked separately above). A devDependency alone still doesn't count -- it
+				// guarantees nothing for a real consumer's own install.
+				const misplaced = dev[name] !== undefined ? "devDependency" : undefined;
 				context.add({
 					code: "RUNTIME_DEPENDENCY_MISSING",
 					severity: "error",

package/service/src/daemon/daemon-service.ts

@@ -455,7 +455,13 @@ export function listManagedPackages(piHome: string, projectRoot?: string): Insta
 }
 
 export interface ReconcileAllResult {
-	reconciled: Array<{ packageName: string; vehicleName: string; installed: boolean; reason?: string }>;
+	/** `versionChanged` is true only when this pass's newly-resolved version genuinely differs
+	 * from what Armada had registered before this sweep started -- `installed: true` alone means
+	 * only "the register call itself succeeded", which is true on every healthy pass whether or
+	 * not anything actually changed underneath (register()/reconcile() is a safe no-op against
+	 * unchanged desired state). A caller wanting to know whether this pass genuinely restarted
+	 * something (vs. just re-confirmed a healthy, unchanged fleet) must check this, not `installed`. */
+	reconciled: Array<{ packageName: string; vehicleName: string; installed: boolean; versionChanged: boolean; reason?: string }>;
 	skipped: number;
 	failed: Array<{ packageName: string; reason: string }>;
 	/** Every Vehicle unregistered because this sweep no longer discovers it at all -- see pruneStaleVehicles. */
@@ -555,6 +561,13 @@ export async function reconcileAllDaemonServices(
 	const failed: ReconcileAllResult["failed"] = [];
 	const seen = new Set<string>();
 	let skipped = 0;
+	// Snapshot BEFORE this sweep's own install() calls mutate Armada's registration -- the only
+	// way to tell "this pass's register() call genuinely changed something" from "register()
+	// succeeded against an already-current registration", since install()'s own ServiceInstallResult
+	// reports only the latter.
+	const previousVersions = new Map<string, string>(
+		(await installer.listRegisteredVehicles()).map((vehicle) => [String(vehicle.name), vehicle.version]),
+	);
 	for (const pkg of packages) {
 		// Re-registering the daemon from inside its own process makes Armada stop
 		// that process before registration can start the replacement.
@@ -577,6 +590,7 @@ export async function reconcileAllDaemonServices(
 			packageName: pkg.name,
 			vehicleName: resolved.spec.name,
 			installed: resolved.result.installed,
+			versionChanged: previousVersions.get(resolved.spec.name) !== resolved.spec.version,
 			...(resolved.result.installed ? {} : { reason: resolved.result.reason }),
 		});
 	}

package/service/src/daemon/daemon.ts

@@ -134,9 +134,10 @@ export function daemonOptions(options: StartPackedDaemonOptions): StartDaemonOpt
 				// success indistinguishable from "this never ran" -- there was no way to confirm a
 				// restart this task performed actually happened, short of checking the process's own
 				// PID by hand.
-				if (result.reconciled.some((entry) => entry.installed) || result.pruned.length > 0) {
+				const changed = result.reconciled.filter((entry) => entry.installed && entry.versionChanged);
+				if (changed.length > 0 || result.pruned.length > 0) {
 					logger.info("vehicle-reconcile applied changes", {
-						reconciled: result.reconciled.filter((entry) => entry.installed).map((entry) => entry.vehicleName),
+						reconciled: changed.map((entry) => entry.vehicleName),
 						pruned: result.pruned.map((entry) => entry.vehicleName),
 					});
 				}

package/service/test/check.test.ts

@@ -441,4 +441,37 @@ describe("dependencyCheck false-positive regressions (packed check)", () => {
 		const report = await checkPackage(root, { generic: false });
 		expect(codes(report.diagnostics)).not.toContain("RUNTIME_DEPENDENCY_MISSING");
 	});
+
+	it("a real (non-*) peerDependency range genuinely satisfies a shipped-code import -- npm's own documented mechanism for a shared-singleton runtime dependency, distinct from CORE_PACKAGES' own peers[name] === '*' contract", async () => {
+		const root = fixture(
+			{
+				...base,
+				files: ["extensions", "README.md", "LICENSE"],
+				peerDependencies: { ...base.peerDependencies, "@scope/shared-singleton": "^1.2.3" },
+				devDependencies: { "@scope/shared-singleton": "^1.2.3" },
+			},
+			{
+				"extensions/index.ts": 'import { thing } from "@scope/shared-singleton";\nexport default function () { return thing; }\n',
+				"README.md": "# Example",
+				LICENSE: "MIT",
+			},
+		);
+		const report = await checkPackage(root, { generic: false });
+		expect(codes(report.diagnostics)).not.toContain("RUNTIME_DEPENDENCY_MISSING");
+	});
+
+	it("still flags a shipped-code import declared only as a devDependency, even though a peerDependency-shaped exception now exists", async () => {
+		const root = fixture(
+			{ ...base, files: ["extensions", "README.md", "LICENSE"], devDependencies: { "leftover-dev-only": "1.0.0" } },
+			{
+				"extensions/index.ts": 'import thing from "leftover-dev-only";\nexport default function () { return thing; }\n',
+				"README.md": "# Example",
+				LICENSE: "MIT",
+			},
+		);
+		const report = await checkPackage(root, { generic: false });
+		expect(codes(report.diagnostics)).toContain("RUNTIME_DEPENDENCY_MISSING");
+		const diagnostic = report.diagnostics.find((d) => d.code === "RUNTIME_DEPENDENCY_MISSING")!;
+		expect(diagnostic.message).toContain("only a devDependency");
+	});
 });

package/service/test/cli.test.ts

@@ -120,7 +120,7 @@ class FakeDaemonServiceInstaller {
 		return {
 			ok: true,
 			output: "reconciled 1 Vehicle(s), skipped 0 non-daemon package(s)",
-			reconciled: [{ packageName: "@danypops/probe", vehicleName: "probe", installed: true }],
+			reconciled: [{ packageName: "@danypops/probe", vehicleName: "probe", installed: true, versionChanged: true }],
 			skipped: 0,
 			failed: [],
 			pruned: [],
@@ -604,7 +604,7 @@ describe("CLI", () => {
 		expect(JSON.parse(json.out)).toEqual({
 			ok: true,
 			output: "reconciled 1 Vehicle(s), skipped 0 non-daemon package(s)",
-			reconciled: [{ packageName: "@danypops/probe", vehicleName: "probe", installed: true }],
+			reconciled: [{ packageName: "@danypops/probe", vehicleName: "probe", installed: true, versionChanged: true }],
 			skipped: 0,
 			failed: [],
 			pruned: [],

package/service/test/daemon-maintenance.test.ts

@@ -343,6 +343,46 @@ describe("startPackedDaemon's own maintenance-task wiring (self-heals Vehicle dr
 		});
 	});
 
+	/**
+	 * Real gap this closes: install()'s own ServiceInstallResult reports `installed: true`
+	 * whenever register()/reconcile() SUCCEEDS -- which is true on every healthy pass whether or
+	 * not anything actually changed underneath (register() is a safe no-op against unchanged
+	 * desired state). A caller logging "applied changes" off `installed` alone would say so on
+	 * literally every tick of a healthy, unchanged fleet -- see pkg-update-never-restarts-
+	 * vehicle-daemon. versionChanged is the honest signal instead.
+	 */
+	describe("reconcileAllDaemonServices reports versionChanged honestly, not just installed", () => {
+		it("is true on a package's first-ever registration, false on an unchanged re-sweep, true again once its on-disk version actually moves", async () => {
+			const piHome = fakePiHome(["npm:@danypops/probe"]);
+			installMockDaemon(piHome, "@danypops/probe");
+			const harness = await createArmadaTestHarness();
+			try {
+				const installer = new RealDaemonServiceInstaller(harness.registrar);
+
+				const first = await reconcileAllDaemonServices(piHome, undefined, installer);
+				expect(first.reconciled).toEqual([
+					{ packageName: "@danypops/probe", vehicleName: "probe", installed: true, versionChanged: true },
+				]);
+
+				const second = await reconcileAllDaemonServices(piHome, undefined, installer);
+				expect(second.reconciled).toEqual([
+					{ packageName: "@danypops/probe", vehicleName: "probe", installed: true, versionChanged: false },
+				]);
+
+				writeFileSync(
+					join(piHome, "npm", "node_modules", "@danypops", "probe", "package.json"),
+					JSON.stringify({ name: "@danypops/probe", version: "1.1.0", packed: { daemonService: { binPath: "cli.ts", args: ["serve"] } } }),
+				);
+				const third = await reconcileAllDaemonServices(piHome, undefined, installer);
+				expect(third.reconciled).toEqual([
+					{ packageName: "@danypops/probe", vehicleName: "probe", installed: true, versionChanged: true },
+				]);
+			} finally {
+				await harness.dispose();
+			}
+		});
+	});
+
 	describe("reconcileAllDaemonServices pruning (the-armada-registrar-jittor-web-spider-daemon-collision)", () => {
 		function stalePiHomeVehicle(piHome: string, name: string): VehicleSpec {
 			return {