@danypops/pi-packed 0.27.13 → 0.27.14

package/extension/src/doctor-render.ts

@@ -1,14 +1,30 @@
 /**
- * doctor.run's own curated presenter -- its DoctorReport output shape (five array fields, several
- * with nested arrays/objects per row: duplicateDependencies' own locations array, extensions'
- * own registrations object) defeats every heuristic in vehicle-render's generic shape-probing
- * chain, so without this it fell all the way through to a raw JSON.stringify dump -- a real, live
- * incident, not a hypothetical. Reuses formatDoctorReport, the exact same human-readable text the
- * CLI's own `packed doctor` (non-JSON) path already renders, so the tool and the CLI never drift
- * into two different descriptions of the same report.
+ * doctor.run's own curated renderResult -- its DoctorReport output shape (five array fields,
+ * several with nested arrays/objects per row: duplicateDependencies' own locations array,
+ * extensions' own registrations object) defeats every heuristic in vehicle-render's generic
+ * shape-probing chain, so without this it fell all the way through to a raw JSON.stringify dump
+ * -- a real, live incident, not a hypothetical.
+ *
+ * A FULL renderResult override via registerVehicleTools' `renderers` option, deliberately NOT
+ * `renderPresenters`: without any presentations/renderers override at all, EVERY real doctor.run
+ * invocation gets a generic vehicle.tool-details/v1 "json"-view presentation projected and
+ * PERSISTED at invocation time (createTool's own default presentationProjector), and that
+ * projected presentation always wins ahead of a renderPresenters entry -- renderPresenters only
+ * ever customizes the output-to-Component step for the non-projected branch, never overriding an
+ * already-successful projection (see vehicle-render/result-rendering.ts's own renderVehicleResult:
+ * `if (projected) return renderProjectedPresentation(...)` runs before presenters are ever
+ * consulted). A real, live incident: wiring this as renderPresenters first left the raw JSON view
+ * rendering completely unchanged after release. `renderers.renderResult` sets
+ * presentationProjector to undefined for this one operation (see tool-creation.ts's own
+ * presentationProjector selection), so this function is now responsible for the operation's every
+ * result shape -- it delegates to the shared generic renderer (renderVehicleResult) for anything
+ * that isn't a real, complete DoctorReport (a partial/error state, a historical session row, or a
+ * future field addition), rather than re-implementing that handling here.
  */
 import { type DoctorReport, formatDoctorReport } from "@danypops/pi-packed/doctor-format";
-import type { VehiclePresenter } from "@danypops/vehicle-client-pi/vehicle-render";
+import { renderVehicleResult } from "@danypops/vehicle-client-pi/vehicle-render";
+import type { VehicleOperationDescriptor } from "@danypops/vehicle-core";
+import type { ToolDefinition } from "@earendil-works/pi-coding-agent";
 import { asciiTextMeasure, CollapsibleText } from "malevich-tui-components";
 
 const DOCTOR_REPORT_COLLAPSED_LINES = 12;
@@ -19,14 +35,22 @@ function isDoctorReport(value: unknown): value is DoctorReport {
 	return typeof candidate.ok === "boolean" && Array.isArray(candidate.conflicts) && Array.isArray(candidate.extensions);
 }
 
-export const renderDoctorRunResult: VehiclePresenter = (output, options, theme) => {
-	if (!isDoctorReport(output)) return undefined;
-	const collapsible = new CollapsibleText({
-		text: theme.fg("text", formatDoctorReport(output, false)),
-		collapsedLines: DOCTOR_REPORT_COLLAPSED_LINES,
-		headerStyle: (s) => theme.fg("dim", s),
-		measure: asciiTextMeasure,
-	});
-	if (options.expanded) collapsible.expand();
-	return collapsible;
-};
+export function createDoctorRunRenderResult(descriptor: VehicleOperationDescriptor): NonNullable<ToolDefinition["renderResult"]> {
+	return (result, options, theme, context) => {
+		if (!context.isError && !options.isPartial) {
+			const details = result.details as { output?: unknown } | undefined;
+			const output = details && Object.hasOwn(details, "output") ? details.output : undefined;
+			if (isDoctorReport(output)) {
+				const collapsible = new CollapsibleText({
+					text: theme.fg("text", formatDoctorReport(output, false)),
+					collapsedLines: DOCTOR_REPORT_COLLAPSED_LINES,
+					headerStyle: (s) => theme.fg("dim", s),
+					measure: asciiTextMeasure,
+				});
+				if (options.expanded) collapsible.expand();
+				return collapsible;
+			}
+		}
+		return renderVehicleResult(descriptor, result, options, theme, context);
+	};
+}

package/extension/src/vehicle-tools.ts

@@ -35,7 +35,7 @@ import { RemoteVehicleClient } from "@danypops/vehicle-client/http";
 import { registerVehicleTools } from "@danypops/vehicle-client-pi";
 import type { VehicleClient, VehicleManifest } from "@danypops/vehicle-core";
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
-import { renderDoctorRunResult } from "./doctor-render.js";
+import { createDoctorRunRenderResult } from "./doctor-render.js";
 import { currentVehicleClientTarget } from "./vehicle-target.js";
 
 /** Already covered by their own dedicated, approval-aware tools in tools.ts -- see this file's own doc comment. */
@@ -98,7 +98,7 @@ export async function registerPackedVehicle(pi: ExtensionAPI): Promise<void> {
 			// ensureVehicleShellHandle) -- no ownVehicleName/broker option needed here anymore; every
 			// vehicle in the process (including packed's own) is discovered and namespaced uniformly.
 			shell: { coreOperations: CORE_OPERATIONS },
-			renderPresenters: { "doctor.run": renderDoctorRunResult },
+			renderers: (descriptor) => (descriptor.name === "doctor.run" ? { renderResult: createDoctorRunRenderResult(descriptor) } : undefined),
 			renderCoverage: { operations: REVIEWED_OPERATIONS },
 		});
 	} catch {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/pi-packed",
-  "version": "0.27.13",
+  "version": "0.27.14",
   "description": "Pi package lifecycle, validation, daemon, tools, profiles, and TUI",
   "type": "module",
   "bin": {