@danypops/pi-packed 0.21.14 → 0.21.15

package/extension/src/approval/reload.ts

@@ -7,9 +7,52 @@
  */
 import type { PackageOperation } from "./permission.js";
 
+/**
+ * Packed's own npm package name -- the one target where install/update/
+ * remove has a real, confirmed hazard plain /reload cannot fix: this
+ * extension's own already-loaded code (e.g. vehicle-target.ts importing
+ * @danypops/pi-packed/client) keeps a stale reference to the pre-mutation
+ * module even after /reload re-evaluates the extension's own source files.
+ * Confirmed live: updating pi-packed mid-session, then /reload, threw
+ * "resolveVehicleClientTarget is not a function" -- a brand-new process
+ * importing the exact same on-disk files resolved it fine. Node/Bun cache
+ * an ES module by resolved file path for the life of the process; an
+ * in-place npm overwrite never invalidates an already-loaded entry, and
+ * /reload only re-executes the extension's own entry file, not every
+ * transitively-cached dependency. Only a full process restart re-imports
+ * everything fresh.
+ */
+export const PACKED_NPM_PACKAGE_NAME = "@danypops/pi-packed";
+
+/**
+ * True when a pkg_install/pkg_update source (npm:@danypops/pi-packed,
+ * npm:@danypops/pi-packed@1.2.3, git:/https: sources never match) or a
+ * pkg_remove bare name refers to Packed's own npm package. Deliberately
+ * narrow -- this is the one case Packed can be CERTAIN has the stale-
+ * module-cache hazard above, since it's the package whose own code is
+ * running the mutation. Any other package's extension could in principle
+ * have the same self-import pattern, but Packed has no way to know that
+ * about third-party code, so it never guesses there.
+ */
+export function targetsPackedItself(sourceOrName: string): boolean {
+	const withoutScheme = sourceOrName.startsWith("npm:") ? sourceOrName.slice(4) : sourceOrName;
+	const bare = withoutScheme.startsWith("@") ? withoutScheme.split("@").slice(0, 2).join("@") : withoutScheme.split("@")[0];
+	return bare === PACKED_NPM_PACKAGE_NAME;
+}
+
+export interface ReloadWarningOptions {
+	/** True when the target is Packed's own package -- see targetsPackedItself(). */
+	restartRequired?: boolean;
+}
+
 /** Inline warning appended to a mutation's pre-confirmation dialog, before
  * the operation runs -- the moment the user is actually deciding. */
-export function reloadWarning(operation: PackageOperation): string {
+export function reloadWarning(operation: PackageOperation, options: ReloadWarningOptions = {}): string {
+	if (options.restartRequired) {
+		return operation === "remove"
+			? "Packed's own code is already running inside this Pi process -- deactivating it needs a full restart (exit and relaunch Pi), not just /reload."
+			: "Packed's own code is already running inside this Pi process -- its updated code can only be picked up by a full restart (exit and relaunch Pi), not just /reload.";
+	}
 	return operation === "remove"
 		? "This will require a Pi reload (/reload) to deactivate it."
 		: "This will likely require a Pi reload (/reload) to activate its resources.";
@@ -35,7 +78,13 @@ export interface ReloadConfirmContext {
  * shares identical wording and behavior instead of drifting apart --
  * reload.ts's whole reason for existing.
  */
-export async function confirmReload(ctx: ReloadConfirmContext): Promise<boolean> {
+export async function confirmReload(ctx: ReloadConfirmContext, options: ReloadWarningOptions = {}): Promise<boolean> {
 	if (!ctx.hasUI) return true;
+	if (options.restartRequired) {
+		return ctx.ui.confirm(
+			"Restart Pi now?",
+			"Packed's own code changed and cannot be hot-reloaded from inside itself -- exit and relaunch Pi to pick it up. /reload alone will not work.",
+		);
+	}
 	return ctx.ui.confirm("Reload Pi now?", "This change only takes effect after a reload.");
 }

package/extension/src/tabs/discover.ts

@@ -13,6 +13,7 @@ import type { ExtensionCommandContext, Theme } from "@earendil-works/pi-coding-a
 import { rawKeyHint } from "@earendil-works/pi-coding-agent";
 import { Input, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import { Card, type Component } from "malevich-tui-components";
+import { targetsPackedItself } from "../approval/reload.js";
 import { cardTheme } from "../menu-theme.js";
 import { formatDownloadCount, formatRelativeDate } from "../model.js";
 import type { Natives, PackageSummary } from "../packed.js";
@@ -32,7 +33,8 @@ export type InstallOutcome = "installed" | "cancelled" | "failed";
  * path (installPackageWithPolicy) -- most packages aren't daemons at all. */
 export async function applyInstall(result: PackageSummary, natives: Natives, ctx: ExtensionCommandContext): Promise<InstallOutcome> {
 	const source = `npm:${result.name}`;
-	const approval = await approvePackageOperation("install", `pi install ${source}`, natives, ctx);
+	const restartRequired = targetsPackedItself(result.name);
+	const approval = await approvePackageOperation("install", `pi install ${source}`, natives, ctx, restartRequired);
 	if (!approval.allowed) {
 		ctx.ui.notify(approval.message ?? "install denied", "warning");
 		return "cancelled";
@@ -46,7 +48,16 @@ export async function applyInstall(result: PackageSummary, natives: Natives, ctx
 				ctx.ui.notify(`note: could not register a persistent service for ${result.name}: ${e instanceof Error ? e.message : e}`, "warning");
 			}
 		}
-		ctx.ui.notify(`${output}; reloading Pi resources.`, "info");
+		// ctx.reload() re-evaluates this extension's own entry file, same as /reload -- harmless to
+		// call either way, but it cannot bust an already-loaded copy of Packed's own client module,
+		// so a self-install/update needs the stronger, honest wording instead of implying reload alone
+		// finished the job (see approval/reload.ts's targetsPackedItself()).
+		ctx.ui.notify(
+			restartRequired
+				? `${output}; restart Pi (exit and relaunch) to activate -- /reload alone will not pick up Packed's own updated code.`
+				: `${output}; reloading Pi resources.`,
+			"info",
+		);
 		await ctx.reload();
 		return "installed";
 	} catch (e) {

package/extension/src/tool-output.ts

@@ -1,6 +1,7 @@
 import type { PackageSummary as Pkg, PackageInfo as PkgInfo } from "@danypops/pi-packed/protocol";
 import type { AgentToolResult, Theme } from "@earendil-works/pi-coding-agent";
 import { Text, truncateToWidth } from "@earendil-works/pi-tui";
+import { targetsPackedItself } from "./approval/reload.js";
 import {
 	TOOL_COLLAPSED_PACKAGE_PREVIEW,
 	TOOL_DETAILS_MAX_CAPABILITIES,
@@ -59,6 +60,11 @@ export interface MutationToolDetails {
 	status: "succeeded" | "cancelled" | "denied";
 	output: string;
 	reloadRequired: boolean;
+	/** Optional (not version-gated) -- see approval/reload.ts's targetsPackedItself().
+	 * Absent on details serialized before this field existed; the renderer treats
+	 * absent the same as false, so an older persisted tool result still renders
+	 * exactly as it always did. */
+	restartRequired?: boolean;
 }
 
 export type PackageToolDetails = SearchToolDetails | InfoToolDetails | MutationToolDetails;
@@ -181,6 +187,10 @@ export function createMutationDetails(
 		status,
 		output: safeDisplayText(output, TOOL_DETAILS_MAX_OUTPUT_CHARACTERS),
 		reloadRequired,
+		// Derived from the raw (pre-sanitized) target -- targetsPackedItself only ever matches a
+		// plain npm name/source, never affected by safePackageTarget's URL-credential redaction.
+		// Only meaningful when a reload/restart is actually pending at all.
+		...(status === "succeeded" && targetsPackedItself(target) ? { restartRequired: true } : {}),
 	};
 }
 
@@ -235,6 +245,7 @@ export function parsePackageToolDetails(value: unknown): PackageToolDetails | un
 			if (typeof candidate.status !== "string" || !MUTATION_STATUSES.has(candidate.status)) return undefined;
 			if (!isShortString(candidate.target) || !isShortString(candidate.output) || typeof candidate.reloadRequired !== "boolean")
 				return undefined;
+			if (candidate.restartRequired !== undefined && typeof candidate.restartRequired !== "boolean") return undefined;
 			return value as MutationToolDetails;
 		}
 	} catch {
@@ -312,7 +323,9 @@ export function renderPackageToolResult(
 			const statusColor = details.status === "succeeded" ? "success" : "warning";
 			const lines = [`${theme.fg(statusColor, details.status === "succeeded" ? "✓" : "○")} ${details.operation} ${details.target}`];
 			if (options.expanded && details.output) lines.push(details.output);
-			if (details.reloadRequired) lines.push(theme.fg("warning", "Reload Pi with /reload to activate the update."));
+			if (details.restartRequired)
+				lines.push(theme.fg("warning", "Restart Pi (exit and relaunch) to activate -- Packed's own running code can't hot-reload itself."));
+			else if (details.reloadRequired) lines.push(theme.fg("warning", "Reload Pi with /reload to activate the update."));
 			return lines.map((line) => truncateToWidth(line, safeWidth));
 		},
 		invalidate() {},

package/extension/src/tools.ts

@@ -2,7 +2,7 @@
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
 import { Type } from "typebox";
 import { type PackageOperation, packagePermissionDecision } from "./approval/permission.js";
-import { reloadWarning } from "./approval/reload.js";
+import { reloadWarning, targetsPackedItself } from "./approval/reload.js";
 import { InstallServiceError, type Natives, PI_COMMAND_NAME } from "./packed.js";
 import {
 	createInfoDetails,
@@ -28,6 +28,10 @@ export async function approvePackageOperation(
 	command: string,
 	natives: Pick<Natives, "security">,
 	ctx: ApprovalContext,
+	// True only for a source/name that resolves to Packed's own npm package -- see
+	// targetsPackedItself(). Every caller below computes this from the exact string it's
+	// about to mutate, so the warning always reflects the real target.
+	restartRequired = false,
 ): Promise<{ allowed: boolean; approved: boolean; reason?: "cancelled" | "denied"; message?: string }> {
 	const settings = await natives.security();
 	const decision = packagePermissionDecision(settings, operation);
@@ -42,7 +46,7 @@ export async function approvePackageOperation(
 	}
 	const approved = await ctx.ui.confirm(
 		`${operation[0]!.toUpperCase()}${operation.slice(1)} Pi package`,
-		`Run: ${command}\n\nThis operation can execute package code or mutate Pi settings/install roots. ${reloadWarning(operation)} Continue?`,
+		`Run: ${command}\n\nThis operation can execute package code or mutate Pi settings/install roots. ${reloadWarning(operation, { restartRequired })} Continue?`,
 	);
 	return approved
 		? { allowed: true, approved: true }
@@ -54,12 +58,16 @@ export async function installPackageWithPolicy(
 	natives: Pick<Natives, "security" | "install" | "installService">,
 	ctx: ApprovalContext,
 ) {
-	const approval = await approvePackageOperation("install", `pi install ${source}`, natives, ctx);
+	const restartRequired = targetsPackedItself(source);
+	const approval = await approvePackageOperation("install", `pi install ${source}`, natives, ctx, restartRequired);
 	if (!approval.allowed) {
 		const output = approval.message ?? "install denied";
 		return text(output, createMutationDetails("install", source, approval.reason ?? "denied", output));
 	}
-	let output = (await natives.install(source, approval.approved)) || `Installed ${source}. Reload with /reload to activate.`;
+	const activateNote = restartRequired
+		? "Restart Pi (exit and relaunch) to activate -- Packed's own running code can't hot-reload itself."
+		: "Reload with /reload to activate.";
+	let output = (await natives.install(source, approval.approved)) || `Installed ${source}. ${activateNote}`;
 	// Piggybacks on the same approval already granted for install -- both are
 	// the same code-execution mutation tier, not a new consent surface. Silent
 	// for the overwhelmingly common case (most Pi packages aren't daemons at
@@ -80,7 +88,8 @@ export async function installPackageWithPolicy(
 }
 
 export async function updatePackageWithPolicy(source: string, natives: Pick<Natives, "security" | "update">, ctx: ApprovalContext) {
-	const approval = await approvePackageOperation("update", `pi update --extension ${source}`, natives, ctx);
+	const restartRequired = targetsPackedItself(source);
+	const approval = await approvePackageOperation("update", `pi update --extension ${source}`, natives, ctx, restartRequired);
 	if (!approval.allowed) {
 		const output = approval.message ?? "update denied";
 		return text(output, createMutationDetails("update", source, approval.reason ?? "denied", output));
@@ -95,17 +104,24 @@ export async function updatePackageWithPolicy(source: string, natives: Pick<Nati
 		return text(message, createMutationDetails("update", source, "succeeded", outcome.output || message, false));
 	}
 	const transition = outcome.previousVersion && outcome.currentVersion ? ` (${outcome.previousVersion} → ${outcome.currentVersion})` : "";
-	const message = `${outcome.output || `Updated ${source}.`}${transition} Reload with /reload to activate.`;
+	const activateNote = restartRequired
+		? "Restart Pi (exit and relaunch) to activate -- Packed's own running code can't hot-reload itself."
+		: "Reload with /reload to activate.";
+	const message = `${outcome.output || `Updated ${source}.`}${transition} ${activateNote}`;
 	return text(message, createMutationDetails("update", source, "succeeded", outcome.output || message, true));
 }
 
 export async function removePackageWithPolicy(name: string, natives: Pick<Natives, "security" | "remove">, ctx: ApprovalContext) {
-	const approval = await approvePackageOperation("remove", `pi remove npm:${name}`, natives, ctx);
+	const restartRequired = targetsPackedItself(name);
+	const approval = await approvePackageOperation("remove", `pi remove npm:${name}`, natives, ctx, restartRequired);
 	if (!approval.allowed) {
 		const output = approval.message ?? "remove denied";
 		return text(output, createMutationDetails("remove", name, approval.reason ?? "denied", output));
 	}
-	const output = (await natives.remove(name, approval.approved)) || `Removed ${name}. Reload with /reload to deactivate.`;
+	const deactivateNote = restartRequired
+		? "Restart Pi (exit and relaunch) to deactivate -- Packed's own running code can't hot-reload itself."
+		: "Reload with /reload to deactivate.";
+	const output = (await natives.remove(name, approval.approved)) || `Removed ${name}. ${deactivateNote}`;
 	return text(output, createMutationDetails("remove", name, "succeeded", output));
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/pi-packed",
-  "version": "0.21.14",
+  "version": "0.21.15",
   "description": "Pi package lifecycle, validation, daemon, tools, profiles, and TUI",
   "type": "module",
   "bin": {