@danypops/pi-packed 0.21.12 → 0.21.14

package/service/test/cli.test.ts

@@ -1,6 +1,6 @@
-import { afterAll, beforeAll, describe, expect, it } from "bun:test";
+import { afterAll, afterEach, beforeAll, describe, expect, it } from "bun:test";
 import { spawnSync } from "node:child_process";
-import { existsSync, mkdirSync, mkdtempSync, readFileSync, writeFileSync } from "node:fs";
+import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join, resolve } from "node:path";
 import { writeDaemonHandle } from "@danypops/vehicle-server/paths";
@@ -125,6 +125,16 @@ class FakeDaemonServiceInstaller {
 	}
 }
 
+const roots: string[] = [];
+afterEach(() => {
+	for (const root of roots.splice(0)) rmSync(root, { recursive: true, force: true });
+});
+
+function track(dir: string): string {
+	roots.push(dir);
+	return dir;
+}
+
 function deps(over: Partial<CliDeps> = {}): CliDeps {
 	return {
 		reg: new FakeRegistry(),
@@ -138,8 +148,8 @@ function deps(over: Partial<CliDeps> = {}): CliDeps {
 				return { mutationApproval };
 			},
 		},
-		stateDir: mkdtempSync(join(tmpdir(), "packed-")),
-		piHome: mkdtempSync(join(tmpdir(), "packed-pihome-")),
+		stateDir: track(mkdtempSync(join(tmpdir(), "packed-"))),
+		piHome: track(mkdtempSync(join(tmpdir(), "packed-pihome-"))),
 		...over,
 	};
 }
@@ -389,7 +399,7 @@ describe("CLI", () => {
 	it("updates --project also checks a project's own .pi/settings.json pins -- global-only misses them entirely", async () => {
 		const d = deps();
 		writeFileSync(join(d.piHome, "settings.json"), JSON.stringify({ packages: ["npm:pi-global@1.0.0"] }));
-		const projectRoot = mkdtempSync(join(tmpdir(), "packed-project-"));
+		const projectRoot = track(mkdtempSync(join(tmpdir(), "packed-project-")));
 		const projectHome = join(projectRoot, ".pi");
 		mkdirSync(projectHome, { recursive: true });
 		writeFileSync(join(projectHome, "settings.json"), JSON.stringify({ packages: ["npm:papyrus@0.21.2"] }));
@@ -938,7 +948,7 @@ describe("CLI", () => {
 	});
 
 	it("advisories runs standalone without a daemon and degrades to zero findings, never a real network call, when nothing is installed", async () => {
-		const d = deps({ piHome: mkdtempSync(join(tmpdir(), "packed-advisories-cli-")) });
+		const d = deps({ piHome: track(mkdtempSync(join(tmpdir(), "packed-advisories-cli-"))) });
 		const result = await cliRun(["advisories", "--json"], d);
 		expect(result.code).toBe(0);
 		expect(JSON.parse(result.out)).toEqual({ scanned: 0, findings: [], diagnostics: [], truncated: false });
@@ -956,7 +966,7 @@ describe("CLI", () => {
 	});
 
 	it("resources list and toggle run standalone without a daemon (CLI parity for the daemon-only resources.list/toggle operations)", async () => {
-		const piHome = mkdtempSync(join(tmpdir(), "packed-resources-cli-"));
+		const piHome = track(mkdtempSync(join(tmpdir(), "packed-resources-cli-")));
 		writeFileSync(join(piHome, "settings.json"), JSON.stringify({ packages: ["npm:pi-demo"] }));
 		const pkgDir = join(piHome, "npm", "node_modules", "pi-demo");
 		mkdirSync(pkgDir, { recursive: true });
@@ -998,7 +1008,7 @@ describe("CLI", () => {
 	(bwrapUsable ? it : it.skip)(
 		"doctor runs standalone without a daemon and reproduces the jittor incident through the real CLI (CLI parity for the daemon-only doctor.run operation)",
 		async () => {
-			const piHome = mkdtempSync(join(tmpdir(), "packed-doctor-cli-"));
+			const piHome = track(mkdtempSync(join(tmpdir(), "packed-doctor-cli-")));
 			writeFileSync(join(piHome, "settings.json"), JSON.stringify({ packages: ["npm:pi-papyrus"] }));
 			const globalPkg = join(piHome, "npm", "node_modules", "pi-papyrus");
 			mkdirSync(join(globalPkg, "extension"), { recursive: true });
@@ -1007,7 +1017,7 @@ describe("CLI", () => {
 				JSON.stringify({ name: "pi-papyrus", version: "1.0.0", pi: { extensions: ["extension/index.ts"] } }),
 			);
 			writeFileSync(join(globalPkg, "extension", "index.ts"), 'export default function (pi: any) { pi.registerTool({ name: "tasks" }); }');
-			const projectRoot = mkdtempSync(join(tmpdir(), "packed-doctor-cli-project-"));
+			const projectRoot = track(mkdtempSync(join(tmpdir(), "packed-doctor-cli-project-")));
 			const projectHome = join(projectRoot, ".pi");
 			mkdirSync(projectHome, { recursive: true });
 			writeFileSync(join(projectHome, "settings.json"), JSON.stringify({ packages: ["npm:papyrus"] }));
@@ -1063,12 +1073,14 @@ describe("CLI", () => {
 describe("daemon client", () => {
 	let server: Server<undefined>;
 	let daemonDir: string;
+	let daemonPiHome: string;
 	let daemonPaths: PackedPaths;
 	let daemonInstaller: FakeInstaller;
 	const daemonToken = "d".repeat(64);
 
 	beforeAll(async () => {
 		daemonDir = mkdtempSync(join(tmpdir(), "packed-daemon-"));
+		daemonPiHome = mkdtempSync(join(tmpdir(), "packed-daemon-pi-"));
 		daemonPaths = resolvePackedPaths({ env: { PI_PACKED_HOME: daemonDir } });
 		writeFileSync(daemonPaths.token, `${daemonToken}\n`);
 		daemonInstaller = new FakeInstaller();
@@ -1100,7 +1112,7 @@ describe("daemon client", () => {
 			},
 			token: daemonToken,
 			stateDir: daemonDir,
-			piHome: mkdtempSync(join(tmpdir(), "packed-daemon-pi-")),
+			piHome: daemonPiHome,
 			packer: {
 				async verify(path) {
 					return {
@@ -1169,7 +1181,11 @@ describe("daemon client", () => {
 		server = Bun.serve({ port: 0, hostname: "127.0.0.1", fetch: (req) => app.fetch(req) });
 		writeDaemonHandle(daemonPaths.handle, { host: "127.0.0.1", port: server.port!, pid: process.pid });
 	});
-	afterAll(() => server.stop(true));
+	afterAll(() => {
+		server.stop(true);
+		rmSync(daemonDir, { recursive: true, force: true });
+		rmSync(daemonPiHome, { recursive: true, force: true });
+	});
 
 	it("probe finds a live daemon", async () => {
 		const found = await probe(daemonPaths);
@@ -1188,7 +1204,7 @@ describe("daemon client", () => {
 	});
 
 	it("probe rejects dead state", async () => {
-		const directory = mkdtempSync(join(tmpdir(), "packed-"));
+		const directory = track(mkdtempSync(join(tmpdir(), "packed-")));
 		expect(await probe(resolvePackedPaths({ env: { PI_PACKED_HOME: directory } }))).toBeUndefined();
 	});
 
@@ -1260,7 +1276,7 @@ describe("daemon client", () => {
 	it("resolveRegistry prefers daemon, falls back direct", async () => {
 		const viaDaemon = await resolveRegistry(daemonPaths, "https://registry.npmjs.org");
 		expect(viaDaemon).toBeInstanceOf(DaemonRegistry);
-		const directory = mkdtempSync(join(tmpdir(), "packed-"));
+		const directory = track(mkdtempSync(join(tmpdir(), "packed-")));
 		const direct = await resolveRegistry(resolvePackedPaths({ env: { PI_PACKED_HOME: directory } }), "https://registry.npmjs.org");
 		expect(direct).toBeInstanceOf(HttpRegistry);
 	});

package/service/test/db.test.ts

@@ -1,5 +1,5 @@
-import { describe, expect, it } from "bun:test";
-import { existsSync, mkdtempSync } from "node:fs";
+import { afterEach, describe, expect, it } from "bun:test";
+import { existsSync, mkdtempSync, rmSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { syncCatalog } from "../src/packages/catalog.ts";
@@ -127,9 +127,15 @@ class PagedRegistry implements Registry {
 	}
 }
 
+const roots: string[] = [];
+afterEach(() => {
+	for (const root of roots.splice(0)) rmSync(root, { recursive: true, force: true });
+});
+
 describe("syncCatalog → SQLite", () => {
 	it("accumulates pages into the DB and records sync meta", async () => {
 		const dir = mkdtempSync(join(tmpdir(), "packed-"));
+		roots.push(dir);
 		const reg = new PagedRegistry({ 0: PKGS.slice(0, 2), 2: PKGS.slice(2) }, 3);
 		expect(await syncCatalog(reg, dir)).toBe(3);
 		expect(existsSync(dbPath(dir))).toBe(true);

package/service/test/doctor.test.ts

@@ -13,6 +13,11 @@ afterEach(() => {
 	for (const root of roots.splice(0)) rmSync(root, { recursive: true, force: true });
 });
 
+function track(dir: string): string {
+	roots.push(dir);
+	return dir;
+}
+
 // Same sandbox-availability probe as smoke.test.ts: binary presence alone
 // doesn't prove bwrap actually works under this host's user namespaces.
 function bwrapUsable(): boolean {
@@ -216,8 +221,8 @@ describeIfSandboxed("doctor.run (daemon RPC wiring)", () => {
 			reg: new NoopRegistry(),
 			inst: new NoopInstaller(),
 			token: "test-token",
-			stateDir: mkdtempSync(join(tmpdir(), "packed-doctor-state-")),
-			dataDir: mkdtempSync(join(tmpdir(), "packed-doctor-data-")),
+			stateDir: track(mkdtempSync(join(tmpdir(), "packed-doctor-state-"))),
+			dataDir: track(mkdtempSync(join(tmpdir(), "packed-doctor-data-"))),
 			piHome: home,
 		});
 		const client = new AuthenticatedRpcClient<OperationName, OperationInputs, OperationOutputs>("http://packed.test", "test-token", {

package/service/test/domain.test.ts

@@ -1,5 +1,5 @@
-import { describe, expect, it } from "bun:test";
-import { mkdirSync, mkdtempSync, writeFileSync } from "node:fs";
+import { afterEach, describe, expect, it } from "bun:test";
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { AuthenticatedRpcClient } from "@danypops/vehicle-client/rpc-client";
@@ -17,8 +17,18 @@ import {
 } from "../src/packages/installed.ts";
 import type { Installer, PkgInfo, Registry, SearchPage, UpdateOutcome, UpdatesSnapshot } from "../src/packages/package.ts";
 
+const roots: string[] = [];
+afterEach(() => {
+	for (const root of roots.splice(0)) rmSync(root, { recursive: true, force: true });
+});
+
+function track(dir: string): string {
+	roots.push(dir);
+	return dir;
+}
+
 function writePiHome(settings: unknown, nodeModules: Record<string, string> = {}): string {
-	const dir = mkdtempSync(join(tmpdir(), "packed-pihome-"));
+	const dir = track(mkdtempSync(join(tmpdir(), "packed-pihome-")));
 	writeFileSync(join(dir, "settings.json"), JSON.stringify(settings));
 	for (const [name, version] of Object.entries(nodeModules)) {
 		const pkgDir = join(dir, "npm", "node_modules", name);
@@ -99,7 +109,7 @@ describe("readInstalledPackages", () => {
 	});
 
 	it("missing settings → empty", () => {
-		expect(readInstalledPackages(mkdtempSync(join(tmpdir(), "packed-")))).toEqual([]);
+		expect(readInstalledPackages(track(mkdtempSync(join(tmpdir(), "packed-"))))).toEqual([]);
 	});
 });
 
@@ -113,7 +123,7 @@ describe("readInstalledPackagesAcrossScopes", () => {
 
 	it("reproduces the real jittor gap: a stale project-scoped pin is invisible to a global-only read, visible once project scope is included", () => {
 		const home = writePiHome({ packages: ["npm:pi-global@1.0.0"] });
-		const projectRoot = mkdtempSync(join(tmpdir(), "packed-project-"));
+		const projectRoot = track(mkdtempSync(join(tmpdir(), "packed-project-")));
 		const projectHome = join(projectRoot, ".pi");
 		mkdirSync(projectHome, { recursive: true });
 		writeFileSync(join(projectHome, "settings.json"), JSON.stringify({ packages: ["npm:papyrus@0.21.2"] }));
@@ -128,7 +138,7 @@ describe("readInstalledPackagesAcrossScopes", () => {
 
 	it("is unaffected by a missing project settings file", () => {
 		const home = writePiHome({ packages: ["npm:pi-global@1.0.0"] });
-		const projectRoot = mkdtempSync(join(tmpdir(), "packed-project-"));
+		const projectRoot = track(mkdtempSync(join(tmpdir(), "packed-project-")));
 		expect(readInstalledPackagesAcrossScopes(home, projectRoot)).toEqual([
 			{ name: "pi-global", pinned: "1.0.0", installed: undefined, scope: "global" },
 		]);
@@ -214,13 +224,13 @@ class NoopInstaller implements Installer {
 
 describe("package.updates.project (daemon RPC wiring)", () => {
 	it("computes a live, cross-scope drift check on demand, distinct from package.updates' own persisted global-only snapshot", async () => {
-		const home = mkdtempSync(join(tmpdir(), "packed-updates-project-"));
+		const home = track(mkdtempSync(join(tmpdir(), "packed-updates-project-")));
 		writeFileSync(join(home, "settings.json"), JSON.stringify({ packages: ["npm:pi-global@1.0.0"] }));
-		const projectRoot = mkdtempSync(join(tmpdir(), "packed-updates-project-root-"));
+		const projectRoot = track(mkdtempSync(join(tmpdir(), "packed-updates-project-root-")));
 		const projectHome = join(projectRoot, ".pi");
 		mkdirSync(projectHome, { recursive: true });
 		writeFileSync(join(projectHome, "settings.json"), JSON.stringify({ packages: ["npm:papyrus@0.21.2"] }));
-		const stateDir = mkdtempSync(join(tmpdir(), "packed-updates-project-state-"));
+		const stateDir = track(mkdtempSync(join(tmpdir(), "packed-updates-project-state-")));
 		const db = openDb(dbPath(stateDir));
 		replaceAll(
 			db,
@@ -249,7 +259,7 @@ describe("package.updates.project (daemon RPC wiring)", () => {
 
 describe("updates store", () => {
 	it("roundtrips", async () => {
-		const dir = mkdtempSync(join(tmpdir(), "packed-"));
+		const dir = track(mkdtempSync(join(tmpdir(), "packed-")));
 		const snap = { checkedAt: new Date().toISOString(), updates: [{ name: "a", installed: "1", latest: "2", detectedAt: "" }] };
 		await saveUpdates(dir, snap);
 		expect(await loadUpdates(dir)).toEqual(snap);
@@ -259,7 +269,7 @@ describe("updates store", () => {
 
 describe("watcher producer", () => {
 	it("writes a snapshot on tick", async () => {
-		const dir = mkdtempSync(join(tmpdir(), "packed-"));
+		const dir = track(mkdtempSync(join(tmpdir(), "packed-")));
 		let signalTick: ((snapshot: UpdatesSnapshot) => void) | undefined;
 		const tick = new Promise<UpdatesSnapshot>((resolve) => {
 			signalTick = resolve;
@@ -282,7 +292,7 @@ describe("watcher producer", () => {
 
 describe("catalog status", () => {
 	it("stale when unsynced, fresh after sync", () => {
-		const dir = mkdtempSync(join(tmpdir(), "packed-"));
+		const dir = track(mkdtempSync(join(tmpdir(), "packed-")));
 		expect(catalogStatus(dir, 6 * 3_600_000).stale).toBe(true);
 		const db = openDb(`${dir}/packed.db`);
 		replaceAll(db, [{ name: "a", version: "1" }], "test");

package/service/test/index.test.ts

@@ -1,5 +1,5 @@
-import { afterAll, beforeAll, describe, expect, it } from "bun:test";
-import { mkdtempSync, readFileSync } from "node:fs";
+import { afterAll, afterEach, beforeAll, describe, expect, it } from "bun:test";
+import { mkdtempSync, readFileSync, rmSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import type { Server } from "bun";
@@ -7,6 +7,16 @@ import { buildIndex, generateIndex, indexPath, indexStatus, readIndex, writeInde
 import { dbPath, openDb, replaceAll } from "../src/packages/db.ts";
 import { HttpRegistry } from "../src/registry/registry.ts";
 
+const roots: string[] = [];
+afterEach(() => {
+	for (const root of roots.splice(0)) rmSync(root, { recursive: true, force: true });
+});
+
+function track(dir: string): string {
+	roots.push(dir);
+	return dir;
+}
+
 // Guards the "never bulk GitHub calls" constraint against regression: a
 // future edit could easily start threading a GitHub-commit fetcher through
 // buildIndex the same way scoreTarget does. A source-level check catches
@@ -89,7 +99,10 @@ describe("buildIndex", () => {
 		registry = new HttpRegistry(`http://127.0.0.1:${server.port}`, 250, 0, 1, `http://127.0.0.1:${server.port}`);
 	});
 
-	afterAll(() => server.stop(true));
+	afterAll(() => {
+		server.stop(true);
+		rmSync(catalogDir, { recursive: true, force: true });
+	});
 
 	it("builds one entry per cataloged package, skipping a lookup failure rather than failing the whole run", async () => {
 		const index = await buildIndex(registry, catalogDir, { delayMs: 0, currentPiVersion: async () => "0.83.0" });
@@ -123,7 +136,7 @@ describe("buildIndex", () => {
 
 describe("buildIndex bounds", () => {
 	it("never calls downloads() -- confirmed live to trigger npm's 429s at real catalog scale -- and truncates past maxPackages, marking the result", async () => {
-		const dir = mkdtempSync(join(tmpdir(), "packed-index-bounds-"));
+		const dir = track(mkdtempSync(join(tmpdir(), "packed-index-bounds-")));
 		const db = openDb(dbPath(dir));
 		replaceAll(
 			db,
@@ -160,7 +173,7 @@ describe("buildIndex bounds", () => {
 	});
 
 	it("collapses two concurrent callers into one run -- confirmed live to matter: the daemon's own maintenance tick and an on-demand CLI build overlapping compounded into a shutdown the daemon's SIGTERM grace period couldn't outlast", async () => {
-		const dir = mkdtempSync(join(tmpdir(), "packed-index-concurrent-"));
+		const dir = track(mkdtempSync(join(tmpdir(), "packed-index-concurrent-")));
 		const db = openDb(dbPath(dir));
 		replaceAll(db, [{ name: "pi-one", version: "1.0.0" }], "test");
 		db.close();
@@ -203,7 +216,7 @@ describe("buildIndex bounds", () => {
 
 describe("buildIndex incremental delta scanning", () => {
 	it("partitions the catalog into New/Changed/Unchanged against the prior index -- Unchanged makes zero live registry calls, New and Changed do", async () => {
-		const dir = mkdtempSync(join(tmpdir(), "packed-index-delta-"));
+		const dir = track(mkdtempSync(join(tmpdir(), "packed-index-delta-")));
 		const db = openDb(dbPath(dir));
 		replaceAll(
 			db,
@@ -275,7 +288,7 @@ describe("buildIndex incremental delta scanning", () => {
 	});
 
 	it("maxPackages bounds only the New+Changed live-call queue -- Unchanged entries beyond that count still complete", async () => {
-		const dir = mkdtempSync(join(tmpdir(), "packed-index-delta-bound-"));
+		const dir = track(mkdtempSync(join(tmpdir(), "packed-index-delta-bound-")));
 		const db = openDb(dbPath(dir));
 		// 5 unchanged entries alone already exceed maxPackages: 1 below.
 		replaceAll(
@@ -323,7 +336,7 @@ describe("buildIndex incremental delta scanning", () => {
 
 describe("index persistence", () => {
 	it("writes, reads, and reports staleness", async () => {
-		const dir = mkdtempSync(join(tmpdir(), "packed-index-store-"));
+		const dir = track(mkdtempSync(join(tmpdir(), "packed-index-store-")));
 		const path = indexPath(dir);
 		expect(readIndex(path)).toBeUndefined();
 		expect(indexStatus(path, 1_000).stale).toBe(true);
@@ -343,7 +356,7 @@ describe("index persistence", () => {
 	});
 
 	it("generateIndex builds and writes in one call", async () => {
-		const dir = mkdtempSync(join(tmpdir(), "packed-index-generate-"));
+		const dir = track(mkdtempSync(join(tmpdir(), "packed-index-generate-")));
 		const db = openDb(dbPath(dir));
 		replaceAll(db, [{ name: "pi-alpha", version: "1.0.0" }], "npm:keywords:pi-package");
 		db.close();

package/service/test/install-validation.test.ts

@@ -7,8 +7,8 @@
  * a broken fixture must genuinely be refused, a healthy one must genuinely
  * pass.
  */
-import { describe, expect, it } from "bun:test";
-import { mkdirSync, mkdtempSync, writeFileSync } from "node:fs";
+import { afterEach, describe, expect, it } from "bun:test";
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { dirname, join } from "node:path";
 import { fileURLToPath } from "node:url";
@@ -23,6 +23,16 @@ const BROKEN = join(FIXTURES, "broken-package");
 const NO_MANIFEST = join(FIXTURES, "no-manifest-package");
 const DEP_PACKAGE = join(FIXTURES, "dep-package");
 
+const roots: string[] = [];
+afterEach(() => {
+	for (const root of roots.splice(0)) rmSync(root, { recursive: true, force: true });
+});
+
+function track(dir: string): string {
+	roots.push(dir);
+	return dir;
+}
+
 /** Writes a fresh package into `dir` whose extension entry point has a real
  * runtime import (`packed-fixture-dep`, a `file:` dependency resolvable
  * fully offline) -- otherwise healthy, structurally identical to HEALTHY,
@@ -145,7 +155,7 @@ describe("HeadlessInstallValidator (vehicle-client-pi pi-load-harness, non-gatin
 
 describe("HeadlessInstallValidator (bug repro, packed-headlessinstallvalidator-never-installs-the): staged tarball's own declared dependencies are never installed before the load check", () => {
 	it("approves an otherwise-healthy package whose entry point needs its one declared file: dependency", async () => {
-		const dir = mkdtempSync(join(tmpdir(), "packed-install-validation-dep-fixture-"));
+		const dir = track(mkdtempSync(join(tmpdir(), "packed-install-validation-dep-fixture-")));
 		writePackageWithRealDependency(dir);
 
 		// Ground truth this isn't a broken fixture: a plain `bun install` in an
@@ -193,7 +203,7 @@ describe("ExecInstaller.install() -- refuses before ever spawning the real pi bi
 		// step to cwd into -- /bin/true always exits 0 regardless, proving both
 		// the real install spawn *and* the re-resolution spawn were reached (a
 		// refused install never gets this far to find out).
-		const piHome = mkdtempSync(join(tmpdir(), "packed-install-validation-pihome-"));
+		const piHome = track(mkdtempSync(join(tmpdir(), "packed-install-validation-pihome-")));
 		mkdirSync(join(piHome, "npm"), { recursive: true });
 		const installer = new ExecInstaller(
 			"/bin/true",

package/service/test/install.test.ts

@@ -10,20 +10,40 @@
  * always-"Updated"-regardless-of-outcome text, and assert the real on-disk
  * version diff is what actually drives reloadRequired/alreadyUpToDate.
  */
-import { describe, expect, it } from "bun:test";
-import { chmodSync, mkdirSync, mkdtempSync, readFileSync, writeFileSync } from "node:fs";
+import { afterEach, describe, expect, it } from "bun:test";
+import { chmodSync, mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { ExecInstaller } from "../src/packages/install.ts";
+import { createLogger } from "../src/shared/log.ts";
 
 /**
  * A fake `pi` binary: always prints "Updated <source>" and exits 0 (matching
  * real `pi`'s observed behavior for a no-op). When `rewrite` is given, it
  * additionally overwrites that exact package's on-disk version -- letting a
  * test simulate a genuine version change on demand. The rewrite target is
- * baked into the script file itself (not an env var) so it is immune to
- * Bun.spawn's default env snapshot not picking up late process.env writes.
+ * baked into the script file itself (not an env var) rather than read from
+ * process.env at spawn time, keeping these fixtures independent of whichever
+ * way ExecInstaller happens to thread its own env through -- see the
+ * `run()`/`reresolveDependencyTree() thread env explicitly` describe block
+ * below for a dedicated test of that env-threading behavior itself, added
+ * after service/test/perf/multi-install.perf.test.ts caught it live: a
+ * runtime process.env mutation (redirecting Pi's home directory) silently
+ * never reached the spawned `pi`/`npm` children because Bun.spawn's own
+ * default env inheritance doesn't pick up a mutation made after this
+ * process's own startup snapshot -- only an explicit `env: process.env`
+ * option re-reads the current object.
  */
+const roots: string[] = [];
+afterEach(() => {
+	for (const root of roots.splice(0)) rmSync(root, { recursive: true, force: true });
+});
+
+function track(dir: string): string {
+	roots.push(dir);
+	return dir;
+}
+
 function writeFakePi(dir: string, rewrite?: { piHome: string; name: string; newVersion: string }): string {
 	const script = join(dir, "fake-pi");
 	const rewriteLine = rewrite
@@ -39,7 +59,7 @@ function writeFakePi(dir: string, rewrite?: { piHome: string; name: string; newV
 }
 
 function writePiHome(nodeModules: Record<string, string> = {}): string {
-	const dir = mkdtempSync(join(tmpdir(), "packed-exec-pihome-"));
+	const dir = track(mkdtempSync(join(tmpdir(), "packed-exec-pihome-")));
 	mkdirSync(join(dir, "npm"), { recursive: true });
 	for (const [name, version] of Object.entries(nodeModules)) {
 		const pkgDir = join(dir, "npm", "node_modules", name);
@@ -73,7 +93,7 @@ function writeFakeNpm(dir: string, logFile: string, rewrite?: { piHome: string;
 
 describe("ExecInstaller.update() — honest reloadRequired despite pi's ambiguous exit-0 text", () => {
 	it("pinned source, version genuinely unchanged: alreadyUpToDate, reloadRequired false", async () => {
-		const scriptDir = mkdtempSync(join(tmpdir(), "packed-exec-bin-"));
+		const scriptDir = track(mkdtempSync(join(tmpdir(), "packed-exec-bin-")));
 		const bin = writeFakePi(scriptDir);
 		const npmBin = writeFakeNpm(scriptDir, join(scriptDir, "npm.log"));
 		const piHome = writePiHome({ "@scope/pkg": "1.2.3" });
@@ -90,7 +110,7 @@ describe("ExecInstaller.update() — honest reloadRequired despite pi's ambiguou
 	});
 
 	it('unpinned source, already latest (pi still exits 0 and says "Updated"): alreadyUpToDate', async () => {
-		const scriptDir = mkdtempSync(join(tmpdir(), "packed-exec-bin-"));
+		const scriptDir = track(mkdtempSync(join(tmpdir(), "packed-exec-bin-")));
 		const bin = writeFakePi(scriptDir);
 		const npmBin = writeFakeNpm(scriptDir, join(scriptDir, "npm.log"));
 		const piHome = writePiHome({ plain: "0.5.0" });
@@ -106,7 +126,7 @@ describe("ExecInstaller.update() — honest reloadRequired despite pi's ambiguou
 	});
 
 	it("unpinned source, a real version change happens: reloadRequired true", async () => {
-		const scriptDir = mkdtempSync(join(tmpdir(), "packed-exec-bin-"));
+		const scriptDir = track(mkdtempSync(join(tmpdir(), "packed-exec-bin-")));
 		const piHome = writePiHome({ plain: "0.5.0" });
 		const bin = writeFakePi(scriptDir, { piHome, name: "plain", newVersion: "0.6.0" });
 		const npmBin = writeFakeNpm(scriptDir, join(scriptDir, "npm.log"));
@@ -122,7 +142,7 @@ describe("ExecInstaller.update() — honest reloadRequired despite pi's ambiguou
 	});
 
 	it("git: source (no npm resolution possible either side): conservatively assumes it may have changed", async () => {
-		const scriptDir = mkdtempSync(join(tmpdir(), "packed-exec-bin-"));
+		const scriptDir = track(mkdtempSync(join(tmpdir(), "packed-exec-bin-")));
 		const bin = writeFakePi(scriptDir);
 		const npmBin = writeFakeNpm(scriptDir, join(scriptDir, "npm.log"));
 		const piHome = writePiHome();
@@ -141,7 +161,7 @@ describe("ExecInstaller.update() — honest reloadRequired despite pi's ambiguou
 
 describe("ExecInstaller — forces full dependency re-resolution, not just the target's own subtree", () => {
 	it("update() fixes a stale root-level sibling that the targeted pi update never touched", async () => {
-		const scriptDir = mkdtempSync(join(tmpdir(), "packed-exec-bin-"));
+		const scriptDir = track(mkdtempSync(join(tmpdir(), "packed-exec-bin-")));
 		// Simulates the confirmed live defect: after `pi update npm:@scope/leaf`,
 		// the leaf's own version bumps, but a root-level sibling
 		// (@scope/shared) that the freshly-updated leaf now needs a newer
@@ -170,7 +190,7 @@ describe("ExecInstaller — forces full dependency re-resolution, not just the t
 	});
 
 	it("install() also forces a full re-resolution after a successful pi install", async () => {
-		const scriptDir = mkdtempSync(join(tmpdir(), "packed-exec-bin-"));
+		const scriptDir = track(mkdtempSync(join(tmpdir(), "packed-exec-bin-")));
 		const piHome = writePiHome({ "@scope/shared": "1.0.0" });
 		const bin = writeFakePi(scriptDir);
 		const npmLog = join(scriptDir, "npm.log");
@@ -185,7 +205,7 @@ describe("ExecInstaller — forces full dependency re-resolution, not just the t
 	});
 
 	it("surfaces a failed re-resolution instead of silently reporting success", async () => {
-		const scriptDir = mkdtempSync(join(tmpdir(), "packed-exec-bin-"));
+		const scriptDir = track(mkdtempSync(join(tmpdir(), "packed-exec-bin-")));
 		const piHome = writePiHome({ plain: "0.5.0" });
 		const bin = writeFakePi(scriptDir, { piHome, name: "plain", newVersion: "0.6.0" });
 		const failingNpm = join(scriptDir, "fake-npm-fail");
@@ -196,3 +216,100 @@ describe("ExecInstaller — forces full dependency re-resolution, not just the t
 		await expect(installer.update("npm:plain")).rejects.toThrow(/npm install failed to re-resolve/);
 	});
 });
+
+describe("ExecInstaller — timing instrumentation (see service/test/perf/multi-install.perf.test.ts for a real multi-package measurement)", () => {
+	it("install() logs a validateMs/installMs/reresolveMs/totalMs breakdown, not just a pass/fail result", async () => {
+		const scriptDir = track(mkdtempSync(join(tmpdir(), "packed-exec-bin-")));
+		const bin = writeFakePi(scriptDir);
+		const npmBin = writeFakeNpm(scriptDir, join(scriptDir, "npm.log"));
+		const piHome = writePiHome();
+		const lines: string[] = [];
+		const logger = createLogger("test", (line) => lines.push(line), "debug");
+		const installer = new ExecInstaller(bin, piHome, { validate: async (source) => ({ ok: true, source, extensions: [] }) }, npmBin, logger);
+
+		await installer.install("npm:plain");
+
+		const timing = lines.map((line) => JSON.parse(line)).find((entry) => entry.msg === "install timing");
+		expect(timing).toBeDefined();
+		expect(timing.source).toBe("npm:plain");
+		for (const field of ["validateMs", "installMs", "reresolveMs", "totalMs"]) {
+			expect(typeof timing[field]).toBe("number");
+			expect(timing[field]).toBeGreaterThanOrEqual(0);
+		}
+		// totalMs is the whole call's own wall clock, not just one phase re-labeled --
+		// bounded above by itself plus a small scheduling-noise allowance, never equal to
+		// a single phase alone once every phase is genuinely counted once.
+		expect(timing.totalMs).toBeGreaterThanOrEqual(timing.validateMs + timing.installMs + timing.reresolveMs - 1);
+	});
+
+	it("update() logs an updateMs/reresolveMs/totalMs breakdown", async () => {
+		const scriptDir = track(mkdtempSync(join(tmpdir(), "packed-exec-bin-")));
+		const bin = writeFakePi(scriptDir);
+		const npmBin = writeFakeNpm(scriptDir, join(scriptDir, "npm.log"));
+		const piHome = writePiHome({ plain: "0.5.0" });
+		const lines: string[] = [];
+		const logger = createLogger("test", (line) => lines.push(line), "debug");
+		const installer = new ExecInstaller(bin, piHome, undefined, npmBin, logger);
+
+		await installer.update("npm:plain");
+
+		const timing = lines.map((line) => JSON.parse(line)).find((entry) => entry.msg === "update timing");
+		expect(timing).toBeDefined();
+		expect(timing.source).toBe("npm:plain");
+		for (const field of ["updateMs", "reresolveMs", "totalMs"]) {
+			expect(typeof timing[field]).toBe("number");
+			expect(timing[field]).toBeGreaterThanOrEqual(0);
+		}
+	});
+});
+
+/**
+ * A fake binary that dumps one specific env var's CURRENT value to `logFile` -- proves a
+ * process.env mutation made at runtime (after this test process's own startup, the exact shape
+ * of a caller redirecting Pi's home directory) actually reaches the spawned child, rather than
+ * whatever snapshot Bun.spawn's own default env inheritance captured earlier.
+ */
+function writeEnvDumpBinary(dir: string, name: string, varName: string, logFile: string): string {
+	const script = join(dir, name);
+	writeFileSync(script, ["#!/usr/bin/env bash", `printf '%s' "\$${varName}" > '${logFile}'`, "exit 0"].join("\n"));
+	chmodSync(script, 0o755);
+	return script;
+}
+
+describe("ExecInstaller — run()/reresolveDependencyTree() thread the CURRENT process.env through explicitly", () => {
+	const MARKER = "PACKED_TEST_ENV_MARKER";
+
+	afterEach(() => {
+		delete process.env[MARKER];
+	});
+
+	it("install()'s pi spawn sees an env var set on process.env after this process already started", async () => {
+		const scriptDir = track(mkdtempSync(join(tmpdir(), "packed-exec-env-")));
+		const piLog = join(scriptDir, "pi-env.log");
+		const bin = writeEnvDumpBinary(scriptDir, "fake-pi-env", MARKER, piLog);
+		const npmBin = writeFakeNpm(scriptDir, join(scriptDir, "npm.log"));
+		const piHome = writePiHome();
+		const installer = new ExecInstaller(bin, piHome, { validate: async (source) => ({ ok: true, source, extensions: [] }) }, npmBin);
+
+		// Mutated well after this test process's own startup -- exactly what redirecting Pi's home
+		// via PI_CODING_AGENT_DIR at runtime looks like from ExecInstaller's own point of view.
+		process.env[MARKER] = "set-after-startup";
+		await installer.install("npm:plain");
+
+		expect(readFileSync(piLog, "utf8")).toBe("set-after-startup");
+	});
+
+	it("reresolveDependencyTree()'s npm spawn sees the same runtime env mutation", async () => {
+		const scriptDir = track(mkdtempSync(join(tmpdir(), "packed-exec-env-")));
+		const bin = writeFakePi(scriptDir);
+		const npmLog = join(scriptDir, "npm-env.log");
+		const npmBin = writeEnvDumpBinary(scriptDir, "fake-npm-env", MARKER, npmLog);
+		const piHome = writePiHome();
+		const installer = new ExecInstaller(bin, piHome, { validate: async (source) => ({ ok: true, source, extensions: [] }) }, npmBin);
+
+		process.env[MARKER] = "reresolve-sees-this-too";
+		await installer.install("npm:plain");
+
+		expect(readFileSync(npmLog, "utf8")).toBe("reresolve-sees-this-too");
+	});
+});