@danypops/pi-packed 0.20.0 → 0.20.2

package/README.md

@@ -10,7 +10,7 @@ The extension connects to Packed's authenticated user daemon and starts the pack
 
 ## Commands
 
-- `/packed` -- one floating overlay, four tabs (Packages/Find/Config/Settings), always shown in a persistent tab bar at the top: the focused tab shows the theme's own selectedBg color as a real background, unfocused tabs show only a foreground color with their own first letter highlighted as a jump mnemonic (the focused tab needs no mnemonic -- there's nothing to jump to when you're already there). `Tab`/`Shift-Tab` (or `←`/`→`) sweep between them -- recognized under legacy CSI, xterm's modifyOtherKeys, and the Kitty keyboard protocol alike, not just one hardcoded encoding; from any tab other than Packages, `p`/`f`/`c`/`s` also jump straight to the matching one (never stolen while that tab's own filter/query box is capturing text). `Esc` returns to Packages from anywhere else, or closes the panel from Packages itself. Every approval and reload confirmation, on any tab, renders inline on this same panel (`y`/`n` keys), never a separate popup or native dialog. A standing test (`keymap.test.ts`, using Malevich's tree-style `findMnemonicConflicts`) verifies no two actions genuinely reachable at once share a key.
+- `/packed` -- one floating overlay, four tabs (Packages/Find/Config/Settings), always shown in a persistent tab bar at the top: the focused tab reverses the theme's text color for high contrast in both dark and light modes, unfocused tabs show only a foreground color with their own first letter highlighted as a jump mnemonic (the focused tab needs no mnemonic -- there's nothing to jump to when you're already there). `Tab`/`Shift-Tab` (or `←`/`→`) sweep between them -- recognized under legacy CSI, xterm's modifyOtherKeys, and the Kitty keyboard protocol alike, not just one hardcoded encoding; from any tab other than Packages, `p`/`f`/`c`/`s` also jump straight to the matching one (never stolen while that tab's own filter/query box is capturing text). `Esc` returns to Packages from anywhere else, or closes the panel from Packages itself. Every approval and reload confirmation, on any tab, renders inline on this same panel (`y`/`n` keys), never a separate popup or native dialog. A standing test (`keymap.test.ts`, using Malevich's tree-style `findMnemonicConflicts`) verifies no two actions genuinely reachable at once share a key.
   - **Packages** (the default tab) -- every installed Pi package, with update availability. Mnemonics follow lazy.nvim's own convention (uppercase acts on every row, lowercase on the one under the cursor):
     - `u` / `U` -- update the selected package / update every outdated package, one combined confirmation and one reload. `U` shows a spinner inline next to the package currently updating, settling into a real ✓ or ✗ plus a short tail of that update's own captured output once it finishes -- the list stays visible throughout, nothing swaps to a separate screen. A reload is confirmed separately from the update itself -- decline it to defer: the update already happened, only picking it up in this Pi session is deferred until `/reload`.
     - `x` -- remove the selected package.

package/extension/src/menu-theme.ts

@@ -31,19 +31,16 @@ export function dialogTheme(theme: Theme): DialogTheme {
  * overlay, replacing what used to be four separately-opened screens. */
 export function tabBarTheme(theme: Theme): TabBarTheme {
 	return {
-		// Real bug, reported live: theme.inverse() swaps whatever
-		// foreground/background happen to be ambient at that point in the
-		// ANSI stream, not a specific color -- and Envelope wraps a whole
-		// content line (including this tab bar) in one continuous border-color
-		// span with no reset until the line's end, so which tab is active
-		// changed what "ambient" meant (blue when Packages was first on the
-		// line and nothing had reset yet, white once an earlier inactive tab's
-		// own fg reset already cleared it). An explicit theme.bg() always
-		// overwrites rather than swaps, so it's immune to that -- matches
-		// Pi's own core session-selector.js, which highlights its selected
-		// line the same way.
 		tab: (s) => theme.fg("dim", s),
-		activeTab: (s) => theme.bg("selectedBg", s),
+		// Set the semantic text color before reversing it. Reverse video then
+		// makes dark themes use their bright text as the highlight background
+		// and light themes use their dark text, without inheriting Envelope's
+		// ambient border foreground. Every tab position gets the same default
+		// terminal background as its displayed foreground.
+		activeTab: (s) => {
+			const text = theme.fg("text", s);
+			return typeof theme.inverse === "function" ? theme.inverse(text) : text;
+		},
 		// Every tab's first letter is a jump mnemonic (p/f/c/s) -- a distinct
 		// warning-colored bold, so it reads as "press this letter" on both the
 		// active and inactive tabs alike, not just whichever style tab/activeTab
@@ -51,3 +48,11 @@ export function tabBarTheme(theme: Theme): TabBarTheme {
 		mnemonic: (s) => theme.bold(theme.fg("warning", s)),
 	};
 }
+
+/** Envelope calls style with assembled lines in released Malevich versions.
+ * Color only frame glyphs so styled content cannot reset the closing border
+ * or inherit the border foreground. This remains compatible with Malevich's
+ * segment-styled Envelope implementation. */
+export function panelFrameStyle(theme: Theme): (text: string) => string {
+	return (text) => text.replace(/[╭─╮│╰╯]+/gu, (glyphs) => theme.fg("border", glyphs));
+}

package/extension/src/tui.ts

@@ -59,7 +59,7 @@ import {
 	type TextMeasure,
 } from "malevich-tui-components";
 import { confirmReload } from "./approval/reload.js";
-import { dialogTheme, menuTheme, tabBarTheme } from "./menu-theme.js";
+import { dialogTheme, menuTheme, panelFrameStyle, tabBarTheme } from "./menu-theme.js";
 import type { Row, ViewMode } from "./model.js";
 import { filterRows, mergeRows, nextMode, visibleRows } from "./model.js";
 import type { Natives, PackageResources } from "./packed.js";
@@ -849,7 +849,7 @@ function renderUnifiedPanel(
 			const envelope = new Envelope({
 				title: "packed",
 				borderStyle: "rounded",
-				style: (s) => theme.fg("border", s),
+				style: panelFrameStyle(theme),
 				titleStyle: (s) => theme.bold(theme.fg("accent", s)),
 				measure,
 			});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/pi-packed",
-  "version": "0.20.0",
+  "version": "0.20.2",
   "description": "Pi package lifecycle, validation, daemon, tools, profiles, and TUI",
   "type": "module",
   "bin": {
@@ -31,14 +31,15 @@
     "@danypops/packed": "^0.6.0",
     "@danypops/pi-extension-harness": "^0.2.0",
     "@danypops/vehicle-client": "^0.5.1",
-    "@danypops/vehicle-core": "^0.10.0",
-    "@danypops/vehicle-server": "^0.15.0",
+    "@danypops/vehicle-core": "^0.12.3",
+    "@danypops/vehicle-server": "^0.17.1",
     "jiti": "2.6.1",
-    "malevich-tui-components": "^0.16.1",
+    "malevich-tui-components": "^0.20.4",
     "publint": "0.3.22",
     "semver": "^7.8.5"
   },
   "devDependencies": {
+    "@danypops/pi-tui-harness": "^0.0.1",
     "@danypops/vehicle-client-pi": "^0.16.0",
     "@types/semver": "^7.7.1"
   },

package/service/src/daemon/service.ts

@@ -251,7 +251,11 @@ export function createApp(deps: Deps): { fetch: (req: Request) => Promise<Respon
 	// Additive, real Vehicle protocol surface for this daemon's full operation set -- served
 	// at /vehicle/* alongside (not replacing) /api/v1/ops below. Every operation delegates to
 	// the exact same executeOperation() this route's own /api/v1/ops handler calls.
-	const vehicleRegistry = new VehicleRegistry({ name: "packed", version: VERSION, description: "Pi package lifecycle daemon" });
+	const vehicleRegistry = new VehicleRegistry({
+		name: "packed",
+		packageJsonUrl: new URL("../../../package.json", import.meta.url),
+		description: "Pi package lifecycle daemon",
+	});
 	registerPackedVehicleOperations(vehicleRegistry, executeOperation);
 	const vehicleApp = createVehicleHttpApp({ registry: vehicleRegistry, token: deps.token });
 

package/service/src/daemon/vehicle-registration.ts

@@ -37,7 +37,7 @@
  */
 
 import type { VehicleEffect, VehicleIdempotency } from "@danypops/vehicle-core";
-import { bindVehicleOperation, defineVehicleOperation, passthroughVehicleSchema, VehicleError } from "@danypops/vehicle-core";
+import { bindVehicleOperation, defineErrorMapping, defineVehicleOperation, passthroughVehicleSchema } from "@danypops/vehicle-core";
 import type { VehicleRegistry } from "@danypops/vehicle-server";
 import { OPERATION_NAMES, type OperationInputs, type OperationName, type OperationOutputs } from "./service.ts";
 
@@ -50,28 +50,12 @@ function hasStatus(error: unknown): error is StatusCarryingError {
 	return error instanceof Error && typeof (error as { status?: unknown }).status === "number";
 }
 
-async function withPackedErrorParity<T>(run: () => T | Promise<T>): Promise<T> {
-	try {
-		return await run();
-	} catch (error) {
-		if (error instanceof VehicleError) throw error;
-		if (hasStatus(error)) {
-			const category =
-				error.status === 403
-					? "authorization"
-					: error.status === 404
-						? "not_found"
-						: error.status === 400
-							? "validation"
-							: error.status >= 500
-								? "unavailable"
-								: "validation";
-			throw new VehicleError("operation-rejected", error.message, { category, cause: error });
-		}
-		const message = error instanceof Error ? error.message : String(error);
-		throw new VehicleError("operation-rejected", message, { category: "validation", cause: error });
-	}
-}
+const withPackedErrorParity = defineErrorMapping([
+	{ matches: (error) => hasStatus(error) && error.status === 403, category: "authorization" },
+	{ matches: (error) => hasStatus(error) && error.status === 404, category: "not_found" },
+	{ matches: (error) => hasStatus(error) && error.status === 400, category: "validation" },
+	{ matches: (error) => hasStatus(error) && error.status >= 500, category: "unavailable" },
+]);
 
 const OWNER = "packed";
 const LIMITS = { defaultTimeoutMs: 30_000, maxTimeoutMs: 120_000, maxRequestBytes: 65_536, maxResponseBytes: 4_194_304 };