@danypops/pi-packed 0.19.5 → 0.19.7

package/extension/src/discover.ts

@@ -16,8 +16,8 @@ import type { Component } from "malevich-tui-components";
 import { shouldSearch } from "./discover-model.js";
 import type { Natives, PackageSummary } from "./packed.js";
 import { InstallServiceError } from "./packed.js";
-import { approvePackageOperation } from "./tools.js";
 import type { TabHost } from "./tab-host.js";
+import { approvePackageOperation } from "./tools.js";
 
 const SEARCH_LIMIT = 20;
 
@@ -52,7 +52,10 @@ export async function applyInstall(result: PackageSummary, natives: Natives, ctx
 	}
 }
 
-interface Theme { fg(color: string, s: string): string; bold(s: string): string; }
+interface Theme {
+	fg(color: string, s: string): string;
+	bold(s: string): string;
+}
 
 /** /packed's Find tab -- a real Component. Its query box always captures
  * free text (isCapturingInput() is unconditionally true), unlike
@@ -71,6 +74,7 @@ export class FindTab implements Component {
 	constructor(
 		private readonly natives: Natives,
 		private readonly host: TabHost,
+		// biome-ignore lint/correctness/noUnusedPrivateClassMembers: read via `const { theme } = this` in render(), which Biome's usage check doesn't trace
 		private readonly theme: Theme,
 	) {}
 
@@ -169,7 +173,10 @@ export class FindTab implements Component {
 		this.busy = true;
 		this.host.requestRender();
 		try {
-			const confirmed = await this.host.inlineCtx.ui.confirm(`Install ${result.name}@${result.version}`, "Search itself never mutates -- this is the first of two confirmations before anything installs.");
+			const confirmed = await this.host.inlineCtx.ui.confirm(
+				`Install ${result.name}@${result.version}`,
+				"Search itself never mutates -- this is the first of two confirmations before anything installs.",
+			);
 			if (!confirmed) return;
 			const outcome = await applyInstall(result, this.natives, this.host.inlineCtx);
 			if (outcome === "installed") this.host.onSessionReplaced();

package/extension/src/index.ts

@@ -9,13 +9,13 @@
  * Install: pi install git:github.com/DanyPops/pi-packed
  */
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
-import { registerTools } from "./tools.js";
-import { showPackedPanel } from "./tui.js";
-import { createNatives } from "./packed.js";
 import { formatUpdateNotice } from "./model.js";
+import { createNatives } from "./packed.js";
 import { registerProfiles } from "./profile.js";
-import { handleSetupCommand } from "./setup-command.js";
 import { handleResourceConfigCommand } from "./resource-config.js";
+import { handleSetupCommand } from "./setup-command.js";
+import { registerTools } from "./tools.js";
+import { showPackedPanel } from "./tui.js";
 
 // Async factory (pi awaits it): the seam creates authenticated daemon
 // clients lazily. It never executes Bun-only adapters or opens SQLite.
@@ -25,7 +25,8 @@ export default async function (pi: ExtensionAPI) {
 	registerTools(pi, natives);
 
 	pi.registerCommand("packed", {
-		description: "Browse and manage installed Pi packages -- u/U update, x remove, d disable, c config, f find, s settings -- or run setup plan/apply or config directly",
+		description:
+			"Browse and manage installed Pi packages -- u/U update, x remove, d disable, c config, f find, s settings -- or run setup plan/apply or config directly",
 		handler: async (args, ctx) => {
 			if (await handleSetupCommand(args, ctx, natives)) return;
 			if (await handleResourceConfigCommand(args, ctx, natives, showPackedPanel)) return;

package/extension/src/packed.ts

@@ -8,14 +8,35 @@
  * the rest of the Pi session -- vehicle-client's createRetryingClient detects
  * that on the failing call itself and reconnects, so the happy path reuses
  * one connected client instead of reconnecting on every single operation.
+ *
+ * Reads/idempotent lookups use call() (transparent retry once on a stale
+ * connection); install/installService/remove/update/setMutationApproval/
+ * setupApply/toggleResource use callOnce() instead -- a stale connection
+ * during any of those must surface its one real failure rather than risk a
+ * silently duplicated mutation (installing/removing/updating a package
+ * twice) if the retried call actually reached the daemon the first time.
  */
-import { createRetryingClient } from "@danypops/vehicle-client/daemon-client";
-import { ensurePackedClient, InstallServiceError, type PackedExtensionClient } from "@danypops/packed/client";
-import { PI_COMMAND_NAME, type InstalledPackage, type PackageInfo, type PackageResources, type PackageSummary, type PiStatus, type ResourceField, type SecuritySettings, type ServiceSpecSummary, type SetupApplyResult, type SetupPlan, type UpdateEntry, type UpdateOutcome } from "@danypops/packed/protocol";
 
-export { InstallServiceError, PI_COMMAND_NAME };
+import { ensurePackedClient, InstallServiceError, type PackedExtensionClient } from "@danypops/packed/client";
+import {
+	type InstalledPackage,
+	type PackageInfo,
+	type PackageResources,
+	type PackageSummary,
+	PI_COMMAND_NAME,
+	type PiStatus,
+	type ResourceField,
+	type SecuritySettings,
+	type ServiceSpecSummary,
+	type SetupApplyResult,
+	type SetupPlan,
+	type UpdateEntry,
+	type UpdateOutcome,
+} from "@danypops/packed/protocol";
+import { createRetryingClient } from "@danypops/vehicle-client/daemon-client";
 
 export type { PackageInfo, PackageResources, PackageSummary, PiStatus, ResourceField, UpdateEntry, UpdateOutcome };
+export { InstallServiceError, PI_COMMAND_NAME };
 export type InstalledPkg = InstalledPackage;
 export type PackageDaemonPort = PackedExtensionClient;
 type MutationApproval = SecuritySettings["mutationApproval"];
@@ -42,7 +63,14 @@ export interface Natives {
 	setupPlan(manifestPath: string, prune?: boolean): Promise<SetupPlan>;
 	setupApply(manifestPath: string, approved?: boolean, prune?: boolean): Promise<SetupApplyResult>;
 	listResources(projectRoot?: string): Promise<{ global: PackageResources[]; project: PackageResources[] }>;
-	toggleResource(source: string, field: ResourceField, path: string, enabled: boolean, projectRoot?: string, approved?: boolean): Promise<string>;
+	toggleResource(
+		source: string,
+		field: ResourceField,
+		path: string,
+		enabled: boolean,
+		projectRoot?: string,
+		approved?: boolean,
+	): Promise<string>;
 	piStatus(): Promise<PiStatus>;
 }
 
@@ -56,21 +84,25 @@ export async function createNatives(connect: PackageDaemonConnector = connectDef
 	const client = createRetryingClient(connect, { label: "pi-packed" });
 
 	return {
+		// Reads/idempotent lookups: transparently retried once on a stale connection.
 		search: (query, limit) => client.call((daemon) => daemon.search(query, limit)),
 		searchOffline: (query, limit) => client.call((daemon) => daemon.search(query, limit, true)),
 		info: (name) => client.call((daemon) => daemon.info(name)),
 		installed: () => client.call((daemon) => daemon.installed()),
 		updates: () => client.call((daemon) => daemon.updates()),
 		security: () => client.call((daemon) => daemon.security()),
-		setMutationApproval: (value, approved) => client.call((daemon) => daemon.setMutationApproval(value, approved)),
-		install: (source, approved) => client.call((daemon) => daemon.install(source, approved)),
-		installService: (source, approved) => client.call((daemon) => daemon.installService(source, approved)),
-		remove: (name, approved) => client.call((daemon) => daemon.remove(name, approved)),
-		update: (source, approved) => client.call((daemon) => daemon.update(source, approved)),
 		setupPlan: (manifestPath, prune) => client.call((daemon) => daemon.setupPlan(manifestPath, prune)),
-		setupApply: (manifestPath, approved, prune) => client.call((daemon) => daemon.setupApply(manifestPath, approved, prune)),
 		listResources: (projectRoot) => client.call((daemon) => daemon.listResources(projectRoot)),
-		toggleResource: (source, field, path, enabled, projectRoot, approved) => client.call((daemon) => daemon.toggleResource(source, field, path, enabled, projectRoot, approved)),
 		piStatus: () => client.call((daemon) => daemon.piStatus()),
+		// Mutations: never transparently retried -- a stale connection surfaces its one
+		// real failure instead of risking a silently duplicated install/remove/update.
+		setMutationApproval: (value, approved) => client.callOnce((daemon) => daemon.setMutationApproval(value, approved)),
+		install: (source, approved) => client.callOnce((daemon) => daemon.install(source, approved)),
+		installService: (source, approved) => client.callOnce((daemon) => daemon.installService(source, approved)),
+		remove: (name, approved) => client.callOnce((daemon) => daemon.remove(name, approved)),
+		update: (source, approved) => client.callOnce((daemon) => daemon.update(source, approved)),
+		setupApply: (manifestPath, approved, prune) => client.callOnce((daemon) => daemon.setupApply(manifestPath, approved, prune)),
+		toggleResource: (source, field, path, enabled, projectRoot, approved) =>
+			client.callOnce((daemon) => daemon.toggleResource(source, field, path, enabled, projectRoot, approved)),
 	};
 }

package/extension/src/profile.ts

@@ -1,7 +1,7 @@
-import { existsSync, lstatSync, mkdirSync, readFileSync, renameSync, rmSync, writeFileSync } from "node:fs";
-import { randomUUID } from "node:crypto";
+import { existsSync, lstatSync, mkdirSync, readFileSync, rmSync } from "node:fs";
 import { join } from "node:path";
-import { CONFIG_DIR_NAME, getAgentDir, type ExtensionAPI, type ExtensionContext } from "@earendil-works/pi-coding-agent";
+import { writeJsonAtomic } from "@danypops/packed/atomic-json";
+import { CONFIG_DIR_NAME, type ExtensionAPI, type ExtensionContext, getAgentDir } from "@earendil-works/pi-coding-agent";
 import { Key } from "@earendil-works/pi-tui";
 export interface Profile {
 	provider?: string;
@@ -30,14 +30,21 @@ function boundedString(value: unknown, maximum: number): string | undefined {
 }
 
 function secretLike(value: string): boolean {
-	return /-----BEGIN [A-Z ]*PRIVATE KEY-----/i.test(value)
-		|| /\b(?:api[_-]?key|access[_-]?token|refresh[_-]?token|password|passwd|secret)\s*[:=]\s*["']?[A-Za-z0-9_\-./+=]{12,}/i.test(value)
-		|| /\b(?:authorization\s*:\s*)?bearer\s+[A-Za-z0-9_\-./+=]{12,}/i.test(value);
+	return (
+		/-----BEGIN [A-Z ]*PRIVATE KEY-----/i.test(value) ||
+		/\b(?:api[_-]?key|access[_-]?token|refresh[_-]?token|password|passwd|secret)\s*[:=]\s*["']?[A-Za-z0-9_\-./+=]{12,}/i.test(value) ||
+		/\b(?:authorization\s*:\s*)?bearer\s+[A-Za-z0-9_\-./+=]{12,}/i.test(value)
+	);
 }
 
 function stringArray(value: unknown, maximum: number): string[] | undefined {
 	if (value === undefined) return undefined;
-	if (!Array.isArray(value) || value.length > maximum || !value.every((item) => typeof item === "string" && item.length > 0 && item.length <= 256)) throw new Error("array must contain bounded strings");
+	if (
+		!Array.isArray(value) ||
+		value.length > maximum ||
+		!value.every((item) => typeof item === "string" && item.length > 0 && item.length <= 256)
+	)
+		throw new Error("array must contain bounded strings");
 	return [...new Set(value)];
 }
 
@@ -52,16 +59,19 @@ export function decodeProfiles(text: string): ProfilesConfig {
 		if (Object.keys(raw).some((key) => !allowed.has(key))) throw new Error(`profile ${name} contains an unknown field`);
 		const profile: Profile = {};
 		for (const field of ["provider", "model", "theme"] as const) {
-			if (raw[field] !== undefined && !boundedString(raw[field], field === "model" ? 256 : 128)) throw new Error(`profile ${name}.${field} is invalid`);
+			if (raw[field] !== undefined && !boundedString(raw[field], field === "model" ? 256 : 128))
+				throw new Error(`profile ${name}.${field} is invalid`);
 			const fieldValue = boundedString(raw[field], field === "model" ? 256 : 128);
 			if (fieldValue) profile[field] = fieldValue;
 		}
-		if (raw.instructions !== undefined && !boundedString(raw.instructions, 16_384)) throw new Error(`profile ${name}.instructions is invalid`);
+		if (raw.instructions !== undefined && !boundedString(raw.instructions, 16_384))
+			throw new Error(`profile ${name}.instructions is invalid`);
 		if (typeof raw.instructions === "string") {
 			if (secretLike(raw.instructions)) throw new Error(`profile ${name}.instructions contains secret-like material`);
 			profile.instructions = raw.instructions;
 		}
-		if (raw.thinkingLevel !== undefined && (typeof raw.thinkingLevel !== "string" || !THINKING_LEVELS.has(raw.thinkingLevel))) throw new Error(`profile ${name}.thinkingLevel is invalid`);
+		if (raw.thinkingLevel !== undefined && (typeof raw.thinkingLevel !== "string" || !THINKING_LEVELS.has(raw.thinkingLevel)))
+			throw new Error(`profile ${name}.thinkingLevel is invalid`);
 		if (raw.thinkingLevel) profile.thinkingLevel = raw.thinkingLevel as ThinkingLevel;
 		profile.tools = stringArray(raw.tools, 100);
 		profile.allowedModels = stringArray(raw.allowedModels, 100);
@@ -75,7 +85,8 @@ export function decodeProfiles(text: string): ProfilesConfig {
 function readProfileFile(path: string): ProfilesConfig {
 	if (!existsSync(path)) return {};
 	const stat = lstatSync(path);
-	if (!stat.isFile() || stat.isSymbolicLink() || stat.size > MAX_PROFILE_BYTES) throw new Error(`${path} is not a safe bounded profile file`);
+	if (!stat.isFile() || stat.isSymbolicLink() || stat.size > MAX_PROFILE_BYTES)
+		throw new Error(`${path} is not a safe bounded profile file`);
 	return decodeProfiles(readFileSync(path, "utf8"));
 }
 
@@ -93,8 +104,12 @@ function loadDefaultProfile(cwd: string, projectTrusted: boolean): string | unde
 		const stat = lstatSync(path);
 		if (!stat.isFile() || stat.isSymbolicLink() || stat.size > 1024 * 1024) return undefined;
 		const value = JSON.parse(readFileSync(path, "utf8")) as { schemaVersion?: unknown; defaultProfile?: unknown };
-		return value.schemaVersion === 1 && typeof value.defaultProfile === "string" && PROFILE_NAME.test(value.defaultProfile) ? value.defaultProfile : undefined;
-	} catch { return undefined; }
+		return value.schemaVersion === 1 && typeof value.defaultProfile === "string" && PROFILE_NAME.test(value.defaultProfile)
+			? value.defaultProfile
+			: undefined;
+	} catch {
+		return undefined;
+	}
 }
 
 function loadLastProfile(agentDir: string): string | undefined {
@@ -105,22 +120,28 @@ function loadLastProfile(agentDir: string): string | undefined {
 		if (!stat.isFile() || stat.isSymbolicLink() || stat.size > 4_096) return undefined;
 		const value = JSON.parse(readFileSync(path, "utf8")) as { name?: unknown };
 		return typeof value.name === "string" && PROFILE_NAME.test(value.name) ? value.name : undefined;
-	} catch { return undefined; }
+	} catch {
+		return undefined;
+	}
 }
 
-function saveLastProfile(agentDir: string, name: string | undefined): void {
+async function saveLastProfile(agentDir: string, name: string | undefined): Promise<void> {
 	mkdirSync(agentDir, { recursive: true, mode: 0o700 });
 	const path = join(agentDir, LAST_PROFILE_FILE);
-	if (!name) { rmSync(path, { force: true }); return; }
-	if (existsSync(path) && lstatSync(path).isSymbolicLink()) throw new Error("last-profile state is a symlink");
-	const temporary = `${path}.${process.pid}.${randomUUID()}.tmp`;
-	try { writeFileSync(temporary, `${JSON.stringify({ name })}\n`, { flag: "wx", mode: 0o600 }); renameSync(temporary, path); }
-	finally { rmSync(temporary, { force: true }); }
+	if (!name) {
+		rmSync(path, { force: true });
+		return;
+	}
+	await writeJsonAtomic(path, { name }, { mode: 0o600 });
 }
 
 function matchesPattern(value: string, pattern: string): boolean {
 	const escaped = pattern.replace(/[.+^${}()|[\]\\]/g, "\\$&").replaceAll("*", ".*");
-	try { return new RegExp(`^${escaped}$`).test(value); } catch { return false; }
+	try {
+		return new RegExp(`^${escaped}$`).test(value);
+	} catch {
+		return false;
+	}
 }
 
 interface OriginalState {
@@ -147,15 +168,19 @@ export function registerProfiles(pi: ExtensionAPI): void {
 	}
 
 	async function apply(name: string, profile: Profile, ctx: ExtensionContext, persist = true): Promise<void> {
-		if (!original) original = { model: ctx.model, thinkingLevel: pi.getThinkingLevel(), tools: pi.getActiveTools(), themeName: ctx.ui.theme.name };
+		if (!original)
+			original = { model: ctx.model, thinkingLevel: pi.getThinkingLevel(), tools: pi.getActiveTools(), themeName: ctx.ui.theme.name };
 		applyingModel = true;
 		try {
 			if (profile.provider && profile.model) {
 				const model = ctx.modelRegistry.find(profile.provider, profile.model);
 				if (!model) ctx.ui.notify(`Profile "${name}": model ${profile.provider}/${profile.model} not found`, "warning");
-				else if (!await pi.setModel(model)) ctx.ui.notify(`Profile "${name}": credentials unavailable for ${profile.provider}/${profile.model}`, "warning");
+				else if (!(await pi.setModel(model)))
+					ctx.ui.notify(`Profile "${name}": credentials unavailable for ${profile.provider}/${profile.model}`, "warning");
 			}
-		} finally { applyingModel = false; }
+		} finally {
+			applyingModel = false;
+		}
 		if (profile.thinkingLevel) pi.setThinkingLevel(profile.thinkingLevel);
 		if (profile.tools?.length) {
 			const available = new Set(pi.getAllTools().map((tool) => tool.name));
@@ -171,7 +196,11 @@ export function registerProfiles(pi: ExtensionAPI): void {
 		activeName = name;
 		activeProfile = profile;
 		if (persist) {
-			try { saveLastProfile(agentDir, name); } catch (error) { ctx.ui.notify(error instanceof Error ? error.message : String(error), "warning"); }
+			try {
+				await saveLastProfile(agentDir, name);
+			} catch (error) {
+				ctx.ui.notify(error instanceof Error ? error.message : String(error), "warning");
+			}
 			persistState(name);
 		}
 		setStatus(ctx);
@@ -190,28 +219,46 @@ export function registerProfiles(pi: ExtensionAPI): void {
 			}
 		}
 		original = undefined;
-		try { saveLastProfile(agentDir, undefined); } catch (error) { ctx.ui.notify(error instanceof Error ? error.message : String(error), "warning"); }
+		try {
+			await saveLastProfile(agentDir, undefined);
+		} catch (error) {
+			ctx.ui.notify(error instanceof Error ? error.message : String(error), "warning");
+		}
 		persistState(undefined);
 		setStatus(ctx);
 	}
 
 	async function choose(ctx: ExtensionContext): Promise<void> {
 		const names = Object.keys(profiles).sort();
-		if (names.length === 0) { ctx.ui.notify("No profiles defined", "warning"); return; }
+		if (names.length === 0) {
+			ctx.ui.notify("No profiles defined", "warning");
+			return;
+		}
 		const none = "(none)";
 		const selected = await ctx.ui.select("Select profile", [none, ...names]);
 		if (!selected) return;
-		if (selected === none) { await clear(ctx); ctx.ui.notify("Profile cleared", "info"); return; }
+		if (selected === none) {
+			await clear(ctx);
+			ctx.ui.notify("Profile cleared", "info");
+			return;
+		}
 		await apply(selected, profiles[selected]!, ctx);
 		ctx.ui.notify(`Profile "${selected}" activated`, "info");
 	}
 
 	async function cycle(ctx: ExtensionContext): Promise<void> {
-		if (Object.keys(profiles).length === 0) { ctx.ui.notify("No profiles defined", "warning"); return; }
+		if (Object.keys(profiles).length === 0) {
+			ctx.ui.notify("No profiles defined", "warning");
+			return;
+		}
 		const values = [undefined, ...Object.keys(profiles).sort()];
 		const index = values.indexOf(activeName);
 		const next = values[(index + 1) % values.length];
-		if (!next) { await clear(ctx); ctx.ui.notify("Profile cleared", "info"); return; }
+		if (!next) {
+			await clear(ctx);
+			ctx.ui.notify("Profile cleared", "info");
+			return;
+		}
 		await apply(next, profiles[next]!, ctx);
 		ctx.ui.notify(`Profile "${next}" activated`, "info");
 	}
@@ -220,14 +267,23 @@ export function registerProfiles(pi: ExtensionAPI): void {
 	pi.registerCommand("profile", {
 		description: "Switch Packed profile",
 		getArgumentCompletions(prefix) {
-			const matches = Object.keys(profiles).sort().filter((name) => name.startsWith(prefix)).map((name) => ({ value: name, label: name }));
+			const matches = Object.keys(profiles)
+				.sort()
+				.filter((name) => name.startsWith(prefix))
+				.map((name) => ({ value: name, label: name }));
 			return matches.length ? matches : null;
 		},
 		async handler(args, ctx) {
 			const name = args.trim();
-			if (!name) { await choose(ctx); return; }
+			if (!name) {
+				await choose(ctx);
+				return;
+			}
 			const profile = profiles[name];
-			if (!profile) { ctx.ui.notify(`Unknown profile "${name}"`, "error"); return; }
+			if (!profile) {
+				ctx.ui.notify(`Unknown profile "${name}"`, "error");
+				return;
+			}
 			await apply(name, profile, ctx);
 			ctx.ui.notify(`Profile "${name}" activated`, "info");
 		},
@@ -237,15 +293,26 @@ export function registerProfiles(pi: ExtensionAPI): void {
 	pi.on("model_select", (event, ctx) => {
 		if (applyingModel || event.source === "restore" || !activeProfile?.allowedModels?.length) return;
 		const selected = `${event.model.provider}/${event.model.id}`;
-		if (!activeProfile.allowedModels.some((pattern) => matchesPattern(selected, pattern))) ctx.ui.notify(`${selected} is outside profile "${activeName}" allowedModels`, "warning");
+		if (!activeProfile.allowedModels.some((pattern) => matchesPattern(selected, pattern)))
+			ctx.ui.notify(`${selected} is outside profile "${activeName}" allowedModels`, "warning");
 	});
-	pi.on("before_agent_start", (event) => activeProfile?.instructions ? { systemPrompt: `${event.systemPrompt}\n\n${activeProfile.instructions}` } : undefined);
+	pi.on("before_agent_start", (event) =>
+		activeProfile?.instructions ? { systemPrompt: `${event.systemPrompt}\n\n${activeProfile.instructions}` } : undefined,
+	);
 	pi.on("session_start", async (event, ctx) => {
-		try { profiles = loadProfiles(agentDir, ctx.cwd, ctx.isProjectTrusted()); }
-		catch (error) { profiles = {}; ctx.ui.notify(`Profile configuration rejected: ${error instanceof Error ? error.message : String(error)}`, "error"); }
+		try {
+			profiles = loadProfiles(agentDir, ctx.cwd, ctx.isProjectTrusted());
+		} catch (error) {
+			profiles = {};
+			ctx.ui.notify(`Profile configuration rejected: ${error instanceof Error ? error.message : String(error)}`, "error");
+		}
 		const flag = pi.getFlag("profile");
 		if (typeof flag === "string" && flag) {
-			if (!profiles[flag]) { ctx.ui.notify(`Unknown profile "${flag}"`, "warning"); setStatus(ctx); return; }
+			if (!profiles[flag]) {
+				ctx.ui.notify(`Unknown profile "${flag}"`, "warning");
+				setStatus(ctx);
+				return;
+			}
 			await apply(flag, profiles[flag]!, ctx);
 			ctx.ui.notify(`Profile "${flag}" activated`, "info");
 			return;
@@ -253,10 +320,18 @@ export function registerProfiles(pi: ExtensionAPI): void {
 		const defaultProfile = loadDefaultProfile(ctx.cwd, ctx.isProjectTrusted());
 		if ((event.reason === "reload" || event.reason === "new") && defaultProfile) {
 			if (profiles[defaultProfile]) await apply(defaultProfile, profiles[defaultProfile]!, ctx, false);
-			else { ctx.ui.notify(`Default profile "${defaultProfile}" is not defined`, "warning"); setStatus(ctx); }
+			else {
+				ctx.ui.notify(`Default profile "${defaultProfile}" is not defined`, "warning");
+				setStatus(ctx);
+			}
 			return;
 		}
-		const state = [...ctx.sessionManager.getEntries()].reverse().find((entry: { type: string; customType?: string }) => entry.type === "custom" && (entry.customType === "profile-state" || entry.customType === "packed-profile-state")) as { data?: { name?: unknown } } | undefined;
+		const state = [...ctx.sessionManager.getEntries()]
+			.reverse()
+			.find(
+				(entry: { type: string; customType?: string }) =>
+					entry.type === "custom" && (entry.customType === "profile-state" || entry.customType === "packed-profile-state"),
+			) as { data?: { name?: unknown } } | undefined;
 		if (state) {
 			if (typeof state.data?.name === "string" && profiles[state.data.name]) {
 				activeName = state.data.name;
@@ -267,12 +342,17 @@ export function registerProfiles(pi: ExtensionAPI): void {
 		}
 		if (defaultProfile) {
 			if (profiles[defaultProfile]) await apply(defaultProfile, profiles[defaultProfile]!, ctx, false);
-			else { ctx.ui.notify(`Default profile "${defaultProfile}" is not defined`, "warning"); setStatus(ctx); }
+			else {
+				ctx.ui.notify(`Default profile "${defaultProfile}" is not defined`, "warning");
+				setStatus(ctx);
+			}
 			return;
 		}
 		const last = loadLastProfile(agentDir);
-		if (last && profiles[last]) { await apply(last, profiles[last]!, ctx, false); ctx.ui.notify(`Profile "${last}" restored`, "info"); }
-		else {
+		if (last && profiles[last]) {
+			await apply(last, profiles[last]!, ctx, false);
+			ctx.ui.notify(`Profile "${last}" restored`, "info");
+		} else {
 			if (last) ctx.ui.notify(`Last active profile "${last}" no longer exists`, "warning");
 			setStatus(ctx);
 		}

package/extension/src/resource-config.ts

@@ -17,8 +17,7 @@ import type { ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
 import { rawKeyHint } from "@earendil-works/pi-coding-agent";
 import { Input, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import type { Component } from "malevich-tui-components";
-import type { PackageResources, ResourceField } from "./packed.js";
-import type { Natives } from "./packed.js";
+import type { Natives, PackageResources, ResourceField } from "./packed.js";
 import { packagePermissionDecision } from "./permission.js";
 import { confirmReload } from "./reload.js";
 import type { TabHost } from "./tab-host.js";
@@ -39,7 +38,8 @@ export function flatten(groups: PackageResources[], scope: Scope): FlatItem[] {
 	const items: FlatItem[] = [];
 	for (const group of groups) {
 		for (const field of RESOURCE_FIELDS) {
-			for (const item of group[field]) items.push({ scope, source: group.source, packageName: group.name, field, path: item.path, enabled: item.enabled });
+			for (const item of group[field])
+				items.push({ scope, source: group.source, packageName: group.name, field, path: item.path, enabled: item.enabled });
 		}
 	}
 	return items.sort((a, b) => a.packageName.localeCompare(b.packageName) || a.field.localeCompare(b.field) || a.path.localeCompare(b.path));
@@ -77,10 +77,17 @@ export type ToggleOutcome = "toggled" | "cancelled" | "failed";
  * actually reached the daemon. Extracted from the render loop so this
  * approve-then-mutate decision is directly testable without faking a full
  * ctx.ui.custom interaction. */
-export async function applyResourceToggle(item: FlatItem, natives: Pick<Natives, "security" | "toggleResource">, ctx: ExtensionCommandContext): Promise<ToggleOutcome> {
+export async function applyResourceToggle(
+	item: FlatItem,
+	natives: Pick<Natives, "security" | "toggleResource">,
+	ctx: ExtensionCommandContext,
+): Promise<ToggleOutcome> {
 	const nextEnabled = !item.enabled;
 	const approved = await approveToggle(natives, ctx, item, nextEnabled);
-	if (!approved) { ctx.ui.notify("toggle cancelled", "warning"); return "cancelled"; }
+	if (!approved) {
+		ctx.ui.notify("toggle cancelled", "warning");
+		return "cancelled";
+	}
 	try {
 		await natives.toggleResource(item.source, item.field, item.path, nextEnabled, item.scope === "project" ? ctx.cwd : undefined, true);
 		return "toggled";
@@ -106,7 +113,10 @@ export async function handleResourceConfigCommand(
 	return true;
 }
 
-interface Theme { fg(color: string, s: string): string; bold(s: string): string; }
+interface Theme {
+	fg(color: string, s: string): string;
+	bold(s: string): string;
+}
 
 /** /packed's Config tab -- a real Component, not its own ctx.ui.custom
  * overlay. Each toggle's reload decision (confirmReload) fires
@@ -129,6 +139,7 @@ export class ConfigTab implements Component {
 	constructor(
 		private readonly natives: Pick<Natives, "listResources" | "security" | "toggleResource">,
 		private readonly host: TabHost,
+		// biome-ignore lint/correctness/noUnusedPrivateClassMembers: read via `const { theme } = this` in render(), which Biome's usage check doesn't trace
 		private readonly theme: Theme,
 		initialFilter?: string,
 	) {
@@ -167,10 +178,20 @@ export class ConfigTab implements Component {
 		const scopeLabel = theme.bold(this.scope === "project" ? "Project Resources" : "Global Resources");
 		const hint = this.searchActive
 			? rawKeyHint("esc", "clear")
-			: rawKeyHint("space", "toggle") + theme.fg("muted", " · ") + rawKeyHint("/", "filter") + theme.fg("muted", " · ") + rawKeyHint("v", "scope") + theme.fg("muted", " · ") + rawKeyHint("r", "refresh");
+			: rawKeyHint("space", "toggle") +
+				theme.fg("muted", " · ") +
+				rawKeyHint("/", "filter") +
+				theme.fg("muted", " · ") +
+				rawKeyHint("v", "scope") +
+				theme.fg("muted", " · ") +
+				rawKeyHint("r", "refresh");
 		const spacing = Math.max(1, width - visibleWidth(scopeLabel) - visibleWidth(hint));
 		const line1 = truncateToWidth(`${scopeLabel}${" ".repeat(spacing)}${hint}`, width, "");
-		const line2 = truncateToWidth(theme.fg("muted", `${this.items.length} resource(s) \u00b7 extensions need a reload after a change`), width, "");
+		const line2 = truncateToWidth(
+			theme.fg("muted", `${this.items.length} resource(s) \u00b7 extensions need a reload after a change`),
+			width,
+			"",
+		);
 		const lines = [line1, line2];
 		if (this.searchActive) lines.push(...this.searchInput.render(width));
 		lines.push("");
@@ -197,25 +218,42 @@ export class ConfigTab implements Component {
 	handleInput(raw: string): void {
 		if (this.busy) return;
 		if (this.searchActive) {
-			if (raw === "\x1b") { this.searchActive = false; this.searchInput.setValue?.(""); this.applyFilter(); }
-			else if (raw === "\r") this.searchActive = false;
-			else { this.searchInput.handleInput(raw); this.applyFilter(); }
+			if (raw === "\x1b") {
+				this.searchActive = false;
+				this.searchInput.setValue?.("");
+				this.applyFilter();
+			} else if (raw === "\r") this.searchActive = false;
+			else {
+				this.searchInput.handleInput(raw);
+				this.applyFilter();
+			}
 			this.host.requestRender();
 			return;
 		}
 		switch (raw) {
-			case "\x1b[A": this.selectedIndex = (this.selectedIndex - 1 + this.filtered.length) % Math.max(this.filtered.length, 1); break;
-			case "\x1b[B": this.selectedIndex = (this.selectedIndex + 1) % Math.max(this.filtered.length, 1); break;
+			case "\x1b[A":
+				this.selectedIndex = (this.selectedIndex - 1 + this.filtered.length) % Math.max(this.filtered.length, 1);
+				break;
+			case "\x1b[B":
+				this.selectedIndex = (this.selectedIndex + 1) % Math.max(this.filtered.length, 1);
+				break;
 			case "v": // Tab is now reserved globally for sweeping between menus (TabbedContainer)
 				this.scope = this.scope === "global" ? "project" : "global";
 				this.rebuildItems();
 				this.applyFilter();
 				break;
-			case "/": this.searchActive = true; break;
-			case "r": void this.refresh(); return;
+			case "/":
+				this.searchActive = true;
+				break;
+			case "r":
+				void this.refresh();
+				return;
 			case " ":
-			case "\r": void this.toggleSelected(); return;
-			default: return;
+			case "\r":
+				void this.toggleSelected();
+				return;
+			default:
+				return;
 		}
 		this.host.requestRender();
 	}

package/extension/src/security-tui.ts

@@ -7,11 +7,14 @@
  * dialog from any custom overlay, confirmed live as the same "opens a
  * different TUI" complaint the other three tabs had.
  */
+
+import type { SecuritySettings } from "@danypops/packed/protocol";
 import { rawKeyHint } from "@earendil-works/pi-coding-agent";
 import { truncateToWidth } from "@earendil-works/pi-tui";
 import type { Component } from "malevich-tui-components";
-import type { SecuritySettings } from "@danypops/packed/protocol";
+
 type MutationApproval = SecuritySettings["mutationApproval"];
+
 import type { Natives } from "./packed.ts";
 import type { TabHost } from "./tab-host.ts";
 
@@ -20,7 +23,10 @@ const OPTIONS: Array<{ value: MutationApproval; label: string }> = [
 	{ value: "never", label: "Never require mutation approval (unsafe opt-out)" },
 ];
 
-interface Theme { fg(color: string, s: string): string; bold(s: string): string; }
+interface Theme {
+	fg(color: string, s: string): string;
+	bold(s: string): string;
+}
 
 export class SettingsTab implements Component {
 	private current: MutationApproval = "always";
@@ -30,6 +36,7 @@ export class SettingsTab implements Component {
 	constructor(
 		private readonly natives: Pick<Natives, "security" | "setMutationApproval">,
 		private readonly host: TabHost,
+		// biome-ignore lint/correctness/noUnusedPrivateClassMembers: read via `const { theme } = this` in render(), which Biome's usage check doesn't trace
 		private readonly theme: Theme,
 	) {}