@danypops/pi-packed 0.19.4 → 0.19.6

package/extension/src/tool-output.ts

@@ -1,3 +1,4 @@
+import type { PackageSummary as Pkg, PackageInfo as PkgInfo } from "@danypops/packed/protocol";
 import type { AgentToolResult, Theme } from "@earendil-works/pi-coding-agent";
 import { Text, truncateToWidth } from "@earendil-works/pi-tui";
 import {
@@ -10,7 +11,6 @@ import {
 	TOOL_DETAILS_MAX_SERIALIZED_CHARACTERS,
 	TOOL_MODEL_CONTENT_MAX_CHARACTERS,
 } from "./constants.js";
-import type { PackageInfo as PkgInfo, PackageSummary as Pkg } from "@danypops/packed/protocol";
 
 const DETAILS_VERSION = 2 as const;
 const MUTATION_OPERATIONS = new Set(["install", "update", "remove"]);
@@ -149,8 +149,12 @@ export function createInfoDetails(info: PkgInfo): InfoToolDetails {
 			...(info.homepage ? { homepage: safePackageTarget(info.homepage) } : {}),
 			...(info.repository ? { repository: safePackageTarget(info.repository) } : {}),
 			...(info.license ? { license: bounded(info.license, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS) } : {}),
-			keywords: (info.keywords ?? []).slice(0, TOOL_DETAILS_MAX_KEYWORDS).map((keyword) => bounded(keyword, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS)),
-			capabilities: Object.keys(info.pi ?? {}).slice(0, TOOL_DETAILS_MAX_CAPABILITIES).map((name) => bounded(name, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS)),
+			keywords: (info.keywords ?? [])
+				.slice(0, TOOL_DETAILS_MAX_KEYWORDS)
+				.map((keyword) => bounded(keyword, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS)),
+			capabilities: Object.keys(info.pi ?? {})
+				.slice(0, TOOL_DETAILS_MAX_CAPABILITIES)
+				.map((name) => bounded(name, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS)),
 			...(info.publication?.provenanceUrl ? { provenance: safePackageTarget(info.publication.provenanceUrl) } : {}),
 			trustedPublisher: info.publication?.trustedPublisher ?? "unknown",
 		},
@@ -191,7 +195,15 @@ export function parsePackageToolDetails(value: unknown): PackageToolDetails | un
 		const candidate = value as Record<string, unknown>;
 		if (candidate.version !== DETAILS_VERSION || typeof candidate.kind !== "string") return undefined;
 		if (candidate.kind === "search") {
-			if (candidate.operation !== "search" || !isShortString(candidate.query, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS) || typeof candidate.total !== "number" || !Number.isSafeInteger(candidate.total) || candidate.total < 0 || typeof candidate.truncated !== "boolean") return undefined;
+			if (
+				candidate.operation !== "search" ||
+				!isShortString(candidate.query, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS) ||
+				typeof candidate.total !== "number" ||
+				!Number.isSafeInteger(candidate.total) ||
+				candidate.total < 0 ||
+				typeof candidate.truncated !== "boolean"
+			)
+				return undefined;
 			if (!Array.isArray(candidate.items) || candidate.items.length > TOOL_DETAILS_MAX_PACKAGES) return undefined;
 			if (!candidate.items.every((item) => isPackageSummary(item))) return undefined;
 			return value as SearchToolDetails;
@@ -199,8 +211,19 @@ export function parsePackageToolDetails(value: unknown): PackageToolDetails | un
 		if (candidate.kind === "info") {
 			if (candidate.operation !== "info" || !candidate.package || typeof candidate.package !== "object") return undefined;
 			const pkg = candidate.package as Record<string, unknown>;
-			if (!isPackageSummary(pkg) || !Array.isArray(pkg.keywords) || pkg.keywords.length > TOOL_DETAILS_MAX_KEYWORDS || !pkg.keywords.every((item) => isShortString(item, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS))) return undefined;
-			if (!Array.isArray(pkg.capabilities) || pkg.capabilities.length > TOOL_DETAILS_MAX_CAPABILITIES || !pkg.capabilities.every((item) => isShortString(item, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS))) return undefined;
+			if (
+				!isPackageSummary(pkg) ||
+				!Array.isArray(pkg.keywords) ||
+				pkg.keywords.length > TOOL_DETAILS_MAX_KEYWORDS ||
+				!pkg.keywords.every((item) => isShortString(item, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS))
+			)
+				return undefined;
+			if (
+				!Array.isArray(pkg.capabilities) ||
+				pkg.capabilities.length > TOOL_DETAILS_MAX_CAPABILITIES ||
+				!pkg.capabilities.every((item) => isShortString(item, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS))
+			)
+				return undefined;
 			for (const field of ["homepage", "repository", "license", "provenance"] as const) {
 				if (pkg[field] !== undefined && !isShortString(pkg[field])) return undefined;
 			}
@@ -210,7 +233,8 @@ export function parsePackageToolDetails(value: unknown): PackageToolDetails | un
 		if (candidate.kind === "mutation") {
 			if (typeof candidate.operation !== "string" || !MUTATION_OPERATIONS.has(candidate.operation)) return undefined;
 			if (typeof candidate.status !== "string" || !MUTATION_STATUSES.has(candidate.status)) return undefined;
-			if (!isShortString(candidate.target) || !isShortString(candidate.output) || typeof candidate.reloadRequired !== "boolean") return undefined;
+			if (!isShortString(candidate.target) || !isShortString(candidate.output) || typeof candidate.reloadRequired !== "boolean")
+				return undefined;
 			return value as MutationToolDetails;
 		}
 	} catch {
@@ -222,15 +246,21 @@ export function parsePackageToolDetails(value: unknown): PackageToolDetails | un
 function isPackageSummary(value: unknown): boolean {
 	if (!value || typeof value !== "object") return false;
 	const item = value as Record<string, unknown>;
-	return isShortString(item.name, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS)
-		&& isShortString(item.version, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS)
-		&& isShortString(item.description, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS)
-		&& typeof item.shape === "string" && PACKAGE_SHAPES.has(item.shape)
-		&& typeof item.verified === "boolean";
+	return (
+		isShortString(item.name, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS) &&
+		isShortString(item.version, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS) &&
+		isShortString(item.description, TOOL_DETAILS_MAX_DESCRIPTION_CHARACTERS) &&
+		typeof item.shape === "string" &&
+		PACKAGE_SHAPES.has(item.shape) &&
+		typeof item.verified === "boolean"
+	);
 }
 
 function contentFallback(result: AgentToolResult<unknown>): string {
-	return result.content.filter((item) => item.type === "text").map((item) => item.text).join("\n");
+	return result.content
+		.filter((item) => item.type === "text")
+		.map((item) => item.text)
+		.join("\n");
 }
 
 export function renderPackageToolCall(label: string, args: Record<string, unknown>, theme: Theme) {
@@ -255,9 +285,13 @@ export function renderPackageToolResult(
 				const heading = `${theme.bold(String(details.total))} packages · showing ${details.items.length}${details.truncated ? " · bounded" : ""}`;
 				const rows = shown.map((pkg) => {
 					const evidence = pkg.verified ? ` [verified ${pkg.shape}]` : " [keyword candidate]";
-					return truncateToWidth(`${theme.fg("accent", `${pkg.name}@${pkg.version}`)}${theme.fg("muted", evidence)}${options.expanded && pkg.description ? ` — ${pkg.description}` : ""}`, safeWidth);
+					return truncateToWidth(
+						`${theme.fg("accent", `${pkg.name}@${pkg.version}`)}${theme.fg("muted", evidence)}${options.expanded && pkg.description ? ` — ${pkg.description}` : ""}`,
+						safeWidth,
+					);
 				});
-				if (!options.expanded && details.items.length > shown.length) rows.push(theme.fg("muted", `… ${details.items.length - shown.length} more`));
+				if (!options.expanded && details.items.length > shown.length)
+					rows.push(theme.fg("muted", `… ${details.items.length - shown.length} more`));
 				return [truncateToWidth(heading, safeWidth), ...rows];
 			}
 			if (details.kind === "info") {
@@ -276,9 +310,7 @@ export function renderPackageToolResult(
 				return lines.filter(Boolean).map((line) => truncateToWidth(line, safeWidth));
 			}
 			const statusColor = details.status === "succeeded" ? "success" : "warning";
-			const lines = [
-				`${theme.fg(statusColor, details.status === "succeeded" ? "✓" : "○")} ${details.operation} ${details.target}`,
-			];
+			const lines = [`${theme.fg(statusColor, details.status === "succeeded" ? "✓" : "○")} ${details.operation} ${details.target}`];
 			if (options.expanded && details.output) lines.push(details.output);
 			if (details.reloadRequired) lines.push(theme.fg("warning", "Reload Pi with /reload to activate the update."));
 			return lines.map((line) => truncateToWidth(line, safeWidth));

package/extension/src/tools.ts

@@ -1,17 +1,17 @@
 /** Agent-facing package tools over the authenticated daemon. */
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
 import { Type } from "typebox";
-import { packagePermissionDecision, type PackageOperation } from "./permission.js";
-import { InstallServiceError, PI_COMMAND_NAME, type Natives } from "./packed.js";
+import { InstallServiceError, type Natives, PI_COMMAND_NAME } from "./packed.js";
+import { type PackageOperation, packagePermissionDecision } from "./permission.js";
 import { reloadWarning } from "./reload.js";
 import {
 	createInfoDetails,
 	createModelContent,
 	createMutationDetails,
 	createSearchDetails,
+	type PackageToolDetails,
 	renderPackageToolCall,
 	renderPackageToolResult,
-	type PackageToolDetails,
 } from "./tool-output.js";
 
 function text(value: string, details: PackageToolDetails) {
@@ -44,7 +44,9 @@ export async function approvePackageOperation(
 		`${operation[0]!.toUpperCase()}${operation.slice(1)} Pi package`,
 		`Run: ${command}\n\nThis operation can execute package code or mutate Pi settings/install roots. ${reloadWarning(operation)} Continue?`,
 	);
-	return approved ? { allowed: true, approved: true } : { allowed: false, approved: false, reason: "cancelled", message: `${operation} cancelled by user.` };
+	return approved
+		? { allowed: true, approved: true }
+		: { allowed: false, approved: false, reason: "cancelled", message: `${operation} cancelled by user.` };
 }
 
 export async function installPackageWithPolicy(
@@ -57,7 +59,7 @@ export async function installPackageWithPolicy(
 		const output = approval.message ?? "install denied";
 		return text(output, createMutationDetails("install", source, approval.reason ?? "denied", output));
 	}
-	let output = await natives.install(source, approval.approved) || `Installed ${source}. Reload with /reload to activate.`;
+	let output = (await natives.install(source, approval.approved)) || `Installed ${source}. Reload with /reload to activate.`;
 	// Piggybacks on the same approval already granted for install -- both are
 	// the same code-execution mutation tier, not a new consent surface. Silent
 	// for the overwhelmingly common case (most Pi packages aren't daemons at
@@ -77,11 +79,7 @@ export async function installPackageWithPolicy(
 	return text(output, createMutationDetails("install", source, "succeeded", output));
 }
 
-export async function updatePackageWithPolicy(
-	source: string,
-	natives: Pick<Natives, "security" | "update">,
-	ctx: ApprovalContext,
-) {
+export async function updatePackageWithPolicy(source: string, natives: Pick<Natives, "security" | "update">, ctx: ApprovalContext) {
 	const approval = await approvePackageOperation("update", `pi update --extension ${source}`, natives, ctx);
 	if (!approval.allowed) {
 		const output = approval.message ?? "update denied";
@@ -101,17 +99,13 @@ export async function updatePackageWithPolicy(
 	return text(message, createMutationDetails("update", source, "succeeded", outcome.output || message, true));
 }
 
-export async function removePackageWithPolicy(
-	name: string,
-	natives: Pick<Natives, "security" | "remove">,
-	ctx: ApprovalContext,
-) {
+export async function removePackageWithPolicy(name: string, natives: Pick<Natives, "security" | "remove">, ctx: ApprovalContext) {
 	const approval = await approvePackageOperation("remove", `pi remove npm:${name}`, natives, ctx);
 	if (!approval.allowed) {
 		const output = approval.message ?? "remove denied";
 		return text(output, createMutationDetails("remove", name, approval.reason ?? "denied", output));
 	}
-	const output = await natives.remove(name, approval.approved) || `Removed ${name}. Reload with /reload to deactivate.`;
+	const output = (await natives.remove(name, approval.approved)) || `Removed ${name}. Reload with /reload to deactivate.`;
 	return text(output, createMutationDetails("remove", name, "succeeded", output));
 }
 
@@ -124,8 +118,12 @@ export function registerTools(pi: ExtensionAPI, natives: Natives): void {
 			query: Type.String({ description: "Search terms, e.g. 'lsp' or 'telegram'" }),
 			limit: Type.Optional(Type.Number({ description: "Max results (default 10, max 50)" })),
 		}),
-		renderCall(args, theme) { return renderPackageToolCall("Search packages", args, theme); },
-		renderResult(result, options, theme, context) { return renderPackageToolResult(result, options, theme, context); },
+		renderCall(args, theme) {
+			return renderPackageToolCall("Search packages", args, theme);
+		},
+		renderResult(result, options, theme, context) {
+			return renderPackageToolResult(result, options, theme, context);
+		},
 		async execute(_id, params) {
 			try {
 				const response = await natives.search(params.query, params.limit ?? 10);
@@ -144,8 +142,12 @@ export function registerTools(pi: ExtensionAPI, natives: Natives): void {
 		label: "Pi Package Info",
 		description: `Show bounded metadata and declared Pi resources for one package. Special case: querying ${PI_COMMAND_NAME} (Pi itself) also reports the locally running version against the latest published release -- a different question from, and in addition to, the generic npm registry metadata every other package gets.`,
 		parameters: Type.Object({ name: Type.String({ description: "npm package name" }) }),
-		renderCall(args, theme) { return renderPackageToolCall("Package info", args, theme); },
-		renderResult(result, options, theme, context) { return renderPackageToolResult(result, options, theme, context); },
+		renderCall(args, theme) {
+			return renderPackageToolCall("Package info", args, theme);
+		},
+		renderResult(result, options, theme, context) {
+			return renderPackageToolResult(result, options, theme, context);
+		},
 		async execute(_id, params) {
 			try {
 				const info = await natives.info(params.name);
@@ -165,11 +167,12 @@ export function registerTools(pi: ExtensionAPI, natives: Natives): void {
 				if (params.name === PI_COMMAND_NAME) {
 					const status = await natives.piStatus().catch(() => undefined);
 					if (status?.current) {
-						const comparison = status.latest === undefined
-							? "latest release unknown"
-							: status.upToDate === false
-								? `behind -- latest is ${status.latest}, run pi update --self`
-								: `up to date with the latest ${status.latest}`;
+						const comparison =
+							status.latest === undefined
+								? "latest release unknown"
+								: status.upToDate === false
+									? `behind -- latest is ${status.latest}, run pi update --self`
+									: `up to date with the latest ${status.latest}`;
 						lines.push(`--- Pi runtime (not npm registry data) ---`, `currently running: ${status.current}`, comparison);
 					}
 				}
@@ -185,8 +188,12 @@ export function registerTools(pi: ExtensionAPI, natives: Natives): void {
 		label: "Pi Package Install",
 		description: "Install a Pi package through the authenticated daemon. Operation-aware approval is secure by default.",
 		parameters: Type.Object({ source: Type.String({ description: "npm:, git:, or https source" }) }),
-		renderCall(args, theme) { return renderPackageToolCall("Install package", args, theme); },
-		renderResult(result, options, theme, context) { return renderPackageToolResult(result, options, theme, context); },
+		renderCall(args, theme) {
+			return renderPackageToolCall("Install package", args, theme);
+		},
+		renderResult(result, options, theme, context) {
+			return renderPackageToolResult(result, options, theme, context);
+		},
 		async execute(_id, params, _signal, _onUpdate, ctx) {
 			return installPackageWithPolicy(params.source, natives, ctx);
 		},
@@ -197,8 +204,12 @@ export function registerTools(pi: ExtensionAPI, natives: Natives): void {
 		label: "Pi Package Update",
 		description: "Update one configured Pi package through Pi's documented update command. Operation-aware approval is secure by default.",
 		parameters: Type.Object({ source: Type.String({ description: "configured npm:, git:, or https source" }) }),
-		renderCall(args, theme) { return renderPackageToolCall("Update package", args, theme); },
-		renderResult(result, options, theme, context) { return renderPackageToolResult(result, options, theme, context); },
+		renderCall(args, theme) {
+			return renderPackageToolCall("Update package", args, theme);
+		},
+		renderResult(result, options, theme, context) {
+			return renderPackageToolResult(result, options, theme, context);
+		},
 		async execute(_id, params, _signal, _onUpdate, ctx) {
 			return updatePackageWithPolicy(params.source, natives, ctx);
 		},
@@ -209,8 +220,12 @@ export function registerTools(pi: ExtensionAPI, natives: Natives): void {
 		label: "Pi Package Remove",
 		description: "Remove an installed npm Pi package through the authenticated daemon. Operation-aware approval is secure by default.",
 		parameters: Type.Object({ name: Type.String({ description: "bare npm name, e.g. pi-lsp or @scope/pkg" }) }),
-		renderCall(args, theme) { return renderPackageToolCall("Remove package", args, theme); },
-		renderResult(result, options, theme, context) { return renderPackageToolResult(result, options, theme, context); },
+		renderCall(args, theme) {
+			return renderPackageToolCall("Remove package", args, theme);
+		},
+		renderResult(result, options, theme, context) {
+			return renderPackageToolResult(result, options, theme, context);
+		},
 		async execute(_id, params, _signal, _onUpdate, ctx) {
 			return removePackageWithPolicy(params.name, natives, ctx);
 		},