@danypops/pi-packed 0.18.0 → 0.19.2

package/README.md

@@ -10,7 +10,7 @@ The extension connects to Packed's authenticated user daemon and starts the pack
 
 ## Commands
 
-- `/packed` -- one floating overlay, four tabs (Packages/Find/Config/Settings), always shown in a persistent tab bar at the top, each label's own first letter highlighted as its mnemonic. `Tab`/`Shift-Tab` (or `←`/`→`) sweep between them; from any tab other than Packages, `p`/`f`/`c`/`s` also jump straight to the matching one (never stolen while that tab's own filter/query box is capturing text). `Esc` returns to Packages from anywhere else, or closes the panel from Packages itself. Every approval and reload confirmation, on any tab, renders inline on this same panel (`y`/`n` keys), never a separate popup or native dialog. A standing test (`keymap.test.ts`, using Malevich's tree-style `findMnemonicConflicts`) verifies no two actions genuinely reachable at once share a key.
+- `/packed` -- one floating overlay, four tabs (Packages/Find/Config/Settings), always shown in a persistent tab bar at the top: the focused tab is real reverse-video (guaranteed visible contrast on any theme, unlike a specific configured background color), unfocused tabs show only a foreground color, and each label's own first letter is highlighted as its mnemonic on both. `Tab`/`Shift-Tab` (or `←`/`→`) sweep between them -- recognized under legacy CSI, xterm's modifyOtherKeys, and the Kitty keyboard protocol alike, not just one hardcoded encoding; from any tab other than Packages, `p`/`f`/`c`/`s` also jump straight to the matching one (never stolen while that tab's own filter/query box is capturing text). `Esc` returns to Packages from anywhere else, or closes the panel from Packages itself. Every approval and reload confirmation, on any tab, renders inline on this same panel (`y`/`n` keys), never a separate popup or native dialog. A standing test (`keymap.test.ts`, using Malevich's tree-style `findMnemonicConflicts`) verifies no two actions genuinely reachable at once share a key.
   - **Packages** (the default tab) -- every installed Pi package, with update availability. Mnemonics follow lazy.nvim's own convention (uppercase acts on every row, lowercase on the one under the cursor):
     - `u` / `U` -- update the selected package / update every outdated package, one combined confirmation and one reload. `U` shows a spinner inline next to the package currently updating, settling into a real ✓ or ✗ plus a short tail of that update's own captured output once it finishes -- the list stays visible throughout, nothing swaps to a separate screen. A reload is confirmed separately from the update itself -- decline it to defer: the update already happened, only picking it up in this Pi session is deferred until `/reload`.
     - `x` -- remove the selected package.

package/extension/src/menu-theme.ts

@@ -31,12 +31,18 @@ export function dialogTheme(theme: Theme): DialogTheme {
  * overlay, replacing what used to be four separately-opened screens. */
 export function tabBarTheme(theme: Theme): TabBarTheme {
 	return {
-		tab: (s) => theme.fg("muted", s),
-		activeTab: (s) => theme.bold(theme.fg("accent", s)),
+		// Matches pi-tickets' own TabMenu convention (tab/activeTab, same
+		// reverse-video choice) rather than inventing a new one: real ANSI
+		// reverse-video for the focused tab, since a theme's own selectedBg
+		// can be too close in luminance to the surrounding UI to read as a
+		// highlight at all -- reverse video swaps whatever foreground and
+		// background are already in effect, guaranteeing contrast on any theme.
+		tab: (s) => theme.fg("dim", s),
+		activeTab: (s) => theme.inverse(s),
 		// Every tab's first letter is a jump mnemonic (p/f/c/s) -- a distinct
 		// warning-colored bold, so it reads as "press this letter" on both the
-		// active and inactive tabs alike, not just whichever accent color
-		// activeTab already uses for the whole label.
+		// active and inactive tabs alike, not just whichever style tab/activeTab
+		// already applies to the whole label.
 		mnemonic: (s) => theme.bold(theme.fg("warning", s)),
 	};
 }

package/extension/src/tui.ts

@@ -46,7 +46,7 @@
  */
 import type { ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
 import { DynamicBorder, rawKeyHint } from "@earendil-works/pi-coding-agent";
-import { Container, Input, Spacer, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
+import { Container, Input, matchesKey, Spacer, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import { Dialog, Envelope, Menu, Spinner, Table, TabbedContainer, type Component, type MenuItem, type TextMeasure } from "malevich-tui-components";
 import { filterRows, mergeRows, nextMode, visibleRows } from "./model.js";
 import type { Row, ViewMode } from "./model.js";
@@ -779,6 +779,13 @@ function renderUnifiedPanel(
 			],
 			theme: tabBarTheme(theme),
 			initialKey: initialTab,
+			// Malevich's own default matcher only recognizes legacy CSI sequences;
+			// pi-tui's real matchesKey also covers the Kitty keyboard protocol and
+			// xterm's modifyOtherKeys encodings for the same keys. Malevich's
+			// KeyMatcher type takes a bare string (it doesn't share pi-tui's KeyId
+			// union), so this only ever forwards the small fixed set of key names
+			// TabbedContainer itself actually calls with (left/right/tab/shift+tab).
+			matchesKey: (data, keyId) => matchesKey(data, keyId as Parameters<typeof matchesKey>[1]),
 		});
 
 		// measure must be explicit: Envelope's own default is ASCII-only (raw
@@ -822,13 +829,18 @@ function renderUnifiedPanel(
 				// Tab/Shift-Tab always sweep between menus -- nothing needs a literal
 				// Tab character for itself (Packages'/Config's own former Tab bindings
 				// moved to v once Tab was claimed globally; see the mnemonics.test.ts
-				// conflict check for why that reassignment was necessary).
-				if (data === "\t" || data === "\x1b[Z") {
+				// conflict check for why that reassignment was necessary). Real
+				// matchesKey(), not a hardcoded "\x1b[Z" literal, because Shift-Tab has
+				// no single universal encoding: legacy terminals send CSI Z, but the
+				// Kitty keyboard protocol and xterm's modifyOtherKeys mode both send a
+				// different sequence for the same keypress -- a literal check silently
+				// misses whichever ones it doesn't happen to be pinned to.
+				if (matchesKey(data, "tab") || matchesKey(data, "shift+tab")) {
 					tabbedContainer.handleInput(data);
 					tui.requestRender();
 					return;
 				}
-				if ((data === "\x1b[C" || data === "\x1b[D") && !(activeTab.capturesHorizontalArrows?.() ?? false)) {
+				if ((matchesKey(data, "right") || matchesKey(data, "left")) && !(activeTab.capturesHorizontalArrows?.() ?? false)) {
 					tabbedContainer.handleInput(data); // owns Left/Right cycling itself
 					tui.requestRender();
 					return;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/pi-packed",
-  "version": "0.18.0",
+  "version": "0.19.2",
   "description": "Pi package tools, commands, profiles, and TUI for the Packed daemon",
   "type": "module",
   "keywords": ["pi-package"],