@danypops/pi-packed 0.13.1 → 0.14.0

package/README.md

@@ -11,7 +11,7 @@ The extension connects to Packed's authenticated user daemon and starts the pack
 ## Commands
 
 - `/packed` -- a floating overlay panel: every installed Pi package, with update availability. Mnemonics follow lazy.nvim's own convention (uppercase acts on every row, lowercase on the one under the cursor):
-  - `u` / `U` -- update the selected package / update every outdated package, one combined confirmation and one reload. `U`'s progress bar appears inline next to the package currently updating -- the list stays visible throughout, nothing swaps to a separate screen.
+  - `u` / `U` -- update the selected package / update every outdated package, one combined confirmation and one reload. `U`'s progress bar appears inline next to the package currently updating -- the list stays visible throughout, nothing swaps to a separate screen. A reload is confirmed separately from the update itself -- decline it to defer: the update already happened, only picking it up in this Pi session is deferred until `/reload`.
   - `x` -- remove the selected package.
   - `d` -- disable (or re-enable) the selected package's own extensions.
   - `c` -- jump to resource config for the selected package (skills, prompts, themes).

package/extension/src/reload.ts

@@ -14,3 +14,28 @@ export function reloadWarning(operation: PackageOperation): string {
 		? "This will require a Pi reload (/reload) to deactivate it."
 		: "This will likely require a Pi reload (/reload) to activate its resources.";
 }
+
+export interface ReloadConfirmContext {
+	hasUI: boolean;
+	ui: { confirm(title: string, message: string): Promise<boolean> };
+}
+
+/**
+ * The second, separate decision point: reloadWarning above is a still-just-
+ * likely warning shown before a mutation runs; this is asked only once the
+ * mutation has actually succeeded and a reload is now definitely needed,
+ * not merely predicted. Declining defers it -- the mutation itself already
+ * happened (the package really did install/update/toggle); only Pi's own
+ * currently-loaded resources are stale until /reload runs later. No-UI
+ * contexts reload immediately: there's no one to ask, and staying silently
+ * stale forever is worse than reloading.
+ *
+ * Extracted from resource-config.ts's own pre-existing pendingReload gate
+ * (the first surface to implement this pattern) so every mutation surface
+ * shares identical wording and behavior instead of drifting apart --
+ * reload.ts's whole reason for existing.
+ */
+export async function confirmReload(ctx: ReloadConfirmContext): Promise<boolean> {
+	if (!ctx.hasUI) return true;
+	return ctx.ui.confirm("Reload Pi now?", "This change only takes effect after a reload.");
+}

package/extension/src/resource-config.ts

@@ -14,6 +14,7 @@ import { Container, Input, Spacer, truncateToWidth, visibleWidth } from "@earend
 import type { PackageResources, ResourceField } from "./packed.js";
 import type { Natives } from "./packed.js";
 import { packagePermissionDecision } from "./permission.js";
+import { confirmReload } from "./reload.js";
 
 type Scope = "global" | "project";
 const RESOURCE_FIELDS = ["extensions", "skills", "prompts", "themes"] as const satisfies readonly ResourceField[];
@@ -132,8 +133,7 @@ export async function showResourceConfig(ctx: ExtensionCommandContext, natives:
 	}
 
 	if (!pendingReload) return;
-	const confirmed = await ctx.ui.confirm("Reload Pi now?", "Extension changes only take effect after a reload.");
-	if (confirmed) await ctx.reload();
+	if (await confirmReload(ctx)) await ctx.reload();
 	else ctx.ui.notify("Extension changes pending -- run /reload when ready.", "warning");
 }
 

package/extension/src/tui.ts

@@ -8,16 +8,22 @@
  * extensions, c jump to full resource config, f find/install new
  * packages, s settings. The panel itself is a real bordered (rounded)
  * floating overlay (`ctx.ui.custom` with overlay:true, Malevich's
- * Envelope for the box), anchored to the top so its header stays put and
- * only the footer moves as content height changes. Enter opens a second,
- * smaller overlay action menu on top of it. U's batch update stays on
+ * Envelope for the box), positioned at 40% of terminal height (pi-tui's
+ * own row percentage, not a fixed row count -- scales with the real
+ * terminal, unlike the anchor:"top-center"+offsetY this replaced, which
+ * was pinned 1 row below the absolute top on any terminal size). Enter
+ * opens a second, smaller overlay action menu on top of it. U's batch update stays on
  * this same package list -- progress renders inline next to the row
  * currently being updated, not as a separate screen. Rows render through
  * Malevich's Table (real column-aligned Package/Version/status cells,
  * per-row selection styling baked into each cell since Table's own
  * cellStyle is column-wide, not row-wide) inside this panel's own
  * scroll-window slice -- Table deliberately owns no pagination of its
- * own, so the visible-window-around-selectedIndex math stays here. All
+ * own, so the visible-window-around-selectedIndex math stays here. Every
+ * mutation that actually changes something asks confirmReload separately
+ * from the earlier mutation-approval confirm -- declining defers the
+ * reload (the mutation itself already happened) and keeps the panel open
+ * with refreshed rows instead of ending the session. All
  * data flows through the packed CLI (thin seam).
  */
 import type { ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
@@ -32,6 +38,7 @@ import { showPackedSettings } from "./security-tui.js";
 import { showResourceConfig, applyResourceToggle } from "./resource-config.js";
 import { showDiscoverPanel } from "./discover.js";
 import { menuTheme } from "./menu-theme.js";
+import { confirmReload } from "./reload.js";
 
 interface PanelAction {
 	type: "update" | "remove" | "disable" | "config" | "find" | "refresh" | "settings";
@@ -41,8 +48,11 @@ interface PanelAction {
 /** Outcome of a confirmed row action, resolved after any real mutation and
  * reload decision -- "changed" means the daemon state changed and Pi has
  * already been reloaded (the caller should stop showing the stale panel);
+ * "deferred" means the mutation itself genuinely happened but the user
+ * declined confirmReload's separate reload gate -- Pi's session is still
+ * alive and the panel should refresh its rows and keep running, not close;
  * "unchanged"/"cancelled" mean the panel keeps running as-is. */
-export type PackageChoiceOutcome = "changed" | "unchanged" | "cancelled";
+export type PackageChoiceOutcome = "changed" | "unchanged" | "cancelled" | "deferred";
 
 export async function applyPackageChoice(
 	choice: string | undefined,
@@ -68,6 +78,10 @@ export async function applyPackageChoice(
 				return "unchanged";
 			}
 			const transition = outcome.previousVersion && outcome.currentVersion ? ` (${outcome.previousVersion} → ${outcome.currentVersion})` : "";
+			if (!(await confirmReload(ctx))) {
+				ctx.ui.notify(`Updated ${row.name}${transition}; reload pending -- run /reload when ready.`, "warning");
+				return "deferred";
+			}
 			ctx.ui.notify(`Updated ${row.name}${transition}; reloading Pi resources.`, "info");
 			await ctx.reload();
 			return "changed";
@@ -84,6 +98,10 @@ export async function applyPackageChoice(
 				return "cancelled";
 			}
 			await natives.remove(row.name, approval.approved);
+			if (!(await confirmReload(ctx))) {
+				ctx.ui.notify(`Removed ${row.name}; reload pending -- run /reload when ready.`, "warning");
+				return "deferred";
+			}
 			ctx.ui.notify(`Removed ${row.name}; reloading Pi resources.`, "info");
 			await ctx.reload();
 			return "changed";
@@ -154,7 +172,12 @@ async function approveAndRunUpdateAll(
 		ctx.ui.notify(failedNames.length > 0 ? `No packages updated; ${failedNames.length} failed.` : "All packages already up to date.", failedNames.length > 0 ? "warning" : "info");
 		return failedNames.length > 0 ? "cancelled" : "unchanged";
 	}
-	ctx.ui.notify(`Updated ${changed} package(s)${failedNames.length > 0 ? `, ${failedNames.length} failed` : ""}; reloading Pi resources.`, "info");
+	const failedSuffix = failedNames.length > 0 ? `, ${failedNames.length} failed` : "";
+	if (!(await confirmReload(ctx))) {
+		ctx.ui.notify(`Updated ${changed} package(s)${failedSuffix}; reload pending -- run /reload when ready.`, "warning");
+		return "deferred";
+	}
+	ctx.ui.notify(`Updated ${changed} package(s)${failedSuffix}; reloading Pi resources.`, "info");
 	await ctx.reload();
 	return "changed";
 }
@@ -237,7 +260,12 @@ export async function applyDisableExtensions(row: Row, natives: Natives, ctx: Ex
 		else if (outcome === "cancelled") return toggled > 0 ? "changed" : "cancelled";
 	}
 	if (toggled === 0) return "unchanged";
-	ctx.ui.notify(`${disabling ? "Disabled" : "Enabled"} ${toggled} extension(s) for ${row.name}; reloading Pi resources.`, "info");
+	const verb = disabling ? "Disabled" : "Enabled";
+	if (!(await confirmReload(ctx))) {
+		ctx.ui.notify(`${verb} ${toggled} extension(s) for ${row.name}; reload pending -- run /reload when ready.`, "warning");
+		return "deferred";
+	}
+	ctx.ui.notify(`${verb} ${toggled} extension(s) for ${row.name}; reloading Pi resources.`, "info");
 	await ctx.reload();
 	return "changed";
 }
@@ -285,6 +313,14 @@ export async function showPackedPanel(ctx: ExtensionCommandContext, natives: Nat
 		return;
 	}
 
+	// A deferred reload means the mutation itself genuinely happened but
+	// ctx.reload() was declined -- the session is still alive, so refresh
+	// rows (real on-disk versions) and keep the panel open, same as "refresh".
+	async function refreshRows(): Promise<void> {
+		({ rows, error } = await loadRows(natives));
+		if (error) ctx.ui.notify(`refresh failed: ${error}`, "error");
+	}
+
 	// Panel loop: actions resolve the component, run outside it, then reopen.
 	// U/updateAll is handled entirely inside renderPanel itself (progress
 	// rendered on the same already-open overlay) and never reaches here.
@@ -293,8 +329,7 @@ export async function showPackedPanel(ctx: ExtensionCommandContext, natives: Nat
 		if (!action) return; // closed
 
 		if (action.type === "refresh") {
-			({ rows, error } = await loadRows(natives));
-			if (error) ctx.ui.notify(`refresh failed: ${error}`, "error");
+			await refreshRows();
 			continue;
 		}
 
@@ -319,11 +354,13 @@ export async function showPackedPanel(ctx: ExtensionCommandContext, natives: Nat
 		if (action.type === "disable") {
 			const outcome = await applyDisableExtensions(row, natives, ctx);
 			if (outcome === "changed") return;
+			if (outcome === "deferred") await refreshRows();
 			continue;
 		}
 
 		const outcome = await applyPackageChoice(action.type === "update" ? `Update to ${row.latest}` : "Remove", row, natives, ctx);
 		if (outcome === "changed") return; // ctx.reload() already replaced the session
+		if (outcome === "deferred") await refreshRows();
 	}
 }
 
@@ -576,5 +613,14 @@ function renderPanel(ctx: ExtensionCommandContext, natives: Natives, initialRows
 				tui.requestRender();
 			},
 		};
-	}, { overlay: true, overlayOptions: { width: "70%", maxHeight: "70%", anchor: "top-center", offsetY: 1 } });
+		// row is a real percentage of terminal height (0%=top, 100%=bottom) --
+		// unlike anchor:"top-center"+offsetY (a fixed row count, effectively
+		// pinned to the very top on any terminal size), this scales with the
+		// actual screen. anchor:"center" still governs horizontal centering
+		// (row overrides only the vertical resolution). Note this isn't fully
+		// content-height-independent -- pi-tui's own row-percentage formula
+		// interpolates over the range of positions that still fit the current
+		// content height, so a shorter/taller row count shifts this somewhat;
+		// only exactly 0%/100% are perfectly jitter-free in that library.
+	}, { overlay: true, overlayOptions: { width: "70%", maxHeight: "70%", anchor: "center", row: "40%" } });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/pi-packed",
-  "version": "0.13.1",
+  "version": "0.14.0",
   "description": "Pi package tools, commands, profiles, and TUI for the Packed daemon",
   "type": "module",
   "keywords": ["pi-package"],