@danypops/pi-lector 0.2.2 → 0.4.0

package/extension/src/code-intelligence-rendering.ts

@@ -4,6 +4,7 @@ import type {
 	DocumentSymbolEntry,
 	Hover,
 	IncomingCall,
+	IntelligenceProvenance,
 	JobSnapshot,
 	OutgoingCall,
 	PopulateSymbolGraphResult,
@@ -159,20 +160,29 @@ function formatCallHierarchyEntry(entry: { kind: string; name: string; location:
 	return `${kind} ${name} -- ${location}`;
 }
 
-export function formatPrepareCallHierarchyCall(args: { path?: unknown; line?: unknown; character?: unknown }, theme: LectorTheme): string {
-	return formatPositionalCall("prepare_call_hierarchy", args, theme);
+export type CallHierarchyDirection = "prepare" | "incoming" | "outgoing";
+
+// A real discriminated union, not one shape with optional fields -- lets formatCallHierarchyResult
+// narrow `items`/`calls` per branch without an unsafe assertion.
+export type CallHierarchyToolDetails =
+	| { readonly direction: "prepare"; readonly items: readonly CallHierarchyEntry[]; readonly provenance?: IntelligenceProvenance }
+	| { readonly direction: "incoming"; readonly calls: readonly IncomingCall[]; readonly provenance?: IntelligenceProvenance }
+	| { readonly direction: "outgoing"; readonly calls: readonly OutgoingCall[]; readonly provenance?: IntelligenceProvenance };
+
+export function formatCallHierarchyCall(args: { direction?: unknown; path?: unknown; line?: unknown; character?: unknown }, theme: LectorTheme): string {
+	const direction = typeof args.direction === "string" ? args.direction : "";
+	const path = typeof args.path === "string" ? args.path : "";
+	const line = typeof args.line === "number" ? args.line : "?";
+	const character = typeof args.character === "number" ? args.character : "?";
+	return `${theme.fg("toolTitle", theme.bold("call_hierarchy"))} ${theme.fg("muted", direction)} ${theme.fg("accent", `${path}:${line}:${character}`)}`;
 }
 
-export function formatPrepareCallHierarchyResult(items: readonly CallHierarchyEntry[] | undefined, theme: LectorTheme): string {
+function formatPrepareCallHierarchyResult(items: readonly CallHierarchyEntry[] | undefined, theme: LectorTheme): string {
 	if (!items || items.length === 0) return theme.fg("dim", "No call-hierarchy root at this position.");
 	return items.map((item) => formatCallHierarchyEntry(item, theme)).join("\n");
 }
 
-export function formatIncomingCallsCall(args: { path?: unknown; line?: unknown; character?: unknown }, theme: LectorTheme): string {
-	return formatPositionalCall("incoming_calls", args, theme);
-}
-
-export function formatIncomingCallsResult(calls: readonly IncomingCall[] | undefined, expanded: boolean, theme: LectorTheme): string {
+function formatIncomingCallsResult(calls: readonly IncomingCall[] | undefined, expanded: boolean, theme: LectorTheme): string {
 	if (!calls || calls.length === 0) return theme.fg("dim", "No incoming calls found.");
 
 	const displayCount = expanded ? calls.length : Math.min(calls.length, DEFAULT_VISIBLE_CALLS);
@@ -184,11 +194,7 @@ export function formatIncomingCallsResult(calls: readonly IncomingCall[] | undef
 	return lines.join("\n");
 }
 
-export function formatOutgoingCallsCall(args: { path?: unknown; line?: unknown; character?: unknown }, theme: LectorTheme): string {
-	return formatPositionalCall("outgoing_calls", args, theme);
-}
-
-export function formatOutgoingCallsResult(calls: readonly OutgoingCall[] | undefined, expanded: boolean, theme: LectorTheme): string {
+function formatOutgoingCallsResult(calls: readonly OutgoingCall[] | undefined, expanded: boolean, theme: LectorTheme): string {
 	if (!calls || calls.length === 0) return theme.fg("dim", "No outgoing calls found.");
 
 	const displayCount = expanded ? calls.length : Math.min(calls.length, DEFAULT_VISIBLE_CALLS);
@@ -200,6 +206,13 @@ export function formatOutgoingCallsResult(calls: readonly OutgoingCall[] | undef
 	return lines.join("\n");
 }
 
+export function formatCallHierarchyResult(details: CallHierarchyToolDetails | undefined, expanded: boolean, theme: LectorTheme): string {
+	if (!details) return theme.fg("dim", "No result.");
+	if (details.direction === "prepare") return formatPrepareCallHierarchyResult(details.items, theme);
+	if (details.direction === "incoming") return formatIncomingCallsResult(details.calls, expanded, theme);
+	return formatOutgoingCallsResult(details.calls, expanded, theme);
+}
+
 export function formatPopulateSymbolGraphCall(args: { path?: unknown; maxFiles?: unknown; maxSymbolsPerFile?: unknown }, theme: LectorTheme): string {
 	const path = typeof args.path === "string" ? args.path : "";
 	return `${theme.fg("toolTitle", theme.bold("populate_symbol_graph"))} ${theme.fg("accent", path)}`;

package/extension/src/git-rendering.ts

@@ -6,12 +6,30 @@ const DEFAULT_VISIBLE_FILES = 20;
 const DEFAULT_VISIBLE_COMMITS = 10;
 const DEFAULT_VISIBLE_DIFF_LINES = 60;
 
-export function formatGitStatusCall(args: { directory?: unknown }, theme: LectorTheme): string {
+export type GitAction = "status" | "log" | "diff";
+
+export interface GitToolDetails {
+	readonly action: GitAction;
+	readonly summary?: GitStatusSummary;
+	readonly entries?: readonly GitLogEntry[];
+	readonly result?: GitDiffResult;
+}
+
+export function formatGitCall(args: { action?: unknown; directory?: unknown; ref?: unknown }, theme: LectorTheme): string {
+	const action = typeof args.action === "string" ? args.action : "";
 	const directory = typeof args.directory === "string" ? args.directory : "";
-	return `${theme.fg("toolTitle", theme.bold("git_status"))} ${theme.fg("accent", directory)}`;
+	const ref = typeof args.ref === "string" ? ` ${args.ref}` : "";
+	return `${theme.fg("toolTitle", theme.bold("git"))} ${theme.fg("muted", action)} ${theme.fg("accent", directory)}${ref}`;
 }
 
-export function formatGitStatusResult(summary: GitStatusSummary | undefined, expanded: boolean, theme: LectorTheme): string {
+export function formatGitResult(details: GitToolDetails | undefined, expanded: boolean, theme: LectorTheme): string {
+	if (!details) return theme.fg("dim", "No result.");
+	if (details.action === "status") return formatGitStatusResult(details.summary, expanded, theme);
+	if (details.action === "log") return formatGitLogResult(details.entries, expanded, theme);
+	return formatGitDiffResult(details.result, expanded, theme);
+}
+
+function formatGitStatusResult(summary: GitStatusSummary | undefined, expanded: boolean, theme: LectorTheme): string {
 	if (!summary) return theme.fg("dim", "No status available.");
 	const branch = summary.current ?? "(detached)";
 	const tracking = summary.tracking ? `, tracking ${summary.tracking} (+${summary.ahead}/-${summary.behind})` : "";
@@ -30,12 +48,7 @@ export function formatGitStatusResult(summary: GitStatusSummary | undefined, exp
 	return lines.join("\n");
 }
 
-export function formatGitLogCall(args: { directory?: unknown; maxCount?: unknown }, theme: LectorTheme): string {
-	const directory = typeof args.directory === "string" ? args.directory : "";
-	return `${theme.fg("toolTitle", theme.bold("git_log"))} ${theme.fg("accent", directory)}`;
-}
-
-export function formatGitLogResult(entries: readonly GitLogEntry[] | undefined, expanded: boolean, theme: LectorTheme): string {
+function formatGitLogResult(entries: readonly GitLogEntry[] | undefined, expanded: boolean, theme: LectorTheme): string {
 	if (!entries || entries.length === 0) return theme.fg("dim", "No commits found.");
 	const displayCount = expanded ? entries.length : Math.min(DEFAULT_VISIBLE_COMMITS, entries.length);
 	const lines = entries
@@ -46,13 +59,7 @@ export function formatGitLogResult(entries: readonly GitLogEntry[] | undefined,
 	return lines.join("\n");
 }
 
-export function formatGitDiffCall(args: { directory?: unknown; ref?: unknown }, theme: LectorTheme): string {
-	const directory = typeof args.directory === "string" ? args.directory : "";
-	const ref = typeof args.ref === "string" ? ` ${args.ref}` : "";
-	return `${theme.fg("toolTitle", theme.bold("git_diff"))} ${theme.fg("accent", directory)}${ref}`;
-}
-
-export function formatGitDiffResult(result: GitDiffResult | undefined, expanded: boolean, theme: LectorTheme): string {
+function formatGitDiffResult(result: GitDiffResult | undefined, expanded: boolean, theme: LectorTheme): string {
 	if (!result || result.diff.length === 0) return theme.fg("dim", "No differences.");
 	const lines = result.diff.split("\n");
 	const displayCount = expanded ? lines.length : Math.min(DEFAULT_VISIBLE_DIFF_LINES, lines.length);