@danypops/pi-lector 0.2.0 → 0.2.2

package/extension/src/code-intelligence-operations.ts

@@ -1,5 +1,5 @@
 import type { JobSnapshot, OperationInputs, OperationOutputs, PopulateSymbolGraphResult, SymbolEdgeKind, SymbolNode } from "@danypops/lector";
-import { lectorClient, withWorkspace, workspaceForCodeIntelligencePath } from "./lector-client.ts";
+import { lectorClient, withWorkspace, workspaceForCodeIntelligencePath, workspaceForPathOrDirectory } from "./lector-client.ts";
 
 /**
  * Thin wrappers over Lector's code-intelligence operations: goToDefinition,
@@ -13,6 +13,13 @@ import { lectorClient, withWorkspace, workspaceForCodeIntelligencePath } from ".
  * falling back to the file's own containing directory, never the filesystem
  * root -- every one of these operations spawns a real language server,
  * unlike read/write/edit) -- never a value captured once at session start.
+ *
+ * Exception: populateSymbolGraph, workspaceMap, and hasWarmIndex are not file-anchored --
+ * their `path` genuinely means "the project itself", so they resolve via
+ * workspaceForPathOrDirectory instead, which does not blindly take dirname() first. A real,
+ * confirmed live bug: passing a project's own root directory through workspaceForCodeIntelligencePath
+ * silently resolved to that directory's *parent* (dirname strips the final segment even when the
+ * given path was already a directory with its own .git), mixing in every sibling project's graph.
  */
 export interface CodeIntelligenceOperations {
 	goToDefinition(path: string, line: number, character: number): Promise<OperationOutputs["workspace.goToDefinition"]>;
@@ -123,7 +130,7 @@ export function createLectorCodeIntelligenceOperations(): CodeIntelligenceOperat
 		},
 		async populateSymbolGraph(path, maxFiles, maxSymbolsPerFile, waitMs = 500) {
 			return withWorkspace(
-				() => workspaceForCodeIntelligencePath(path),
+				() => workspaceForPathOrDirectory(path),
 				async ({ workspaceId }) => {
 					const client = await lectorClient();
 					const { job } = await client.call("job.submit", {
@@ -152,7 +159,7 @@ export function createLectorCodeIntelligenceOperations(): CodeIntelligenceOperat
 		},
 		async hasWarmIndex(path) {
 			return withWorkspace(
-				() => workspaceForCodeIntelligencePath(path),
+				() => workspaceForPathOrDirectory(path),
 				async ({ workspaceId }) => {
 					const client = await lectorClient();
 					const { warm } = await client.call("workspace.hasWarmIndex", { workspaceId });
@@ -162,7 +169,7 @@ export function createLectorCodeIntelligenceOperations(): CodeIntelligenceOperat
 		},
 		async workspaceMap(path, maxNodes, maxEdges, maxEntries, maxBytes) {
 			return withWorkspace(
-				() => workspaceForCodeIntelligencePath(path),
+				() => workspaceForPathOrDirectory(path),
 				async ({ workspaceId }) => {
 					const client = await lectorClient();
 					return client.call("workspace.map", { workspaceId, maxNodes, maxEdges, maxEntries, maxBytes });

package/extension/src/lector-client.ts

@@ -1,3 +1,4 @@
+import { existsSync, statSync } from "node:fs";
 import { dirname, parse } from "node:path";
 import { createRetryingClient, type RetryingClient } from "@danypops/daemon-kit/pi-client";
 import {
@@ -111,6 +112,24 @@ export function workspaceForCodeIntelligencePath(absolutePath: string): Promise<
 	return workspaceForDirectory(dirname(absolutePath));
 }
 
+/**
+ * For an operation whose `path` genuinely means "the project/workspace itself"
+ * (populateSymbolGraph, workspaceMap, hasWarmIndex) rather than one specific file
+ * to act on -- unlike workspaceForCodeIntelligencePath, does NOT blindly take
+ * dirname() first. A real, confirmed live bug: passing a project's own root
+ * directory (e.g. "/repo", which has its own .git right there) through
+ * dirname() strips its final segment, silently resolving to the *parent*
+ * directory's own nearest git root instead -- for a project nested one level
+ * under a broader already-registered workspace, this mixes in every sibling
+ * project's own graph, with no error at all. Checks whether the path is
+ * itself a real, existing directory first; only takes dirname() when it is
+ * not (a file, or a not-yet-existing path).
+ */
+export function workspaceForPathOrDirectory(path: string): Promise<ResolvedWorkspace> {
+	const isRealDirectory = existsSync(path) && statSync(path).isDirectory();
+	return workspaceForDirectory(isRealDirectory ? path : dirname(path));
+}
+
 /**
  * Resolves a workspace via `resolve`, then calls `perform` with it. A daemon
  * restart wipes its in-memory workspace registry (workspace ids are not

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@danypops/pi-lector",
-	"version": "0.2.0",
+	"version": "0.2.2",
 	"description": "Pi host adapter for Lector: overrides read/write/edit with a daemon-backed, hash-guarded filesystem",
 	"license": "MIT",
 	"type": "module",
@@ -19,7 +19,7 @@
 	},
 	"dependencies": {
 		"@danypops/daemon-kit": "^0.4.0",
-		"@danypops/lector": "^0.1.15"
+		"@danypops/lector": "^0.2.0"
 	},
 	"devDependencies": {
 		"@earendil-works/pi-ai": "^0.81.1",