@danypops/pi-lector 0.13.11 → 0.15.0

package/extension/src/apply-patch/rendering.ts

@@ -1,6 +1,7 @@
 import type { EditOutcome } from "@danypops/lector";
 import { renderDiffLines, renderTruncatedList, type TextMeasure } from "malevich-tui-components";
 import type { LectorTheme } from "../lector-tui-theme.ts";
+import { presentationTitle } from "../presentation/tool-presentation.ts";
 
 /**
  * The applied result (EditOutcome) only carries a hash transition, not the
@@ -15,7 +16,7 @@ const DEFAULT_VISIBLE_PATCH_LINES = 12;
 
 export function formatApplyPatchCall(args: { path?: unknown; patchText?: unknown }, theme: LectorTheme, measure?: TextMeasure): string {
 	const path = typeof args.path === "string" ? args.path : "";
-	const header = `${theme.fg("toolTitle", theme.bold("apply_patch"))} ${theme.fg("accent", path)}`;
+	const header = `${theme.fg("toolTitle", theme.bold(presentationTitle("apply_patch")))} ${theme.fg("accent", path)}`;
 	if (typeof args.patchText !== "string" || args.patchText.length === 0) return header;
 
 	const styledLines = renderDiffLines(

package/extension/src/code-intelligence/rendering.ts

@@ -14,6 +14,7 @@ import type {
 import { keyHint, type ThemeColor } from "@earendil-works/pi-coding-agent";
 import { renderTruncatedList } from "malevich-tui-components";
 import { colorForKind, formatLocation, type LectorTheme } from "../lector-tui-theme.ts";
+import { presentationTitle } from "../presentation/tool-presentation.ts";
 
 /**
  * Custom TUI rendering for the code-intelligence tools: go_to_definition,
@@ -41,7 +42,7 @@ function formatPositionalCall(toolName: string, args: { path?: unknown; line?: u
 	const path = typeof args.path === "string" ? args.path : "";
 	const line = typeof args.line === "number" ? args.line : "?";
 	const character = typeof args.character === "number" ? args.character : "?";
-	return `${theme.fg("toolTitle", theme.bold(toolName))} ${theme.fg("accent", `${path}:${line}:${character}`)}`;
+	return `${theme.fg("toolTitle", theme.bold(presentationTitle(toolName)))} ${theme.fg("accent", `${path}:${line}:${character}`)}`;
 }
 
 function moreLine(theme: LectorTheme): (hidden: number) => string {
@@ -110,7 +111,7 @@ export function formatHoverResult(hover: Hover | undefined, expanded: boolean, t
 
 export function formatDocumentSymbolsCall(args: { path?: unknown }, theme: LectorTheme): string {
 	const path = typeof args.path === "string" ? args.path : "";
-	return `${theme.fg("toolTitle", theme.bold("document_symbols"))} ${theme.fg("accent", path)}`;
+	return `${theme.fg("toolTitle", theme.bold(presentationTitle("document_symbols")))} ${theme.fg("accent", path)}`;
 }
 
 /** Flattens a hierarchical DocumentSymbolEntry[] into (depth, entry) pairs, depth-first, for bounded rendering. */
@@ -149,7 +150,7 @@ export function formatDocumentSymbolsResult(symbols: readonly DocumentSymbolEntr
 
 export function formatDiagnosticsCall(args: { path?: unknown }, theme: LectorTheme): string {
 	const path = typeof args.path === "string" ? args.path : "";
-	return `${theme.fg("toolTitle", theme.bold("diagnostics"))} ${theme.fg("accent", path)}`;
+	return `${theme.fg("toolTitle", theme.bold(presentationTitle("diagnostics")))} ${theme.fg("accent", path)}`;
 }
 
 export function formatDiagnosticsResult(diagnostics: readonly Diagnostic[] | undefined, expanded: boolean, theme: LectorTheme): string {
@@ -175,7 +176,7 @@ export function formatDiagnosticsResult(diagnostics: readonly Diagnostic[] | und
 
 function formatPathCall(toolName: string, args: { path?: unknown }, theme: LectorTheme, qualifier = ""): string {
 	const path = typeof args.path === "string" ? args.path : "";
-	return `${theme.fg("toolTitle", theme.bold(toolName))}${qualifier ? ` ${theme.fg("muted", qualifier)}` : ""} ${theme.fg("accent", path)}`;
+	return `${theme.fg("toolTitle", theme.bold(presentationTitle(toolName)))}${qualifier ? ` ${theme.fg("muted", qualifier)}` : ""} ${theme.fg("accent", path)}`;
 }
 
 export function formatCodeActionPreviewCall(
@@ -249,7 +250,11 @@ export function formatDiagnosticDeltaResult(result: OperationOutputs["workspace.
 }
 
 export function formatTypeHierarchyCall(args: { direction?: unknown; path?: unknown; line?: unknown; character?: unknown }, theme: LectorTheme): string {
-	return `${formatPositionalCall("type_hierarchy", args, theme)} ${theme.fg("muted", typeof args.direction === "string" ? args.direction : "")}`;
+	const direction = typeof args.direction === "string" ? args.direction : undefined;
+	const path = typeof args.path === "string" ? args.path : "";
+	const line = typeof args.line === "number" ? args.line : "?";
+	const character = typeof args.character === "number" ? args.character : "?";
+	return `${theme.fg("toolTitle", theme.bold(presentationTitle("type_hierarchy", direction)))} ${theme.fg("accent", `${path}:${line}:${character}`)}`;
 }
 
 export function formatTypeHierarchyResult(
@@ -311,7 +316,7 @@ export function formatCallHierarchyCall(args: { direction?: unknown; path?: unkn
 	const path = typeof args.path === "string" ? args.path : "";
 	const line = typeof args.line === "number" ? args.line : "?";
 	const character = typeof args.character === "number" ? args.character : "?";
-	return `${theme.fg("toolTitle", theme.bold("call_hierarchy"))} ${theme.fg("muted", direction)} ${theme.fg("accent", `${path}:${line}:${character}`)}`;
+	return `${theme.fg("toolTitle", theme.bold(presentationTitle("call_hierarchy", direction)))} ${theme.fg("accent", `${path}:${line}:${character}`)}`;
 }
 
 function formatPrepareCallHierarchyResult(items: readonly CallHierarchyEntry[] | undefined, theme: LectorTheme): string {
@@ -384,7 +389,7 @@ export function formatReachableFromResult(symbols: readonly SymbolNode[] | undef
 export function formatWorkspaceMapCall(args: { path?: unknown; maxEntries?: unknown }, theme: LectorTheme): string {
 	const path = typeof args.path === "string" ? args.path : "";
 	const maxEntries = typeof args.maxEntries === "number" ? ` (top ${args.maxEntries})` : "";
-	return `${theme.fg("toolTitle", theme.bold("workspace_map"))} ${theme.fg("dim", path)}${theme.fg("muted", maxEntries)}`;
+	return `${theme.fg("toolTitle", theme.bold(presentationTitle("workspace_map")))} ${theme.fg("dim", path)}${theme.fg("muted", maxEntries)}`;
 }
 
 export function formatWorkspaceMapResult(result: WorkspaceMapResult | undefined, expanded: boolean, theme: LectorTheme): string {

package/extension/src/cross-workspace-search/model-content.ts

@@ -0,0 +1,69 @@
+import type { SymbolSearchResult, TextSearchResult } from "@danypops/lector";
+import { boundModelContentText, DEFAULT_MODEL_CONTENT_BYTES } from "../presentation/model-content.ts";
+import type { CrossWorkspaceOutcome } from "./operations.ts";
+
+const MAX_RESULTS_PER_PROJECT = 10;
+
+function appendOutcomeHeader<T>(lines: string[], entry: CrossWorkspaceOutcome<T>): boolean {
+	const { outcome } = entry;
+	switch (outcome.status) {
+		case "ready":
+			lines.push(`${entry.directory} -- ready`);
+			break;
+		case "loading":
+			lines.push(`${entry.directory} -- loading: ${outcome.message}`);
+			return false;
+		case "error":
+			lines.push(`${entry.directory} -- error: ${outcome.message}`);
+			return false;
+		default: {
+			const exhaustive: never = outcome;
+			throw new Error(`unhandled workspace query outcome: ${JSON.stringify(exhaustive)}`);
+		}
+	}
+	if (entry.collapsedWith.length > 0) lines.push(`  same workspace as: ${entry.collapsedWith.join(", ")}`);
+	return true;
+}
+
+/** Formats cross-project symbol outcomes with concrete, independently bounded results for model consumption. */
+export function formatFindSymbolsAcrossProjectsModelContent(
+	results: readonly CrossWorkspaceOutcome<SymbolSearchResult>[],
+	maxBytes = DEFAULT_MODEL_CONTENT_BYTES,
+): string {
+	const lines = ["Find Symbols Across Projects", `projects: ${results.length}`];
+	for (const entry of results) {
+		if (!appendOutcomeHeader(lines, entry)) continue;
+		if (entry.outcome.status !== "ready") continue;
+		const { result } = entry.outcome;
+		lines.push(`  provenance: ${result.provenance.fidelity} via ${result.provenance.backend}`);
+		lines.push(`  upstream truncated: ${result.truncated}`);
+		for (const item of result.symbols.slice(0, MAX_RESULTS_PER_PROJECT)) {
+			lines.push(`  ${item.kind} ${item.name} -- ${item.location.path}:${item.location.line}:${item.location.character}`);
+		}
+		if (result.symbols.length > MAX_RESULTS_PER_PROJECT) lines.push(`  ${result.symbols.length - MAX_RESULTS_PER_PROJECT} more symbols omitted`);
+		if (result.symbols.length === 0) lines.push("  no symbols matched");
+	}
+	return boundModelContentText(lines.join("\n"), maxBytes);
+}
+
+/** Formats cross-project text outcomes with concrete, independently bounded matches for model consumption. */
+export function formatSearchTextAcrossProjectsModelContent(
+	results: readonly CrossWorkspaceOutcome<TextSearchResult>[],
+	maxBytes = DEFAULT_MODEL_CONTENT_BYTES,
+): string {
+	const lines = ["Search Code Across Projects", `projects: ${results.length}`];
+	for (const entry of results) {
+		if (!appendOutcomeHeader(lines, entry)) continue;
+		if (entry.outcome.status !== "ready") continue;
+		const { result } = entry.outcome;
+		if (result.provenance) lines.push(`  provenance: lexical via ${result.provenance.backend} (${result.provenance.indexState})`);
+		lines.push(`  upstream truncated: ${result.truncated}`);
+		for (const item of result.matches.slice(0, MAX_RESULTS_PER_PROJECT)) {
+			const line = item.line.replace(/\n$/, "");
+			lines.push(`  ${item.path}:${item.lineNumber}: ${line}${item.lineTruncated ? " (line truncated)" : ""}`);
+		}
+		if (result.matches.length > MAX_RESULTS_PER_PROJECT) lines.push(`  ${result.matches.length - MAX_RESULTS_PER_PROJECT} more matches omitted`);
+		if (result.matches.length === 0) lines.push("  no matches");
+	}
+	return boundModelContentText(lines.join("\n"), maxBytes);
+}

package/extension/src/cross-workspace-search/rendering.ts

@@ -3,14 +3,19 @@ import { keyHint } from "@earendil-works/pi-coding-agent";
 import { renderTruncatedList } from "malevich-tui-components";
 import { describeFindSymbolSources } from "../find-symbols/rendering.ts";
 import type { LectorTheme } from "../lector-tui-theme.ts";
+import { presentationTitle } from "../presentation/tool-presentation.ts";
 import type { CrossWorkspaceOutcome } from "./operations.ts";
 
 const DEFAULT_VISIBLE_PER_WORKSPACE = 10;
 
-export function formatCrossWorkspaceCall(args: { directories?: unknown; query?: unknown }, theme: LectorTheme): string {
+export function formatCrossWorkspaceCall(
+	toolName: "find_symbols_across_projects" | "search_code_across_projects",
+	args: { directories?: unknown; query?: unknown },
+	theme: LectorTheme,
+): string {
 	const directories = Array.isArray(args.directories) ? args.directories.filter((d): d is string => typeof d === "string") : [];
 	const query = typeof args.query === "string" ? args.query : "";
-	return `${theme.fg("accent", `"${query}"`)} ${theme.fg("dim", `across ${directories.length} project(s)`)}`;
+	return `${theme.fg("toolTitle", theme.bold(presentationTitle(toolName)))} ${theme.fg("accent", `"${query}"`)} ${theme.fg("dim", `across ${directories.length} project(s)`)}`;
 }
 
 function formatOutcomeHeader(entry: CrossWorkspaceOutcome<unknown>, theme: LectorTheme): string {

package/extension/src/external-search/rendering.ts

@@ -1,27 +1,61 @@
 import type { GithubRepoSearchResult, NpmPackageCandidate, SourcegraphCodeCandidate } from "@danypops/lector";
 import type { LectorTheme } from "../lector-tui-theme.ts";
+import { presentationTitle } from "../presentation/tool-presentation.ts";
 
 type ExternalSearchAction = "github_repos" | "npm_packages" | "sourcegraph_code";
 
 export function formatExternalSearchCall(action: ExternalSearchAction, args: { query?: unknown }, theme: LectorTheme): string {
-	const label = theme.fg("toolTitle", theme.bold("external_search"));
+	const label = theme.fg("toolTitle", theme.bold(presentationTitle("external_search", action)));
 	const query = typeof args.query === "string" ? args.query : "";
-	return `${label} ${theme.fg("accent", action)} ${theme.fg("dim", query)}`;
+	return `${label} ${theme.fg("accent", `"${query}"`)}`;
 }
 
-export function formatGithubRepoSearchResult(result: GithubRepoSearchResult | undefined, theme: LectorTheme): string {
+const VISIBLE_CANDIDATES = 8;
+
+function boundedCandidates<T>(candidates: readonly T[], expanded: boolean): { visible: readonly T[]; more: number } {
+	const visible = expanded ? candidates : candidates.slice(0, VISIBLE_CANDIDATES);
+	return { visible, more: candidates.length - visible.length };
+}
+
+export function formatGithubRepoSearchResult(result: GithubRepoSearchResult | undefined, expanded: boolean, theme: LectorTheme): string {
 	if (!result) return theme.fg("dim", "No result.");
-	const count = result.candidates.length;
-	const summary = count === 0 ? theme.fg("dim", "no repositories matched") : theme.fg("success", `${count} repositor${count === 1 ? "y" : "ies"}`);
-	return result.authenticated ? summary : `${summary} ${theme.fg("warning", "(unauthenticated -- lower rate limit)")}`;
+	if (result.candidates.length === 0) return theme.fg("dim", "no repositories matched");
+	const { visible, more } = boundedCandidates(result.candidates, expanded);
+	const lines = visible.map(
+		(candidate) =>
+			`${theme.fg("accent", `${candidate.host}/${candidate.owner}/${candidate.repo}`)} · ${candidate.stars} stars${candidate.language ? ` · ${candidate.language}` : ""}${candidate.description ? `\n  ${candidate.description}` : ""}`,
+	);
+	if (more > 0) lines.push(theme.fg("muted", `… ${more} more (expand to show)`));
+	if (!result.authenticated) lines.push(theme.fg("warning", "unauthenticated -- lower rate limit"));
+	return lines.join("\n");
 }
 
-export function formatNpmPackageSearchResult(result: { candidates: readonly NpmPackageCandidate[] } | undefined, theme: LectorTheme): string {
-	const count = result?.candidates.length ?? 0;
-	return count === 0 ? theme.fg("dim", "no packages matched") : theme.fg("success", `${count} package${count === 1 ? "" : "s"}`);
+export function formatNpmPackageSearchResult(
+	result: { candidates: readonly NpmPackageCandidate[] } | undefined,
+	expanded: boolean,
+	theme: LectorTheme,
+): string {
+	if (!result || result.candidates.length === 0) return theme.fg("dim", "no packages matched");
+	const { visible, more } = boundedCandidates(result.candidates, expanded);
+	const lines = visible.map(
+		(candidate) =>
+			`${theme.fg("accent", `${candidate.name}@${candidate.version}`)} · score ${candidate.score.toFixed(3)}${candidate.description ? `\n  ${candidate.description}` : ""}`,
+	);
+	if (more > 0) lines.push(theme.fg("muted", `… ${more} more (expand to show)`));
+	return lines.join("\n");
 }
 
-export function formatSourcegraphCodeSearchResult(result: { candidates: readonly SourcegraphCodeCandidate[] } | undefined, theme: LectorTheme): string {
-	const count = result?.candidates.length ?? 0;
-	return count === 0 ? theme.fg("dim", "no code matches") : theme.fg("success", `${count} match${count === 1 ? "" : "es"}`);
+export function formatSourcegraphCodeSearchResult(
+	result: { candidates: readonly SourcegraphCodeCandidate[] } | undefined,
+	expanded: boolean,
+	theme: LectorTheme,
+): string {
+	if (!result || result.candidates.length === 0) return theme.fg("dim", "no code matches");
+	const { visible, more } = boundedCandidates(result.candidates, expanded);
+	const lines = visible.map((candidate) => {
+		const matches = candidate.lineMatches.slice(0, expanded ? candidate.lineMatches.length : 3);
+		return `${theme.fg("accent", `${candidate.repository}/${candidate.path}`)}\n${matches.map((match) => `  ${match.line}: ${match.preview}`).join("\n")}`;
+	});
+	if (more > 0) lines.push(theme.fg("muted", `… ${more} more (expand to show)`));
+	return lines.join("\n");
 }

package/extension/src/find-files/rendering.ts

@@ -2,13 +2,14 @@ import type { FindFilesResult } from "@danypops/lector";
 import { keyHint } from "@earendil-works/pi-coding-agent";
 import { renderTruncatedList } from "malevich-tui-components";
 import type { LectorTheme } from "../lector-tui-theme.ts";
+import { presentationTitle } from "../presentation/tool-presentation.ts";
 
 const DEFAULT_VISIBLE_PATHS = 40;
 
 export function formatFindFilesCall(args: { directory?: unknown; patterns?: unknown }, theme: LectorTheme): string {
 	const directory = typeof args.directory === "string" ? args.directory : "";
 	const patterns = Array.isArray(args.patterns) ? args.patterns.filter((p): p is string => typeof p === "string") : [];
-	return `${theme.fg("toolTitle", theme.bold("find_files"))} ${theme.fg("accent", patterns.map((p) => `"${p}"`).join(", "))} ${theme.fg("dim", directory)}`;
+	return `${theme.fg("toolTitle", theme.bold(presentationTitle("find_files")))} ${theme.fg("accent", patterns.map((p) => `"${p}"`).join(", "))} ${theme.fg("dim", directory)}`;
 }
 
 export function formatFindFilesResult(result: FindFilesResult | undefined, expanded: boolean, theme: LectorTheme): string {

package/extension/src/find-symbols/rendering.ts

@@ -2,6 +2,7 @@ import type { SymbolSearchResult, WorkspaceSymbol } from "@danypops/lector";
 import { keyHint } from "@earendil-works/pi-coding-agent";
 import { renderTruncatedList } from "malevich-tui-components";
 import { colorForKind, formatLocation, type LectorTheme } from "../lector-tui-theme.ts";
+import { presentationTitle } from "../presentation/tool-presentation.ts";
 
 /**
  * Custom TUI rendering for find_symbols -- the one Lector-backed tool with
@@ -18,7 +19,7 @@ const DEFAULT_VISIBLE_RESULTS = 8;
 
 export function formatFindSymbolsCall(args: { query?: unknown; directory?: unknown }, theme: FindSymbolsTheme): string {
 	const query = typeof args.query === "string" ? args.query : "";
-	let content = `${theme.fg("toolTitle", theme.bold("find_symbols"))} ${theme.fg("accent", `"${query}"`)}`;
+	let content = `${theme.fg("toolTitle", theme.bold(presentationTitle("find_symbols")))} ${theme.fg("accent", `"${query}"`)}`;
 	if (typeof args.directory === "string" && args.directory.length > 0) {
 		content += ` ${theme.fg("muted", `in ${args.directory}`)}`;
 	}

package/extension/src/git/rendering.ts

@@ -3,6 +3,7 @@ import { keyHint } from "@earendil-works/pi-coding-agent";
 import { truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import { renderDiffLines, renderTruncatedList, type TextMeasure } from "malevich-tui-components";
 import type { LectorTheme } from "../lector-tui-theme.ts";
+import { presentationTitle } from "../presentation/tool-presentation.ts";
 
 /** Real ANSI-aware measurement, not Malevich's own ASCII-only default -- every diff line renderDiffLines receives is already theme.fg-styled. */
 const measure: TextMeasure = { visibleWidth, truncateToWidth };
@@ -61,31 +62,32 @@ export function formatGitCall(
 	theme: LectorTheme,
 ): string {
 	const action = typeof args.action === "string" ? args.action : "";
+	const label = theme.fg("toolTitle", theme.bold(presentationTitle("git", action)));
 	const directory = typeof args.directory === "string" ? args.directory : "";
 	if (action === "compare-symbol") {
 		const path = typeof args.path === "string" ? args.path : "";
 		const symbol = typeof args.symbol === "string" ? args.symbol : "";
 		const fromRef = typeof args.fromRef === "string" ? args.fromRef : "";
 		const toRef = typeof args.toRef === "string" ? ` -> ${args.toRef}` : "";
-		return `${theme.fg("toolTitle", theme.bold("git"))} ${theme.fg("muted", action)} ${theme.fg("accent", `${directory}/${path}`)} (${symbol}) ${fromRef}${toRef}`;
+		return `${label} ${theme.fg("accent", `${directory}/${path}`)} (${symbol}) ${fromRef}${toRef}`;
 	}
 	if (action === "is-ancestor") {
 		const ancestorRef = typeof args.ancestorRef === "string" ? args.ancestorRef : "";
 		const ref = typeof args.ref === "string" ? args.ref : "";
-		return `${theme.fg("toolTitle", theme.bold("git"))} ${theme.fg("muted", action)} ${theme.fg("accent", directory)} ${ancestorRef} -> ${ref}`;
+		return `${label} ${theme.fg("accent", directory)} ${ancestorRef} -> ${ref}`;
 	}
 	if (action === "grep-ref" || action === "grep-history") {
 		const ref = action === "grep-ref" && typeof args.ref === "string" ? `${args.ref} ` : "";
 		const pattern = typeof args.pattern === "string" ? args.pattern : "";
-		return `${theme.fg("toolTitle", theme.bold("git"))} ${theme.fg("muted", action)} ${theme.fg("accent", directory)} ${ref}"${pattern}"`;
+		return `${label} ${theme.fg("accent", directory)} ${ref}"${pattern}"`;
 	}
 	if (action === "show") {
 		const ref = typeof args.ref === "string" ? args.ref : "";
 		const path = typeof args.path === "string" ? args.path : "";
-		return `${theme.fg("toolTitle", theme.bold("git"))} ${theme.fg("muted", action)} ${theme.fg("accent", `${directory}/${path}`)} @ ${ref}`;
+		return `${label} ${theme.fg("accent", `${directory}/${path}`)} @ ${ref}`;
 	}
 	const ref = typeof args.ref === "string" ? ` ${args.ref}` : "";
-	return `${theme.fg("toolTitle", theme.bold("git"))} ${theme.fg("muted", action)} ${theme.fg("accent", directory)}${ref}`;
+	return `${label} ${theme.fg("accent", directory)}${ref}`;
 }
 
 function formatGitWorktreeAddResult(result: GitWorktreeAddResult | undefined, theme: LectorTheme): string {