@danypops/pi-lector 0.12.8 → 0.12.9

package/extension/src/reference-based-rename/operations.ts

@@ -13,6 +13,16 @@ import { lectorClient, type ResolvedWorkspace, withWorkspace, workspaceForCodeIn
  * the whole declared monorepo once (workspace_cache pointed at the repo root) and still rename a
  * file inside one of its member packages, without collapsing genuinely unrelated sibling projects
  * that were never declared together into one workspace identity.
+ *
+ * autoPopulate (Lector's own opt-in recovery from a "not-cached" graph) is applied carefully, not
+ * blanket-enabled: only once the correct FINAL scope is already known, never on a speculative
+ * first attempt that might still need widening. If a declared monorepo ancestor exists, the
+ * narrow project's own first attempt runs WITHOUT autoPopulate (so a genuinely never-populated
+ * narrow project still throws and triggers the widen-to-declared-root fallback below, exactly as
+ * before -- auto-populating the too-narrow scope here could make a rename "succeed" while
+ * silently missing a real cross-package reference the wider scope would have caught). Once widened
+ * to the declared root (or when no wider ancestor exists at all, meaning the narrow project IS the
+ * correct final scope), autoPopulate is safe and turned on -- one call converges instead of two.
  */
 export interface ReferenceBasedRenameOperations {
 	rename(fromPath: string, toPath: string, maxFiles: number, maxSymbolsPerFile: number): Promise<OperationOutputs["workspace.referenceBasedRename"]>;
@@ -21,19 +31,32 @@ export interface ReferenceBasedRenameOperations {
 export function createReferenceBasedRenameOperations(): ReferenceBasedRenameOperations {
 	return {
 		async rename(fromPath, toPath, maxFiles, maxSymbolsPerFile) {
-			const performRename = async ({ workspaceId }: ResolvedWorkspace) => {
+			const performRename = async ({ workspaceId }: ResolvedWorkspace, autoPopulate: boolean) => {
 				const client = await lectorClient();
-				return client.callOnce("workspace.referenceBasedRename", { workspaceId, fromPath, toPath, maxFiles, maxSymbolsPerFile });
+				return client.callOnce("workspace.referenceBasedRename", { workspaceId, fromPath, toPath, maxFiles, maxSymbolsPerFile, autoPopulate });
 			};
 
+			const narrow = await workspaceForCodeIntelligencePath(fromPath);
+			const declared = await workspaceForDeclaredMonorepoRoot(narrow.root);
+			if (!declared) {
+				// No wider declared ancestor -- the narrow project IS the correct, final scope, so
+				// auto-populating it directly is exactly as safe as the already-widened case below.
+				return withWorkspace(
+					() => Promise.resolve(narrow),
+					(resolved) => performRename(resolved, true),
+				);
+			}
 			try {
-				return await withWorkspace(() => workspaceForCodeIntelligencePath(fromPath), performRename);
+				return await withWorkspace(
+					() => Promise.resolve(narrow),
+					(resolved) => performRename(resolved, false),
+				);
 			} catch (error) {
 				if (!remoteErrorIs(error, "ReferenceBasedRenameRequiresFreshGraph")) throw error;
-				const narrow = await workspaceForCodeIntelligencePath(fromPath);
-				const declared = await workspaceForDeclaredMonorepoRoot(narrow.root);
-				if (!declared) throw error;
-				return withWorkspace(() => Promise.resolve(declared), performRename);
+				return withWorkspace(
+					() => Promise.resolve(declared),
+					(resolved) => performRename(resolved, true),
+				);
 			}
 		},
 	};

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@danypops/pi-lector",
-	"version": "0.12.8",
+	"version": "0.12.9",
 	"description": "Pi host adapter for Lector: overrides read/write/edit with a daemon-backed, hash-guarded filesystem",
 	"license": "MIT",
 	"type": "module",