@danypops/papyrus 0.29.4 → 0.29.6

package/extension/src/index.ts

@@ -95,7 +95,7 @@ export function renderTaskWidgetLines(theme: Theme, projection: TaskWidgetProjec
 	return lines;
 }
 
-class TaskOverlay {
+export class TaskOverlay {
 	private uiCtx: ExtensionUIContext | undefined;
 	private registered = false;
 	private tui: any | undefined;
@@ -116,6 +116,12 @@ class TaskOverlay {
 	// concurrent agent's focused task never shows as active in this session's widget.
 	setSessionId(sessionId: string): void { this.sessionId = sessionId; }
 
+	/**
+	 * Never throws: called from several pi.on(...) handlers, some of which (session_compact,
+	 * session_tree, tool_execution_end) don't wrap it themselves -- Pi's event emitter does not
+	 * guarantee catching a handler's rejection, so an unguarded throw here would become an
+	 * unhandled rejection at the call site instead of a stability issue contained to this widget.
+	 */
 	async refresh(): Promise<void> {
 		if (!this.projectRoot) return;
 		try {
@@ -123,7 +129,11 @@ class TaskOverlay {
 		} catch {
 			this.snapshot = { nodes: [], rootIds: [] };
 		}
-		this.render();
+		try {
+			this.render();
+		} catch {
+			// A rendering bug must not crash the extension host over a best-effort status widget.
+		}
 	}
 
 	private render(): void {
@@ -519,7 +529,7 @@ export default async function (pi: ExtensionAPI) {
 				const usage = ctx.getContextUsage?.();
 				// Real tree (not just the linear current-branch path): surfaces content sitting in an
 				// abandoned /tree branch, which cost real tokens to generate but isn't in context now.
-				const tree = ctx.sessionManager.getTree() as unknown as SessionTreeNodeLike[];
+				const tree = ctx.sessionManager.getTree() as SessionTreeNodeLike[];
 				// buildContextEntries(), NOT getBranch(): getBranch() returns every raw entry on the
 				// current path including everything a real compaction has already summarized away.
 				// A session with 3 real compactions confirmed this made "active" message-history
@@ -528,8 +538,8 @@ export default async function (pi: ExtensionAPI) {
 				// LLM"); buildContextEntries() is the compaction-aware entry list matching what the
 				// LLM actually sees (the latest compaction entry itself, plus kept entries from its
 				// firstKeptEntryId onward, plus everything after -- older summarized entries omitted).
-				const activeEntryIds = new Set((ctx.sessionManager.buildContextEntries() as unknown as SessionEntryLike[]).map((entry) => entry.id));
-				const branchEntryIds = new Set((ctx.sessionManager.getBranch() as unknown as SessionEntryLike[]).map((entry) => entry.id));
+				const activeEntryIds = new Set((ctx.sessionManager.buildContextEntries() as SessionEntryLike[]).map((entry) => entry.id));
+				const branchEntryIds = new Set((ctx.sessionManager.getBranch() as SessionEntryLike[]).map((entry) => entry.id));
 				const messageHistory = buildMessageHistoryTree(tree, activeEntryIds, branchEntryIds);
 				const breakdown = buildContextBreakdown({
 					totalTokens: usage?.tokens ?? null,

package/extension/src/tasks.ts

@@ -120,7 +120,8 @@ export async function showTasks(ctx: ExtensionCommandContext): Promise<void> {
 		if (action.type === "graph") { await showTaskGraph(ctx, graph); continue; }
 		if (action.type !== "action" || !action.row) continue;
 
-		const node = graph.nodes.find((entry) => entry.task.id === action.row!.id);
+		const rowId = action.row.id;
+		const node = graph.nodes.find((entry) => entry.task.id === rowId);
 		const active = node?.active === true;
 		const focusStatus = node?.focusStatus;
 		const choices = [
@@ -136,8 +137,8 @@ export async function showTasks(ctx: ExtensionCommandContext): Promise<void> {
 		const choice = await ctx.ui.select(action.row.title, choices);
 		if (!choice) continue;
 
-		if (choice === "Remove dependency" || choice === "Remove from parent") {
-			const relatedIds = choice === "Remove dependency" ? node!.dependencyIds : node!.parentIds;
+		if ((choice === "Remove dependency" || choice === "Remove from parent") && node) {
+			const relatedIds = choice === "Remove dependency" ? node.dependencyIds : node.parentIds;
 			const relatedTasks = relatedIds.map((relatedId) => graph.nodes.find((entry) => entry.task.id === relatedId)?.task).filter((task): task is Artifact => task !== undefined);
 			const relatedTitles = taskChoiceLabels(relatedTasks);
 			const selected = await ctx.ui.select(choice === "Remove dependency" ? "Remove which dependency?" : "Remove from which parent?", relatedTitles);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/papyrus",
-  "version": "0.29.4",
+  "version": "0.29.6",
   "description": "Daemon-backed graph artifacts, evidence-bearing tasks, rules, skills, and native TUI workflows for Pi",
   "type": "module",
   "keywords": ["pi-package"],

package/src/cli.ts

@@ -112,7 +112,8 @@ const USAGE = `Usage:
   papyrus skills instantiate <template-id> [--title <title>] [--body <body>] [--status <status>] [--labels-json <json>] [--extra-json <json>] [--json]
   papyrus skills assign-project <id> [project-root] [--json]
   papyrus skills update <id> [--title <title>] [--body <body>] [--labels-json <json>] [--json]
-  papyrus playbooks create --title <title> [--body <body>] [--trigger <text>] [--steps-json <json>] [--tools-json <json>] [--labels-json <json>] [--extra-json <json>] [--arguments-json <json>] [--project-root <path>] [--json]
+  papyrus playbooks create --title <title> [--body <body>] [--trigger <text>] [--steps-json <json>] [--tools-json <json>] [--labels-json <json>] [--extra-json <json>] [--arguments-json <json array>] [--project-root <path>] [--json]
+  papyrus playbooks invoke <id> [--arguments-json <json object>] [--json]
   papyrus playbooks list [--status <status>] [--text <query>] [--limit <count>] [--project-root <path>] [--json]
   papyrus playbooks show <id> [--json]
   papyrus playbooks invoke <id> [--json]
@@ -201,12 +202,15 @@ function parseJsonStringArrayFlag(value: string | undefined, flag: string): stri
 	return parsed as string[];
 }
 
-/** Top-level shape only -- element shape (e.g. {name, description?, required?}) is validated server-side. */
-function parseJsonArrayFlag(value: string | undefined, flag: string): unknown[] {
+/**
+ * No shape assertion here -- unlike every other JSON flag, playbooks --arguments-json is genuinely
+ * polymorphic (an array on create, a {name: value} map on invoke), and the two actions share one
+ * flag-parsing pass in runPlaybooksCli. The service validates the shape for whichever operation
+ * actually receives it.
+ */
+function parseJsonAnyFlag(value: string | undefined, flag: string): unknown {
 	if (value === undefined) throw new Error(`${flag} requires a value`);
-	const parsed = JSON.parse(value) as unknown;
-	if (!Array.isArray(parsed)) throw new Error(`${flag} must be a JSON array`);
-	return parsed;
+	return JSON.parse(value) as unknown;
 }
 
 function artifactLabel(artifact: CliArtifact): string {
@@ -794,7 +798,7 @@ export async function runPlaybooksCli(args: string[], client: TaskCliClient): Pr
 	let tools: string[] | undefined;
 	let labels: string[] | undefined;
 	let extra: Record<string, unknown> | undefined;
-	let playbookArguments: unknown[] | undefined;
+	let playbookArguments: unknown;
 	let status: string | undefined;
 	let text: string | undefined;
 	let limit: number | undefined;
@@ -809,7 +813,7 @@ export async function runPlaybooksCli(args: string[], client: TaskCliClient): Pr
 		if (argument === "--tools-json") { tools = parseJsonStringArrayFlag(args[++index], "--tools-json"); continue; }
 		if (argument === "--labels-json") { labels = parseJsonStringArrayFlag(args[++index], "--labels-json"); continue; }
 		if (argument === "--extra-json") { extra = parseJsonObjectFlag(args[++index], "--extra-json"); continue; }
-		if (argument === "--arguments-json") { playbookArguments = parseJsonArrayFlag(args[++index], "--arguments-json"); continue; }
+		if (argument === "--arguments-json") { playbookArguments = parseJsonAnyFlag(args[++index], "--arguments-json"); continue; }
 		if (argument === "--status") { status = args[++index]; if (!status) throw new Error("--status requires a value"); continue; }
 		if (argument === "--text") { text = args[++index]; if (text === undefined) throw new Error("--text requires a value"); continue; }
 		if (argument === "--project-root") { playbookProjectRoot = args[++index]; if (!playbookProjectRoot) throw new Error("--project-root requires a value"); continue; }
@@ -850,7 +854,7 @@ export async function runPlaybooksCli(args: string[], client: TaskCliClient): Pr
 		}
 		case "invoke": {
 			if (!id || second) throw new Error("playbooks invoke requires exactly one playbook id");
-			const invocation = await client.call<Record<string, unknown>, string>("playbooks.invoke", { id });
+			const invocation = await client.call<Record<string, unknown>, string>("playbooks.invoke", { id, arguments: playbookArguments });
 			result = invocation;
 			human = invocation;
 			break;

package/src/daemon.ts

@@ -52,7 +52,11 @@ export function serveMain(): void {
 		clearInterval(purgeTrashTimer);
 		clearDaemonPort(stateDir);
 		service.close();
-		void server.stop(true).finally(() => process.exit(0));
+		// .finally() re-throws rather than handling a rejection -- catching it first turns a bare
+		// unhandled-rejection warning into a real, queryable shutdown-failure log line.
+		void server.stop(true)
+			.catch((error) => logEvent("error", "server_stop_failed", { message: error instanceof Error ? error.message : String(error) }))
+			.finally(() => process.exit(0));
 	};
 	process.on("SIGINT", shutdown);
 	process.on("SIGTERM", shutdown);

package/src/db.ts

@@ -12,13 +12,23 @@ import { SQLITE_BUSY_TIMEOUT_MS, SQLITE_SCHEMA_VERSION } from "./constants.ts";
 
 const require_ = createRequire(import.meta.url);
 const IS_BUN = typeof (globalThis as { Bun?: unknown }).Bun !== "undefined";
-const backend = IS_BUN
-	? (require_("bun:sqlite") as typeof import("bun:sqlite"))
-	: (require_("node:sqlite") as unknown as typeof import("bun:sqlite"));
 
-const DatabaseCtor = (
-	"DatabaseSync" in backend ? (backend as { DatabaseSync: unknown }).DatabaseSync : backend.Database
-) as new (path: string, opts?: { create?: boolean }) => Db;
+/** Bun's bun:sqlite exports Database; Node's node:sqlite exports DatabaseSync -- neither module is
+ * actually the other, but both satisfy this shape at the methods Papyrus calls through Db/DbStatement. */
+interface SqliteBackendModule {
+	Database?: new (path: string, opts?: { create?: boolean }) => Db;
+	DatabaseSync?: new (path: string, opts?: { create?: boolean }) => Db;
+}
+
+const backend = require_(IS_BUN ? "bun:sqlite" : "node:sqlite") as SqliteBackendModule;
+// IIFE + explicit return type, not a bare `const DatabaseCtor = backend.DatabaseSync ?? backend.Database`
+// with a following throw-guard: that guard's narrowing wouldn't propagate into openDb() below, a
+// separate function closing over this module-level binding.
+const DatabaseCtor: new (path: string, opts?: { create?: boolean }) => Db = (() => {
+	const ctor = backend.DatabaseSync ?? backend.Database;
+	if (!ctor) throw new Error("no compatible sqlite backend found (expected bun:sqlite's Database or node:sqlite's DatabaseSync)");
+	return ctor;
+})();
 
 export interface DbStatement {
 	/** changes: number of rows the statement affected. Both bun:sqlite and node:sqlite's real run() return this at runtime; declared here so callers (e.g. reapStale) can rely on it without an unsafe cast. */

package/src/task-service.ts

@@ -286,10 +286,11 @@ export class Tasks {
 		const byId = new Map(tasks.map((task) => [task.id, task]));
 		const focus = this.focusStore.get(filter.sessionId);
 		const focusedId = focus?.taskId;
+		const focusStatus = focus?.status;
 		const nodes = new Map(tasks.map((task) => [task.id, {
 			task,
 			active: task.id === focusedId,
-			...(task.id === focusedId ? { focusStatus: focus!.status } : {}),
+			...(task.id === focusedId ? { focusStatus } : {}),
 			parentIds: [] as string[],
 			childIds: [] as string[],
 			dependencyIds: [] as string[],