@danypops/papyrus 0.27.7 → 0.27.8

package/extension/src/discuss-ask-view.ts

@@ -99,6 +99,18 @@ export interface AskQuestionParams {
 	 * the same live ask run concurrently, each opening its own picker for the same question.
 	 */
 	onUpdate?: AgentToolUpdateCallback;
+	/**
+	 * The tool call's OWN abort signal (execute()'s 3rd parameter) -- fires only if this specific
+	 * tool call is genuinely interrupted (e.g. the human pressed Ctrl+C on the whole agent
+	 * operation). Deliberately NOT `ExtensionContext.signal`: that one tracks "is the agent
+	 * currently streaming a model response" and settles/aborts within a second or two of the
+	 * assistant's tool_call message finishing generation -- which is normal, unrelated bookkeeping
+	 * that happens long before a human actually answers a slow interactive prompt. A live-observed
+	 * bug (the picker silently self-cancelling ~7-10s after opening, well before the human
+	 * finished deciding, with their real answer then arriving disconnected as a stray follow-up)
+	 * traced back to listening on the wrong signal here.
+	 */
+	signal?: AbortSignal;
 }
 
 export interface AskAnswer {
@@ -1200,9 +1212,9 @@ async function askQuestionBlocking(
 	let hasAnnouncedHide = false;
 	let response: AskResponse | null;
 	try {
-		diag("factory about to construct AskComponent", { hasSignal: ctx.signal !== undefined, signalAlreadyAborted: ctx.signal?.aborted ?? null, hasExplicitTimeout: params.timeout !== undefined });
+		diag("factory about to construct AskComponent", { hasSignal: params.signal !== undefined, signalAlreadyAborted: params.signal?.aborted ?? null, hasExplicitTimeout: params.timeout !== undefined });
 		const factory = (tui: TUI, theme: Theme, keybindings: KeybindingsManager, done: (result: AskResponse | null) => void) => {
-			if (ctx.signal) ctx.signal.addEventListener("abort", () => { diag("ctx.signal fired abort -- resolving null"); done(null); }, { once: true });
+			if (params.signal) params.signal.addEventListener("abort", () => { diag("tool call signal fired abort -- resolving null"); done(null); }, { once: true });
 			if (params.timeout && params.timeout > 0) setTimeout(() => { diag("explicit params.timeout expired -- resolving null", { timeout: params.timeout }); done(null); }, params.timeout);
 			return new AskComponent(params.question, normalizedContext, options, allowMultiple, allowFreeform, allowComment, displayMode, tui, theme, keybindings, shortcuts, done);
 		};

package/extension/src/domain-tools.ts

@@ -39,7 +39,7 @@ function text(message: string, details: unknown = {}) {
  * is available, never throws -- an unanswered live prompt still leaves the round it already
  * recorded intact.
  */
-async function liveAnswer(ctx: ExtensionContext, discussion: Artifact, onUpdate: AgentToolUpdateCallback | undefined): Promise<{ content: string; selected?: string[] } | undefined> {
+async function liveAnswer(ctx: ExtensionContext, discussion: Artifact, onUpdate: AgentToolUpdateCallback | undefined, signal: AbortSignal | undefined): Promise<{ content: string; selected?: string[] } | undefined> {
 	if (!ctx.hasUI) return undefined;
 	const pending = (() => { try { return readDiscussionExtra(discussion.extra); } catch { return undefined; } })();
 	const question = `Reply to "${discussion.title}":`;
@@ -49,10 +49,11 @@ async function liveAnswer(ctx: ExtensionContext, discussion: Artifact, onUpdate:
 			options: pending.pendingOptions.map((title) => ({ title })),
 			allowMultiple: pending.pendingOptionsMode === "multi",
 			onUpdate,
+			signal,
 			key: discussion.id,
 		});
 	}
-	return askQuestion(ctx, { question, onUpdate, key: discussion.id });
+	return askQuestion(ctx, { question, onUpdate, signal, key: discussion.id });
 }
 
 /**
@@ -705,7 +706,7 @@ export function registerDomainTools(pi: ExtensionAPI): void {
 		executionMode: "sequential",
 		renderCall(args, theme) { return renderPapyrusToolCall("Discuss", args, theme); },
 		renderResult(result, options, theme, context) { return renderPapyrusToolResult(result, options, theme, context); },
-		async execute(_id, rawParams, _signal, onUpdate, ctx) {
+		async execute(_id, rawParams, signal, onUpdate, ctx) {
 			try {
 				const params: Record<string, unknown> = { ...rawParams };
 				const action = params.action;
@@ -722,7 +723,7 @@ export function registerDomainTools(pi: ExtensionAPI): void {
 						? text(`Opened discussion ${artifactLine(result.discussion)}`, createArtifactDetails("discuss.open", result.discussion))
 						: text(`Round ${result.rounds[0]?.roundNumber} added to "${result.discussion.title}"`, createArtifactDetails("discuss.reply", result.discussion));
 					if (params.live !== true) return fallback;
-					const answer = await liveAnswer(ctx, result.discussion, onUpdate);
+					const answer = await liveAnswer(ctx, result.discussion, onUpdate, signal);
 					if (!answer) return fallback;
 					const answered = await callService<Record<string, unknown>, DiscussionAndRounds>("discuss.reply", {
 						id: result.discussion.id, actor: "human", content: answer.content, ...(answer.selected ? { selected: answer.selected } : {}), source: "discuss-live",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/papyrus",
-  "version": "0.27.7",
+  "version": "0.27.8",
   "description": "Daemon-backed graph artifacts, evidence-bearing tasks, rules, skills, and native TUI workflows for Pi",
   "type": "module",
   "keywords": ["pi-package"],