@danypops/papyrus 0.11.1 → 0.11.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danypops/papyrus",
-  "version": "0.11.1",
+  "version": "0.11.2",
   "description": "Daemon-backed graph artifacts, evidence-bearing tasks, rules, skills, and native TUI workflows for Pi",
   "type": "module",
   "keywords": ["pi-package"],

package/src/constants.ts

@@ -142,6 +142,22 @@ export const SEED_STATUSES = [
 	{ name: "deprecated", kind: "skill" },
 ] as const;
 
+/**
+ * The initial status a newly created artifact of a kind gets when no caller-supplied
+ * status is given. This must be an explicit, named mapping — never derived from row order
+ * in the `statuses` table (SEED_STATUSES' listed order, or a migration's insertion order,
+ * is not a semantic guarantee; a migrated database can freely have a different physical
+ * row order for the same logical status set). Deriving "the default" from "whichever row
+ * happens to be first by rowid" was the root cause of a real production defect where
+ * migrated databases created new Tasks as done instead of todo.
+ */
+export const DEFAULT_STATUS_BY_KIND: Readonly<Record<string, string>> = {
+	doc: "draft",
+	task: "todo",
+	rule: "active",
+	skill: "active",
+};
+
 /**
  * Universal relation names — any kind can link to any kind.
  *

package/src/ops.ts

@@ -6,6 +6,7 @@ import { createRequire } from "node:module";
 import { exec } from "node:child_process";
 import type { Db } from "./db.ts";
 import { inTransaction } from "./db.ts";
+import { DEFAULT_STATUS_BY_KIND } from "./constants.ts";
 import type { Artifact, ArtifactQuery, CreateArtifactInput, UpdateArtifactInput } from "./domain/artifact.ts";
 import type { Gate, GateResult, GateRunOptions } from "./domain/gate.ts";
 export type { Artifact } from "./domain/artifact.ts";
@@ -102,9 +103,13 @@ function slugify(s: string): string {
 }
 
 function defaultStatusFor(db: Db, kind: string): string {
-	// First-inserted status per kind (seed order defines the default)
-	const row = db.prepare("SELECT name FROM statuses WHERE kind = ? ORDER BY rowid LIMIT 1").get(kind) as { name: string } | null;
-	return row?.name ?? "draft";
+	// Explicit per-kind mapping, never row order -- see DEFAULT_STATUS_BY_KIND's doc comment
+	// for the production defect this replaced (row order is not a semantic guarantee).
+	const candidate = DEFAULT_STATUS_BY_KIND[kind];
+	if (candidate === undefined) throw new Error(`no default status is configured for kind "${kind}"`);
+	const exists = db.prepare("SELECT 1 FROM statuses WHERE kind = ? AND name = ?").get(kind, candidate);
+	if (!exists) throw new Error(`configured default status "${candidate}" for kind "${kind}" is not a registered status`);
+	return candidate;
 }
 
 function rowToArtifact(row: Record<string, unknown>): Artifact {