@danieltmn/tamnora 0.16.1 → 0.18.0

package/harness/packages/core/test/redact.test.js

@@ -3,10 +3,12 @@ import assert from 'node:assert/strict';
 import {
   REDACTED,
   isSecretName,
+  isSensitiveEnvName,
   maskEnv,
   maskSecret,
   redactDeep,
   redactSecrets,
+  scrubEnv,
   secretValues,
 } from '../src/redact.js';
 
@@ -43,3 +45,23 @@ test('maskSecret y maskEnv enmascaran sin exponer el valor', () => {
     MYSQL_PASSWORD: '••••cret',
   });
 });
+
+test('scrubEnv quita credenciales pero conserva vars legitimas', () => {
+  const env = {
+    PATH: '/usr/bin',
+    HOME: '/home/ana',
+    OPENROUTER_API_KEY: 'sk-xxx',
+    GITHUB_TOKEN: 'ghp_yyy',
+    MYSQL_PASSWORD: 'zzz',
+    SSH_AUTH_SOCK: '/tmp/agent.sock',
+  };
+  const clean = scrubEnv(env);
+  assert.equal(clean.PATH, '/usr/bin');
+  assert.equal(clean.HOME, '/home/ana');
+  assert.equal(clean.SSH_AUTH_SOCK, '/tmp/agent.sock');
+  assert.equal(clean.OPENROUTER_API_KEY, undefined);
+  assert.equal(clean.GITHUB_TOKEN, undefined);
+  assert.equal(clean.MYSQL_PASSWORD, undefined);
+  assert.equal(isSensitiveEnvName('SSH_AUTH_SOCK'), false);
+  assert.equal(isSensitiveEnvName('OPENAI_API_KEY'), true);
+});

package/harness/packages/core/test/skills.test.js

@@ -5,6 +5,7 @@ import { tmpdir } from 'node:os';
 import path from 'node:path';
 import { parseSkillMarkdown, loadSkills, mergeSkills, buildSkillsPrompt, buildSkillsIndex } from '../src/skills/index.js';
 import { parseSkillRef } from '../src/skills/remote.js';
+import { SKILLS_CATALOG, skillCatalogEntry } from '../src/skills/catalog.js';
 
 test('parseSkillMarkdown reads frontmatter and body', () => {
   const parsed = parseSkillMarkdown(
@@ -76,3 +77,13 @@ test('buildSkillsIndex lists id + when without the body (progressive disclosure)
   assert.match(text, /skill\(\{ name \}\)/);
   assert.doesNotMatch(text, /SECRETO_BODY/);
 });
+
+test('el catálogo de skills trae cuerpo con frontmatter parseable', () => {
+  assert.ok(SKILLS_CATALOG.length > 0);
+  for (const entry of SKILLS_CATALOG) {
+    assert.match(entry.id, /^[a-z0-9][a-z0-9_-]*$/);
+    assert.ok(entry.body.trim().length > 0);
+  }
+  assert.equal(skillCatalogEntry('code-review').id, 'code-review');
+  assert.equal(skillCatalogEntry('nope'), null);
+});

package/harness/packages/core/test/tools.test.js

@@ -4,9 +4,17 @@ import { mkdtemp, readFile, writeFile, mkdir } from 'node:fs/promises';
 import { tmpdir } from 'node:os';
 import path from 'node:path';
 import { resolveInRoot, toRel } from '../src/tools/paths.js';
-import { evaluatePermission } from '../src/tools/permissions.js';
+import { evaluatePermission, bashGuard } from '../src/tools/permissions.js';
 import { createTools, createToolRegistry } from '../src/tools/index.js';
-import { fetchUrlTool, previewUrlTool, screenshotTool, consoleTool } from '../src/tools/executors.js';
+import {
+  fetchUrlTool,
+  previewUrlTool,
+  screenshotTool,
+  consoleTool,
+  askUserTool,
+  offerChoicesTool,
+  showPlanTool,
+} from '../src/tools/executors.js';
 
 async function makeWorkspace() {
   const root = await mkdtemp(path.join(tmpdir(), 'tamnora-ws-'));
@@ -36,6 +44,23 @@ test('evaluatePermission applies defaults and pattern maps', () => {
   );
 });
 
+test('bashGuard marca comandos peligrosos (piso de seguridad)', () => {
+  assert.equal(bashGuard('rm -rf /'), 'deny');
+  assert.equal(bashGuard('sudo rm -rf ~'), 'deny');
+  assert.equal(bashGuard('mkfs.ext4 /dev/sda1'), 'deny');
+  assert.equal(bashGuard('dd if=/dev/zero of=/dev/sda'), 'deny');
+  assert.equal(bashGuard('git push --force origin main'), 'ask');
+  assert.equal(bashGuard('git reset --hard HEAD~3'), 'ask');
+  assert.equal(bashGuard('rm -rf .'), 'ask');
+  assert.equal(bashGuard('rm -rf ./build'), null);
+  assert.equal(bashGuard('npm test'), null);
+
+  // El piso no se saltea con una policy permisiva.
+  assert.equal(evaluatePermission('bash', { command: 'rm -rf /' }, { bash: 'allow' }), 'deny');
+  assert.equal(evaluatePermission('bash', { command: 'git push -f' }, { bash: 'allow' }), 'ask');
+  assert.equal(evaluatePermission('bash', { command: 'rm -rf ./dist' }, { bash: 'allow' }), 'allow');
+});
+
 test('local tools read, write, list, glob, grep and edit', async () => {
   const root = await makeWorkspace();
   const reg = createToolRegistry({ root, permissions: { write: 'allow', edit: 'allow' } });
@@ -144,7 +169,10 @@ test('createTools combines local and MCP tool routing', async () => {
     handles: (n) => n === 'mcp__x__ping',
     call: async () => 'pong',
   };
-  const { definitions, execute } = createTools({ root, mcp });
+  const denied = createTools({ root, mcp });
+  assert.match(await denied.execute('mcp__x__ping', {}), /denegado/);
+
+  const { definitions, execute } = createTools({ root, mcp, permissions: { 'mcp__x__ping': 'allow' } });
   assert.ok(definitions.some((d) => d.function.name === 'mcp__x__ping'));
   assert.equal(await execute('mcp__x__ping', {}), 'pong');
   assert.match(await execute('nope', {}), /desconocida/);
@@ -158,6 +186,23 @@ test('bash runs inside the workspace root', async () => {
   assert.match(out, /\[exit 0\]/);
 });
 
+test('bash no hereda variables con pinta de secreto', async () => {
+  const root = await makeWorkspace();
+  process.env.TAMNORA_TEST_API_KEY = 'supersecret123';
+  process.env.TAMNORA_TEST_OK = 'visible';
+  try {
+    const reg = createToolRegistry({ root, permissions: { bash: 'allow' } });
+    const out = await reg.execute('bash', {
+      command: `node -e "process.stdout.write('K='+String(process.env.TAMNORA_TEST_API_KEY)+' O='+process.env.TAMNORA_TEST_OK)"`,
+    });
+    assert.doesNotMatch(out, /supersecret123/);
+    assert.match(out, /visible/);
+  } finally {
+    delete process.env.TAMNORA_TEST_API_KEY;
+    delete process.env.TAMNORA_TEST_OK;
+  }
+});
+
 test('bash se cancela cuando aborta la señal del run', async () => {
   const root = await makeWorkspace();
   const ac = new AbortController();
@@ -202,3 +247,52 @@ test('screenshot, console_errors y preview_url validan la URL sin lanzar el nave
     assert.ok(definitions.some((d) => d.function.name === name), `falta ${name}`);
   }
 });
+
+test('ask_user: fallback sin canal y respuestas formateadas con onQuestion', async () => {
+  assert.match(await askUserTool(null, {}), /Error/);
+  assert.match(await askUserTool(null, { questions: [{ id: 'n', label: 'Nombre' }] }), /canal/);
+
+  const out = await askUserTool(
+    null,
+    {
+      questions: [
+        { id: 'n', label: 'Nombre' },
+        { id: 'f', label: 'Framework', type: 'select', options: ['React', 'Vue'] },
+      ],
+    },
+    { onQuestion: async () => ({ ok: true, answers: { n: 'Ana', f: 'Vue' } }) }
+  );
+  assert.match(out, /Nombre: Ana/);
+  assert.match(out, /Framework: Vue/);
+
+  const cancelled = await askUserTool(null, { questions: [{ id: 'n', label: 'N' }] }, { onQuestion: async () => ({ ok: false }) });
+  assert.match(cancelled, /no respondi/i);
+
+  assert.equal(evaluatePermission('ask_user', {}, {}), 'allow');
+  const { definitions } = createTools({ root: await makeWorkspace() });
+  assert.ok(definitions.some((d) => d.function.name === 'ask_user'));
+});
+
+test('offer_choices valida question y options', async () => {
+  assert.match(offerChoicesTool(null, {}), /Error/);
+  const out = offerChoicesTool(null, { question: '¿Sigo?', options: ['sí', 'no'] });
+  assert.match(out, /sí/);
+  assert.match(out, /no/);
+  assert.equal(evaluatePermission('offer_choices', {}, {}), 'allow');
+});
+
+test('show_plan valida steps y marca el estado', () => {
+  assert.match(showPlanTool(null, {}), /Error/);
+  const out = showPlanTool(null, {
+    title: 'Plan',
+    steps: [
+      { text: 'Uno', status: 'done' },
+      { text: 'Dos', status: 'active' },
+      { text: 'Tres' },
+    ],
+  });
+  assert.match(out, /\[x\] Uno/);
+  assert.match(out, /\[~\] Dos/);
+  assert.match(out, /\[ \] Tres/);
+  assert.equal(evaluatePermission('show_plan', {}, {}), 'allow');
+});