@danielmarbach/mnemonic-mcp 0.28.0 → 0.30.0

package/build/vault.js

@@ -1,7 +1,7 @@
 import fs from "fs/promises";
 import path from "path";
 import { simpleGit } from "simple-git";
-import { debugLog, getErrorMessage } from "./error-utils.js";
+import { attempt, debugLog, getErrorMessage } from "./error-utils.js";
 import { Storage } from "./storage.js";
 import { memoryId } from "./brands.js";
 import { GitOps } from "./git.js";
@@ -200,58 +200,48 @@ function makeVault(vaultPath, gitRoot, notesRelDir, isProject, vaultFolderName,
  * namespaces for submodule-specific context while sharing the same git history.
  */
 async function discoverSubmoduleVaultFolders(gitRoot) {
-    try {
-        const entries = await fs.readdir(gitRoot, { withFileTypes: true });
-        return entries
-            .filter(e => e.isDirectory() && e.name.startsWith(".mnemonic-"))
-            .map(e => e.name)
-            .sort();
-    }
-    catch (err) {
-        debugLog("vault:discover-submodules", `failed: ${getErrorMessage(err)}`);
+    const result = await attempt("vault:discover-submodules", () => fs.readdir(gitRoot, { withFileTypes: true }));
+    if (!result.ok) {
+        debugLog("vault:discover-submodules", `failed: ${getErrorMessage(result.error)}`);
         return [];
     }
+    return result.value
+        .filter(e => e.isDirectory() && e.name.startsWith(".mnemonic-"))
+        .map(e => e.name)
+        .sort();
 }
 async function findGitRoot(cwd, visited = new Set()) {
-    try {
-        const git = simpleGit(cwd);
-        const root = await git.revparse(["--show-toplevel"]);
-        const trimmedRoot = root.trim();
-        if (!trimmedRoot)
-            return null;
-        // Guard against infinite recursion in pathological submodule configurations.
-        if (visited.has(trimmedRoot))
-            return trimmedRoot;
-        visited.add(trimmedRoot);
-        // When inside a git submodule, walk up to the top-level superproject root
-        // so that project vaults are always anchored at the main repository.
-        try {
-            const superproject = await git.revparse(["--show-superproject-working-tree"]);
-            const trimmedSuperproject = superproject.trim();
-            if (trimmedSuperproject) {
-                return findGitRoot(trimmedSuperproject, visited);
-            }
-        }
-        catch {
-            debugLog("vault:find-git-root", "not inside a submodule or flag unsupported, using current root");
-        }
-        return trimmedRoot;
+    const git = simpleGit(cwd);
+    const rootResult = await attempt("vault:find-git-root", () => git.revparse(["--show-toplevel"]));
+    if (!rootResult.ok) {
+        debugLog("vault:find-git-root", `failed: ${getErrorMessage(rootResult.error)}`);
+        return null;
     }
-    catch (err) {
-        debugLog("vault:find-git-root", `failed: ${getErrorMessage(err)}`);
+    const trimmedRoot = rootResult.value.trim();
+    if (!trimmedRoot)
         return null;
+    if (visited.has(trimmedRoot))
+        return trimmedRoot;
+    visited.add(trimmedRoot);
+    const superResult = await attempt("vault:find-git-root:superproject", () => git.revparse(["--show-superproject-working-tree"]));
+    if (superResult.ok) {
+        const trimmedSuperproject = superResult.value.trim();
+        if (trimmedSuperproject) {
+            return findGitRoot(trimmedSuperproject, visited);
+        }
     }
+    else {
+        debugLog("vault:find-git-root", "not inside a submodule or flag unsupported, using current root");
+    }
+    return trimmedRoot;
 }
 export async function ensureGitignore(ignorePath) {
     const requiredLines = ["embeddings/", "projections/"];
-    let existing;
-    try {
-        existing = await fs.readFile(ignorePath, "utf-8");
-    }
-    catch (err) {
-        debugLog("vault:ensure-gitignore", `no existing gitignore: ${getErrorMessage(err)}`);
-        existing = "";
-    }
+    const existingResult = await attempt("vault:ensure-gitignore", () => fs.readFile(ignorePath, "utf-8"));
+    const existing = existingResult.ok ? existingResult.value : (() => {
+        debugLog("vault:ensure-gitignore", `no existing gitignore: ${getErrorMessage(existingResult.error)}`);
+        return "";
+    })();
     const missing = requiredLines.filter(line => !existing.includes(line));
     if (missing.length === 0)
         return;
@@ -259,12 +249,7 @@ export async function ensureGitignore(ignorePath) {
     await fs.writeFile(ignorePath, updated);
 }
 async function pathExists(p) {
-    try {
-        await fs.access(p);
-        return true;
-    }
-    catch {
-        return false;
-    }
+    const result = await attempt("vault:pathExists", () => fs.access(p));
+    return result.ok;
 }
 //# sourceMappingURL=vault.js.map

package/build/vault.js.map

@@ -1 +1 @@
-{"version":3,"file":"vault.js","sourceRoot":"","sources":["../src/vault.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,aAAa,CAAC;AAC7B,OAAO,IAAI,MAAM,MAAM,CAAC;AACxB,OAAO,EAAE,SAAS,EAAE,MAAM,YAAY,CAAC;AAEvC,OAAO,EAAE,QAAQ,EAAE,eAAe,EAAE,MAAM,kBAAkB,CAAC;AAC7D,OAAO,EAAE,OAAO,EAAa,MAAM,cAAc,CAAC;AAClD,OAAO,EAAE,QAAQ,EAAE,MAAM,aAAa,CAAC;AACvC,OAAO,EAAE,MAAM,EAAE,MAAM,UAAU,CAAC;AAuBlC,gFAAgF;AAEhF,MAAM,OAAO,YAAY;IACd,IAAI,CAAQ;IACrB;;;OAGG;IACK,oBAAoB,GAAG,IAAI,GAAG,EAAiB,CAAC;IACxD;;;OAGG;IACK,sBAAsB,GAAG,IAAI,GAAG,EAAmB,CAAC;IAC5D,yDAAyD;IACjD,WAAW,GAAG,EAAE,CAAC;IAEzB,YAAY,aAAqB;QAC/B,MAAM,QAAQ,GAAG,IAAI,CAAC,OAAO,CAAC,aAAa,CAAC,CAAC;QAC7C,IAAI,CAAC,IAAI,GAAG,SAAS,CAAC,QAAQ,EAAE,QAAQ,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE,CAAC,CAAC;IAChE,CAAC;IAED,KAAK,CAAC,QAAQ;QACZ,MAAM,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC;QAC/B,MAAM,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,EAAE,CAAC;QAC3B,MAAM,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,SAAS,EAAE,YAAY,CAAC,CAAC,CAAC;QAC5E,IAAI,CAAC,WAAW,GAAG,CAAC,MAAM,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,SAAS,CAAC;IACrG,CAAC;IAED;;;;;OAKG;IACH,KAAK,CAAC,uBAAuB,CAAC,GAAW;QACvC,MAAM,OAAO,GAAG,MAAM,WAAW,CAAC,GAAG,CAAC,CAAC;QACvC,IAAI,CAAC,OAAO,IAAI,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC;YAAE,OAAO,IAAI,CAAC;QACtD,OAAO,IAAI,CAAC,oBAAoB,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC;IAClD,CAAC;IAED;;;;OAIG;IACH,KAAK,CAAC,uBAAuB,CAAC,GAAW;QACvC,MAAM,OAAO,GAAG,MAAM,WAAW,CAAC,GAAG,CAAC,CAAC;QACvC,IAAI,CAAC,OAAO,IAAI,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC;YAAE,OAAO,IAAI,CAAC;QACtD,OAAO,IAAI,CAAC,oBAAoB,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;IACnD,CAAC;IAED;;;;OAIG;IACH,KAAK,CAAC,gBAAgB,CAAC,GAAW,EAAE,UAAkB;QACpD,MAAM,OAAO,GAAG,MAAM,WAAW,CAAC,GAAG,CAAC,CAAC;QACvC,IAAI,CAAC,OAAO,IAAI,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC;YAAE,OAAO,IAAI,CAAC;QACtD,MAAM,QAAQ,GAAG,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC;QAEvC,0EAA0E;QAC1E,IAAI,CAAC,IAAI,CAAC,sBAAsB,CAAC,GAAG,CAAC,QAAQ,CAAC,EAAE,CAAC;YAC/C,MAAM,IAAI,CAAC,oBAAoB,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;QAClD,CAAC;QAED,OAAO,IAAI,CAAC,sBAAsB,CAAC,GAAG,CAAC,QAAQ,CAAC,EAAE,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,eAAe,KAAK,UAAU,CAAC,IAAI,IAAI,CAAC;IACxG,CAAC;IAED;;;OAGG;IACH,KAAK,CAAC,QAAQ,CAAC,EAAU,EAAE,GAAY;QACrC,MAAM,WAAW,GAAG,QAAQ,CAAC,EAAE,CAAC,CAAC;QACjC,KAAK,MAAM,KAAK,IAAI,MAAM,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,EAAE,CAAC;YAChD,MAAM,IAAI,GAAG,MAAM,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAC,WAAW,CAAC,CAAC;YACvD,IAAI,IAAI;gBAAE,OAAO,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC;QACnC,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;IAED,mGAAmG;IACnG,cAAc;QACZ,MAAM,GAAG,GAAY,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACjC,KAAK,MAAM,MAAM,IAAI,IAAI,CAAC,sBAAsB,CAAC,MAAM,EAAE,EAAE,CAAC;YAC1D,GAAG,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC,CAAC;QACtB,CAAC;QACD,OAAO,GAAG,CAAC;IACb,CAAC;IAED;;;;OAIG;IACH,KAAK,CAAC,WAAW,CAAC,GAAY;QAC5B,MAAM,MAAM,GAAY,EAAE,CAAC;QAC3B,IAAI,GAAG,EAAE,CAAC;YACR,MAAM,OAAO,GAAG,MAAM,WAAW,CAAC,GAAG,CAAC,CAAC;YACvC,IAAI,OAAO,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC,EAAE,CAAC;gBACzC,MAAM,EAAE,GAAG,MAAM,IAAI,CAAC,oBAAoB,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;gBAC3D,IAAI,EAAE,EAAE,CAAC;oBACP,MAAM,GAAG,GAAG,IAAI,CAAC,sBAAsB,CAAC,GAAG,CAAC,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC;oBACnE,IAAI,GAAG,EAAE,CAAC;wBACR,MAAM,CAAC,IAAI,CAAC,GAAG,GAAG,CAAC,CAAC;oBACtB,CAAC;yBAAM,CAAC;wBACN,qEAAqE;wBACrE,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;oBAClB,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;QACD,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACvB,OAAO,MAAM,CAAC;IAChB,CAAC;IAED,uEAAuE;IACvE,WAAW,CAAC,KAAY,EAAE,MAAc;QACtC,OAAO,GAAG,KAAK,CAAC,WAAW,IAAI,MAAM,KAAK,CAAC;IAC7C,CAAC;IAED;;;OAGG;IACH,KAAK,CAAC,mBAAmB,CAAC,KAAY,EAAE,OAAiB;QACvD,MAAM,MAAM,GAAG,MAAM,KAAK,CAAC,GAAG,CAAC,MAAM,EAAE,CAAC;QACxC,MAAM,YAAY,GAAa,EAAE,CAAC;QAClC,KAAK,MAAM,MAAM,IAAI,OAAO,EAAE,CAAC;YAC7B,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC;YACjD,IAAI,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,IAAI,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,QAAQ,CAAC,EAAE,CAAC;gBAC3E,YAAY,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;YAC9B,CAAC;QACH,CAAC;QACD,OAAO,YAAY,CAAC;IACtB,CAAC;IAED,+EAA+E;IAEvE,UAAU,CAAC,OAAe;QAChC,OAAO,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,KAAK,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IAClE,CAAC;IAED;;;;OAIG;IACK,KAAK,CAAC,oBAAoB,CAAC,OAAe,EAAE,MAAe;QACjE,MAAM,QAAQ,GAAG,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC;QAEvC,IAAI,IAAI,CAAC,oBAAoB,CAAC,GAAG,CAAC,QAAQ,CAAC,EAAE,CAAC;YAC5C,OAAO,IAAI,CAAC,oBAAoB,CAAC,GAAG,CAAC,QAAQ,CAAE,CAAC;QAClD,CAAC;QAED,MAAM,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QAEtD,IAAI,CAAC,MAAM,IAAI,CAAC,CAAC,MAAM,UAAU,CAAC,YAAY,CAAC,CAAC;YAAE,OAAO,IAAI,CAAC;QAE9D,MAAM,YAAY,GAAG,SAAS,CAAC,YAAY,EAAE,QAAQ,EAAE,iBAAiB,EAAE,IAAI,EAAE,WAAW,CAAC,CAAC;QAC7F,MAAM,YAAY,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC;QAClC,MAAM,YAAY,CAAC,GAAG,CAAC,IAAI,EAAE,CAAC;QAE9B,IAAI,MAAM,EAAE,CAAC;YACX,MAAM,aAAa,GAAG,IAAI,CAAC,IAAI,CAAC,YAAY,EAAE,YAAY,CAAC,CAAC;YAC5D,MAAM,KAAK,GAAG,CAAC,CAAC,MAAM,UAAU,CAAC,aAAa,CAAC,CAAC,CAAC;YACjD,MAAM,eAAe,CAAC,aAAa,CAAC,CAAC;YAErC,IAAI,KAAK,EAAE,CAAC;gBACV,iEAAiE;gBACjE,MAAM,YAAY,CAAC,GAAG,CAAC,MAAM,CAAC,mCAAmC,EAAE,CAAC,sBAAsB,CAAC,CAAC,CAAC;YAC/F,CAAC;QACH,CAAC;QAED,IAAI,CAAC,oBAAoB,CAAC,GAAG,CAAC,QAAQ,EAAE,YAAY,CAAC,CAAC;QAEtD,gFAAgF;QAChF,oFAAoF;QACpF,uDAAuD;QACvD,MAAM,SAAS,GAAY,CAAC,YAAY,CAAC,CAAC;QAC1C,MAAM,oBAAoB,GAAG,MAAM,6BAA6B,CAAC,QAAQ,CAAC,CAAC;QAC3E,KAAK,MAAM,UAAU,IAAI,oBAAoB,EAAE,CAAC;YAC9C,MAAM,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,QAAQ,EAAE,UAAU,CAAC,CAAC;YACrD,IAAI,CAAC,CAAC,MAAM,UAAU,CAAC,YAAY,CAAC,CAAC;gBAAE,SAAS;YAChD,MAAM,WAAW,GAAG,GAAG,UAAU,QAAQ,CAAC;YAC1C,MAAM,QAAQ,GAAG,SAAS,CACxB,YAAY,EACZ,QAAQ,EACR,WAAW,EACX,IAAI,EACJ,UAAU,EACV,YAAY,CAAC,OAAO,CAAC,aAAa,CACnC,CAAC;YACF,MAAM,QAAQ,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC;YAC9B,MAAM,QAAQ,CAAC,GAAG,CAAC,IAAI,EAAE,CAAC;YAC1B,SAAS,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAC3B,CAAC;QAED,IAAI,CAAC,sBAAsB,CAAC,GAAG,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAC;QACrD,OAAO,YAAY,CAAC;IACtB,CAAC;CACF;AAED,iFAAiF;AAEjF,SAAS,SAAS,CAChB,SAAiB,EACjB,OAAe,EACf,WAAmB,EACnB,SAAkB,EAClB,eAAuB,EACvB,qBAA8B;IAE9B,OAAO;QACL,OAAO,EAAE,IAAI,OAAO,CAAC,SAAS,EAAE,qBAAqB,CAAC;QACtD,GAAG,EAAE,IAAI,MAAM,CAAC,OAAO,EAAE,WAAW,CAAC;QACrC,WAAW;QACX,SAAS;QACT,eAAe;KAChB,CAAC;AACJ,CAAC;AAED;;;;GAIG;AACH,KAAK,UAAU,6BAA6B,CAAC,OAAe;IAC1D,IAAI,CAAC;QACH,MAAM,OAAO,GAAG,MAAM,EAAE,CAAC,OAAO,CAAC,OAAO,EAAE,EAAE,aAAa,EAAE,IAAI,EAAE,CAAC,CAAC;QACnE,OAAO,OAAO;aACX,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,WAAW,EAAE,IAAI,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,YAAY,CAAC,CAAC;aAC/D,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC;aAChB,IAAI,EAAE,CAAC;IACZ,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,QAAQ,CAAC,2BAA2B,EAAE,WAAW,eAAe,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;QACzE,OAAO,EAAE,CAAC;IACZ,CAAC;AACH,CAAC;AAED,KAAK,UAAU,WAAW,CAAC,GAAW,EAAE,UAAuB,IAAI,GAAG,EAAE;IACtE,IAAI,CAAC;QACH,MAAM,GAAG,GAAG,SAAS,CAAC,GAAG,CAAC,CAAC;QAC3B,MAAM,IAAI,GAAG,MAAM,GAAG,CAAC,QAAQ,CAAC,CAAC,iBAAiB,CAAC,CAAC,CAAC;QACrD,MAAM,WAAW,GAAG,IAAI,CAAC,IAAI,EAAE,CAAC;QAChC,IAAI,CAAC,WAAW;YAAE,OAAO,IAAI,CAAC;QAE9B,6EAA6E;QAC7E,IAAI,OAAO,CAAC,GAAG,CAAC,WAAW,CAAC;YAAE,OAAO,WAAW,CAAC;QACjD,OAAO,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;QAEzB,0EAA0E;QAC1E,qEAAqE;QACrE,IAAI,CAAC;YACH,MAAM,YAAY,GAAG,MAAM,GAAG,CAAC,QAAQ,CAAC,CAAC,kCAAkC,CAAC,CAAC,CAAC;YAC9E,MAAM,mBAAmB,GAAG,YAAY,CAAC,IAAI,EAAE,CAAC;YAChD,IAAI,mBAAmB,EAAE,CAAC;gBACxB,OAAO,WAAW,CAAC,mBAAmB,EAAE,OAAO,CAAC,CAAC;YACnD,CAAC;QACH,CAAC;QAAC,MAAM,CAAC;YACP,QAAQ,CAAC,qBAAqB,EAAE,gEAAgE,CAAC,CAAC;QACpG,CAAC;QAED,OAAO,WAAW,CAAC;IACrB,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,QAAQ,CAAC,qBAAqB,EAAE,WAAW,eAAe,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;QACnE,OAAO,IAAI,CAAC;IACd,CAAC;AACH,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,eAAe,CAAC,UAAkB;IACtD,MAAM,aAAa,GAAG,CAAC,aAAa,EAAE,cAAc,CAAC,CAAC;IACtD,IAAI,QAAgB,CAAC;IACrB,IAAI,CAAC;QACH,QAAQ,GAAG,MAAM,EAAE,CAAC,QAAQ,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC;IACpD,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,QAAQ,CAAC,wBAAwB,EAAE,0BAA0B,eAAe,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;QACrF,QAAQ,GAAG,EAAE,CAAC;IAChB,CAAC;IACD,MAAM,OAAO,GAAG,aAAa,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC;IACvE,IAAI,OAAO,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO;IACjC,MAAM,OAAO,GAAG,QAAQ,CAAC,OAAO,EAAE,GAAG,IAAI,GAAG,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC;IACtE,MAAM,EAAE,CAAC,SAAS,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC;AAC1C,CAAC;AAED,KAAK,UAAU,UAAU,CAAC,CAAS;IACjC,IAAI,CAAC;QACH,MAAM,EAAE,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;QACnB,OAAO,IAAI,CAAC;IACd,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,KAAK,CAAC;IACf,CAAC;AACH,CAAC"}
+{"version":3,"file":"vault.js","sourceRoot":"","sources":["../src/vault.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,aAAa,CAAC;AAC7B,OAAO,IAAI,MAAM,MAAM,CAAC;AACxB,OAAO,EAAE,SAAS,EAAE,MAAM,YAAY,CAAC;AAEvC,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,eAAe,EAAE,MAAM,kBAAkB,CAAC;AACtE,OAAO,EAAE,OAAO,EAAa,MAAM,cAAc,CAAC;AAClD,OAAO,EAAE,QAAQ,EAAE,MAAM,aAAa,CAAC;AACvC,OAAO,EAAE,MAAM,EAAE,MAAM,UAAU,CAAC;AAuBlC,gFAAgF;AAEhF,MAAM,OAAO,YAAY;IACd,IAAI,CAAQ;IACrB;;;OAGG;IACK,oBAAoB,GAAG,IAAI,GAAG,EAAiB,CAAC;IACxD;;;OAGG;IACK,sBAAsB,GAAG,IAAI,GAAG,EAAmB,CAAC;IAC5D,yDAAyD;IACjD,WAAW,GAAG,EAAE,CAAC;IAEzB,YAAY,aAAqB;QAC/B,MAAM,QAAQ,GAAG,IAAI,CAAC,OAAO,CAAC,aAAa,CAAC,CAAC;QAC7C,IAAI,CAAC,IAAI,GAAG,SAAS,CAAC,QAAQ,EAAE,QAAQ,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE,CAAC,CAAC;IAChE,CAAC;IAED,KAAK,CAAC,QAAQ;QACZ,MAAM,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC;QAC/B,MAAM,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,EAAE,CAAC;QAC3B,MAAM,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,SAAS,EAAE,YAAY,CAAC,CAAC,CAAC;QAC5E,IAAI,CAAC,WAAW,GAAG,CAAC,MAAM,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,SAAS,CAAC;IACrG,CAAC;IAED;;;;;OAKG;IACH,KAAK,CAAC,uBAAuB,CAAC,GAAW;QACvC,MAAM,OAAO,GAAG,MAAM,WAAW,CAAC,GAAG,CAAC,CAAC;QACvC,IAAI,CAAC,OAAO,IAAI,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC;YAAE,OAAO,IAAI,CAAC;QACtD,OAAO,IAAI,CAAC,oBAAoB,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC;IAClD,CAAC;IAED;;;;OAIG;IACH,KAAK,CAAC,uBAAuB,CAAC,GAAW;QACvC,MAAM,OAAO,GAAG,MAAM,WAAW,CAAC,GAAG,CAAC,CAAC;QACvC,IAAI,CAAC,OAAO,IAAI,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC;YAAE,OAAO,IAAI,CAAC;QACtD,OAAO,IAAI,CAAC,oBAAoB,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;IACnD,CAAC;IAED;;;;OAIG;IACH,KAAK,CAAC,gBAAgB,CAAC,GAAW,EAAE,UAAkB;QACpD,MAAM,OAAO,GAAG,MAAM,WAAW,CAAC,GAAG,CAAC,CAAC;QACvC,IAAI,CAAC,OAAO,IAAI,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC;YAAE,OAAO,IAAI,CAAC;QACtD,MAAM,QAAQ,GAAG,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC;QAEvC,0EAA0E;QAC1E,IAAI,CAAC,IAAI,CAAC,sBAAsB,CAAC,GAAG,CAAC,QAAQ,CAAC,EAAE,CAAC;YAC/C,MAAM,IAAI,CAAC,oBAAoB,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;QAClD,CAAC;QAED,OAAO,IAAI,CAAC,sBAAsB,CAAC,GAAG,CAAC,QAAQ,CAAC,EAAE,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,eAAe,KAAK,UAAU,CAAC,IAAI,IAAI,CAAC;IACxG,CAAC;IAED;;;OAGG;IACH,KAAK,CAAC,QAAQ,CAAC,EAAU,EAAE,GAAY;QACrC,MAAM,WAAW,GAAG,QAAQ,CAAC,EAAE,CAAC,CAAC;QACjC,KAAK,MAAM,KAAK,IAAI,MAAM,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,EAAE,CAAC;YAChD,MAAM,IAAI,GAAG,MAAM,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAC,WAAW,CAAC,CAAC;YACvD,IAAI,IAAI;gBAAE,OAAO,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC;QACnC,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;IAED,mGAAmG;IACnG,cAAc;QACZ,MAAM,GAAG,GAAY,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACjC,KAAK,MAAM,MAAM,IAAI,IAAI,CAAC,sBAAsB,CAAC,MAAM,EAAE,EAAE,CAAC;YAC1D,GAAG,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC,CAAC;QACtB,CAAC;QACD,OAAO,GAAG,CAAC;IACb,CAAC;IAED;;;;OAIG;IACH,KAAK,CAAC,WAAW,CAAC,GAAY;QAC5B,MAAM,MAAM,GAAY,EAAE,CAAC;QAC3B,IAAI,GAAG,EAAE,CAAC;YACR,MAAM,OAAO,GAAG,MAAM,WAAW,CAAC,GAAG,CAAC,CAAC;YACvC,IAAI,OAAO,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC,EAAE,CAAC;gBACzC,MAAM,EAAE,GAAG,MAAM,IAAI,CAAC,oBAAoB,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;gBAC3D,IAAI,EAAE,EAAE,CAAC;oBACP,MAAM,GAAG,GAAG,IAAI,CAAC,sBAAsB,CAAC,GAAG,CAAC,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC;oBACnE,IAAI,GAAG,EAAE,CAAC;wBACR,MAAM,CAAC,IAAI,CAAC,GAAG,GAAG,CAAC,CAAC;oBACtB,CAAC;yBAAM,CAAC;wBACN,qEAAqE;wBACrE,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;oBAClB,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;QACD,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACvB,OAAO,MAAM,CAAC;IAChB,CAAC;IAED,uEAAuE;IACvE,WAAW,CAAC,KAAY,EAAE,MAAc;QACtC,OAAO,GAAG,KAAK,CAAC,WAAW,IAAI,MAAM,KAAK,CAAC;IAC7C,CAAC;IAED;;;OAGG;IACH,KAAK,CAAC,mBAAmB,CAAC,KAAY,EAAE,OAAiB;QACvD,MAAM,MAAM,GAAG,MAAM,KAAK,CAAC,GAAG,CAAC,MAAM,EAAE,CAAC;QACxC,MAAM,YAAY,GAAa,EAAE,CAAC;QAClC,KAAK,MAAM,MAAM,IAAI,OAAO,EAAE,CAAC;YAC7B,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC;YACjD,IAAI,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,IAAI,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,QAAQ,CAAC,EAAE,CAAC;gBAC3E,YAAY,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;YAC9B,CAAC;QACH,CAAC;QACD,OAAO,YAAY,CAAC;IACtB,CAAC;IAED,+EAA+E;IAEvE,UAAU,CAAC,OAAe;QAChC,OAAO,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,KAAK,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IAClE,CAAC;IAED;;;;OAIG;IACK,KAAK,CAAC,oBAAoB,CAAC,OAAe,EAAE,MAAe;QACjE,MAAM,QAAQ,GAAG,IAAI,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC;QAEvC,IAAI,IAAI,CAAC,oBAAoB,CAAC,GAAG,CAAC,QAAQ,CAAC,EAAE,CAAC;YAC5C,OAAO,IAAI,CAAC,oBAAoB,CAAC,GAAG,CAAC,QAAQ,CAAE,CAAC;QAClD,CAAC;QAED,MAAM,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;QAEtD,IAAI,CAAC,MAAM,IAAI,CAAC,CAAC,MAAM,UAAU,CAAC,YAAY,CAAC,CAAC;YAAE,OAAO,IAAI,CAAC;QAE9D,MAAM,YAAY,GAAG,SAAS,CAAC,YAAY,EAAE,QAAQ,EAAE,iBAAiB,EAAE,IAAI,EAAE,WAAW,CAAC,CAAC;QAC7F,MAAM,YAAY,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC;QAClC,MAAM,YAAY,CAAC,GAAG,CAAC,IAAI,EAAE,CAAC;QAE9B,IAAI,MAAM,EAAE,CAAC;YACX,MAAM,aAAa,GAAG,IAAI,CAAC,IAAI,CAAC,YAAY,EAAE,YAAY,CAAC,CAAC;YAC5D,MAAM,KAAK,GAAG,CAAC,CAAC,MAAM,UAAU,CAAC,aAAa,CAAC,CAAC,CAAC;YACjD,MAAM,eAAe,CAAC,aAAa,CAAC,CAAC;YAErC,IAAI,KAAK,EAAE,CAAC;gBACV,iEAAiE;gBACjE,MAAM,YAAY,CAAC,GAAG,CAAC,MAAM,CAAC,mCAAmC,EAAE,CAAC,sBAAsB,CAAC,CAAC,CAAC;YAC/F,CAAC;QACH,CAAC;QAED,IAAI,CAAC,oBAAoB,CAAC,GAAG,CAAC,QAAQ,EAAE,YAAY,CAAC,CAAC;QAEtD,gFAAgF;QAChF,oFAAoF;QACpF,uDAAuD;QACvD,MAAM,SAAS,GAAY,CAAC,YAAY,CAAC,CAAC;QAC1C,MAAM,oBAAoB,GAAG,MAAM,6BAA6B,CAAC,QAAQ,CAAC,CAAC;QAC3E,KAAK,MAAM,UAAU,IAAI,oBAAoB,EAAE,CAAC;YAC9C,MAAM,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,QAAQ,EAAE,UAAU,CAAC,CAAC;YACrD,IAAI,CAAC,CAAC,MAAM,UAAU,CAAC,YAAY,CAAC,CAAC;gBAAE,SAAS;YAChD,MAAM,WAAW,GAAG,GAAG,UAAU,QAAQ,CAAC;YAC1C,MAAM,QAAQ,GAAG,SAAS,CACxB,YAAY,EACZ,QAAQ,EACR,WAAW,EACX,IAAI,EACJ,UAAU,EACV,YAAY,CAAC,OAAO,CAAC,aAAa,CACnC,CAAC;YACF,MAAM,QAAQ,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC;YAC9B,MAAM,QAAQ,CAAC,GAAG,CAAC,IAAI,EAAE,CAAC;YAC1B,SAAS,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAC3B,CAAC;QAED,IAAI,CAAC,sBAAsB,CAAC,GAAG,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAC;QACrD,OAAO,YAAY,CAAC;IACtB,CAAC;CACF;AAED,iFAAiF;AAEjF,SAAS,SAAS,CAChB,SAAiB,EACjB,OAAe,EACf,WAAmB,EACnB,SAAkB,EAClB,eAAuB,EACvB,qBAA8B;IAE9B,OAAO;QACL,OAAO,EAAE,IAAI,OAAO,CAAC,SAAS,EAAE,qBAAqB,CAAC;QACtD,GAAG,EAAE,IAAI,MAAM,CAAC,OAAO,EAAE,WAAW,CAAC;QACrC,WAAW;QACX,SAAS;QACT,eAAe;KAChB,CAAC;AACJ,CAAC;AAED;;;;GAIG;AACH,KAAK,UAAU,6BAA6B,CAAC,OAAe;IAC1D,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,2BAA2B,EAAE,GAAG,EAAE,CAC7D,EAAE,CAAC,OAAO,CAAC,OAAO,EAAE,EAAE,aAAa,EAAE,IAAI,EAAE,CAAC,CAC7C,CAAC;IACF,IAAI,CAAC,MAAM,CAAC,EAAE,EAAE,CAAC;QACf,QAAQ,CAAC,2BAA2B,EAAE,WAAW,eAAe,CAAC,MAAM,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAClF,OAAO,EAAE,CAAC;IACZ,CAAC;IACD,OAAO,MAAM,CAAC,KAAK;SAChB,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,WAAW,EAAE,IAAI,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,YAAY,CAAC,CAAC;SAC/D,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC;SAChB,IAAI,EAAE,CAAC;AACZ,CAAC;AAED,KAAK,UAAU,WAAW,CAAC,GAAW,EAAE,UAAuB,IAAI,GAAG,EAAE;IACtE,MAAM,GAAG,GAAG,SAAS,CAAC,GAAG,CAAC,CAAC;IAC3B,MAAM,UAAU,GAAG,MAAM,OAAO,CAAC,qBAAqB,EAAE,GAAG,EAAE,CAC3D,GAAG,CAAC,QAAQ,CAAC,CAAC,iBAAiB,CAAC,CAAC,CAClC,CAAC;IACF,IAAI,CAAC,UAAU,CAAC,EAAE,EAAE,CAAC;QACnB,QAAQ,CAAC,qBAAqB,EAAE,WAAW,eAAe,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAChF,OAAO,IAAI,CAAC;IACd,CAAC;IACD,MAAM,WAAW,GAAG,UAAU,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC;IAC5C,IAAI,CAAC,WAAW;QAAE,OAAO,IAAI,CAAC;IAE9B,IAAI,OAAO,CAAC,GAAG,CAAC,WAAW,CAAC;QAAE,OAAO,WAAW,CAAC;IACjD,OAAO,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;IAEzB,MAAM,WAAW,GAAG,MAAM,OAAO,CAAC,kCAAkC,EAAE,GAAG,EAAE,CACzE,GAAG,CAAC,QAAQ,CAAC,CAAC,kCAAkC,CAAC,CAAC,CACnD,CAAC;IACF,IAAI,WAAW,CAAC,EAAE,EAAE,CAAC;QACnB,MAAM,mBAAmB,GAAG,WAAW,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC;QACrD,IAAI,mBAAmB,EAAE,CAAC;YACxB,OAAO,WAAW,CAAC,mBAAmB,EAAE,OAAO,CAAC,CAAC;QACnD,CAAC;IACH,CAAC;SAAM,CAAC;QACN,QAAQ,CAAC,qBAAqB,EAAE,gEAAgE,CAAC,CAAC;IACpG,CAAC;IAED,OAAO,WAAW,CAAC;AACrB,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,eAAe,CAAC,UAAkB;IACtD,MAAM,aAAa,GAAG,CAAC,aAAa,EAAE,cAAc,CAAC,CAAC;IACtD,MAAM,cAAc,GAAG,MAAM,OAAO,CAAC,wBAAwB,EAAE,GAAG,EAAE,CAClE,EAAE,CAAC,QAAQ,CAAC,UAAU,EAAE,OAAO,CAAC,CACjC,CAAC;IACF,MAAM,QAAQ,GAAG,cAAc,CAAC,EAAE,CAAC,CAAC,CAAC,cAAc,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,GAAG,EAAE;QAChE,QAAQ,CAAC,wBAAwB,EAAE,0BAA0B,eAAe,CAAC,cAAc,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QACtG,OAAO,EAAE,CAAC;IACZ,CAAC,CAAC,EAAE,CAAC;IACL,MAAM,OAAO,GAAG,aAAa,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC;IACvE,IAAI,OAAO,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO;IACjC,MAAM,OAAO,GAAG,QAAQ,CAAC,OAAO,EAAE,GAAG,IAAI,GAAG,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,IAAI,CAAC;IACtE,MAAM,EAAE,CAAC,SAAS,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC;AAC1C,CAAC;AAED,KAAK,UAAU,UAAU,CAAC,CAAS;IACjC,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,kBAAkB,EAAE,GAAG,EAAE,CAAC,EAAE,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC;IACrE,OAAO,MAAM,CAAC,EAAE,CAAC;AACnB,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danielmarbach/mnemonic-mcp",
-  "version": "0.28.0",
+  "version": "0.30.0",
   "description": "A local MCP memory server backed by markdown + JSON files, synced via git",
   "type": "module",
   "repository": {
@@ -37,7 +37,8 @@
     "skills:update": "node scripts/install-skills.mjs --target all --mode copy --update",
     "test": "vitest run",
     "test:watch": "vitest",
-    "typecheck": "tsc --noEmit"
+    "typecheck": "tsc --noEmit",
+    "lint:ast": "ast-grep scan"
   },
   "dependencies": {
     "@modelcontextprotocol/sdk": "^1.10.1",
@@ -50,6 +51,7 @@
     "zod": "^4.3.6"
   },
   "devDependencies": {
+    "@ast-grep/cli": "^0.42.1",
     "@types/node": "^24.0.0",
     "typescript": "^6.0.0",
     "vitest": "^4.0.18"

package/skills/mnemonic-rpi-workflow/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: mnemonic-rpi-workflow
-description: Executes multi-step research-plan-implement-review workflows using mnemonic for workflow artifacts. Triggers on multi-step feature or bugfix work, subagent handoffs, plan-heavy tasks, or any work needing structured RPIR artifacts with explicit handoffs and consistent role/relationship conventions.
+description: Executes multi-step research-plan-implement-review workflows using mnemonic for workflow artifacts. Triggers on multi-step feature or bugfix work, subagent handoffs, plan-heavy tasks, or any work needing structured RPIR artifacts with explicit handoffs and consistent role/relationship conventions. Review phase always dispatches a fresh-context subagent with adversarial posture and constraint violation hunting.
 ---
 
 # RPIR Workflow: Research → Plan → Implement → Review
@@ -58,32 +58,42 @@ Only after confirmation: proceed to Implement checklist.
 - Link to plan note (`follows` for ordered steps).
 - For non-trivial work, dispatch a subagent with narrow scope (see [handoff template](#subagent-handoff-template)).
 
-### 4. Review
+### 4. Review (Fresh-Context Subagent Required)
 
-Before reviewing, retrieve the context that informed implementation:
-1. `get` the research note(s) and plan note linked to this work
+The implementer's own context is contaminated — they designed the code, so they see intent rather than behavior. Review must be performed by a fresh-context subagent that has no prior exposure to the implementation decisions.
+
+**Before writing the review, the orchestrator must:**
+1. `get` the research note(s), plan note, and apply/task note(s) linked to this work
 2. Read the apply/task note(s) to confirm what actually shipped
+3. Extract all explicit constraints from the plan (performance constraints, I/O constraints, fail-soft requirements, schema requirements, etc.) into a constraint checklist
 
-Create review notes: `role: review`, `lifecycle: temporary`.
-Link to apply/task notes or plan (`derives-from` when conclusions derive from specific artifacts).
+**The review subagent receives the full artifact chain and must:**
+
+**A. Constraint violation hunting (adversarial — prove violations don't exist)**
+- Enumerate every explicit constraint from the plan (e.g., "no new I/O on cold paths", "fail-soft to undefined", "always populate contextual metrics", "every Zod field gets `.describe()`")
+- For each constraint: cite the exact code path(s) that satisfy it, or flag it as a violation
+- If any constraint is unmentioned in the apply note, flag it — silent omission is a violation
 
-Review against research and plan:
-- Does the implementation satisfy the requirements identified in research?
-- Were all planned deliverables completed? If not, why?
+**B. Deliverable completeness**
+- Does the implementation satisfy every requirement from research?
+- Were all planned deliverables completed? If not, why, and is the deferral explicit?
 - Are there gaps between what was planned and what was delivered?
 - Were any assumptions from research invalidated during implementation?
 
-Before recording outcome, run a self-review checklist:
-- Re-read research requirements — is each addressed in implementation or explicitly deferred?
-- Re-read plan deliverables — do all checkboxes have matching verification evidence?
-- Is any unchecked item silently ignored rather than called out?
+**C. Fresh verification**
+- Every verification command must be run fresh during this review — do not reuse results from implementation
+- Record each command, result, and evidence
 
-For non-trivial work, dispatch a subagent with the full artifact chain (research, plan, apply notes) using the [review handoff variant](#review-handoff-variant) below.
+The review subagent must adopt an adversarial posture: assume violations exist and prove they don't. A review that only confirms what the apply note claims is not sufficient.
+
+Create review notes: `role: review`, `lifecycle: temporary`.
+Link to apply/task notes or plan (`derives-from` when conclusions derive from specific artifacts).
 
 Record outcome: continue, block, or update plan.
 Reconcile checklist state with verification evidence; call out any unchecked items explicitly.
 If review causes a material plan change, update plan note first.
-Every verification command must be run fresh during this review — do not reuse results from implementation. Every review note must include verification evidence:
+
+Every review note must include verification evidence:
 
 ```text
 - Command: <run command>
@@ -91,6 +101,14 @@ Every verification command must be run fresh during this review — do not reuse
 - Details: <counts, errors>
 ```
 
+And a constraint checklist:
+
+```text
+| Constraint | Status | Evidence |
+|---|---|---|
+| <constraint from plan> | pass/fail | <code path or violation detail> |
+```
+
 ### 5. Consolidate
 
 - Create permanent decision note(s) and summary note(s).
@@ -117,7 +135,7 @@ Must return: apply note content, optional review note, recommendation (continue
 
 ### Review Handoff Variant
 
-For subagent-driven review, include the full artifact chain so the reviewer has the same context as the implementer:
+Dispatch a fresh-context subagent with the full artifact chain. The reviewer has no prior exposure to implementation decisions and must adopt an adversarial posture.
 
 ```text
 Request note:      <note-id/title>
@@ -126,12 +144,25 @@ Plan note:         <note-id/title>
 Apply/task notes:  <note-id/title>, ...
 Durable context:   <note-id/title>, ...
 
+Constraint checklist (extracted from plan):
+| Constraint | Status | Evidence |
+|---|---|---|
+| <explicit constraint from plan> | ? | <to be verified> |
+
 Review scope:
 - What was planned: <summary from plan note>
 - What was implemented: <summary from apply note>
 - Validation: <tests/checks>
 
-Instructions: Compare implementation against research requirements and plan deliverables. Identify gaps, regressions, or deviations. Return: review note content, recommendation (continue | block | update plan), and any unchecked items.
+Adversarial review mandate:
+1. Assume violations exist — prove they don't
+2. For each explicit plan constraint: cite the code path that satisfies it, or flag it as a violation
+3. For each research requirement: confirm it is addressed or explicitly deferred
+4. For each plan deliverable: verify matching evidence exists
+5. Run all verification commands fresh — do not reuse implementation results
+6. If a constraint is not mentioned in the apply note, flag it as a potential violation
+
+Return: review note content with constraint checklist, recommendation (continue | block | update plan), and any unchecked items.
 ```
 
 ## Canonical Graph