@danieljvdm/dev-kit 0.15.0 → 0.17.0

package/src/project-package.ts

@@ -1,4 +1,4 @@
-import { Effect, FileSystem, Path, Schema } from "effect";
+import { Effect, FileSystem, Option, Path, Schema } from "effect";
 
 export class ProjectPackageError extends Schema.TaggedError<ProjectPackageError>()(
   "ProjectPackageError",
@@ -91,23 +91,87 @@ export const detectPackageManager = Effect.fn("detectPackageManager")(function*
   return detected.length === 1 ? detected[0] : undefined;
 });
 
-export const readDirectDependencyNames = Effect.fn("readDirectDependencyNames")(function* (
-  projectDir: string,
+const readOptionalProjectPackage = Effect.fn("readOptionalProjectPackage")(function* (
+  packageDir: string,
 ) {
-  const manifest = yield* readProjectPackage(projectDir).pipe(
+  return yield* readProjectPackage(packageDir).pipe(
     Effect.catchTag("ProjectPackageError", (error) =>
       error.message.startsWith("package.json not found:") ? Effect.void : Effect.fail(error),
     ),
   );
+});
+
+const manifestDependencyNames = (
+  manifest: (typeof ProjectPackageSchema)["Type"] | undefined | void,
+): ReadonlyArray<string> =>
+  manifest === undefined
+    ? []
+    : [
+        ...Object.keys(manifest.dependencies ?? {}),
+        ...Object.keys(manifest.devDependencies ?? {}),
+        ...Object.keys(manifest.optionalDependencies ?? {}),
+        ...Object.keys(manifest.peerDependencies ?? {}),
+      ];
+
+export const readDirectDependencyNames = Effect.fn("readDirectDependencyNames")(function* (
+  projectDir: string,
+) {
+  const manifest = yield* readOptionalProjectPackage(projectDir);
+
+  return [...new Set(manifestDependencyNames(manifest))].sort();
+});
+
+const WorkspacePatternsSchema = Schema.Union([
+  Schema.Array(Schema.String),
+  Schema.Struct({ packages: Schema.Array(Schema.String) }),
+]);
+// `workspaces` is declared `Schema.Unknown` in the project manifest schema, so
+// this is a genuinely untyped boundary.
+const decodeWorkspacePatterns = Schema.decodeUnknownOption(WorkspacePatternsSchema);
+
+const workspacePatterns = (workspaces: unknown): ReadonlyArray<string> => {
+  const decoded = decodeWorkspacePatterns(workspaces);
 
-  if (manifest === undefined) return [];
+  if (Option.isNone(decoded)) return [];
+
+  return "packages" in decoded.value ? decoded.value.packages : decoded.value;
+};
+
+/**
+ * Direct dependency names of the project package plus every workspace member
+ * package. Only literal workspace paths and single trailing-star globs
+ * (`apps/*`) are expanded; other patterns are skipped.
+ */
+export const readWorkspaceDependencyNames = Effect.fn("readWorkspaceDependencyNames")(function* (
+  projectDir: string,
+) {
+  const fs = yield* FileSystem.FileSystem;
+  const path = yield* Path.Path;
+  const manifest = yield* readOptionalProjectPackage(projectDir);
+  const names = new Set(manifestDependencyNames(manifest));
+
+  for (const pattern of workspacePatterns(manifest?.workspaces)) {
+    if (pattern.startsWith("!")) continue;
+    const star = pattern.indexOf("*");
+    let memberDirs: ReadonlyArray<string> = [];
+
+    if (star === -1) {
+      memberDirs = [pattern];
+    } else if (pattern.endsWith("/*") && star === pattern.length - 1) {
+      const parent = path.join(projectDir, pattern.slice(0, -2));
+
+      if (yield* fs.exists(parent)) {
+        memberDirs = (yield* fs.readDirectory(parent)).map((name) =>
+          path.join(pattern.slice(0, -2), name),
+        );
+      }
+    }
+    for (const memberDir of memberDirs) {
+      const member = yield* readOptionalProjectPackage(path.join(projectDir, memberDir));
+
+      for (const name of manifestDependencyNames(member)) names.add(name);
+    }
+  }
 
-  return [
-    ...new Set([
-      ...Object.keys(manifest.dependencies ?? {}),
-      ...Object.keys(manifest.devDependencies ?? {}),
-      ...Object.keys(manifest.optionalDependencies ?? {}),
-      ...Object.keys(manifest.peerDependencies ?? {}),
-    ]),
-  ].sort();
+  return [...names].sort();
 });

package/src/sync.ts

@@ -15,6 +15,7 @@ import {
   planEffectTsgoPatch,
   type EffectTsgoPatchPlan,
 } from "./effect-tsgo.ts";
+import { maybePruneGlobalCache } from "./global-cache.ts";
 import { DevKitManifestSchema, normalizeManifest } from "./manifest.ts";
 import { observeSymbolicLink } from "./node-symbolic-link.ts";
 import { resolvePackageSkillSelector } from "./package-skill-source.ts";
@@ -29,6 +30,7 @@ import {
   detectPackageManager,
   PACKAGE_MANAGER_COMMANDS,
   readDirectDependencyNames,
+  readWorkspaceDependencyNames,
   readProjectPackage,
   type PackageManagerName,
 } from "./project-package.ts";
@@ -266,7 +268,13 @@ const encodePlanSnapshotJson = Schema.encodeSync(Schema.fromJsonString(Schema.Un
 const encodeAppliedStatePrettyJson = Schema.encodeSync(fromJsonString(AppliedStateSchema, 2));
 
 const SKILL_FAMILIES: SkillCatalog = {
-  effect: ["effect-ts", "effect-architecture-audit", "build-effect-apis", "build-effect-clis"],
+  effect: [
+    "effect-ts",
+    "effect-architecture-audit",
+    "build-effect-apis",
+    "effect-atom-state",
+    "build-effect-clis",
+  ],
 };
 
 export const DEFAULT_MANIFEST = "dev-kit.jsonc";
@@ -805,7 +813,7 @@ const renderAgentInstructions = Effect.fn("renderAgentInstructions")(function* (
           );
   const directDependencyNames = yield* readDirectDependencyNames(projectDir);
   const usesVitePlus = directDependencyNames.includes("vite-plus");
-  const effectInstructions =
+  const effectGuideInstructions =
     directDependencyNames.includes("effect") &&
     (yield* observePath(path.join(projectDir, "node_modules", "effect", "AGENTS.md"))).kind ===
       "file"
@@ -821,6 +829,20 @@ guide doesn't cover, search through the source code in \`node_modules/effect/src
 
 `
       : "";
+  const atomBoundaryInstructions = (yield* readWorkspaceDependencyNames(projectDir)).includes(
+    "@effect/atom-react",
+  )
+    ? `# Effect Atom client boundary
+
+This repository consumes APIs through Effect Atom clients (\`@effect/atom-react\`).
+Keep business logic in Effect: compose multi-step client workflows as atoms,
+declare cross-query invalidation as reactivity keys on mutations, and keep
+promise-mode dispatches at the React boundary logic-free — no \`.then\` chains
+in components or routes.
+
+`
+    : "";
+  const effectInstructions = `${effectGuideInstructions}${atomBoundaryInstructions}`;
   const projectPackage = yield* readProjectPackage(projectDir).pipe(
     Effect.catchTag("ProjectPackageError", (error) =>
       error.message.startsWith("package.json not found:") ? Effect.void : Effect.fail(error),
@@ -1877,6 +1899,18 @@ export const runProjectSkillPlan = Effect.fn("runProjectSkillPlan")(function* (
       yield* applyPlannedSkillChanges(replanned);
     }),
   );
+  const fs = yield* FileSystem.FileSystem;
+  const path = yield* Path.Path;
+
+  // Catalog checkouts moved to the machine-global cache; drop the regenerable
+  // project-local copies left behind by earlier dev-kit versions.
+  yield* fs
+    .remove(path.join(plan.projectDir, ".dev-kit", "cache", "catalog"), {
+      force: true,
+      recursive: true,
+    })
+    .pipe(Effect.ignore);
+  yield* maybePruneGlobalCache().pipe(Effect.ignore);
   yield* printStatus(
     "success",
     changes === 0 && !replanned.metadataChanged ? "Dev kit up to date" : "Dev kit ready",

package/src/vite-plus.js

@@ -1,5 +1,5 @@
 import { recommendedOxfmtConfig } from "./oxfmt.js";
-import { recommendedOxlintConfig } from "./oxlint.js";
+import { createAbsoluteImportsOxlintOverride, recommendedOxlintConfig } from "./oxlint.js";
 import { devKitToolIgnorePatterns } from "./tool-ignore-patterns.js";
 
 export { devKitToolIgnorePatterns } from "./tool-ignore-patterns.js";
@@ -58,6 +58,12 @@ const createTypecheckTask = (options) => {
 /** Build composable quality defaults for a project-owned Vite+ config. */
 export const createRecommendedVitePlusConfig = (options = {}) => {
   const ignorePatterns = [...devKitToolIgnorePatterns, ...(options.ignorePatterns ?? [])];
+  const lintOverrides = options.absoluteImports
+    ? [
+        ...recommendedOxlintConfig.overrides,
+        createAbsoluteImportsOxlintOverride(options.absoluteImports),
+      ]
+    : recommendedOxlintConfig.overrides;
 
   return {
     staged: {
@@ -70,6 +76,7 @@ export const createRecommendedVitePlusConfig = (options = {}) => {
     lint: {
       ...recommendedOxlintConfig,
       ignorePatterns,
+      overrides: lintOverrides,
     },
     run: {
       tasks: {

package/src/vite-plus.ts

@@ -1,7 +1,12 @@
 import { recommendedOxfmtConfig } from "./oxfmt.ts";
-import { recommendedOxlintConfig } from "./oxlint.ts";
+import {
+  type AbsoluteImportsOptions,
+  createAbsoluteImportsOxlintOverride,
+  recommendedOxlintConfig,
+} from "./oxlint.ts";
 import { devKitToolIgnorePatterns } from "./tool-ignore-patterns.ts";
 
+export type { AbsoluteImportsOptions } from "./oxlint.ts";
 export { devKitToolIgnorePatterns } from "./tool-ignore-patterns.ts";
 
 export type VitePlusTypecheckOptions =
@@ -16,6 +21,8 @@ export type VitePlusTypecheckOptions =
     };
 
 export type RecommendedVitePlusConfigOptions = {
+  /** Enforce path-alias imports (no `../`) inside the given globs. */
+  readonly absoluteImports?: AbsoluteImportsOptions;
   /** Additional project-owned generated or vendored paths. */
   readonly ignorePatterns?: ReadonlyArray<string>;
   readonly typecheck?: VitePlusTypecheckOptions;
@@ -79,6 +86,12 @@ const createTypecheckTask = (options: VitePlusTypecheckOptions | undefined) => {
  */
 export const createRecommendedVitePlusConfig = (options: RecommendedVitePlusConfigOptions = {}) => {
   const ignorePatterns = [...devKitToolIgnorePatterns, ...(options.ignorePatterns ?? [])];
+  const lintOverrides = options.absoluteImports
+    ? [
+        ...recommendedOxlintConfig.overrides,
+        createAbsoluteImportsOxlintOverride(options.absoluteImports),
+      ]
+    : recommendedOxlintConfig.overrides;
 
   return {
     staged: {
@@ -91,6 +104,7 @@ export const createRecommendedVitePlusConfig = (options: RecommendedVitePlusConf
     lint: {
       ...recommendedOxlintConfig,
       ignorePatterns,
+      overrides: lintOverrides,
     },
     run: {
       tasks: {