@danielgindi/selectbox 2.0.4 → 2.0.5

package/dist/lib.cjs.js

@@ -1,5 +1,5 @@
 /*!
- * @danielgindi/selectbox 2.0.4
+ * @danielgindi/selectbox 2.0.5
  * git://github.com/danielgindi/selectbox.git
  */
 'use strict';
@@ -1216,11 +1216,10 @@ class DropList {
       if (!Array.isArray(filteredItems)) {
         if (term) {
           const matcher = new RegExp(escapeRegex(term), 'i');
-          const labelProp = p.labelProp;
 
           filteredItems = p.items.filter((x) => {
             if (!filterGroups && x._group) return true;
-            return matcher.test(x[labelProp]);
+            return matcher.test(x.label);
           });
         } else {
           filteredItems = null;
@@ -1494,6 +1493,8 @@ class DropList {
 
     // Calculate virtual viewport size
     if (p.virtualListHelper.isVirtual()) {
+      // Avoid extremely high size which will cause laying out the whole list
+      menuEl.style.height = Math.min(el.clientHeight, document.body.clientHeight) + 'px';
       p.virtualListHelper.render();
     }
 
@@ -3655,7 +3656,6 @@ class SelectBox {
       p.resizeObserver.observe(p.el);
     }
 
-    if (o.filterFn)
     this.setFilterFn(o.filterFn);
 
     this.setItems(o.items);
@@ -4449,6 +4449,10 @@ class SelectBox {
     const p = this._p;
     if (p.filterFn === fn)
     return this;
+
+    // Do not keep this reference, as far as the user is concerned - he/she did not set a custom filter.
+    p.filterFn = fn;
+
     if (!fn) {
       // Add search by multi-item label
       fn = (items, term) => {
@@ -4462,7 +4466,6 @@ class SelectBox {
         });
       };
     }
-    p.filterFn = fn;
     p.dropList?.setFilterFn(fn);
     return this;
   }