@danielgindi/selectbox 2.0.35 → 2.0.37

package/lib/DropList.js

@@ -2775,10 +2775,6 @@ class DropList {
             let next = p.virtualListHelper.getItemElementAt(matchIndex);
             this._focus(evt, next || null, matchIndex, true);
 
-            if (!this.isVisible()) {
-                this.triggerItemSelection(next ? null : items[matchIndex], evt);
-            }
-
             // Record the last filter used
             p.previousFilter = keyword;
 

package/lib/SelectBox.js

@@ -2221,6 +2221,10 @@ class SelectBox {
                         break;
 
                     default:
+                        if (!dropList.isVisible()) {
+                            this.openList();
+                        }
+
                         dropList._keydownFreeType(evt);
                         break;
                 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danielgindi/selectbox",
-  "version": "2.0.35",
+  "version": "2.0.37",
   "description": "A collection of dom utilities. So you can work natively with the dom without dom frameworks.",
   "main": "dist/lib.cjs.min.js",
   "module": "lib/index.js",

package/vue/DropList.vue

@@ -3,7 +3,7 @@
 </template>
 
 <script>
-import DropList from '../lib/DropList';
+import DropList, { DefaultOptions } from '../lib/DropList';
 import DomEventsSink from '@danielgindi/dom-utils/lib/DomEventsSink';
 import { createSlotBasedRenderFunc, createSlotBasedUnrenderFunc } from './utils/slots.js';
 import { version } from 'vue';
@@ -60,11 +60,11 @@ export const PropTypes = {
     },
     noResultsText: {
         type: String,
-        default: 'No matching results',
+        required: false,
     },
     filterThrottleWindow: {
         type: Number,
-        default: 300,
+        required: false,
     },
     filterOnEmptyTerm: {
         type: Boolean,
@@ -303,12 +303,12 @@ export default {
 
         noResultsText(value) {
             if (this.nonReactive.instance)
-                this.nonReactive.instance.setNoResultsText(value);
+                this.nonReactive.instance.setNoResultsText(value ?? DefaultOptions.noResultsText);
         },
 
         filterThrottleWindow(value) {
             if (this.nonReactive.instance)
-                this.nonReactive.instance.setFilterThrottleWindow(value || 0);
+                this.nonReactive.instance.setFilterThrottleWindow(value ?? DefaultOptions.filterThrottleWindow ?? 0);
         },
 
         filterOnEmptyTerm(value) {

package/vue/SelectBox.vue

@@ -4,7 +4,7 @@
 
 <script>
 import { version } from 'vue';
-import SelectBox from '../lib/SelectBox';
+import SelectBox, { DefaultOptions } from '../lib/SelectBox';
 import { createSlotBasedRenderFunc, createSlotBasedUnrenderFunc } from './utils/slots';
 import deepEqual from 'fast-deep-equal';
 
@@ -111,11 +111,11 @@ export const PropTypes = {
     },
     noResultsText: {
         type: String,
-        default: 'No matching results',
+        required: false,
     },
     filterThrottleWindow: {
         type: Number,
-        default: 300,
+        required: false,
     },
     filterOnEmptyTerm: {
         type: Boolean,
@@ -246,7 +246,7 @@ export const PropTypes = {
     },
     closeListWhenLoading: {
         type: Boolean,
-        default: true,
+        required: false,
     },
     clearInputWhen: {
         type: Array,
@@ -570,12 +570,12 @@ export default {
 
         noResultsText(value) {
             if (this.nonReactive.instance)
-                this.nonReactive.instance.setNoResultsText(value);
+                this.nonReactive.instance.setNoResultsText(value ?? DefaultOptions.noResultsText);
         },
 
         filterThrottleWindow(value) {
             if (this.nonReactive.instance)
-                this.nonReactive.instance.setFilterThrottleWindow(value || 0);
+                this.nonReactive.instance.setFilterThrottleWindow(value ?? DefaultOptions.filterThrottleWindow ?? 0);
         },
 
         filterOnEmptyTerm(value) {
@@ -710,7 +710,7 @@ export default {
 
         closeListWhenLoading() {
             if (this.nonReactive.instance)
-                this.nonReactive.instance.setCloseListWhenLoading(!!this.closeListWhenLoading);
+                this.nonReactive.instance.setCloseListWhenLoading(this.closeListWhenLoading ?? DefaultOptions.closeListWhenLoading);
         },
 
         clearInputWhen() {
@@ -827,8 +827,8 @@ export default {
                 blurOnSingleSelection: this.blurOnSingleSelection,
                 multi: this.multi,
                 searchable: this.searchable,
-                noResultsText: this.noResultsText,
-                filterThrottleWindow: this.filterThrottleWindow,
+                noResultsText: this.noResultsText ?? DefaultOptions.noResultsText,
+                filterThrottleWindow: this.filterThrottleWindow ?? DefaultOptions.filterThrottleWindow ?? 0,
                 filterOnEmptyTerm: this.filterOnEmptyTerm,
                 labelProp: this.labelProp,
                 valueProp: this.valueProp,
@@ -848,7 +848,7 @@ export default {
                 on: this._handleBoxEvents.bind(this),
                 additionalClasses: this.additionalClassesList,
                 isLoadingMode: this.isLoadingMode,
-                closeListWhenLoading: this.closeListWhenLoading,
+                closeListWhenLoading: this.closeListWhenLoading ?? DefaultOptions.closeListWhenLoading,
                 clearInputWhen: this.clearInputWhen,
                 treatGroupSelectionAsItems: this.treatGroupSelectionAsItems,
             });