@danielgindi/selectbox 1.0.67 → 1.0.68

package/lib/SelectBox.js

@@ -360,6 +360,7 @@ class SelectBox {
         }
 
         this.setItems(o.items);
+        delete o.items; // we do not need this in memory anymore
 
         if (o.multi && Array.isArray(o.selectedValues)) {
             this.setSelectedValues(o.selectedValues);
@@ -511,6 +512,8 @@ class SelectBox {
         p.filteredItems = null;
         p.itemsChanged = true;
 
+        this._updateItemByValueMap();
+
         if (resetValues) {
             this.setSelectedValues(this.getSelectedValues());
         }
@@ -540,9 +543,9 @@ class SelectBox {
     }
 
     updateItemByValue(value, newItem) {
-        const p = this._p, valueProp = p.valueProp;
+        const p = this._p;
 
-        let existingItem = p.items.find(x => x[valueProp] === value);
+        let existingItem = p.itemByValueMap.get(value);
         if (existingItem)
             Object.assign(existingItem, newItem);
 
@@ -1064,11 +1067,17 @@ class SelectBox {
      */
     setValueProp(prop) {
         const p = this._p;
+
+        if (p.valueProp === prop)
+            return this;
+
         p.valueProp = prop;
 
 		if (p.dropList)
 			p.dropList.setValueProp(prop);
 
+        this._updateItemByValueMap();
+
         return this;
     }
 
@@ -1220,7 +1229,7 @@ class SelectBox {
 
             selectedValues.push(value);
 
-            let item = p.items.find(x => x[valueProp] === value);
+            let item = p.itemByValueMap.get(value);
             if (item !== undefined) {
                 selectedItems.push(item);
             } else {
@@ -1441,6 +1450,21 @@ class SelectBox {
         return this;
     }
 
+    /**
+     * Prepare the mapping between values and items.
+     * This reduces search time greatly (i.e when checking items), especially when Vue proxies are in place.
+     * @private
+     */
+    _updateItemByValueMap() {
+        const p = this._p;
+
+        const itemByValueMap = p.itemByValueMap = new Map();
+        const valueProp = p.valueProp;
+        for (let item of p.items) {
+            itemByValueMap.set(item[valueProp], item);
+        }
+    }
+
     /** @private */
     _renderBase() {
         const p = this._p;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@danielgindi/selectbox",
-  "version": "1.0.67",
+  "version": "1.0.68",
   "description": "A collection of dom utilities. So you can work natively with the dom without dom frameworks.",
   "main": "dist/lib.cjs.min.js",
   "module": "lib/index.js",