@danielgindi/selectbox 1.0.66 → 1.0.69

package/dist/lib.es6.js

@@ -1,5 +1,5 @@
 /*!
- * @danielgindi/selectbox 1.0.66
+ * @danielgindi/selectbox 1.0.69
  * git://github.com/danielgindi/selectbox.git
  */
 import { createElement, closestUntil, setElementAttrs, next, prev } from '@danielgindi/dom-utils/lib/Dom';
@@ -2574,6 +2574,7 @@ class SelectBox {
         }
 
         this.setItems(o.items);
+        delete o.items; // we do not need this in memory anymore
 
         if (o.multi && Array.isArray(o.selectedValues)) {
             this.setSelectedValues(o.selectedValues);
@@ -2725,6 +2726,8 @@ class SelectBox {
         p.filteredItems = null;
         p.itemsChanged = true;
 
+        this._updateItemByValueMap();
+
         if (resetValues) {
             this.setSelectedValues(this.getSelectedValues());
         }
@@ -2754,9 +2757,9 @@ class SelectBox {
     }
 
     updateItemByValue(value, newItem) {
-        const p = this._p, valueProp = p.valueProp;
+        const p = this._p;
 
-        let existingItem = p.items.find(x => x[valueProp] === value);
+        let existingItem = p.itemByValueMap.get(value);
         if (existingItem)
             Object.assign(existingItem, newItem);
 
@@ -3278,11 +3281,17 @@ class SelectBox {
      */
     setValueProp(prop) {
         const p = this._p;
+
+        if (p.valueProp === prop)
+            return this;
+
         p.valueProp = prop;
 
 		if (p.dropList)
 			p.dropList.setValueProp(prop);
 
+        this._updateItemByValueMap();
+
         return this;
     }
 
@@ -3434,7 +3443,7 @@ class SelectBox {
 
             selectedValues.push(value);
 
-            let item = p.items.find(x => x[valueProp] === value);
+            let item = p.itemByValueMap.get(value);
             if (item !== undefined) {
                 selectedItems.push(item);
             } else {
@@ -3655,6 +3664,21 @@ class SelectBox {
         return this;
     }
 
+    /**
+     * Prepare the mapping between values and items.
+     * This reduces search time greatly (i.e when checking items), especially when Vue proxies are in place.
+     * @private
+     */
+    _updateItemByValueMap() {
+        const p = this._p;
+
+        const itemByValueMap = p.itemByValueMap = new Map();
+        const valueProp = p.valueProp;
+        for (let item of p.items) {
+            itemByValueMap.set(item[valueProp], item);
+        }
+    }
+
     /** @private */
     _renderBase() {
         const p = this._p;
@@ -5429,6 +5453,11 @@ class SelectBox {
             stickyGroup = groups[0].filter(x => stickyValues.has(x[valueProp]));
             if (stickyGroup.length > 0) {
                 groups[0] = groups[0].filter(x => !stickyValues.has(x[valueProp]));
+
+                if (groups[0].length === 0)
+                    groups.shift();
+            } else {
+                stickyGroup = null;
             }
         }
 
@@ -5453,7 +5482,7 @@ class SelectBox {
             });
         }
 
-        if (stickyGroup && stickyGroup.length > 0) {
+        if (stickyGroup) {
             groups.unshift(stickyGroup);
         }