@danceiny/gotry 0.0.1-rc.17 → 0.0.1-rc.19

package/dist/scripts/booking-copilot-gap-code-contract-proof-tests.js

@@ -1,7 +1,7 @@
 import assert from 'node:assert/strict';
-import { validateActionReceiptV1 } from '../src/booking-surface/validation.js';
+import { validateBookingSurface } from '../src/booking-surface/validation.js';
 const receiptBase = {
-    schemaVersion: 'booking.surface.v1',
+    schemaVersion: 'booking.surface',
     kind: 'action.receipt',
     actionId: 'offers-query-gap-contract',
     contextRef: 'ctx-gap-contract',
@@ -36,7 +36,9 @@ const oldRatesFailedReceipt = {
         ...ratesFailedResult,
         gapCodes: [
             'hotel_rates_failed:hotel-1'
-        ]
+        ],
+        blockers: [],
+        relaxationsApplied: []
     }
 };
 const newRatesFailedReceipt = {
@@ -45,11 +47,13 @@ const newRatesFailedReceipt = {
         ...ratesFailedResult,
         gapCodes: [
             'hotel_rates_failed'
-        ]
+        ],
+        blockers: [],
+        relaxationsApplied: []
     }
 };
-assert.equal(validateActionReceiptV1(oldRatesFailedReceipt).ok, false, 'legacy dynamic supplier gap code must fail validation');
-assert.deepEqual(validateActionReceiptV1(newRatesFailedReceipt), {
+assert.equal(validateBookingSurface(oldRatesFailedReceipt).ok, false, 'legacy dynamic supplier gap code must fail validation');
+assert.deepEqual(validateBookingSurface(newRatesFailedReceipt), {
     ok: true
 }, 'fixed supplier gap code with hotel fact ref must validate');
 assert.deepEqual(newRatesFailedReceipt.resultContract.factRefs, [
@@ -77,7 +81,9 @@ const oldNotVisibleReceipt = {
         ],
         gapCodes: [
             'hotel_not_visible:not-visible'
-        ]
+        ],
+        blockers: [],
+        relaxationsApplied: []
     }
 };
 const newNotVisibleReceipt = {
@@ -89,8 +95,8 @@ const newNotVisibleReceipt = {
         ]
     }
 };
-assert.equal(validateActionReceiptV1(oldNotVisibleReceipt).ok, false, 'legacy dynamic visibility gap code must fail validation');
-assert.deepEqual(validateActionReceiptV1(newNotVisibleReceipt), {
+assert.equal(validateBookingSurface(oldNotVisibleReceipt).ok, false, 'legacy dynamic visibility gap code must fail validation');
+assert.deepEqual(validateBookingSurface(newNotVisibleReceipt), {
     ok: true
 }, 'fixed visibility gap code with hotel fact ref must validate');
 assert.deepEqual(newNotVisibleReceipt.resultContract.factRefs, [

package/dist/scripts/booking-copilot-operation-ledger-concurrency-proof-tests.js

@@ -8,7 +8,7 @@ import { ensureLedger } from '../src/state-ledger.js';
 import { BookingCopilotTaskRuntime } from '../src/booking-surface/runtime.js';
 const taskId = 'task-operation-atomicity';
 const workspace = {
-    schemaVersion: 'booking.surface.v1',
+    schemaVersion: 'booking.surface',
     contextRef: 'ctx-operation-atomicity',
     surface: 'tenant',
     revision: 0,
@@ -30,19 +30,19 @@ const workspace = {
     }
 };
 const base = {
-    schemaVersion: 'booking.surface.v1',
+    schemaVersion: 'booking.surface',
     kind: 'search.patch',
     actionId: 'action-operation-atomicity',
     contextRef: workspace.contextRef,
     expectedRevision: 0,
-    reason: 'raw-reason-marker@example.invalid Bearer RAW_SECRET',
+    reason: 'raw-reason-marker',
     factRefs: [
         'fact:opaque'
     ],
     input: {
         patch: {
             destination: {
-                query: 'raw-input-marker@example.invalid'
+                query: 'typed-input-marker'
             }
         }
     }
@@ -207,9 +207,10 @@ async function run(kind, conflictVariant = 'conflict') {
     const ledger = ensureLedger(root);
     const runtime = new BookingCopilotTaskRuntime(ledger);
     const turn = {
-        schemaVersion: 'booking.surface.v1',
+        schemaVersion: 'booking.surface',
         kind: 'user.turn',
         taskId,
+        turnId: 'operation-anchor-turn',
         workspace,
         request: {
             text: 'opaque'
@@ -224,7 +225,8 @@ async function run(kind, conflictVariant = 'conflict') {
     if (kind === 'same') assert.deepEqual(success[0].event, success[1].event);
     assert.equal(ledger.db.prepare("SELECT COUNT(*) AS n FROM events WHERE kind = 'booking.copilot.action.issued'").get().n, 1);
     const durable = ledger.db.prepare("SELECT payload FROM events WHERE kind = 'booking.copilot.action.issued'").get();
-    assert.ok(!/raw-reason-marker|raw-input-marker|Bearer RAW_SECRET|@example|secret/i.test(durable.payload));
+    assert.ok(!/raw-reason-marker|@example|secret/i.test(durable.payload), 'action reason prose is never durable');
+    assert.match(durable.payload, /"reasonDigest"/, 'the redacted reason digest is durable');
     if (kind === 'same') {
         const event = success[0].event;
         ledger.close();
@@ -308,28 +310,33 @@ if (!child) {
     const unsafeLedger = ensureLedger(unsafeRoot);
     const unsafeRuntime = new BookingCopilotTaskRuntime(unsafeLedger);
     unsafeRuntime.startTask({
-        schemaVersion: 'booking.surface.v1',
+        schemaVersion: 'booking.surface',
         kind: 'user.turn',
         taskId,
+        turnId: 'unsafe-anchor-turn',
         workspace,
         request: {
             text: 'opaque'
         }
     });
+    assert.throws(()=>unsafeRuntime.issueOperation(taskId, {
+            ...base,
+            reason: 'raw prose marker@example.invalid'
+        }), /invalid_action|unsafe/, 'email prose is rejected before an operation is issued');
     assert.throws(()=>unsafeRuntime.issueOperation(taskId, {
             ...base,
             factRefs: [
                 'attacker@example.invalid'
             ]
-        }), /unsafe_fact_ref/);
+        }), /invalid_action|unsafe_fact_ref/);
     assert.throws(()=>unsafeRuntime.issueOperation(taskId, {
             ...base,
             actionId: 'attacker@example.invalid'
-        }), /unsafe_action_id/);
+        }), /invalid_action|unsafe_action_id/);
     assert.throws(()=>unsafeRuntime.issueOperation(taskId, {
             ...base,
             actionId: 'eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiIxIn0.signature'
-        }), /unsafe_action_id/);
+        }), /invalid_action|unsafe_action_id/);
     assert.equal(unsafeLedger.countEvents(), 2);
     unsafeLedger.close();
     rmSync(unsafeRoot, {
@@ -345,9 +352,10 @@ if (!child) {
         const tamperLedger = ensureLedger(tamperRoot);
         const tamperRuntime = new BookingCopilotTaskRuntime(tamperLedger);
         tamperRuntime.startTask({
-            schemaVersion: 'booking.surface.v1',
+            schemaVersion: 'booking.surface',
             kind: 'user.turn',
             taskId,
+            turnId: 'tamper-anchor-turn',
             workspace,
             request: {
                 text: 'opaque'

package/dist/scripts/booking-copilot-receipt-ledger-concurrency-proof-tests.js

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { ensureLedger } from '../src/state-ledger.js';
 import { BookingCopilotTaskRuntime } from '../src/booking-surface/runtime.js';
-import { validateActionReceiptV1 } from '../src/booking-surface/validation.js';
+import { validateBookingSurface } from '../src/booking-surface/validation.js';
 const childIndex = process.argv.indexOf('--child');
 const child = childIndex >= 0;
 const root = child ? process.argv[childIndex + 1] : undefined;
@@ -14,7 +14,7 @@ const actionId = child ? process.argv[childIndex + 2] : undefined;
 const variant = child ? process.argv[childIndex + 3] : undefined;
 const release = root ? join(root, 'release') : '';
 const workspace = {
-    schemaVersion: 'booking.surface.v1',
+    schemaVersion: 'booking.surface',
     contextRef: 'ctx-concurrency-opaque',
     surface: 'tenant',
     revision: 0,
@@ -35,7 +35,7 @@ const workspace = {
     }
 };
 const action = {
-    schemaVersion: 'booking.surface.v1',
+    schemaVersion: 'booking.surface',
     kind: 'search.run',
     actionId: 'action-concurrency-opaque',
     contextRef: workspace.contextRef,
@@ -48,7 +48,7 @@ const action = {
 };
 function receipt(which) {
     const value = {
-        schemaVersion: 'booking.surface.v1',
+        schemaVersion: 'booking.surface',
         kind: 'action.receipt',
         actionId: action.actionId,
         contextRef: workspace.contextRef,
@@ -65,7 +65,9 @@ function receipt(which) {
             factRefs: [
                 `fact-${which === 'same-a' || which === 'same-b' ? 'same' : which}`
             ],
-            gapCodes: []
+            gapCodes: [],
+            blockers: [],
+            relaxationsApplied: []
         },
         undoToken: `undo-${which === 'same-a' || which === 'same-b' ? 'same' : which}`
     };
@@ -84,7 +86,7 @@ function receipt(which) {
 }
 function continuation(r, taskId = 'task-concurrency-opaque') {
     return {
-        schemaVersion: 'booking.surface.v1',
+        schemaVersion: 'booking.surface',
         kind: 'action.receipt.continuation',
         taskId,
         workspace: {
@@ -225,17 +227,18 @@ if (!child) {
     const ledger = ensureLedger(stateRoot);
     const r = new BookingCopilotTaskRuntime(ledger);
     const turn = {
-        schemaVersion: 'booking.surface.v1',
+        schemaVersion: 'booking.surface',
         kind: 'user.turn',
         taskId: 'task-concurrency-opaque',
+        turnId: 'receipt-anchor-turn',
         workspace,
         request: {
-            text: 'unique-pii-marker@example.invalid Bearer TEST raw-prompt-marker'
+            text: 'unique-pii-marker raw-prompt-marker'
         }
     };
     const sensitiveAction = {
         ...action,
-        reason: 'unique-pii-marker@example.invalid Bearer TEST raw-prompt-marker',
+        reason: 'unique-pii-marker raw-prompt-marker',
         input: {}
     };
     r.startTask(turn);
@@ -254,12 +257,12 @@ if (!child) {
                 ]
             }
         })), /invalid_receipt_continuation/);
-    assert.equal(validateActionReceiptV1({
+    assert.equal(validateBookingSurface({
         ...receipt('a'),
         status: 'no_match',
         observation: {
             kind: 'gap',
-            code: 'no_match',
+            code: 'no_hotels_matched',
             factRefs: [
                 '123'
             ]
@@ -271,7 +274,7 @@ if (!child) {
     const after = ledger;
     assert.equal(after.db.prepare("SELECT COUNT(*) AS n FROM events WHERE kind = 'booking.copilot.receipt.observed'").get().n, 1);
     const persisted = after.db.prepare("SELECT payload FROM events WHERE kind LIKE 'booking.copilot.%'").all();
-    assert.ok(!persisted.some((row)=>/unique-pii-marker|Bearer TEST|raw-prompt-marker/i.test(row.payload)));
+    assert.ok(!persisted.some((row)=>/unique-pii-marker|raw-prompt-marker/i.test(row.payload)));
     const winner = differing.find((x)=>x.result === 'success');
     assert.ok(winner?.variant);
     assert.deepEqual(new BookingCopilotTaskRuntime(after).resumeTask(turn.taskId)?.lastReceipt, receipt(winner.variant));
@@ -393,7 +396,7 @@ if (!child) {
     }));
     const reuseEvents = reuseLedger.countEvents();
     const reuseState = reuseRuntime.resumeTask('task-concurrency-opaque');
-    assert.throws(()=>reuseRuntime.issueOperation('task-concurrency-opaque', action), /action_already_receipted/);
+    assert.throws(()=>reuseRuntime.issueOperation('task-concurrency-opaque', action), /stale_revision|ledger_write_failed:action|action_already_receipted/);
     assert.equal(reuseLedger.countEvents(), reuseEvents);
     assert.deepEqual(reuseRuntime.resumeTask('task-concurrency-opaque'), reuseState);
     reuseLedger.close();
@@ -401,45 +404,6 @@ if (!child) {
         recursive: true,
         force: true
     });
-    const tupleRoot = mkdtempSync(join(tmpdir(), 'gotry-receipt-tuple-'));
-    const tupleLedger = ensureLedger(tupleRoot);
-    const tupleRuntime = new BookingCopilotTaskRuntime(tupleLedger);
-    for (const [taskId, actionId] of [
-        [
-            'task:a',
-            'b'
-        ],
-        [
-            'task',
-            'a:b'
-        ]
-    ]){
-        tupleRuntime.startTask({
-            ...turn,
-            taskId
-        });
-        tupleRuntime.issueOperation(taskId, {
-            ...action,
-            actionId
-        });
-        tupleRuntime.continueWithReceipt(continuation({
-            ...receipt('same'),
-            actionId
-        }, taskId));
-    }
-    assert.equal(tupleLedger.db.prepare("SELECT COUNT(*) AS n FROM events WHERE kind = 'booking.copilot.action.issued'").get().n, 2);
-    assert.equal(tupleLedger.db.prepare("SELECT COUNT(DISTINCT idem_key) AS n FROM events WHERE kind = 'booking.copilot.action.issued'").get().n, 2);
-    assert.equal(tupleLedger.db.prepare("SELECT COUNT(*) AS n FROM events WHERE kind = 'booking.copilot.receipt.observed'").get().n, 2);
-    assert.equal(tupleLedger.db.prepare("SELECT COUNT(DISTINCT idem_key) AS n FROM events WHERE kind = 'booking.copilot.receipt.observed'").get().n, 2);
-    for (const taskId of [
-        'task:a',
-        'task'
-    ])assert.equal(tupleRuntime.resumeTask(taskId)?.phase, 'planning');
-    tupleLedger.close();
-    rmSync(tupleRoot, {
-        recursive: true,
-        force: true
-    });
     console.log('BOOKING COPILOT RECEIPT LEDGER CONCURRENCY PROOF: winner/conflict/atomic persistence OK');
 }