@dakkitor/api-contracts 1.9.1 → 1.9.3

package/dist/bookings/backdate-guard.spec.js

@@ -9,9 +9,6 @@ const daysBefore = (n) => {
     return d.toISOString().split('T')[0];
 };
 describe('backdateDaysFrom', () => {
-    it('exposes the threshold as 31', () => {
-        expect(bookings_contract_1.MAX_BOOKING_BACKDATE_DAYS).toBe(31);
-    });
     it('returns 0 for today', () => {
         expect((0, bookings_contract_1.backdateDaysFrom)(daysBefore(0), NOW)).toBe(0);
     });
@@ -29,52 +26,47 @@ describe('backdateDaysFrom', () => {
         expect((0, bookings_contract_1.backdateDaysFrom)(daysBefore(5), new Date('2026-08-13T23:59:59Z'))).toBe(5);
     });
 });
-describe('BookingItemSchema backdating rule', () => {
+describe('BookingItemSchema start date', () => {
     // BookingItemSchema's only other required field is `worker` (ResourceIdSchema);
     // there is no `jobId` on this schema — job assignment happens one level up on
     // CreateBookingSchema.
     const base = {
         worker: { id: '11111111-1111-4111-8111-111111111111' },
     };
-    // BookingItemSchema's cross-field rules call backdateDaysFrom(data.startDate)
-    // with the DEFAULT `now = new Date()` — the real wall clock, not the pinned
-    // NOW above. Fixtures in this block must be built from the real clock too,
-    // or the two clocks drift apart (by a day, then more) and these tests
-    // become flaky/false-failing over time.
+    // The cap that used to live here bounded the booking DATE. It now bounds
+    // actives generation instead (MAX_ACTIVES_BACKFILL_DAYS in apps/api), so an
+    // operator may record a placement over any interval. These fixtures use the
+    // real clock because the schema's superRefine does too.
     const daysBeforeReal = (n) => {
         const d = new Date();
         d.setUTCDate(d.getUTCDate() - n);
         return d.toISOString().split('T')[0];
     };
-    it('rejects a start date 32 days in the past', () => {
+    const startDateIssuesFor = (startDate) => {
+        const result = bookings_contract_1.BookingItemSchema.safeParse({ ...base, startDate });
+        return result.success
+            ? []
+            : result.error.issues.filter((i) => i.path[0] === 'startDate');
+    };
+    it('accepts a start date 32 days in the past', () => {
+        expect(startDateIssuesFor(daysBeforeReal(32))).toEqual([]);
+    });
+    it('accepts a start date years in the past', () => {
+        expect(startDateIssuesFor('2016-04-15')).toEqual([]);
+    });
+    it('accepts today', () => {
+        expect(startDateIssuesFor(daysBeforeReal(0))).toEqual([]);
+    });
+    it('still rejects an In Progress booking starting in the future', () => {
         const result = bookings_contract_1.BookingItemSchema.safeParse({
             ...base,
-            startDate: daysBeforeReal(32),
+            startDate: '2099-01-01',
+            status: { type: 'STARTED_THE_JOB', category: 'IN_PROGRESS' },
         });
         expect(result.success).toBe(false);
         if (!result.success) {
             const issue = result.error.issues.find((i) => i.path[0] === 'startDate');
-            expect(issue?.message).toBe('Start date cannot be more than 31 days in the past (received 32 days).');
+            expect(issue?.message).toBe("In Progress booking start date must be before or equal to today's date.");
         }
     });
-    it('accepts a start date exactly 31 days in the past', () => {
-        const result = bookings_contract_1.BookingItemSchema.safeParse({
-            ...base,
-            startDate: daysBeforeReal(31),
-        });
-        const startDateIssue = result.success
-            ? undefined
-            : result.error.issues.find((i) => i.path[0] === 'startDate');
-        expect(startDateIssue).toBeUndefined();
-    });
-    it('accepts today', () => {
-        const result = bookings_contract_1.BookingItemSchema.safeParse({
-            ...base,
-            startDate: daysBeforeReal(0),
-        });
-        const startDateIssue = result.success
-            ? undefined
-            : result.error.issues.find((i) => i.path[0] === 'startDate');
-        expect(startDateIssue).toBeUndefined();
-    });
 });