@dainamite/cpq 0.4.0 → 0.5.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dainamite/cpq",
-  "version": "0.4.0",
+  "version": "0.5.0",
   "description": "Dainamite CPQ — Configure, Price, Quote engine for Open Mercato (configurable products, multi-charge pricing tables, guided quoting, customer inventory, orders).",
   "type": "module",
   "main": "./dist/modules/cpq/index.js",
@@ -121,14 +121,14 @@
     }
   },
   "peerDependencies": {
-    "@mikro-orm/core": "^7.1.5",
-    "@mikro-orm/decorators": "^7.1.5",
-    "@mikro-orm/postgresql": "^7.1.5",
-    "@open-mercato/core": "^0.6.7",
-    "@open-mercato/events": "^0.6.7",
-    "@open-mercato/shared": "^0.6.7",
-    "@open-mercato/ui": "^0.6.7",
-    "@tanstack/react-table": "^8.0.0 || ^9.0.0",
+    "@mikro-orm/core": "^7.1.14",
+    "@mikro-orm/decorators": "^7.1.14",
+    "@mikro-orm/postgresql": "^7.1.14",
+    "@open-mercato/core": "^0.9.0",
+    "@open-mercato/events": "^0.9.0",
+    "@open-mercato/shared": "^0.9.0",
+    "@open-mercato/ui": "^0.9.0",
+    "@tanstack/react-table": "^9.0.0",
     "awilix": "^12.0.0",
     "bcryptjs": "^3.0.0",
     "lucide-react": "^0.400.0",

package/src/modules/cpq/__integration__/TC-CPQ-002.spec.ts

@@ -108,16 +108,19 @@ test.describe('TC-CPQ-002: Quote golden path (API)', () => {
     expect(res.status()).toBe(400)
   })
 
-  test('rejects fetching an unknown quote (404 expected; prod build observed 500 — accept 4xx/5xx)', async ({ request }) => {
+  test('rejects fetching an unknown quote with 404, also after a page has rendered', async ({ request }) => {
+    // Render a page first. Pages and API routes bundle @dainamite/cpq
+    // separately while sharing one DI container, so once the page bootstrap
+    // has run the route catches a QuotingError from the other copy of the
+    // class. With `instanceof` that surfaced as a 500; the brand-based
+    // isQuotingError guard must keep it a 404.
+    await request.get('/login')
     const res = await apiRequest(
       request,
       'GET',
       '/api/cpq/quotes/00000000-0000-4000-8000-000000000000',
       { token, data: undefined },
     )
-    // Semantically: request must be rejected. Dev mode returns 404 cleanly; prod
-    // build can surface 500 from MikroORM-not-found exceptions. Both prove "rejected".
-    expect(res.ok()).toBeFalsy()
-    expect(res.status()).toBeGreaterThanOrEqual(400)
+    expect(res.status()).toBe(404)
   })
 })

package/src/modules/cpq/api/_helpers/handleArcError.ts

@@ -1,18 +1,19 @@
 import { NextResponse } from 'next/server'
 import { z } from 'zod'
 import { OptimisticLockError } from '@mikro-orm/core'
-import { QuotingError } from '../../services/cpqQuotingService'
+import { isQuotingError } from '../../services/cpqQuotingService'
 
 /**
  * Shared error → JSON-response converter for ARC routes (XD-250).
  *
  * Handles three families:
  *   1. Zod validation errors → 400 with `details` array.
- *   2. Service-layer `QuotingError` (matched both via `instanceof` AND via
- *      duck-typing on `name === 'QuotingError'`) → propagates `err.status`.
- *      The duck-typing fallback exists because Turbopack hot-reload can
- *      produce two distinct class instances for the same source file
- *      across module boundaries, breaking `instanceof` checks at runtime.
+ *   2. Service-layer `QuotingError` (matched via its cross-realm brand,
+ *      `isQuotingError`, with a duck-typed fallback below) → propagates
+ *      `err.status`. `instanceof` is unreliable here: Next bundles this
+ *      package once per server layer, so the route and the DI-resolved
+ *      service can hold two distinct copies of the class — in production
+ *      too, not only under hot-reload.
  *   3. cpqInventoryService throws plain `{ status, error }` objects →
  *      propagate the embedded status.
  *   4. Anything else → 500 + console.error with the route context.
@@ -28,7 +29,7 @@ export function handleArcError(err: unknown, ctx: string): NextResponse {
     )
   }
 
-  if (err instanceof QuotingError) {
+  if (isQuotingError(err)) {
     const body: Record<string, unknown> = { error: err.message }
     if (err.cpqStatus) body.cpqStatus = err.cpqStatus
     if (err.details) Object.assign(body, err.details)
@@ -52,11 +53,10 @@ export function handleArcError(err: unknown, ctx: string): NextResponse {
     )
   }
 
-  // Duck-typed QuotingError (Turbopack instanceof drift) and inventory-service
-  // plain throw shape `{ status, error }`. Both surface a numeric `status`.
-  // Also propagates `details` (object) into response body — preserves the
-  // structured payload (e.g. `existingQuoteId`) that the typed branch above
-  // would have surfaced if instanceof had matched.
+  // cpqInventoryService's plain throw shape `{ status, error }` (QuotingError
+  // from any bundle copy is already handled by `isQuotingError` above).
+  // Propagates `details` (object) into the response body so structured
+  // payloads survive here too.
   if (
     err &&
     typeof err === 'object' &&

package/src/modules/cpq/api/orders/[orderId]/activate/route.ts

@@ -1,7 +1,7 @@
 import { NextResponse } from 'next/server'
 import { OptimisticLockError } from '@mikro-orm/core'
 import { resolveCpqRouteContext } from '../../../context'
-import { OrderError } from '../../../../services/cpqOrderService'
+import { isOrderError } from '../../../../services/cpqOrderService'
 import type { DefaultCpqOrderService } from '../../../../services/cpqOrderService'
 
 export const metadata = {
@@ -20,7 +20,7 @@ export async function POST(req: Request, { params }: { params: Promise<{ orderId
     const result = await service.activateOrder(orderId, scope)
     return NextResponse.json(result)
   } catch (err) {
-    if (err instanceof OrderError) {
+    if (isOrderError(err)) {
       return NextResponse.json({ error: err.message }, { status: err.status })
     }
     // XD-250 ARC: optimistic-lock collision on subscription.version when two

package/src/modules/cpq/api/orders/[orderId]/route.ts

@@ -1,6 +1,6 @@
 import { NextResponse } from 'next/server'
 import { resolveCpqRouteContext } from '../../context'
-import { OrderError } from '../../../services/cpqOrderService'
+import { isOrderError } from '../../../services/cpqOrderService'
 import type { DefaultCpqOrderService } from '../../../services/cpqOrderService'
 
 export const metadata = {
@@ -19,7 +19,7 @@ export async function GET(req: Request, { params }: { params: Promise<{ orderId:
     const result = await service.getOrder(orderId, scope)
     return NextResponse.json(result)
   } catch (err) {
-    if (err instanceof OrderError) {
+    if (isOrderError(err)) {
       return NextResponse.json({ error: err.message }, { status: err.status })
     }
     console.error('[cpq/orders/[orderId].GET]', err)

package/src/modules/cpq/api/orders/[orderId]/status/route.ts

@@ -2,7 +2,7 @@ import { NextResponse } from 'next/server'
 import { z } from 'zod'
 import { resolveCpqRouteContext } from '../../../context'
 import { cpqOrderStatusTransitionSchema } from '../../../../data/validators'
-import { OrderError } from '../../../../services/cpqOrderService'
+import { isOrderError } from '../../../../services/cpqOrderService'
 import type { DefaultCpqOrderService } from '../../../../services/cpqOrderService'
 
 export const metadata = {
@@ -25,7 +25,7 @@ export async function POST(req: Request, { params }: { params: Promise<{ orderId
     if (err instanceof z.ZodError) {
       return NextResponse.json({ error: 'Validation error', details: err.issues }, { status: 400 })
     }
-    if (err instanceof OrderError) {
+    if (isOrderError(err)) {
       return NextResponse.json({ error: err.message }, { status: err.status })
     }
     const errObj = err as Record<string, unknown>

package/src/modules/cpq/api/orders/route.ts

@@ -2,7 +2,7 @@ import { NextResponse } from 'next/server'
 import { z } from 'zod'
 import { resolveCpqRouteContext } from '../context'
 import { cpqConvertQuoteToOrderSchema } from '../../data/validators'
-import { OrderError } from '../../services/cpqOrderService'
+import { isOrderError } from '../../services/cpqOrderService'
 import type { DefaultCpqOrderService } from '../../services/cpqOrderService'
 
 export const metadata = {
@@ -65,7 +65,7 @@ function handleError(err: unknown, context: string) {
   if (err instanceof z.ZodError) {
     return NextResponse.json({ error: 'Validation error', details: err.issues }, { status: 400 })
   }
-  if (err instanceof OrderError) {
+  if (isOrderError(err)) {
     return NextResponse.json({ error: err.message }, { status: err.status })
   }
   const errObj = err as Record<string, unknown>

package/src/modules/cpq/api/quotes/[quoteId]/clone/route.ts

@@ -1,6 +1,6 @@
 import { NextResponse } from 'next/server'
 import { resolveCpqRouteContext } from '../../../context'
-import { QuotingError } from '../../../../services/cpqQuotingService'
+import { isQuotingError } from '../../../../services/cpqQuotingService'
 import { resolveQuotingService } from '../../../resolveQuotingService'
 
 export const metadata = {
@@ -19,7 +19,7 @@ export async function POST(req: Request, { params }: { params: Promise<{ quoteId
     const result = await service.cloneQuote(quoteId, scope)
     return NextResponse.json(result, { status: 201 })
   } catch (err) {
-    if (err instanceof QuotingError) {
+    if (isQuotingError(err)) {
       return NextResponse.json({ error: err.message }, { status: err.status })
     }
     console.error('[cpq/quotes/[quoteId]/clone.POST]', err)

package/src/modules/cpq/api/quotes/[quoteId]/items/[lineId]/route.ts

@@ -2,7 +2,7 @@ import { NextResponse } from 'next/server'
 import { z } from 'zod'
 import { resolveCpqRouteContext } from '../../../../context'
 import { cpqUpdateQuoteItemSchema } from '../../../../../data/validators'
-import { QuotingError } from '../../../../../services/cpqQuotingService'
+import { isQuotingError } from '../../../../../services/cpqQuotingService'
 import { resolveQuotingService } from '../../../../resolveQuotingService'
 
 export const metadata = {
@@ -26,7 +26,7 @@ export async function PUT(req: Request, { params }: { params: Promise<{ quoteId:
     if (err instanceof z.ZodError) {
       return NextResponse.json({ error: 'Validation error', details: err.issues }, { status: 400 })
     }
-    if (err instanceof QuotingError) {
+    if (isQuotingError(err)) {
       return NextResponse.json({ error: err.message }, { status: err.status })
     }
     console.error('[cpq/quotes/[quoteId]/items/[lineId].PUT]', err)
@@ -46,7 +46,7 @@ export async function DELETE(req: Request, { params }: { params: Promise<{ quote
     const result = await service.removeQuoteItem(quoteId, lineId, scope)
     return NextResponse.json(result)
   } catch (err) {
-    if (err instanceof QuotingError) {
+    if (isQuotingError(err)) {
       return NextResponse.json({ error: err.message }, { status: err.status })
     }
     console.error('[cpq/quotes/[quoteId]/items/[lineId].DELETE]', err)

package/src/modules/cpq/api/quotes/[quoteId]/recalculate/route.ts

@@ -2,7 +2,7 @@ import { NextResponse } from 'next/server'
 import { z } from 'zod'
 import { resolveCpqRouteContext } from '../../../context'
 import { cpqRecalculateSchema } from '../../../../data/validators'
-import { QuotingError } from '../../../../services/cpqQuotingService'
+import { isQuotingError } from '../../../../services/cpqQuotingService'
 import { resolveQuotingService } from '../../../resolveQuotingService'
 
 export const metadata = {
@@ -25,7 +25,7 @@ export async function POST(req: Request, { params }: { params: Promise<{ quoteId
     if (err instanceof z.ZodError) {
       return NextResponse.json({ error: 'Validation error', details: err.issues }, { status: 400 })
     }
-    if (err instanceof QuotingError) {
+    if (isQuotingError(err)) {
       return NextResponse.json({ error: err.message }, { status: err.status })
     }
     console.error('[cpq/quotes/[quoteId]/recalculate.POST]', err)

package/src/modules/cpq/api/quotes/[quoteId]/route.ts

@@ -1,7 +1,7 @@
 import { NextResponse } from 'next/server'
 import { resolveCpqRouteContext } from '../../context'
 import { cpqUpdateQuoteSchema } from '../../../data/validators'
-import { QuotingError } from '../../../services/cpqQuotingService'
+import { isQuotingError } from '../../../services/cpqQuotingService'
 import { resolveQuotingService } from '../../resolveQuotingService'
 import { CpqQuoteConfiguration, CpqQuoteLineConfiguration } from '../../../data/entities'
 import { SalesQuote, SalesQuoteLine } from '@open-mercato/core/modules/sales/data/entities'
@@ -25,7 +25,7 @@ export async function GET(req: Request, { params }: { params: Promise<{ quoteId:
     const result = await service.getQuote(quoteId, scope)
     return NextResponse.json(result)
   } catch (err) {
-    if (err instanceof QuotingError) {
+    if (isQuotingError(err)) {
       return NextResponse.json({ error: err.message }, { status: err.status })
     }
     console.error('[cpq/quotes/[quoteId].GET]', err)

package/src/modules/cpq/api/quotes/route.ts

@@ -2,7 +2,7 @@ import { NextResponse } from 'next/server'
 import { z } from 'zod'
 import { resolveCpqRouteContext } from '../context'
 import { cpqCreateQuoteSchema } from '../../data/validators'
-import { QuotingError } from '../../services/cpqQuotingService'
+import { isQuotingError } from '../../services/cpqQuotingService'
 import { resolveQuotingService } from '../resolveQuotingService'
 import { CpqQuoteConfiguration } from '../../data/entities'
 import { SalesQuote } from '@open-mercato/core/modules/sales/data/entities'
@@ -104,7 +104,7 @@ function handleError(err: unknown, context: string) {
   if (err instanceof z.ZodError) {
     return NextResponse.json({ error: 'Validation error', details: err.issues }, { status: 400 })
   }
-  if (err instanceof QuotingError) {
+  if (isQuotingError(err)) {
     const body: Record<string, unknown> = { error: err.message }
     if (err.cpqStatus) body.cpqStatus = err.cpqStatus
     return NextResponse.json(body, { status: err.status })

package/src/modules/cpq/backend/cpq/inventory/AssetsTable.tsx

@@ -2,7 +2,7 @@
 import * as React from 'react'
 import { useT } from '@open-mercato/shared/lib/i18n/context'
 import { useRouter } from 'next/navigation'
-import type { ColumnDef } from '@tanstack/react-table'
+import type { LegacyColumnDef as ColumnDef } from '@tanstack/react-table/legacy'
 import { DataTable } from '@open-mercato/ui/backend/DataTable'
 import { RowActions } from '@open-mercato/ui/backend/RowActions'
 import type { FilterDef, FilterValues } from '@open-mercato/ui/backend/FilterBar'

package/src/modules/cpq/backend/cpq/inventory/SubscriptionsTable.tsx

@@ -2,7 +2,7 @@
 import * as React from 'react'
 import { useT } from '@open-mercato/shared/lib/i18n/context'
 import { useRouter } from 'next/navigation'
-import type { ColumnDef } from '@tanstack/react-table'
+import type { LegacyColumnDef as ColumnDef } from '@tanstack/react-table/legacy'
 import { DataTable } from '@open-mercato/ui/backend/DataTable'
 import { RowActions } from '@open-mercato/ui/backend/RowActions'
 import type { FilterDef, FilterValues } from '@open-mercato/ui/backend/FilterBar'

package/src/modules/cpq/backend/cpq/offerings/page.tsx

@@ -2,7 +2,7 @@
 import * as React from 'react'
 import { useT } from '@open-mercato/shared/lib/i18n/context'
 import { useRouter } from 'next/navigation'
-import type { ColumnDef } from '@tanstack/react-table'
+import type { LegacyColumnDef as ColumnDef } from '@tanstack/react-table/legacy'
 import { type BulkAction } from '@open-mercato/ui/backend/DataTable'
 import { Button } from '@open-mercato/ui/primitives/button'
 import { Checkbox } from '@open-mercato/ui/primitives/checkbox'

package/src/modules/cpq/backend/cpq/orders/page.tsx

@@ -2,7 +2,7 @@
 import * as React from 'react'
 import { useRouter } from 'next/navigation'
 import { useT } from '@open-mercato/shared/lib/i18n/context'
-import type { ColumnDef } from '@tanstack/react-table'
+import type { LegacyColumnDef as ColumnDef } from '@tanstack/react-table/legacy'
 import type { FilterDef, FilterValues } from '@open-mercato/ui/backend/FilterBar'
 import { RowActions } from '@open-mercato/ui/backend/RowActions'
 import { Tag } from '@open-mercato/ui/primitives/tag'

package/src/modules/cpq/backend/cpq/price-rules/page.tsx

@@ -2,7 +2,7 @@
 import * as React from 'react'
 import { useRouter } from 'next/navigation'
 import { useT } from '@open-mercato/shared/lib/i18n/context'
-import type { ColumnDef } from '@tanstack/react-table'
+import type { LegacyColumnDef as ColumnDef } from '@tanstack/react-table/legacy'
 import { Button } from '@open-mercato/ui/primitives/button'
 import { Tag } from '@open-mercato/ui/primitives/tag'
 import type { FilterDef, FilterValues } from '@open-mercato/ui/backend/FilterBar'

package/src/modules/cpq/backend/cpq/pricing/page.tsx

@@ -2,7 +2,7 @@
 import * as React from 'react'
 import { useT } from '@open-mercato/shared/lib/i18n/context'
 import { useRouter } from 'next/navigation'
-import type { ColumnDef } from '@tanstack/react-table'
+import type { LegacyColumnDef as ColumnDef } from '@tanstack/react-table/legacy'
 import { Button } from '@open-mercato/ui/primitives/button'
 import { Tag } from '@open-mercato/ui/primitives/tag'
 import type { FilterDef, FilterValues } from '@open-mercato/ui/backend/FilterBar'

package/src/modules/cpq/backend/cpq/quotes/[id]/page.tsx

@@ -850,9 +850,10 @@ export default function CpqQuoteDetailPage(props: { params?: { id?: string } })
             <Alert variant="warning">
               <AlertTitle>Validation Issues</AlertTitle>
               <AlertDescription>
-                {/* AlertDescription renders a <p>, so the error list MUST be
-                    stacked <span>s — `<ul>`/`<li>` inside `<p>` is invalid
-                    HTML and Next 16 surfaces it as a hydration error. */}
+                {/* Stacked <span>s rather than <ul>/<li>: before Open Mercato
+                    0.8 AlertDescription rendered a <p>, where a list is invalid
+                    HTML and a Next 16 hydration error. It is a <div> now, so a
+                    list would be fine; the spans are kept as harmless. */}
                 <span className="text-xs space-y-0.5 block">
                   {cpqQuote.validationResult.errors.map((e, i) => (
                     <span key={i} className="block">— {e.message}</span>

package/src/modules/cpq/backend/cpq/quotes/page.tsx

@@ -2,7 +2,7 @@
 import * as React from 'react'
 import { useRouter } from 'next/navigation'
 import { useT } from '@open-mercato/shared/lib/i18n/context'
-import type { ColumnDef } from '@tanstack/react-table'
+import type { LegacyColumnDef as ColumnDef } from '@tanstack/react-table/legacy'
 import { Button } from '@open-mercato/ui/primitives/button'
 import { Input } from '@open-mercato/ui/primitives/input'
 import type { FilterDef, FilterValues } from '@open-mercato/ui/backend/FilterBar'

package/src/modules/cpq/backend/cpq/specifications/page.tsx

@@ -2,7 +2,7 @@
 import * as React from 'react'
 import { useT } from '@open-mercato/shared/lib/i18n/context'
 import { useRouter } from 'next/navigation'
-import type { ColumnDef } from '@tanstack/react-table'
+import type { LegacyColumnDef as ColumnDef } from '@tanstack/react-table/legacy'
 import { Button } from '@open-mercato/ui/primitives/button'
 import { Checkbox } from '@open-mercato/ui/primitives/checkbox'
 import { Tag } from '@open-mercato/ui/primitives/tag'

package/src/modules/cpq/backend/cpq/wizards/page.tsx

@@ -2,7 +2,7 @@
 import * as React from 'react'
 import { useRouter } from 'next/navigation'
 import { useT } from '@open-mercato/shared/lib/i18n/context'
-import type { ColumnDef } from '@tanstack/react-table'
+import type { LegacyColumnDef as ColumnDef } from '@tanstack/react-table/legacy'
 import type { FilterDef, FilterValues } from '@open-mercato/ui/backend/FilterBar'
 import { RowActions } from '@open-mercato/ui/backend/RowActions'
 import { Tag } from '@open-mercato/ui/primitives/tag'

package/src/modules/cpq/components/CpqListView.tsx

@@ -1,6 +1,7 @@
 "use client"
 import * as React from 'react'
-import type { ColumnDef, SortingState } from '@tanstack/react-table'
+import type { SortingState } from '@tanstack/react-table'
+import type { LegacyColumnDef as ColumnDef } from '@tanstack/react-table/legacy'
 import { DataTable, type BulkAction } from '@open-mercato/ui/backend/DataTable'
 import { Page, PageBody } from '@open-mercato/ui/backend/Page'
 import type { FilterDef, FilterValues } from '@open-mercato/ui/backend/FilterBar'

package/src/modules/cpq/services/__tests__/errorBrands.test.ts

@@ -0,0 +1,72 @@
+/**
+ * QuotingError / OrderError must be recognisable across duplicate copies of
+ * their module. In a production Next build the page layer and the route layer
+ * each bundle @dainamite/cpq, and the DI container is shared via globalThis,
+ * so a route handler can catch an error built from the *other* copy. With
+ * `instanceof` that silently turned a typed 404 into a 500.
+ *
+ * `jest.isolateModules` loads a second, independent copy of each module —
+ * the same condition the bundler creates.
+ */
+import { QuotingError, isQuotingError } from '../cpqQuotingService'
+import { OrderError, isOrderError } from '../cpqOrderService'
+
+type QuotingModule = typeof import('../cpqQuotingService')
+type OrderModule = typeof import('../cpqOrderService')
+
+function loadIsolated<T>(load: () => T): T {
+  let mod: T | undefined
+  jest.isolateModules(() => {
+    mod = load()
+  })
+  if (!mod) throw new Error('[internal] isolated module failed to load')
+  return mod
+}
+
+describe('isQuotingError', () => {
+  it('recognises an error thrown by a separate copy of the module', () => {
+    const other = loadIsolated<QuotingModule>(() => require('../cpqQuotingService'))
+    const err = new other.QuotingError(404, 'Quote not found')
+
+    // The precondition the guard exists for: the class identities differ.
+    expect(other.QuotingError).not.toBe(QuotingError)
+    expect(err instanceof QuotingError).toBe(false)
+
+    expect(isQuotingError(err)).toBe(true)
+    if (isQuotingError(err)) expect(err.status).toBe(404)
+  })
+
+  it('accepts a same-copy error', () => {
+    expect(isQuotingError(new QuotingError(409, 'conflict'))).toBe(true)
+  })
+
+  it.each([
+    ['a plain Error', new Error('x')],
+    ['an OrderError', new OrderError(404, 'x')],
+    ['a look-alike with the same name and status', Object.assign(new Error('x'), { name: 'QuotingError', status: 404 })],
+    ['null', null],
+    ['a string', 'QuotingError'],
+  ])('rejects %s', (_label, value) => {
+    expect(isQuotingError(value)).toBe(false)
+  })
+})
+
+describe('isOrderError', () => {
+  it('recognises an error thrown by a separate copy of the module', () => {
+    const other = loadIsolated<OrderModule>(() => require('../cpqOrderService'))
+    const err = new other.OrderError(404, 'Order not found')
+
+    expect(other.OrderError).not.toBe(OrderError)
+    expect(err instanceof OrderError).toBe(false)
+
+    expect(isOrderError(err)).toBe(true)
+  })
+
+  it.each([
+    ['a plain Error', new Error('x')],
+    ['a QuotingError', new QuotingError(404, 'x')],
+    ['undefined', undefined],
+  ])('rejects %s', (_label, value) => {
+    expect(isOrderError(value)).toBe(false)
+  })
+})

package/src/modules/cpq/services/cpqOrderService.ts

@@ -1045,7 +1045,13 @@ function pickArcSourceFromConfig(
 
 // ─── Error class ──────────────────────────────────────────────────
 
+// Cross-realm brand — see QUOTING_ERROR_BRAND in cpqQuotingService.ts for why
+// route handlers must not rely on `instanceof`. Use `isOrderError`.
+const ORDER_ERROR_BRAND = Symbol.for('@dainamite/cpq/OrderError')
+
 export class OrderError extends Error {
+  readonly [ORDER_ERROR_BRAND] = true
+
   constructor(
     public status: number,
     message: string,
@@ -1055,6 +1061,10 @@ export class OrderError extends Error {
   }
 }
 
+export function isOrderError(err: unknown): err is OrderError {
+  return !!err && typeof err === 'object' && (err as Record<symbol, unknown>)[ORDER_ERROR_BRAND] === true
+}
+
 // ─── ARC helpers (XD-250) ─────────────────────────────────────────
 
 /**

package/src/modules/cpq/services/cpqQuotingService.ts

@@ -1387,7 +1387,17 @@ function emptyPricingSummary(currencyCode: string): Record<string, unknown> {
 
 // ─── Error class ──────────────────────────────────────────────────
 
+// Cross-realm brand. Next bundles this package once per server layer (page
+// SSR vs route handler), and the DI container is shared through globalThis,
+// so a route handler can catch a QuotingError built from the *other* copy of
+// this class — `instanceof` is then false and a typed 404/409 turns into a
+// 500. `Symbol.for` resolves to the same symbol in every copy. Same approach
+// as `isCrudHttpError` in @open-mercato/shared. Use `isQuotingError`.
+const QUOTING_ERROR_BRAND = Symbol.for('@dainamite/cpq/QuotingError')
+
 export class QuotingError extends Error {
+  readonly [QUOTING_ERROR_BRAND] = true
+
   constructor(
     public status: number,
     message: string,
@@ -1406,6 +1416,10 @@ export class QuotingError extends Error {
   }
 }
 
+export function isQuotingError(err: unknown): err is QuotingError {
+  return !!err && typeof err === 'object' && (err as Record<symbol, unknown>)[QUOTING_ERROR_BRAND] === true
+}
+
 // ─── ARC orchestration (XD-250) ────────────────────────────────────
 //
 // All ARC user-journey logic lives on the CPQ Quote module: