@dainamite/billing 0.18.0 → 0.19.0

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @dainamite/billing
 
+## 0.19.0
+
+### Minor Changes
+
+- 8834b8b: Require Open Mercato `0.6.7`. Peer ranges move from `^0.6.0` to `^0.6.7` for
+  `@open-mercato/core`, `shared`, `ui`, `events` and `queue`, and the MikroORM
+  peers from `^7.0.0` to `^7.1.5` (7.1 split the SQL layer into
+  `@mikro-orm/sql`, so a shared 7.1 instance is required).
+
+  No package source changes — this only narrows the supported framework range.
+  Consumers on Open Mercato `0.6.0`–`0.6.6` must upgrade before taking these
+  versions.
+
+  Note for consumers running commands with a system identity (`ctx.auth: null`):
+  `0.6.7` hardened `ensureTenantScope` / `ensureOrganizationScope`. Those calls
+  are still no-ops with `auth: null`, but an unscoped organization command now
+  logs a warning and will throw `403` if `OM_ENFORCE_ORG_SCOPE_STRICT=true`.
+
 ## 0.18.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dainamite/billing",
-  "version": "0.18.0",
+  "version": "0.19.0",
   "description": "Dainamite Billing — lightweight recurring-billing engine for Open Mercato (Bill Runs, one-time / recurring / usage items, draft invoices in core/sales with human approval).",
   "type": "module",
   "main": "./dist/modules/billing/index.js",
@@ -117,14 +117,14 @@
     }
   },
   "peerDependencies": {
-    "@mikro-orm/core": "^7.0.0",
-    "@mikro-orm/decorators": "^7.0.0",
-    "@mikro-orm/postgresql": "^7.0.0",
-    "@open-mercato/core": "^0.6.0",
-    "@open-mercato/events": "^0.6.0",
-    "@open-mercato/queue": "^0.6.0",
-    "@open-mercato/shared": "^0.6.0",
-    "@open-mercato/ui": "^0.6.0",
+    "@mikro-orm/core": "^7.1.5",
+    "@mikro-orm/decorators": "^7.1.5",
+    "@mikro-orm/postgresql": "^7.1.5",
+    "@open-mercato/core": "^0.6.7",
+    "@open-mercato/events": "^0.6.7",
+    "@open-mercato/queue": "^0.6.7",
+    "@open-mercato/shared": "^0.6.7",
+    "@open-mercato/ui": "^0.6.7",
     "@tanstack/react-table": "^8.0.0 || ^9.0.0",
     "awilix": "^12.0.0",
     "lucide-react": "^0.400.0",

package/src/modules/billing/__tests__/commands/invoices.test.ts

@@ -106,7 +106,7 @@ function makeLine(invoice: FakeInvoice, overrides: Partial<FakeLine> = {}): Fake
 }
 
 type Env = {
-  ctx: { container: { resolve: jest.MockedFunction<(name: string) => unknown> }; auth: { sub?: string } | null }
+  ctx: { container: { resolve: jest.MockedFunction<(name: string) => unknown> }; auth: { sub?: string; tenantId?: string; orgId?: string } | null }
   em: {
     findOne: jest.MockedFunction<(entity: unknown, where: unknown) => Promise<unknown>>
     find: jest.MockedFunction<(entity: unknown, where: unknown) => Promise<unknown[]>>
@@ -131,7 +131,7 @@ function createEnv(
     statusEntryPosted?: string | null
     initialLines?: FakeLine[]
     invoiceFinalLines?: FakeLine[]
-    auth?: { sub?: string } | null
+    auth?: { sub?: string; tenantId?: string; orgId?: string } | null
     testInvoiceRows?: Array<{ id: string }>
   } = {},
 ): Env {
@@ -199,7 +199,7 @@ function createEnv(
   return {
     ctx: {
       container,
-      auth: options.auth ?? { sub: '99999999-9999-4999-8999-999999999999' },
+      auth: options.auth ?? { sub: '99999999-9999-4999-8999-999999999999', tenantId: TENANT, orgId: ORG },
     },
     em,
     persistedEntities,

package/src/modules/billing/__tests__/commands/topups.test.ts

@@ -23,7 +23,7 @@ function makeCtx(em: MockEm, gateway: unknown) {
     flushOrmEntityChanges: jest.fn(async () => undefined),
   }
   return {
-    auth: { sub: '99999999-9999-4999-8999-999999999999' },
+    auth: { sub: '99999999-9999-4999-8999-999999999999', tenantId: TENANT, orgId: ORG },
     container: {
       resolve: jest.fn((name: string) => {
         if (name === 'em') return em

package/src/modules/billing/__tests__/commands/transactions.test.ts

@@ -17,13 +17,15 @@ function prepaidAccount(overrides: Record<string, unknown> = {}) {
   }
 }
 
-function makeCtx(em: MockEm) {
+type CtxAuth = { sub?: string; tenantId?: string; orgId?: string } | null
+
+function makeCtx(em: MockEm, auth: CtxAuth = { sub: '99999999-9999-4999-8999-999999999999', tenantId: TENANT, orgId: ORG }) {
   const dataEngine = {
     markOrmEntityChange: jest.fn(),
     flushOrmEntityChanges: jest.fn(async () => undefined),
   }
   return {
-    auth: { sub: '99999999-9999-4999-8999-999999999999' },
+    auth,
     container: {
       resolve: jest.fn((name: string) => {
         if (name === 'em') return em
@@ -54,6 +56,27 @@ describe('adjustTransactionCommand', () => {
     expect(em.transactions[0].userId).toBe('99999999-9999-4999-8999-999999999999')
   })
 
+  // The CPQ↔billing connector runs as a system identity, not a user: it calls
+  // the command bus with `auth: null` and carries tenant/organization in the
+  // payload instead. Open Mercato 0.6.7 hardened ensureTenantScope from
+  // fail-open to fail-closed, but kept `auth: null` a no-op — this test pins
+  // that, because the connector has no other guarantee than prose. If a future
+  // release closes this branch too, the connector breaks and this fails first.
+  it('accepts a system-identity call (auth: null) without a scope error', async () => {
+    const em = createPrepaidMockEm({
+      account: prepaidAccount(),
+      balance: { tenantId: TENANT, billAccountId: ACCT, balance: '100.0000' },
+    })
+    const ctx = makeCtx(em, null)
+    const result = await adjustTransactionCommand.execute(
+      { tenantId: TENANT, organizationId: ORG, billAccountId: ACCT, amount: -10, description: 'Connector debit' } as never,
+      ctx as never,
+    )
+    expect(result.balance).toBe('90.0000')
+    expect(em.transactions).toHaveLength(1)
+    expect(em.transactions[0].userId).toBeFalsy()
+  })
+
   it('credits the balance', async () => {
     const em = createPrepaidMockEm({
       account: prepaidAccount(),