@daghis/teamcity-mcp 1.9.1 → 1.9.3

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [1.9.3](https://github.com/Daghis/teamcity-mcp/compare/v1.9.2...v1.9.3) (2025-09-21)
+
+
+### Bug Fixes
+
+* **teamcity:** resolve nested artifact downloads ([#188](https://github.com/Daghis/teamcity-mcp/issues/188)) ([e309b90](https://github.com/Daghis/teamcity-mcp/commit/e309b90de42fe121f072fe5b549ab25df3a91aaf))
+
+## [1.9.2](https://github.com/Daghis/teamcity-mcp/compare/v1.9.1...v1.9.2) (2025-09-21)
+
+
+### Bug Fixes
+
+* **teamcity:** restore artifact rules update compatibility ([#185](https://github.com/Daghis/teamcity-mcp/issues/185)) ([1d67268](https://github.com/Daghis/teamcity-mcp/commit/1d67268e6ee837db38ab9be27a94a5f3e072ab83))
+
 ## [1.9.1](https://github.com/Daghis/teamcity-mcp/compare/v1.9.0...v1.9.1) (2025-09-20)
 
 

package/dist/index.js

@@ -1216,26 +1216,72 @@ var ArtifactManager = class _ArtifactManager {
     }
     return payload;
   }
-  parseArtifacts(data, buildId, includeNested, baseUrl) {
+  parseArtifacts(data, buildId, includeNested, baseUrl, parentSegments = []) {
     const artifacts = [];
     const files = data.file ?? [];
     for (const file of files) {
-      if (file.children && includeNested) {
-        const nested = this.parseArtifacts(file.children, buildId, includeNested, baseUrl);
-        artifacts.push(...nested);
-      } else if (!file.children) {
-        artifacts.push({
-          name: file.name ?? "",
-          path: file.fullName ?? file.name ?? "",
-          size: file.size ?? 0,
-          modificationTime: file.modificationTime ?? "",
-          downloadUrl: `${baseUrl}/app/rest/builds/id:${buildId}/artifacts/content/${file.fullName ?? file.name ?? ""}`,
-          isDirectory: false
-        });
-      }
+      const pathSegments = this.buildArtifactSegments(file, parentSegments);
+      const resolvedPath = pathSegments.join("/");
+      const isDirectory = Boolean(file.children);
+      if (isDirectory) {
+        if (includeNested && file.children) {
+          const nested = this.parseArtifacts(
+            file.children,
+            buildId,
+            includeNested,
+            baseUrl,
+            pathSegments
+          );
+          artifacts.push(...nested);
+        }
+        continue;
+      }
+      if (!resolvedPath) {
+        continue;
+      }
+      artifacts.push({
+        name: file.name ?? pathSegments[pathSegments.length - 1] ?? "",
+        path: resolvedPath,
+        size: file.size ?? 0,
+        modificationTime: file.modificationTime ?? "",
+        downloadUrl: `${baseUrl}/app/rest/builds/id:${buildId}/artifacts/content/${this.encodeArtifactPath(pathSegments)}`,
+        isDirectory: false
+      });
     }
     return artifacts;
   }
+  buildArtifactSegments(file, parentSegments) {
+    const fullName = typeof file.fullName === "string" ? file.fullName : void 0;
+    const name = typeof file.name === "string" ? file.name : void 0;
+    const segmentsFromFullName = fullName ? fullName.split("/").filter((segment) => segment.length > 0) : [];
+    if (segmentsFromFullName.length === 0) {
+      if (name && name.length > 0) {
+        return [...parentSegments, name];
+      }
+      return [...parentSegments];
+    }
+    if (parentSegments.length === 0) {
+      return segmentsFromFullName;
+    }
+    if (this.segmentsStartWithParent(segmentsFromFullName, parentSegments)) {
+      return segmentsFromFullName;
+    }
+    return [...parentSegments, ...segmentsFromFullName];
+  }
+  segmentsStartWithParent(segments, parent) {
+    if (parent.length === 0 || segments.length < parent.length) {
+      return false;
+    }
+    for (let i = 0; i < parent.length; i += 1) {
+      if (segments[i] !== parent[i]) {
+        return false;
+      }
+    }
+    return true;
+  }
+  encodeArtifactPath(segments) {
+    return segments.map((segment) => encodeURIComponent(segment)).join("/");
+  }
   ensureBinaryBuffer(payload) {
     if (Buffer.isBuffer(payload)) {
       return payload;
@@ -1346,6 +1392,38 @@ var ArtifactManager = class _ArtifactManager {
 };
 
 // src/teamcity/build-configuration-update-manager.ts
+var ARTIFACT_RULES_SETTINGS_FIELD = "settings/artifactRules";
+var ARTIFACT_RULES_LEGACY_FIELD = "artifactRules";
+var isArtifactRulesRetryableError = (error2) => {
+  if (error2 == null || typeof error2 !== "object") return false;
+  if (!("response" in error2)) return false;
+  const response = error2.response;
+  const status = response?.status;
+  return status === 400 || status === 404;
+};
+var setArtifactRulesWithFallback = async (api, buildTypeId, artifactRules) => {
+  try {
+    await api.setBuildTypeField(buildTypeId, ARTIFACT_RULES_SETTINGS_FIELD, artifactRules);
+  } catch (err) {
+    if (!isArtifactRulesRetryableError(err)) {
+      throw err;
+    }
+    const status = err.response?.status;
+    debug("Retrying artifact rules update via legacy field", {
+      buildTypeId,
+      status
+    });
+    try {
+      await api.setBuildTypeField(buildTypeId, ARTIFACT_RULES_LEGACY_FIELD, artifactRules);
+    } catch (fallbackError) {
+      debug("Legacy artifact rules update failed", {
+        buildTypeId,
+        status: fallbackError.response?.status
+      });
+      throw fallbackError;
+    }
+  }
+};
 var BuildConfigurationUpdateManager = class {
   client;
   constructor(client) {
@@ -1555,6 +1633,14 @@ var BuildConfigurationUpdateManager = class {
       }
       if (settings.length > 0) {
         for (const setting of settings) {
+          if (setting.name === "artifactRules") {
+            await setArtifactRulesWithFallback(
+              this.client.modules.buildTypes,
+              currentConfig.id,
+              setting.value
+            );
+            continue;
+          }
           await this.client.modules.buildTypes.setBuildTypeField(
             currentConfig.id,
             `settings/${setting.name}`,
@@ -40100,9 +40186,9 @@ var FULL_MODE_TOOLS = [
             );
           }
           if (typedArgs.artifactRules !== void 0) {
-            await adapter.modules.buildTypes.setBuildTypeField(
+            await setArtifactRulesWithFallback(
+              adapter.modules.buildTypes,
               typedArgs.buildTypeId,
-              "settings/artifactRules",
               typedArgs.artifactRules
             );
           }
@@ -40123,9 +40209,9 @@ var FULL_MODE_TOOLS = [
           );
         }
         if (typedArgs.artifactRules !== void 0) {
-          await adapter.modules.buildTypes.setBuildTypeField(
+          await setArtifactRulesWithFallback(
+            adapter.modules.buildTypes,
             typedArgs.buildTypeId,
-            "settings/artifactRules",
             typedArgs.artifactRules
           );
         }