@daghis/teamcity-mcp 1.9.0 → 1.9.2

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [1.9.2](https://github.com/Daghis/teamcity-mcp/compare/v1.9.1...v1.9.2) (2025-09-21)
+
+
+### Bug Fixes
+
+* **teamcity:** restore artifact rules update compatibility ([#185](https://github.com/Daghis/teamcity-mcp/issues/185)) ([1d67268](https://github.com/Daghis/teamcity-mcp/commit/1d67268e6ee837db38ab9be27a94a5f3e072ab83))
+
+## [1.9.1](https://github.com/Daghis/teamcity-mcp/compare/v1.9.0...v1.9.1) (2025-09-20)
+
+
+### Bug Fixes
+
+* **tools:** allow manage_build_steps updates ([#182](https://github.com/Daghis/teamcity-mcp/issues/182)) ([2c6bea0](https://github.com/Daghis/teamcity-mcp/commit/2c6bea0cf6770d22068b9e4b733542a056399148))
+
 ## [1.9.0](https://github.com/Daghis/teamcity-mcp/compare/v1.8.2...v1.9.0) (2025-09-20)
 
 

package/dist/index.js

@@ -1346,6 +1346,38 @@ var ArtifactManager = class _ArtifactManager {
 };
 
 // src/teamcity/build-configuration-update-manager.ts
+var ARTIFACT_RULES_SETTINGS_FIELD = "settings/artifactRules";
+var ARTIFACT_RULES_LEGACY_FIELD = "artifactRules";
+var isArtifactRulesRetryableError = (error2) => {
+  if (error2 == null || typeof error2 !== "object") return false;
+  if (!("response" in error2)) return false;
+  const response = error2.response;
+  const status = response?.status;
+  return status === 400 || status === 404;
+};
+var setArtifactRulesWithFallback = async (api, buildTypeId, artifactRules) => {
+  try {
+    await api.setBuildTypeField(buildTypeId, ARTIFACT_RULES_SETTINGS_FIELD, artifactRules);
+  } catch (err) {
+    if (!isArtifactRulesRetryableError(err)) {
+      throw err;
+    }
+    const status = err.response?.status;
+    debug("Retrying artifact rules update via legacy field", {
+      buildTypeId,
+      status
+    });
+    try {
+      await api.setBuildTypeField(buildTypeId, ARTIFACT_RULES_LEGACY_FIELD, artifactRules);
+    } catch (fallbackError) {
+      debug("Legacy artifact rules update failed", {
+        buildTypeId,
+        status: fallbackError.response?.status
+      });
+      throw fallbackError;
+    }
+  }
+};
 var BuildConfigurationUpdateManager = class {
   client;
   constructor(client) {
@@ -1555,6 +1587,14 @@ var BuildConfigurationUpdateManager = class {
       }
       if (settings.length > 0) {
         for (const setting of settings) {
+          if (setting.name === "artifactRules") {
+            await setArtifactRulesWithFallback(
+              this.client.modules.buildTypes,
+              currentConfig.id,
+              setting.value
+            );
+            continue;
+          }
           await this.client.modules.buildTypes.setBuildTypeField(
             currentConfig.id,
             `settings/${setting.name}`,
@@ -40100,9 +40140,9 @@ var FULL_MODE_TOOLS = [
             );
           }
           if (typedArgs.artifactRules !== void 0) {
-            await adapter.modules.buildTypes.setBuildTypeField(
+            await setArtifactRulesWithFallback(
+              adapter.modules.buildTypes,
               typedArgs.buildTypeId,
-              "settings/artifactRules",
               typedArgs.artifactRules
             );
           }
@@ -40123,9 +40163,9 @@ var FULL_MODE_TOOLS = [
           );
         }
         if (typedArgs.artifactRules !== void 0) {
-          await adapter.modules.buildTypes.setBuildTypeField(
+          await setArtifactRulesWithFallback(
+            adapter.modules.buildTypes,
             typedArgs.buildTypeId,
-            "settings/artifactRules",
             typedArgs.artifactRules
           );
         }
@@ -40400,103 +40440,122 @@ var FULL_MODE_TOOLS = [
       required: ["buildTypeId", "action"]
     },
     handler: async (args) => {
-      const typedArgs = args;
-      const adapter = createAdapterFromTeamCityAPI(TeamCityAPI.getInstance());
-      switch (typedArgs.action) {
-        case "add": {
-          const stepProps = Object.fromEntries(
-            Object.entries(typedArgs.properties ?? {}).map(([k, v]) => [k, String(v)])
-          );
-          if (typedArgs.type === "simpleRunner" && stepProps["script.content"]) {
-            stepProps["use.custom.script"] = stepProps["use.custom.script"] ?? "true";
-          }
-          const step = {
-            name: typedArgs.name,
-            type: typedArgs.type,
-            properties: {
-              property: Object.entries(stepProps).map(([k, v]) => ({ name: k, value: v }))
-            }
-          };
-          await adapter.modules.buildTypes.addBuildStepToBuildType(
-            typedArgs.buildTypeId,
-            void 0,
-            step,
-            {
-              headers: { "Content-Type": "application/json", Accept: "application/json" }
-            }
-          );
-          return json({
-            success: true,
-            action: "add_build_step",
-            buildTypeId: typedArgs.buildTypeId
-          });
-        }
-        case "update": {
-          if (typedArgs.stepId == null || typedArgs.stepId === "") {
-            return json({
-              success: false,
-              action: "update_build_step",
-              error: "Step ID is required for update action"
-            });
-          }
-          const updatePayload = {};
-          if (typedArgs.name != null) {
-            updatePayload["name"] = typedArgs.name;
-          }
-          if (typedArgs.type != null) {
-            updatePayload["type"] = typedArgs.type;
-          }
-          const rawProps = typedArgs.properties ?? {};
-          const stepProps = Object.fromEntries(
-            Object.entries(rawProps).map(([k, v]) => [k, String(v)])
-          );
-          if (stepProps["script.content"]) {
-            stepProps["use.custom.script"] = stepProps["use.custom.script"] ?? "true";
-            stepProps["script.type"] = stepProps["script.type"] ?? "customScript";
-          }
-          if (Object.keys(stepProps).length > 0) {
-            updatePayload["properties"] = {
-              property: Object.entries(stepProps).map(([name, value]) => ({ name, value }))
-            };
-          }
-          if (Object.keys(updatePayload).length === 0) {
-            return json({
-              success: false,
-              action: "update_build_step",
-              error: "No update fields provided"
+      const schema = import_zod4.z.object({
+        buildTypeId: import_zod4.z.string().min(1, "buildTypeId is required"),
+        action: import_zod4.z.enum(["add", "update", "delete"]),
+        stepId: import_zod4.z.string().min(1).optional(),
+        name: import_zod4.z.string().optional(),
+        type: import_zod4.z.string().optional(),
+        properties: import_zod4.z.record(import_zod4.z.unknown()).optional()
+      }).superRefine((value, ctx) => {
+        if (value.action === "update" || value.action === "delete") {
+          if (!value.stepId || value.stepId.trim() === "") {
+            ctx.addIssue({
+              code: import_zod4.z.ZodIssueCode.custom,
+              message: "stepId is required for update or delete actions",
+              path: ["stepId"]
             });
           }
-          await adapter.modules.buildTypes.replaceBuildStep(
-            typedArgs.buildTypeId,
-            typedArgs.stepId,
-            void 0,
-            updatePayload
-          );
-          return json({
-            success: true,
-            action: "update_build_step",
-            buildTypeId: typedArgs.buildTypeId,
-            stepId: typedArgs.stepId
-          });
         }
-        case "delete":
-          if (typedArgs.stepId == null || typedArgs.stepId === "") {
-            return json({
-              success: false,
-              action: "delete_build_step",
-              error: "Step ID is required for delete action"
-            });
+      });
+      return runTool(
+        "manage_build_steps",
+        schema,
+        async (typedArgs) => {
+          const adapter = createAdapterFromTeamCityAPI(TeamCityAPI.getInstance());
+          switch (typedArgs.action) {
+            case "add": {
+              const stepProps = Object.fromEntries(
+                Object.entries(typedArgs.properties ?? {}).map(([k, v]) => [k, String(v)])
+              );
+              if (typedArgs.type === "simpleRunner" && stepProps["script.content"]) {
+                stepProps["use.custom.script"] = stepProps["use.custom.script"] ?? "true";
+              }
+              const step = {
+                name: typedArgs.name,
+                type: typedArgs.type,
+                properties: {
+                  property: Object.entries(stepProps).map(([k, v]) => ({ name: k, value: v }))
+                }
+              };
+              await adapter.modules.buildTypes.addBuildStepToBuildType(
+                typedArgs.buildTypeId,
+                void 0,
+                step,
+                {
+                  headers: { "Content-Type": "application/json", Accept: "application/json" }
+                }
+              );
+              return json({
+                success: true,
+                action: "add_build_step",
+                buildTypeId: typedArgs.buildTypeId
+              });
+            }
+            case "update": {
+              const updatePayload = {};
+              if (typedArgs.name != null) {
+                updatePayload["name"] = typedArgs.name;
+              }
+              if (typedArgs.type != null) {
+                updatePayload["type"] = typedArgs.type;
+              }
+              const rawProps = typedArgs.properties ?? {};
+              const stepProps = Object.fromEntries(
+                Object.entries(rawProps).map(([k, v]) => [k, String(v)])
+              );
+              if (stepProps["script.content"]) {
+                stepProps["use.custom.script"] = stepProps["use.custom.script"] ?? "true";
+                stepProps["script.type"] = stepProps["script.type"] ?? "customScript";
+              }
+              if (Object.keys(stepProps).length > 0) {
+                updatePayload["properties"] = {
+                  property: Object.entries(stepProps).map(([name, value]) => ({ name, value }))
+                };
+              }
+              if (Object.keys(updatePayload).length === 0) {
+                return json({
+                  success: false,
+                  action: "update_build_step",
+                  error: "No update fields provided"
+                });
+              }
+              await adapter.modules.buildTypes.replaceBuildStep(
+                typedArgs.buildTypeId,
+                typedArgs.stepId,
+                void 0,
+                updatePayload,
+                {
+                  headers: {
+                    "Content-Type": "application/json",
+                    Accept: "application/json"
+                  }
+                }
+              );
+              return json({
+                success: true,
+                action: "update_build_step",
+                buildTypeId: typedArgs.buildTypeId,
+                stepId: typedArgs.stepId
+              });
+            }
+            case "delete":
+              await adapter.modules.buildTypes.deleteBuildStep(
+                typedArgs.buildTypeId,
+                typedArgs.stepId
+              );
+              return json({
+                success: true,
+                action: "delete_build_step",
+                buildTypeId: typedArgs.buildTypeId,
+                stepId: typedArgs.stepId
+              });
+            default:
+              return json({ success: false, error: "Invalid action" });
           }
-          await adapter.modules.buildTypes.deleteBuildStep(typedArgs.buildTypeId, typedArgs.stepId);
-          return json({
-            success: true,
-            action: "delete_build_step",
-            buildTypeId: typedArgs.buildTypeId,
-            stepId: typedArgs.stepId
-          });
-        default:
-          return json({ success: false, error: "Invalid action" });
-      }
+        },
+        args
+      );
     },
     mode: "full"
   },