@daghis/teamcity-mcp 1.8.2 → 1.9.1

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [1.9.1](https://github.com/Daghis/teamcity-mcp/compare/v1.9.0...v1.9.1) (2025-09-20)
+
+
+### Bug Fixes
+
+* **tools:** allow manage_build_steps updates ([#182](https://github.com/Daghis/teamcity-mcp/issues/182)) ([2c6bea0](https://github.com/Daghis/teamcity-mcp/commit/2c6bea0cf6770d22068b9e4b733542a056399148))
+
+## [1.9.0](https://github.com/Daghis/teamcity-mcp/compare/v1.8.2...v1.9.0) (2025-09-20)
+
+
+### Features
+
+* **teamcity:** add runtime guards for manager responses ([#179](https://github.com/Daghis/teamcity-mcp/issues/179)) ([9d7eaef](https://github.com/Daghis/teamcity-mcp/commit/9d7eaef161e675246d317603df47f7f39407b7d8))
+
 ## [1.8.2](https://github.com/Daghis/teamcity-mcp/compare/v1.8.1...v1.8.2) (2025-09-20)
 
 

package/dist/index.js

@@ -938,11 +938,15 @@ var ResolutionTypeEnum = {
 
 // src/teamcity/artifact-manager.ts
 var import_axios = require("axios");
+init_errors();
 
 // src/teamcity/utils/build-locator.ts
 var toBuildLocator = (buildId) => buildId.includes(":") ? buildId : `id:${buildId}`;
 
 // src/teamcity/artifact-manager.ts
+var isRecord = (value) => {
+  return typeof value === "object" && value !== null;
+};
 var ArtifactManager = class _ArtifactManager {
   client;
   cache = /* @__PURE__ */ new Map();
@@ -979,12 +983,8 @@ var ArtifactManager = class _ArtifactManager {
         "file(name,fullName,size,modificationTime,href,children(file(name,fullName,size,modificationTime,href)))"
       );
       const baseUrl = this.getBaseUrl();
-      let artifacts = this.parseArtifacts(
-        response.data ?? {},
-        buildId,
-        options.includeNested,
-        baseUrl
-      );
+      const artifactPayload = this.ensureArtifactListingResponse(response.data, buildId);
+      let artifacts = this.parseArtifacts(artifactPayload, buildId, options.includeNested, baseUrl);
       artifacts = this.applyFilters(artifacts, options);
       if (options.limit ?? options.offset) {
         artifacts = this.paginate(
@@ -1183,6 +1183,39 @@ var ArtifactManager = class _ArtifactManager {
   /**
    * Parse artifacts from API response
    */
+  ensureArtifactListingResponse(data, buildId) {
+    if (!isRecord(data)) {
+      throw new TeamCityAPIError(
+        "TeamCity returned a non-object artifact listing response",
+        "INVALID_RESPONSE",
+        void 0,
+        { buildId }
+      );
+    }
+    const payload = data;
+    const { file } = payload;
+    if (file !== void 0 && !Array.isArray(file)) {
+      throw new TeamCityAPIError(
+        "TeamCity artifact listing response contains a non-array file field",
+        "INVALID_RESPONSE",
+        void 0,
+        { buildId }
+      );
+    }
+    if (Array.isArray(file)) {
+      file.forEach((entry, index) => {
+        if (!isRecord(entry)) {
+          throw new TeamCityAPIError(
+            "TeamCity artifact listing response contains a non-object file entry",
+            "INVALID_RESPONSE",
+            void 0,
+            { buildId, index }
+          );
+        }
+      });
+    }
+    return payload;
+  }
   parseArtifacts(data, buildId, includeNested, baseUrl) {
     const artifacts = [];
     const files = data.file ?? [];
@@ -1699,6 +1732,10 @@ var BuildConfigurationUpdateManager = class {
 };
 
 // src/teamcity/build-results-manager.ts
+init_errors();
+var isRecord2 = (value) => {
+  return typeof value === "object" && value !== null;
+};
 var BuildResultsManager = class _BuildResultsManager {
   client;
   cache = /* @__PURE__ */ new Map();
@@ -1783,15 +1820,14 @@ var BuildResultsManager = class _BuildResultsManager {
       toBuildLocator(buildId),
       _BuildResultsManager.fields
     );
-    return response.data;
+    return this.ensureBuildSummary(response.data, buildId);
   }
   /**
    * Transform build data to result format
    */
-  transformBuildData(data) {
-    const buildData = data;
+  transformBuildData(buildData) {
     const build = {
-      id: buildData.id,
+      id: typeof buildData.id === "string" ? Number.parseInt(buildData.id, 10) : buildData.id,
       number: buildData.number,
       status: buildData.status,
       state: buildData.state,
@@ -1820,16 +1856,107 @@ var BuildResultsManager = class _BuildResultsManager {
       build.duration = finish - start;
     }
     if (buildData.triggered) {
-      build.triggered = {
+      const triggered = {
         type: buildData.triggered.type,
         date: buildData.triggered.date
       };
-      if (buildData.triggered.user) {
-        build.triggered.user = buildData.triggered.user.username ?? buildData.triggered.user.name;
+      const triggeredUser = buildData.triggered.user;
+      if (triggeredUser) {
+        const username = triggeredUser.username ?? triggeredUser.name;
+        if (username) {
+          triggered.user = username;
+        }
       }
+      build.triggered = triggered;
     }
     return build;
   }
+  ensureBuildSummary(data, buildId) {
+    if (!isRecord2(data)) {
+      throw new TeamCityAPIError(
+        "TeamCity returned a non-object build summary response",
+        "INVALID_RESPONSE",
+        void 0,
+        { buildId, expected: "object with build fields", receivedType: typeof data }
+      );
+    }
+    const summary = data;
+    const { id, number, status, state, buildTypeId, webUrl, triggered } = summary;
+    if (typeof id !== "number" && typeof id !== "string" || typeof number !== "string" || typeof status !== "string" || typeof state !== "string" || typeof buildTypeId !== "string" || typeof webUrl !== "string") {
+      throw new TeamCityAPIError(
+        "TeamCity build summary response is missing required fields",
+        "INVALID_RESPONSE",
+        void 0,
+        { buildId, receivedKeys: Object.keys(summary) }
+      );
+    }
+    let normalizedTriggered;
+    if (triggered !== void 0 && triggered !== null) {
+      if (!isRecord2(triggered)) {
+        throw new TeamCityAPIError(
+          "TeamCity build summary response contains an invalid triggered payload",
+          "INVALID_RESPONSE",
+          void 0,
+          { buildId, receivedType: typeof triggered }
+        );
+      }
+      const { type, date, user } = triggered;
+      if (typeof type !== "string" || typeof date !== "string") {
+        throw new TeamCityAPIError(
+          "TeamCity build summary response contains an invalid triggered payload",
+          "INVALID_RESPONSE",
+          void 0,
+          { buildId }
+        );
+      }
+      if (user !== void 0 && user !== null && !isRecord2(user)) {
+        throw new TeamCityAPIError(
+          "TeamCity build summary response contains an invalid trigger user payload",
+          "INVALID_RESPONSE",
+          void 0,
+          { buildId }
+        );
+      }
+      let normalizedUser;
+      if (user !== void 0 && user !== null) {
+        const userRecord = user;
+        const username = userRecord["username"];
+        const name = userRecord["name"];
+        const normalizedUsername = typeof username === "string" ? username : void 0;
+        const normalizedName = typeof name === "string" ? name : void 0;
+        if (normalizedUsername !== void 0 || normalizedName !== void 0) {
+          normalizedUser = {};
+          if (normalizedUsername) {
+            normalizedUser.username = normalizedUsername;
+          }
+          if (normalizedName) {
+            normalizedUser.name = normalizedName;
+          }
+        }
+      }
+      normalizedTriggered = {
+        type,
+        date,
+        ...normalizedUser ? { user: normalizedUser } : {}
+      };
+    }
+    const normalized = {
+      id,
+      number,
+      status,
+      state,
+      buildTypeId,
+      statusText: typeof summary["statusText"] === "string" ? summary["statusText"] : void 0,
+      webUrl,
+      projectId: typeof summary["projectId"] === "string" ? summary["projectId"] : void 0,
+      branchName: typeof summary["branchName"] === "string" ? summary["branchName"] : void 0,
+      startDate: typeof summary["startDate"] === "string" ? summary["startDate"] : void 0,
+      finishDate: typeof summary["finishDate"] === "string" ? summary["finishDate"] : void 0,
+      queuedDate: typeof summary["queuedDate"] === "string" ? summary["queuedDate"] : void 0,
+      triggered: normalizedTriggered
+    };
+    return normalized;
+  }
   /**
    * Fetch build artifacts
    */
@@ -1839,7 +1966,7 @@ var BuildResultsManager = class _BuildResultsManager {
       const response = await this.client.modules.builds.getFilesListOfBuild(
         toBuildLocator(buildId)
       );
-      const artifactListing = response.data;
+      const artifactListing = this.ensureArtifactListResponse(response.data, buildId);
       let artifacts = artifactListing.file ?? [];
       if (options.artifactFilter) {
         artifacts = this.filterArtifacts(artifacts, options.artifactFilter);
@@ -1881,7 +2008,11 @@ var BuildResultsManager = class _BuildResultsManager {
       );
       return result;
     } catch (error2) {
-      warn("Failed to fetch artifacts", { error: error2, buildId });
+      warn("Failed to fetch artifacts", {
+        error: error2 instanceof Error ? error2.message : error2,
+        buildId,
+        expected: "file[]"
+      });
       return [];
     }
   }
@@ -1894,6 +2025,137 @@ var BuildResultsManager = class _BuildResultsManager {
     );
     return artifacts.filter((a) => regex.test(a.name));
   }
+  ensureArtifactListResponse(data, buildId) {
+    if (!isRecord2(data)) {
+      throw new TeamCityAPIError(
+        "TeamCity returned a non-object artifact list response",
+        "INVALID_RESPONSE",
+        void 0,
+        { buildId, expected: "object with file[]" }
+      );
+    }
+    const { file } = data;
+    if (file !== void 0 && !Array.isArray(file)) {
+      throw new TeamCityAPIError(
+        "TeamCity artifact list response contains a non-array file field",
+        "INVALID_RESPONSE",
+        void 0,
+        { buildId, receivedType: typeof file }
+      );
+    }
+    return data;
+  }
+  ensureStatisticsResponse(data, buildId) {
+    if (!isRecord2(data)) {
+      throw new TeamCityAPIError(
+        "TeamCity returned a non-object statistics response",
+        "INVALID_RESPONSE",
+        void 0,
+        { buildId, expected: "object with property[]" }
+      );
+    }
+    const { property } = data;
+    if (property === void 0) {
+      return {};
+    }
+    if (!Array.isArray(property)) {
+      throw new TeamCityAPIError(
+        "TeamCity statistics response contains a non-array property field",
+        "INVALID_RESPONSE",
+        void 0,
+        { buildId, receivedType: typeof property }
+      );
+    }
+    property.forEach((entry, index) => {
+      if (!isRecord2(entry)) {
+        throw new TeamCityAPIError(
+          "TeamCity statistics response contains a non-object property entry",
+          "INVALID_RESPONSE",
+          void 0,
+          { buildId, index }
+        );
+      }
+      const { name, value } = entry;
+      if (typeof name !== "string" || typeof value !== "string") {
+        throw new TeamCityAPIError(
+          "TeamCity statistics response property entry is missing required fields",
+          "INVALID_RESPONSE",
+          void 0,
+          { buildId, index, receivedKeys: Object.keys(entry) }
+        );
+      }
+    });
+    return { property };
+  }
+  ensureChangesResponse(data, buildId) {
+    if (!isRecord2(data)) {
+      throw new TeamCityAPIError(
+        "TeamCity returned a non-object changes response",
+        "INVALID_RESPONSE",
+        void 0,
+        { buildId, expected: "object with change[]" }
+      );
+    }
+    const { change } = data;
+    if (change !== void 0 && !Array.isArray(change)) {
+      throw new TeamCityAPIError(
+        "TeamCity changes response contains a non-array change field",
+        "INVALID_RESPONSE",
+        void 0,
+        { buildId, receivedType: typeof change }
+      );
+    }
+    return data;
+  }
+  ensureDependenciesResponse(data, buildId) {
+    if (!isRecord2(data)) {
+      throw new TeamCityAPIError(
+        "TeamCity returned a non-object dependencies response",
+        "INVALID_RESPONSE",
+        void 0,
+        { buildId, expected: "object with build[]" }
+      );
+    }
+    const { build } = data;
+    if (build !== void 0 && !Array.isArray(build)) {
+      throw new TeamCityAPIError(
+        "TeamCity dependencies response contains a non-array build field",
+        "INVALID_RESPONSE",
+        void 0,
+        { buildId, receivedType: typeof build }
+      );
+    }
+    if (Array.isArray(build)) {
+      build.forEach((entry, index) => {
+        if (!isRecord2(entry)) {
+          throw new TeamCityAPIError(
+            "TeamCity dependencies response contains a non-object build entry",
+            "INVALID_RESPONSE",
+            void 0,
+            { buildId, index }
+          );
+        }
+        const { id, number, buildTypeId, status } = entry;
+        if (typeof id !== "number" && typeof id !== "string" || typeof number !== "string" || typeof buildTypeId !== "string" || typeof status !== "string") {
+          throw new TeamCityAPIError(
+            "TeamCity dependencies response is missing required fields on build entry",
+            "INVALID_RESPONSE",
+            void 0,
+            { buildId, index, receivedKeys: Object.keys(entry) }
+          );
+        }
+        if (typeof id === "string" && Number.isNaN(Number.parseInt(id, 10))) {
+          throw new TeamCityAPIError(
+            "TeamCity dependencies response contains a non-numeric id value",
+            "INVALID_RESPONSE",
+            void 0,
+            { buildId, index, receivedValue: id }
+          );
+        }
+      });
+    }
+    return data;
+  }
   /**
    * Fetch build statistics
    */
@@ -1902,7 +2164,7 @@ var BuildResultsManager = class _BuildResultsManager {
       const response = await this.client.modules.builds.getBuildStatisticValues(
         toBuildLocator(buildId)
       );
-      const payload = response.data;
+      const payload = this.ensureStatisticsResponse(response.data, buildId);
       const properties = payload.property ?? [];
       const stats = {};
       for (const prop of properties) {
@@ -1934,7 +2196,11 @@ var BuildResultsManager = class _BuildResultsManager {
       }
       return stats;
     } catch (error2) {
-      warn("Failed to fetch statistics", { error: error2, buildId });
+      warn("Failed to fetch statistics", {
+        error: error2 instanceof Error ? error2.message : error2,
+        buildId,
+        expected: "property[]"
+      });
       return {};
     }
   }
@@ -1944,7 +2210,7 @@ var BuildResultsManager = class _BuildResultsManager {
   async fetchChanges(buildId) {
     try {
       const response = await this.client.modules.changes.getAllChanges(`build:(id:${buildId})`);
-      const changePayload = response.data;
+      const changePayload = this.ensureChangesResponse(response.data, buildId);
       const changes = changePayload.change ?? [];
       return changes.map((change) => ({
         revision: change.version,
@@ -1957,7 +2223,11 @@ var BuildResultsManager = class _BuildResultsManager {
         }))
       }));
     } catch (error2) {
-      warn("Failed to fetch changes", { error: error2, buildId });
+      warn("Failed to fetch changes", {
+        error: error2 instanceof Error ? error2.message : error2,
+        buildId,
+        expected: "change[]"
+      });
       return [];
     }
   }
@@ -1970,16 +2240,20 @@ var BuildResultsManager = class _BuildResultsManager {
         `snapshotDependency:(to:(id:${buildId}))`,
         "build(id,number,buildTypeId,status)"
       );
-      const depsData = response.data;
+      const depsData = this.ensureDependenciesResponse(response.data, buildId);
       const builds = depsData.build ?? [];
       return builds.map((build) => ({
-        buildId: build.id,
+        buildId: typeof build.id === "string" ? Number.parseInt(build.id, 10) : build.id,
         buildNumber: build.number,
         buildTypeId: build.buildTypeId,
         status: build.status
       }));
     } catch (error2) {
-      warn("Failed to fetch dependencies", { error: error2, buildId });
+      warn("Failed to fetch dependencies", {
+        error: error2 instanceof Error ? error2.message : error2,
+        buildId,
+        expected: "build[]"
+      });
       return [];
     }
   }
@@ -40126,103 +40400,122 @@ var FULL_MODE_TOOLS = [
       required: ["buildTypeId", "action"]
     },
     handler: async (args) => {
-      const typedArgs = args;
-      const adapter = createAdapterFromTeamCityAPI(TeamCityAPI.getInstance());
-      switch (typedArgs.action) {
-        case "add": {
-          const stepProps = Object.fromEntries(
-            Object.entries(typedArgs.properties ?? {}).map(([k, v]) => [k, String(v)])
-          );
-          if (typedArgs.type === "simpleRunner" && stepProps["script.content"]) {
-            stepProps["use.custom.script"] = stepProps["use.custom.script"] ?? "true";
-          }
-          const step = {
-            name: typedArgs.name,
-            type: typedArgs.type,
-            properties: {
-              property: Object.entries(stepProps).map(([k, v]) => ({ name: k, value: v }))
-            }
-          };
-          await adapter.modules.buildTypes.addBuildStepToBuildType(
-            typedArgs.buildTypeId,
-            void 0,
-            step,
-            {
-              headers: { "Content-Type": "application/json", Accept: "application/json" }
-            }
-          );
-          return json({
-            success: true,
-            action: "add_build_step",
-            buildTypeId: typedArgs.buildTypeId
-          });
-        }
-        case "update": {
-          if (typedArgs.stepId == null || typedArgs.stepId === "") {
-            return json({
-              success: false,
-              action: "update_build_step",
-              error: "Step ID is required for update action"
-            });
-          }
-          const updatePayload = {};
-          if (typedArgs.name != null) {
-            updatePayload["name"] = typedArgs.name;
-          }
-          if (typedArgs.type != null) {
-            updatePayload["type"] = typedArgs.type;
-          }
-          const rawProps = typedArgs.properties ?? {};
-          const stepProps = Object.fromEntries(
-            Object.entries(rawProps).map(([k, v]) => [k, String(v)])
-          );
-          if (stepProps["script.content"]) {
-            stepProps["use.custom.script"] = stepProps["use.custom.script"] ?? "true";
-            stepProps["script.type"] = stepProps["script.type"] ?? "customScript";
-          }
-          if (Object.keys(stepProps).length > 0) {
-            updatePayload["properties"] = {
-              property: Object.entries(stepProps).map(([name, value]) => ({ name, value }))
-            };
-          }
-          if (Object.keys(updatePayload).length === 0) {
-            return json({
-              success: false,
-              action: "update_build_step",
-              error: "No update fields provided"
+      const schema = import_zod4.z.object({
+        buildTypeId: import_zod4.z.string().min(1, "buildTypeId is required"),
+        action: import_zod4.z.enum(["add", "update", "delete"]),
+        stepId: import_zod4.z.string().min(1).optional(),
+        name: import_zod4.z.string().optional(),
+        type: import_zod4.z.string().optional(),
+        properties: import_zod4.z.record(import_zod4.z.unknown()).optional()
+      }).superRefine((value, ctx) => {
+        if (value.action === "update" || value.action === "delete") {
+          if (!value.stepId || value.stepId.trim() === "") {
+            ctx.addIssue({
+              code: import_zod4.z.ZodIssueCode.custom,
+              message: "stepId is required for update or delete actions",
+              path: ["stepId"]
             });
           }
-          await adapter.modules.buildTypes.replaceBuildStep(
-            typedArgs.buildTypeId,
-            typedArgs.stepId,
-            void 0,
-            updatePayload
-          );
-          return json({
-            success: true,
-            action: "update_build_step",
-            buildTypeId: typedArgs.buildTypeId,
-            stepId: typedArgs.stepId
-          });
         }
-        case "delete":
-          if (typedArgs.stepId == null || typedArgs.stepId === "") {
-            return json({
-              success: false,
-              action: "delete_build_step",
-              error: "Step ID is required for delete action"
-            });
+      });
+      return runTool(
+        "manage_build_steps",
+        schema,
+        async (typedArgs) => {
+          const adapter = createAdapterFromTeamCityAPI(TeamCityAPI.getInstance());
+          switch (typedArgs.action) {
+            case "add": {
+              const stepProps = Object.fromEntries(
+                Object.entries(typedArgs.properties ?? {}).map(([k, v]) => [k, String(v)])
+              );
+              if (typedArgs.type === "simpleRunner" && stepProps["script.content"]) {
+                stepProps["use.custom.script"] = stepProps["use.custom.script"] ?? "true";
+              }
+              const step = {
+                name: typedArgs.name,
+                type: typedArgs.type,
+                properties: {
+                  property: Object.entries(stepProps).map(([k, v]) => ({ name: k, value: v }))
+                }
+              };
+              await adapter.modules.buildTypes.addBuildStepToBuildType(
+                typedArgs.buildTypeId,
+                void 0,
+                step,
+                {
+                  headers: { "Content-Type": "application/json", Accept: "application/json" }
+                }
+              );
+              return json({
+                success: true,
+                action: "add_build_step",
+                buildTypeId: typedArgs.buildTypeId
+              });
+            }
+            case "update": {
+              const updatePayload = {};
+              if (typedArgs.name != null) {
+                updatePayload["name"] = typedArgs.name;
+              }
+              if (typedArgs.type != null) {
+                updatePayload["type"] = typedArgs.type;
+              }
+              const rawProps = typedArgs.properties ?? {};
+              const stepProps = Object.fromEntries(
+                Object.entries(rawProps).map(([k, v]) => [k, String(v)])
+              );
+              if (stepProps["script.content"]) {
+                stepProps["use.custom.script"] = stepProps["use.custom.script"] ?? "true";
+                stepProps["script.type"] = stepProps["script.type"] ?? "customScript";
+              }
+              if (Object.keys(stepProps).length > 0) {
+                updatePayload["properties"] = {
+                  property: Object.entries(stepProps).map(([name, value]) => ({ name, value }))
+                };
+              }
+              if (Object.keys(updatePayload).length === 0) {
+                return json({
+                  success: false,
+                  action: "update_build_step",
+                  error: "No update fields provided"
+                });
+              }
+              await adapter.modules.buildTypes.replaceBuildStep(
+                typedArgs.buildTypeId,
+                typedArgs.stepId,
+                void 0,
+                updatePayload,
+                {
+                  headers: {
+                    "Content-Type": "application/json",
+                    Accept: "application/json"
+                  }
+                }
+              );
+              return json({
+                success: true,
+                action: "update_build_step",
+                buildTypeId: typedArgs.buildTypeId,
+                stepId: typedArgs.stepId
+              });
+            }
+            case "delete":
+              await adapter.modules.buildTypes.deleteBuildStep(
+                typedArgs.buildTypeId,
+                typedArgs.stepId
+              );
+              return json({
+                success: true,
+                action: "delete_build_step",
+                buildTypeId: typedArgs.buildTypeId,
+                stepId: typedArgs.stepId
+              });
+            default:
+              return json({ success: false, error: "Invalid action" });
           }
-          await adapter.modules.buildTypes.deleteBuildStep(typedArgs.buildTypeId, typedArgs.stepId);
-          return json({
-            success: true,
-            action: "delete_build_step",
-            buildTypeId: typedArgs.buildTypeId,
-            stepId: typedArgs.stepId
-          });
-        default:
-          return json({ success: false, error: "Invalid action" });
-      }
+        },
+        args
+      );
     },
     mode: "full"
   },